github-actions[bot] commented on code in PR #24935:
URL: https://github.com/apache/doris/pull/24935#discussion_r1338193974
##########
be/src/vec/functions/array/function_array_difference.h:
##########
@@ -178,7 +179,8 @@ class FunctionArrayDifference : public IFunction {
}
}
- ColumnPtr _execute_non_nullable(const ColumnWithTypeAndName& arg, size_t
input_rows_count) {
+ ColumnPtr _execute_non_nullable(const ColumnWithTypeAndName& arg,
Review Comment:
warning: function '_execute_non_nullable' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] ColumnPtr _execute_non_nullable(const
ColumnWithTypeAndName& arg,
```
##########
be/src/vec/functions/array/function_array_element.h:
##########
@@ -129,7 +129,8 @@ class FunctionArrayElement : public IFunction {
private:
//=========================== map element===========================//
- ColumnPtr _get_mapped_idx(const ColumnArray& column, const
ColumnWithTypeAndName& argument) {
+ ColumnPtr _get_mapped_idx(const ColumnArray& column,
Review Comment:
warning: function '_get_mapped_idx' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] ColumnPtr _get_mapped_idx(const ColumnArray& column,
```
##########
be/src/vec/functions/function_json.cpp:
##########
@@ -995,7 +996,7 @@ class FunctionJsonContains : public IFunction {
return true;
}
- bool json_contains(const rapidjson::Value& target, const rapidjson::Value&
search_value) {
+ bool json_contains(const rapidjson::Value& target, const rapidjson::Value&
search_value) const {
Review Comment:
warning: function 'json_contains' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool json_contains(const rapidjson::Value& target, const
rapidjson::Value& search_value) const {
```
##########
be/src/vec/functions/function_json.cpp:
##########
@@ -974,7 +974,8 @@ class FunctionJsonContains : public IFunction {
return true;
}
- bool json_contains_array(const rapidjson::Value& target, const
rapidjson::Value& search_value) {
+ bool json_contains_array(const rapidjson::Value& target,
Review Comment:
warning: function 'json_contains_array' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool json_contains_array(const rapidjson::Value& target,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
