github-actions[bot] commented on code in PR #24964:
URL: https://github.com/apache/doris/pull/24964#discussion_r1338246197
##########
be/src/vec/common/pod_array.h:
##########
@@ -340,6 +340,7 @@ class PODArray : public PODArrayBase<sizeof(T),
initial_bytes, TAllocator, pad_r
const_iterator cbegin() const { return t_start(); }
const_iterator cend() const { return t_end(); }
+ void* get_begin_ptr() const { return this->c_start; }
Review Comment:
warning: function 'get_begin_ptr' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] void* get_begin_ptr() const { return this->c_start; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
