[GitHub] [doris] github-actions[bot] commented on pull request #17421: [refactor](functioncontext) remove duplicate type definition in function context
github-actions[bot] commented on PR #17421: URL: https://github.com/apache/doris/pull/17421#issuecomment-1455657849 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17421: [refactor](functioncontext) remove duplicate type definition in function context
github-actions[bot] commented on PR #17421: URL: https://github.com/apache/doris/pull/17421#issuecomment-1455657948 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yinzhijian opened a new pull request, #17455: [Fix](FQDN) fix `show frontends` may result in slow performance when ip changed
yinzhijian opened a new pull request, #17455: URL: https://github.com/apache/doris/pull/17455 # Proposed changes Issue Number: close #xxx ## Problem summary If the IP address is changed in FQDN mode, executing the command "show frontends" may result in slow performance. ### the cause of the problem ReplicationGroupAdmin converts the hostname to an IP address after creation. However, after a k8s pod is restarted, the IP address may change, which can cause RPC calls to hang because the old IP address is no longer reachable. ### solution To solve this problem, ReplicationGroupAdmin cannot be cached. ### performence The use of ReplicationGroupAdmin is not frequent, so the cost of building the connection can be ignored. ### changed - [x] remove ReplicationGroupAdmin cache - [x] remove unused code - [x] fix display problem of isHelper ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17236: [Enhance](auth)Users support multiple roles
zddr commented on PR #17236: URL: https://github.com/apache/doris/pull/17236#issuecomment-1455659767 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #17421: [refactor](functioncontext) remove duplicate type definition in function context
yiguolei merged PR #17421: URL: https://github.com/apache/doris/pull/17421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (e7cba11680 -> 9477c48ef8)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from e7cba11680 [fix](array)(parquet) fix be core dump due to load from parquet file containing array types (#17298) add 9477c48ef8 [refactor](functioncontext) remove duplicate type definition in function context (#17421) No new revisions were added by this update. Summary of changes: be/src/exprs/function_filter.h | 8 +- be/src/exprs/json_functions.h | 2 - be/src/exprs/math_functions.h | 4 +- be/src/exprs/string_functions.h| 2 +- be/src/olap/like_column_predicate.cpp | 11 +- be/src/olap/like_column_predicate.h| 4 +- be/src/olap/olap_define.h | 25 -- be/src/olap/rowset/beta_rowset_writer.cpp | 2 +- be/src/runtime/buffer_control_block.cpp| 2 + be/src/runtime/collection_value.h | 6 +- be/src/runtime/datetime_value.h| 4 +- be/src/runtime/decimalv2_value.h | 2 - be/src/runtime/descriptor_helper.h | 9 +- be/src/runtime/descriptors.cpp | 50 +--- be/src/runtime/descriptors.h | 23 -- be/src/runtime/primitive_type.cpp | 127 -- be/src/runtime/primitive_type.h| 5 - be/src/runtime/types.cpp | 1 + be/src/runtime/types.h | 10 +- be/src/udf/CMakeLists.txt | 2 +- be/src/udf/uda_test_harness.h | 270 - be/src/udf/udf.cpp | 37 ++- be/src/udf/udf.h | 92 +--- be/src/udf/udf_debug.h | 50 be/src/udf/udf_internal.h | 20 +- be/src/util/bitmap_value.h | 16 +- be/src/util/counts.h | 6 +- be/src/vec/common/string_ref.h | 1 - be/src/vec/exec/format/parquet/schema_desc.cpp | 1 + be/src/vec/exec/scan/new_es_scanner.cpp| 5 +- be/src/vec/exec/scan/new_olap_scan_node.cpp| 4 +- be/src/vec/exec/scan/new_olap_scan_node.h | 2 +- be/src/vec/exec/scan/new_olap_scanner.cpp | 5 +- be/src/vec/exec/scan/vfile_scanner.cpp | 6 +- be/src/vec/exec/scan/vmeta_scanner.cpp | 5 +- be/src/vec/exec/scan/vscan_node.cpp| 4 +- be/src/vec/exec/scan/vscan_node.h | 2 +- be/src/vec/exec/scan/vscanner.cpp | 8 + be/src/vec/exec/scan/vscanner.h| 4 +- be/src/vec/exprs/vexpr.cpp | 127 +- be/src/vec/exprs/vexpr.h | 1 - be/src/vec/exprs/vexpr_context.cpp | 14 +- be/src/vec/exprs/vexpr_context.h | 17 +- be/src/vec/functions/function_timestamp.cpp| 2 +- be/src/vec/functions/in.h | 11 +- be/src/vec/runtime/vdatetime_value.h | 7 +- be/test/CMakeLists.txt | 6 +- be/test/runtime/datetime_value_test.cpp| 4 +- be/test/testutil/desc_tbl_builder.cc | 14 +- be/test/testutil/function_utils.cpp| 9 +- be/test/testutil/function_utils.h | 9 +- be/test/udf/uda_test.cpp | 315 - be/test/udf/udf_test.cpp | 193 --- be/test/util/counts_test.cpp | 4 +- be/test/vec/function/function_test_util.cpp| 36 +-- be/test/vec/function/function_test_util.h | 20 +- gensrc/proto/descriptors.proto | 2 +- 57 files changed, 176 insertions(+), 1452 deletions(-) delete mode 100644 be/src/udf/uda_test_harness.h delete mode 100644 be/src/udf/udf_debug.h delete mode 100644 be/test/udf/uda_test.cpp delete mode 100644 be/test/udf/udf_test.cpp - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17445: [fix](meta) fix catalog parameter when checking privilege of show_create_table stmt
hello-stephen commented on PR #17445: URL: https://github.com/apache/doris/pull/17445#issuecomment-1455664564 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.65 seconds stream load tsv: 451 seconds loaded 74807831229 Bytes, about 158 MB/s stream load json: 36 seconds loaded 2358488459 Bytes, about 62 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230306080751_clickbench_pr_109133.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhengshiJ commented on pull request #16616: [Feature](nereids) Support Mark join
zhengshiJ commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1455675004 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yinzhijian commented on pull request #17455: [Fix](FQDN) fix `show frontends` may result in slow performance when ip changed
yinzhijian commented on PR #17455: URL: https://github.com/apache/doris/pull/17455#issuecomment-1455675494 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #17344: [feature](function) support type template in SQL function
xy720 commented on code in PR #17344:
URL: https://github.com/apache/doris/pull/17344#discussion_r1126075820
##
fe/fe-common/src/main/java/org/apache/doris/catalog/TemplateType.java:
##
@@ -0,0 +1,132 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.catalog;
+
+import org.apache.doris.thrift.TColumnType;
+import org.apache.doris.thrift.TTypeDesc;
+
+import com.google.common.base.Strings;
+import com.google.gson.annotations.SerializedName;
+
+import java.util.Map;
+
+/**
+ * Describes a TemplateType type, used for SQL function argument and return
type,
+ * NOT used for table column type.
+ */
+public class TemplateType extends Type {
+
+@SerializedName(value = "name")
+private final String name;
+
+public TemplateType(String name) {
+this.name = name;
+}
+
+@Override
+public PrimitiveType getPrimitiveType() {
+return PrimitiveType.TEMPLATE;
+}
+
+@Override
+public boolean equals(Object other) {
+if (!(other instanceof TemplateType)) {
+return false;
+}
+TemplateType o = (TemplateType) other;
+return o.name.equals(name);
+}
+
+@Override
+public boolean matchesType(Type t) {
+// not matches any type
+return false;
+}
+
+@Override
+public boolean hasTemplateType() {
+return true;
+}
+
+@Override
+public Type specializeTemplateType(Type specificType, Map
specializedTypeMap,
+ boolean useSpecializedType) throws
TypeException {
+if (specificType.hasTemplateType() && !specificType.isNull()) {
+throw new TypeException(specificType + " should not
hasTemplateType");
+}
+
+Type specializedType = specializedTypeMap.get(name);
+if (useSpecializedType) {
+if (specializedType == null) {
+throw new TypeException("template type " + name + " is not
specialized yet");
+}
+return specializedType;
+}
+
+if (specializedType != null
+&& !specificType.equals(specializedType)
+&& !specificType.matchesType(specializedType)
+&& !Type.isImplicitlyCastable(specificType, specializedType,
true)
+&& !Type.canCastTo(specificType, specializedType)) {
+throw new TypeException(
+String.format("can not specialize template type %s to %s since
it's already specialized as %s",
+name, specificType, specializedType));
+}
+
+if (specializedType == null) {
Review Comment:
As discussion, when specializedType != null
specializedTypeMap should store the CompatibleType of specificType and
specializedType.
You can use `Type.getAssignmentCompatibleType` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #17131: [Fix](planner)fix cast error when query a view with cast to string-like type.
morrySnow merged PR #17131: URL: https://github.com/apache/doris/pull/17131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.1-lts updated: [Fix](planner)fix cast error when query a view with cast to string-like type. (#17131)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch branch-1.1-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.1-lts by this push:
new 1fe5b846f6 [Fix](planner)fix cast error when query a view with cast to
string-like type. (#17131)
1fe5b846f6 is described below
commit 1fe5b846f671b9c8f646b278ef6eccbb38f5afe9
Author: mch_ucchi <41606806+sohardforan...@users.noreply.github.com>
AuthorDate: Mon Mar 6 16:27:30 2023 +0800
[Fix](planner)fix cast error when query a view with cast to string-like
type. (#17131)
fix bug:
create table t (
id int,
k1 int
)
distributed by hash(id) buckets 4
properties(...)
create view v1 as select cast(k1 as varchar) k1 from t1
select k1 from v1
which will cause 'Failed analysis when expr subsitution' because
inlineViewDef always change string-like type to char.
---
fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java | 7 ++-
.../src/test/java/org/apache/doris/catalog/CreateFunctionTest.java | 4 ++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
index 261c1cf89a..4cf590eb63 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
@@ -194,7 +194,12 @@ public class CastExpr extends Expr {
}
if (isAnalyzed) {
if (type.isStringType()) {
-return "CAST(" + getChild(0).toSql() + " AS " + "CHARACTER" +
")";
+String typeString = type.toSql();
+ScalarType scalarType = ((ScalarType) type);
+if (scalarType.isWildcardChar() ||
scalarType.isWildcardVarchar()) {
+typeString = typeString.replace("(-1)", "");
+}
+return "CAST(" + getChild(0).toSql() + " AS " + typeString +
")";
} else {
return "CAST(" + getChild(0).toSql() + " AS " +
type.toString() + ")";
}
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/catalog/CreateFunctionTest.java
b/fe/fe-core/src/test/java/org/apache/doris/catalog/CreateFunctionTest.java
index 7da7f92b8e..1e7c2fa9b7 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/catalog/CreateFunctionTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/catalog/CreateFunctionTest.java
@@ -197,7 +197,7 @@ public class CreateFunctionTest {
Assert.assertTrue(constExprLists.get(0).get(0) instanceof
StringLiteral);
queryStr = "select db1.varchar(k1, 4) from db1.tbl1;";
-
Assert.assertTrue(dorisAssert.query(queryStr).explainQuery().contains("CAST(`k1`
AS CHARACTER)"));
+
Assert.assertTrue(dorisAssert.query(queryStr).explainQuery().contains("CAST(`k1`
AS varchar(4))"));
// cast any type to char with fixed length
createFuncStr = "create alias function db1.char(all, int) with
parameter(text, length) as " +
@@ -224,6 +224,6 @@ public class CreateFunctionTest {
Assert.assertTrue(constExprLists.get(0).get(0) instanceof
StringLiteral);
queryStr = "select db1.char(k1, 4) from db1.tbl1;";
-
Assert.assertTrue(dorisAssert.query(queryStr).explainQuery().contains("CAST(`k1`
AS CHARACTER)"));
+
Assert.assertTrue(dorisAssert.query(queryStr).explainQuery().contains("CAST(`k1`
AS char(4))"));
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #17445: [fix](meta) fix catalog parameter when checking privilege of show_create_table stmt
Yulei-Yang commented on PR #17445: URL: https://github.com/apache/doris/pull/17445#issuecomment-1455699831 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg opened a new pull request, #17456: [fix](bitmap) fix wrong result of bitmap_or for null
jacktengg opened a new pull request, #17456: URL: https://github.com/apache/doris/pull/17456 # Proposed changes Issue Number: close #xxx ## Problem summary Result of `select bitmap_to_string(bitmap_or(to_bitmap(1), null))` should be `1` instead `of null`. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null
github-actions[bot] commented on PR #17456: URL: https://github.com/apache/doris/pull/17456#issuecomment-1455722307 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #17326: [fix](restore) fix bug when replay restore with reserve dynamic partition cause OBSERVER down
nextdreamblue commented on PR #17326: URL: https://github.com/apache/doris/pull/17326#issuecomment-1455723828 run COMPILE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #17457: [Feature](Nereids)add rule to eliminate SetOperation nodes
sohardforaname opened a new pull request, #17457: URL: https://github.com/apache/doris/pull/17457 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #17451: [fix](planner) Doris returns empty sets when select from a inline view
adonis0147 commented on PR #17451: URL: https://github.com/apache/doris/pull/17451#issuecomment-1455729497 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17395: [enhencement](jdbc catalog) Use Druid instead of HikariCP in JdbcClient
github-actions[bot] commented on PR #17395: URL: https://github.com/apache/doris/pull/17395#issuecomment-1455730794 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #17328: [Enchancement](function) Inline some aggregate function && remove nullable combinator
BiteThet commented on PR #17328: URL: https://github.com/apache/doris/pull/17328#issuecomment-1455734318 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #17377: [dependency](fe)Dependency Upgrade
CalvinKirs commented on PR #17377: URL: https://github.com/apache/doris/pull/17377#issuecomment-1455742606 rerun COMPILE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17428: [docs](typo) fix faq docs, already support rename column.
github-actions[bot] commented on PR #17428: URL: https://github.com/apache/doris/pull/17428#issuecomment-1455746399 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17428: [docs](typo) fix faq docs, already support rename column.
github-actions[bot] commented on PR #17428: URL: https://github.com/apache/doris/pull/17428#issuecomment-1455746467 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer opened a new pull request, #17458: [fix](log) fix error code for tablet writer write failure (#14078)
freemandealer opened a new pull request, #17458: URL: https://github.com/apache/doris/pull/17458 Fix vague error code (-1) in err log if tablet writer write failed. The original error print: tablet writer write failed ... err=6, errorcode=-1 ... After this commit: tablet writer write failed ... err=6, errorcode=-238 ... # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17395: [enhencement](jdbc catalog) Use Druid instead of HikariCP in JdbcClient
github-actions[bot] commented on PR #17395: URL: https://github.com/apache/doris/pull/17395#issuecomment-1455761709 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #17451: [fix](planner) Doris returns empty sets when select from a inline view
adonis0147 commented on PR #17451: URL: https://github.com/apache/doris/pull/17451#issuecomment-1455765177 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #17342: [Improvement](meta) support return total statistics of all databases for command show proc '/jobs
Yulei-Yang commented on PR #17342: URL: https://github.com/apache/doris/pull/17342#issuecomment-1455768797 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BePPPower commented on a diff in pull request #17395: [enhencement](jdbc catalog) Use Druid instead of HikariCP in JdbcClient
BePPPower commented on code in PR #17395:
URL: https://github.com/apache/doris/pull/17395#discussion_r1126135320
##
be/src/vec/exec/vjdbc_connector.cpp:
##
@@ -140,6 +140,7 @@ Status JdbcConnector::open(RuntimeState* state, bool read) {
std::abs((int64_t)hash_str(_conn_param.resource_name)),
_conn_param.driver_path,
_conn_param.driver_checksum, &local_location));
}
+LOG(INFO) << "driver local path = " << local_location;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #17389: [Optimize](Random distribution) Improve the performance of tablet sin…
eldenmoon commented on PR #17389: URL: https://github.com/apache/doris/pull/17389#issuecomment-1455776490 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #17459: [Chore](schema change) remove some unused code in schema change
BiteThet opened a new pull request, #17459: URL: https://github.com/apache/doris/pull/17459 # Proposed changes 1. remove some unused code in schema change. 2. remove some row-based config and code. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17389: [Optimize](Random distribution) Improve the performance of tablet sin…
github-actions[bot] commented on PR #17389: URL: https://github.com/apache/doris/pull/17389#issuecomment-1455785155 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17389: [Optimize](Random distribution) Improve the performance of tablet sin…
github-actions[bot] commented on PR #17389: URL: https://github.com/apache/doris/pull/17389#issuecomment-1455786279 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17459: [Chore](schema change) remove some unused code in schema change
github-actions[bot] commented on PR #17459: URL: https://github.com/apache/doris/pull/17459#issuecomment-1455789126 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #17359: [fix](inverted index) fix missing several numeric types for inverted index query
Tanya-W commented on PR #17359: URL: https://github.com/apache/doris/pull/17359#issuecomment-1455791397 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #17459: [Chore](schema change) remove some unused code in schema change
BiteThet commented on PR #17459: URL: https://github.com/apache/doris/pull/17459#issuecomment-1455791928 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 opened a new pull request, #17460: [fix](planner) Slots in the cojuncts of table function node didn't got materialized
Kikyou1997 opened a new pull request, #17460: URL: https://github.com/apache/doris/pull/17460 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #17425: [fix](regression) Adjust the test_add_drop_index case to avoid that FE failed to start when replaying the log
morningman merged PR #17425: URL: https://github.com/apache/doris/pull/17425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (9477c48ef8 -> 843b4b5746)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 9477c48ef8 [refactor](functioncontext) remove duplicate type definition in function context (#17421) add 843b4b5746 [fix](regression) Adjust the test_add_drop_index case to avoid that FE failed to start when replaying the log (#17425) No new revisions were added by this update. Summary of changes: regression-test/suites/inverted_index_p0/test_add_drop_index.groovy | 4 1 file changed, 4 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #17326: [fix](restore) fix bug when replay restore with reserve dynamic partition cause OBSERVER down
nextdreamblue commented on PR #17326: URL: https://github.com/apache/doris/pull/17326#issuecomment-1455801640 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #16813: [enhance](cooldown) turn write cooldown meta async
ByteYue commented on PR #16813: URL: https://github.com/apache/doris/pull/16813#issuecomment-1455812398 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16813: [enhance](cooldown) turn write cooldown meta async
github-actions[bot] commented on PR #16813: URL: https://github.com/apache/doris/pull/16813#issuecomment-1455814109 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17395: [enhencement](jdbc catalog) Use Druid instead of HikariCP in JdbcClient
github-actions[bot] commented on PR #17395: URL: https://github.com/apache/doris/pull/17395#issuecomment-1455817794 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #17202: [Chore](third-party) upgrade thrift from 0.13 to 0.16
BiteThet commented on PR #17202: URL: https://github.com/apache/doris/pull/17202#issuecomment-1455818206 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #17330: [Refactor](map) remove using column array in map to reduce offset column
amorynan commented on PR #17330: URL: https://github.com/apache/doris/pull/17330#issuecomment-1455820678 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17202: [Chore](third-party) upgrade thrift from 0.13 to 0.16
github-actions[bot] commented on PR #17202: URL: https://github.com/apache/doris/pull/17202#issuecomment-1455826830 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #17393: [enhancement](Nereids) support decimalv3 type
morrySnow commented on PR #17393: URL: https://github.com/apache/doris/pull/17393#issuecomment-1455828810 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #17337: [fix](ParquetReader) definition level of repeated parent is wrong
morningman merged PR #17337: URL: https://github.com/apache/doris/pull/17337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](ParquetReader) definition level of repeated parent is wrong (#17337)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new dca16796ad [fix](ParquetReader) definition level of repeated parent is
wrong (#17337)
dca16796ad is described below
commit dca16796adfac43f5bbcf74df33d212c2bcf8510
Author: Ashin Gau
AuthorDate: Mon Mar 6 18:15:57 2023 +0800
[fix](ParquetReader) definition level of repeated parent is wrong (#17337)
Fix three bugs:
1. `repeated_parent_def_level ` should be the definition of its repeated
parent.
2. Failed to parse schema like `decimal(p, s)`
3. Fill wrong offsets for array type
---
be/src/vec/exec/format/parquet/schema_desc.cpp | 22 +++---
.../exec/format/parquet/vparquet_column_reader.cpp | 8
.../doris/catalog/HiveMetaStoreClientHelper.java | 7 ++-
3 files changed, 21 insertions(+), 16 deletions(-)
diff --git a/be/src/vec/exec/format/parquet/schema_desc.cpp
b/be/src/vec/exec/format/parquet/schema_desc.cpp
index c7ff2353d4..ebd9a25352 100644
--- a/be/src/vec/exec/format/parquet/schema_desc.cpp
+++ b/be/src/vec/exec/format/parquet/schema_desc.cpp
@@ -55,11 +55,11 @@ static int num_children_node(const tparquet::SchemaElement&
schema) {
return schema.__isset.num_children ? schema.num_children : 0;
}
-static void set_child_node_level(FieldSchema* parent, size_t rep_inc = 0,
size_t def_inc = 0) {
+static void set_child_node_level(FieldSchema* parent, int16_t
repeated_parent_def_level) {
for (auto& child : parent->children) {
-child.repetition_level = parent->repetition_level + rep_inc;
-child.definition_level = parent->definition_level + def_inc;
-child.repeated_parent_def_level = parent->definition_level;
+child.repetition_level = parent->repetition_level;
+child.definition_level = parent->definition_level;
+child.repeated_parent_def_level = repeated_parent_def_level;
}
}
@@ -129,7 +129,7 @@ Status FieldDescriptor::parse_node_field(const
std::vectorrepetition_level++;
node_field->definition_level++;
node_field->children.resize(1);
-set_child_node_level(node_field);
+set_child_node_level(node_field, node_field->definition_level);
auto child = &node_field->children[0];
parse_physical_field(t_schema, false, child);
@@ -315,7 +315,7 @@ Status FieldDescriptor::parse_group_field(const
std::vectorrepetition_level++;
group_field->definition_level++;
group_field->children.resize(1);
-set_child_node_level(group_field);
+set_child_node_level(group_field, group_field->definition_level);
auto struct_field = &group_field->children[0];
// the list of struct:
// repeated group (LIST) {
@@ -379,16 +379,16 @@ Status FieldDescriptor::parse_list_field(const
std::vector, LIST,
LIST>
// skip bag/list, it's a repeated element.
-set_child_node_level(list_field);
+set_child_node_level(list_field, list_field->definition_level);
RETURN_IF_ERROR(parse_node_field(t_schemas, curr_pos + 2,
list_child));
} else {
// required field, produce the list of struct
-set_child_node_level(list_field);
+set_child_node_level(list_field, list_field->definition_level);
RETURN_IF_ERROR(parse_struct_field(t_schemas, curr_pos + 1,
list_child));
}
} else if (num_children == 0) {
// required two level list, for compatibility reason.
-set_child_node_level(list_field);
+set_child_node_level(list_field, list_field->definition_level);
parse_physical_field(second_level, false, list_child);
_next_schema_pos = curr_pos + 2;
}
@@ -450,7 +450,7 @@ Status FieldDescriptor::parse_map_field(const
std::vectordefinition_level++;
map_field->children.resize(1);
-set_child_node_level(map_field);
+set_child_node_level(map_field, map_field->repeated_parent_def_level);
auto map_kv_field = &map_field->children[0];
// produce MAP>
RETURN_IF_ERROR(parse_struct_field(t_schemas, curr_pos + 1, map_kv_field));
@@ -473,7 +473,7 @@ Status FieldDescriptor::parse_struct_field(const
std::vectorchildren.resize(num_children);
-set_child_node_level(struct_field);
+set_child_node_level(struct_field,
struct_field->repeated_parent_def_level);
_next_schema_pos = curr_pos + 1;
for (int i = 0; i < num_children; ++i) {
RETURN_IF_ERROR(parse_node_field(t_schemas, _next_schema_pos,
&struct_field->children[i]));
diff --git a/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
b/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
index 4e270c30cf..3e94a3082f 100644
--- a/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
+++ b/be/src/vec/exec/format
[GitHub] [doris] morningman merged pull request #17338: [cherry-pick](status) Unify error code
morningman merged PR #17338: URL: https://github.com/apache/doris/pull/17338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei opened a new pull request, #17461: [refactor](remove string val) remove string val structure, it is same with string ref
yiguolei opened a new pull request, #17461: URL: https://github.com/apache/doris/pull/17461 # Proposed changes 1. remove stringval, decimalv2val, bigintval ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #17452: [enhance](Nereids): remove rule flag in LogicalJoin
jackwener commented on PR #17452: URL: https://github.com/apache/doris/pull/17452#issuecomment-1455858507 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #17365: [feature](Nereids): pushdown complex project through inner/outer Join.
jackwener commented on PR #17365: URL: https://github.com/apache/doris/pull/17365#issuecomment-1455859309 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17453: [fix](publish) add retry publish when succeed replica num less than qorum and transaction not VISIBLE
hello-stephen commented on PR #17453: URL: https://github.com/apache/doris/pull/17453#issuecomment-1455861796 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.01 seconds stream load tsv: 482 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s stream load orc: 74 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230306102142_clickbench_pr_109219.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17342: [Improvement](meta) support return total statistics of all databases for command show proc '/jobs
github-actions[bot] commented on PR #17342: URL: https://github.com/apache/doris/pull/17342#issuecomment-1455860431 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17342: [Improvement](meta) support return total statistics of all databases for command show proc '/jobs
github-actions[bot] commented on PR #17342: URL: https://github.com/apache/doris/pull/17342#issuecomment-1455860510 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #17355: [refactor](Nereids): refactor PushdownLimit
jackwener commented on PR #17355: URL: https://github.com/apache/doris/pull/17355#issuecomment-1455861564 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17358: [doc](auth)auth doc
github-actions[bot] commented on PR #17358: URL: https://github.com/apache/doris/pull/17358#issuecomment-1455865950 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17358: [doc](auth)auth doc
github-actions[bot] commented on PR #17358: URL: https://github.com/apache/doris/pull/17358#issuecomment-1455866023 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #17369: [Enhencement](csv_reader) support quotes content include delimiter and escape character
morningman commented on PR #17369: URL: https://github.com/apache/doris/pull/17369#issuecomment-1455866370 > > Hi @ZhangYu0123 , I saw you submit several PR with same issue, and the others are closed. What is difference among this PR? > > The code are the same, but the other PR’s regression tests are not passed cased by the nereidsp0 test. You don't need to submit a new PR, you can just update your branch, the PR will be updated automatically -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BePPPower commented on pull request #17395: [enhencement](jdbc catalog) Use Druid instead of HikariCP in JdbcClient
BePPPower commented on PR #17395: URL: https://github.com/apache/doris/pull/17395#issuecomment-1455871999 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref
github-actions[bot] commented on code in PR #17461:
URL: https://github.com/apache/doris/pull/17461#discussion_r1126214752
##
be/src/exprs/function_filter.h:
##
@@ -26,7 +26,7 @@ namespace doris {
class FunctionFilter {
public:
FunctionFilter(bool opposite, const std::string& col_name,
doris::FunctionContext* fn_ctx,
- doris::StringVal string_param)
+ doris::StringRef string_param)
Review Comment:
warning: variable has incomplete type 'doris::StringRef'
[clang-diagnostic-error]
```cpp
doris::StringRef string_param)
^
```
**be/src/udf/udf.h:33:** forward declaration of 'doris::StringRef'
```cpp
struct StringRef;
^
```
##
be/src/exprs/function_filter.h:
##
@@ -36,8 +36,8 @@
std::string _col_name;
// these pointer's life time controlled by scan node
doris::FunctionContext* _fn_ctx;
-doris::StringVal
-_string_param; // only one param from conjunct, because now only
support like predicate
+// only one param from conjunct, because now only support like predicate
+doris::StringRef _string_param;
Review Comment:
warning: field has incomplete type 'doris::StringRef'
[clang-diagnostic-error]
```cpp
doris::StringRef _string_param;
^
```
**be/src/udf/udf.h:33:** forward declaration of 'doris::StringRef'
```cpp
struct StringRef;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #17369: [Enhencement](csv_reader) support quotes content include delimiter and escape character
morningman commented on code in PR #17369:
URL: https://github.com/apache/doris/pull/17369#discussion_r1126215691
##
be/src/vec/exec/format/csv/csv_reader.cpp:
##
@@ -462,8 +462,22 @@ void
CsvReader::_split_line_for_single_char_delimiter(const Slice& line) {
size_t cur_pos = 0;
size_t start_field = 0;
const size_t size = line.size;
+bool quoted = false;
+
for (; cur_pos < size; ++cur_pos) {
-if (*(value + cur_pos) == _value_separator[0]) {
+if (_trim_double_quotes && *(value + cur_pos) == '\"') {
+if (cur_pos == start_field) {
+// start_field is ", mark quoted true
+quoted = true;
+} else if (*(value + cur_pos - 1) != '\\' && quoted) {
+// cur_pos is ", mark quoted finished
+quoted = !quoted;
+}
+continue;
+} else if (_trim_double_quotes && quoted) {
Review Comment:
Better leave `_split_line_for_single_char_delimiter` fast enough to not
handle this complex situation.
Maybe we should be a new parameter to specify the `escape` explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg opened a new issue, #17462: [Bug] Crashing caused by `IS NULL` expression
mrhhsg opened a new issue, #17462: URL: https://github.com/apache/doris/issues/17462 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's Wrong? For `ColumnNullable`, in addition to checking whether it is exclusive itself, we also need to check its nested column and null_map to determine if it is exclusive. ```bash #0 0x7f02ca5bd37f in raise () from /lib64/libc.so.6 #1 0x7f02ca5a7db5 in abort () from /lib64/libc.so.6 #2 0x564583ddf8e9 in ?? () #3 0x564583dd5efd in google::LogMessage::SendToLog() () #4 0x564583dd63fc in google::LogMessage::Flush() () #5 0x564583dd9919 in google::LogMessageFatal::~LogMessageFatal() () #6 0x56457ec43f36 in doris::vectorized::ColumnVector::filter (this=, filter=...) at /root/doris-master/be/src/vec/columns/column_vector.cpp:447 #7 0x56457ec02990 in doris::vectorized::ColumnNullable::filter (this=0x5645b8eca6c0, filter=...) at /root/doris-master/be/src/vec/columns/column_nullable.cpp:313 #8 0x56457ece8ffe in doris::vectorized::Block::filter_block_internal (block=block@entry=0x5645a9f9fc20, columns_to_filter=..., filter=...) at /root/doris-master/be/src/vec/core/block.cpp:672 #9 0x56457ece953f in doris::vectorized::Block::filter_block (block=block@entry=0x5645a9f9fc20, columns_to_filter=..., filter_column_id=filter_column_id@entry=7, column_to_keep=column_to_keep@entry=7) at /root/doris-master/be/src/vec/core/block.cpp:744 #10 0x56457ece99e3 in doris::vectorized::Block::filter_block (block=0x5645a9f9fc20, filter_column_id=7, column_to_keep=7) at /root/doris-master/be/src/vec/core/block.cpp:757 #11 0x56457ff0ff51 in doris::vectorized::VExprContext::filter_block (vexpr_ctx=0x5645bb312200, block=0x5645a9f9fc20, column_to_keep=7) at /root/doris-master/be/src/vec/exprs/vexpr_context.cpp:112 #12 0x56458320780f in doris::vectorized::VScanner::_filter_output_block (this=0x5645b24bfb00, block=0x5645a9f9fc20) at /root/doris-master/be/src/vec/exec/scan/vscanner.cpp:95 #13 doris::vectorized::VScanner::get_block (this=0x5645b24bfb00, state=0x5645c5625c00, block=0x5645a9f9fc20, eof=0x7f020386f097) at /root/doris-master/be/src/vec/exec/scan/vscanner.cpp:72 #14 0x56458320071d in doris::vectorized::ScannerScheduler::_scanner_scan (this=, scheduler=, ctx=0x5645b0d76000, scanner=0x5645b24bfb00) at /root/doris-master/be/src/vec/exec/scan/scanner_scheduler.cpp:306 #15 0x564583202dcd in std::function::operator()() const (this=) at /root/.local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560 #16 doris::PriorityWorkStealingThreadPool::work_thread (this=0x564589608540, thread_id=) at /root/doris-master/be/src/util/priority_work_stealing_thread_pool.hpp:135 #17 0x564586554e60 in execute_native_thread_routine () #18 0x7f02c9de817a in start_thread () from /lib64/libpthread.so.0 #19 0x7f02ca682df3 in clone () from /lib64/libc.so.6 ``` ### What You Expected? Do not crash. ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #17372: [test](external)add hive external different parquet files test 0303
morningman commented on code in PR #17372:
URL: https://github.com/apache/doris/pull/17372#discussion_r1126217232
##
regression-test/suites/external_catalog_p0/hive/test_different_parquet_types.groovy:
##
@@ -0,0 +1,230 @@
+package suites.external_catalog_p0.hive
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_different_parquet_types", "p0") {
+
+String hms_port = context.config.otherConfigs.get("hms_port")
+String hdfs_port = context.config.otherConfigs.get("hdfs_port")
+
+// 发现问题 1 ： hive执行select * from delta_byte_array limit
10可以查出数据，但是doris无法查出数据
+def q01 = {
+def res1_1 = sql """
+select * from delta_byte_array limit 10
+"""
+logger.info("record res" + res1_1.toString())
+
+def res1_2 = sql """
+select count(*) from delta_byte_array
+"""
+logger.info("record res" + res1_2.toString())
+
+def res1_3 = sql """
+select * from hdfs(\"uri" =
\"hdfs://127.0.0.1:${hdfs_port}/user/doris/preinstalled_data/different_types_parquet/delta_byte_array/delta_byte_array.parquet\",\"fs.defaultFS\"
= \"hdfs://127.0.0.1:${hdfs_port}\",\"format\" = \"parquet\") limit 10
+"""
+logger.info("record res" + res1_3.toString())
+}
+
+// hive加载数据报错 此用例无效
+// def q02 = {
+// def res2_1 = sql """
+// select * from delta_length_byte_array limit 10;
+// """
+// logger.info("record res" + res2_1.toString())
+
+// def res2_2 = sql """
+// select count(*) from delta_length_byte_array;
+// """
+// logger.info("record res" + res2_2.toString())
+
+// def res2_3 = sql """
+// select * from hdfs(\"uri" =
\"hdfs://127.0.0.1:${hdfs_port}/user/doris/preinstalled_data/different_types_parquet/delta_length_byte_array/delta_length_byte_array.parquet\",\"fs.defaultFS\"
= \"hdfs://127.0.0.1:${hdfs_port}\",\"format\" = \"parquet\") limit 10
+// """
+// logger.info("record res" + res2_3.toString())
+// }
+
+
+// 发现问题二： hive查询出的数据全为空，doris catalog查询报错 tvf不报错 返回为空
+def q03 = { //hive查询出的数据全为空
+
+//查询报错 [INTERNAL_ERROR]Only support csv data in utf8 codec
+
+def res3_1 = sql """
+select * from delta_binary_packed limit 10;
+"""
+logger.info("record res" + res3_1.toString())
+
+//查询报错 [INTERNAL_ERROR]Only support csv data in utf8 codec
+
+def res3_2 = sql """
+select count(*) from delta_binary_packed;
+"""
+logger.info("record res" + res3_1.toString())
+
+//查询返回数据为空 不报错
+def res3_3 = sql """
+select * from hdfs(\"uri" =
\"hdfs://127.0.0.1:${hdfs_port}/user/doris/preinstalled_data/different_types_parquet/delta_binary_packed/delta_binary_packed.parquet\",\"fs.defaultFS\"
= \"hdfs://127.0.0.1:${hdfs_port}\",\"format\" = \"parquet\") limit 10
+"""
+logger.info("record res" + res3_3.toString())
+}
+
+def q04 = {
+def res4_1 = sql """
+select * from delta_encoding_required_column limit 10;
+"""
+logger.info("record res" + res4_1.toString())
+
+def res4_2 = sql """
+select count(*) from delta_encoding_required_column;
+"""
+logger.info("record res" + res4_2.toString())
+
+//发现问题 Can not get first file, please check uri.
+def res4_3 = sql """
+ select * from hdfs(\"uri" =
\"hdfs://127.0.0.1:${hdfs_port}/user/doris/preinstalled_data/different_types_parquet/delta_encoding_required_column/delta_encoding_required_column.parquet\",\"fs.defaultFS\"
= \"hdfs://127.0.0.1:${hdfs_port}\",\"format\" = \"parquet\") limit 10
+ """
+logger.info("record res" + res4_3.toString())
+}
+
+ // 发现问题三： hive查询报错 doris查询全部为空
+def q05 = {
+def res5_1 = sql """
+select * from delta_encoding_optional_column limit 10;
+"""
+logger.info("record res" + res5_1.toString())
+
+
+def res5_2 = sql """
+select count(*) from delta_encoding_optional_column;
+"""
+logger.info("r
[GitHub] [doris] github-actions[bot] commented on pull request #17459: [Chore](schema change) remove some unused code in schema change
github-actions[bot] commented on PR #17459: URL: https://github.com/apache/doris/pull/17459#issuecomment-1455878076 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17459: [Chore](schema change) remove some unused code in schema change
github-actions[bot] commented on PR #17459: URL: https://github.com/apache/doris/pull/17459#issuecomment-1455878141 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref
github-actions[bot] commented on code in PR #17461:
URL: https://github.com/apache/doris/pull/17461#discussion_r1126218842
##
be/test/util/counts_test.cpp:
##
@@ -59,7 +59,7 @@ TEST_F(TCountsTest, TotalTest) {
counts.merge(&other1);
// 1 1 1 1 2 5 7 7 9 9 10 19 50 50 50 99 99 100 100 100
-EXPECT_EQ(counts.terminate(0.3).val, 6.4);
+EXPECT_EQ(counts.terminate(0.3), 6.4);
Review Comment:
warning: member reference base type 'double' is not a structure or union
[clang-diagnostic-error]
```cpp
EXPECT_EQ(counts.terminate(0.3).val, 6.4);
^
```
**thirdparty/installed/include/gtest/gtest.h:2043:** expanded from macro
'EXPECT_EQ'
```cpp
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
```
**thirdparty/installed/include/gtest/gtest_pred_impl.h:163:** expanded from
macro 'EXPECT_PRED_FORMAT2'
```cpp
GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
^
```
**thirdparty/installed/include/gtest/gtest_pred_impl.h:148:** expanded from
macro 'GTEST_PRED_FORMAT2_'
```cpp
GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
^
```
**thirdparty/installed/include/gtest/gtest_pred_impl.h:76:** expanded from
macro 'GTEST_ASSERT_'
```cpp
if (const ::testing::AssertionResult gtest_ar = (expression)) \
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17455: [Fix](FQDN) fix `show frontends` may result in slow performance when ip changed
hello-stephen commented on PR #17455: URL: https://github.com/apache/doris/pull/17455#issuecomment-1455884370 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.06 seconds stream load tsv: 453 seconds loaded 74807831229 Bytes, about 157 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230306103626_clickbench_pr_109251.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17262: [Enchancement](Materialized-View) add more error infomation for select materialized view fail
github-actions[bot] commented on PR #17262: URL: https://github.com/apache/doris/pull/17262#issuecomment-1455889686 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17262: [Enchancement](Materialized-View) add more error infomation for select materialized view fail
github-actions[bot] commented on PR #17262: URL: https://github.com/apache/doris/pull/17262#issuecomment-1455889757 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg opened a new pull request, #17463: [fix](olap)Crashing caused by IS NULL expression
mrhhsg opened a new pull request, #17463: URL: https://github.com/apache/doris/pull/17463 # Proposed changes Issue Number: close #17462 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #17464: [Enhancement](Planner)fix unclear exception msg when tag.location invaild.
sohardforaname opened a new pull request, #17464: URL: https://github.com/apache/doris/pull/17464 # Proposed changes Issue Number: close #xxx ## Problem summary CREATE TABLE `test` ( `id` BIGINT COMMENT '', ) ENGINE = OLAP DUPLICATE KEY(`dmp_share_cd_time_idatat`) COMMENT 'OLAP' DISTRIBUTED BY HASH(`dmp_share_cd_time_idatat`) BUCKETS AUTO PROPERTIES ( "replication_allocation" = "tag.location: 1", "in_memory" = "false", "storage_format" = "V2", "compression" = "ZSTD", "estimate_partition_size" = "115G", "disable_auto_compaction" = "false" ); exception msg: String index out of range: -1 is weird, now it will be 'Invalid replication allocation location tag property: tag: location: 1' ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #17363: [regression-test](Nereids)add binary arithmetic test for nereids
sohardforaname commented on PR #17363: URL: https://github.com/apache/doris/pull/17363#issuecomment-1455894696 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17463: [fix](olap)Crashing caused by IS NULL expression
github-actions[bot] commented on PR #17463: URL: https://github.com/apache/doris/pull/17463#issuecomment-1455895744 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17300: [Chore](execution) change PipelineTaskState to enum class && remove some row-based code
github-actions[bot] commented on PR #17300: URL: https://github.com/apache/doris/pull/17300#issuecomment-1455897851 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17300: [Chore](execution) change PipelineTaskState to enum class && remove some row-based code
github-actions[bot] commented on PR #17300: URL: https://github.com/apache/doris/pull/17300#issuecomment-1455897767 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly commented on pull request #17284: [fix](nereids) fix bugs in nereids window function
englefly commented on PR #17284: URL: https://github.com/apache/doris/pull/17284#issuecomment-1455903315 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly commented on pull request #16927: [feature](nereids)support bitmap runtime filter on nereids
englefly commented on PR #16927: URL: https://github.com/apache/doris/pull/16927#issuecomment-1455903687 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #17262: [Enchancement](Materialized-View) add more error infomation for select materialized view fail
BiteThet merged PR #17262: URL: https://github.com/apache/doris/pull/17262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Enchancement](Materialized-View) add more error infomation for select materialized view fail (#17262)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 28c55f15c9 [Enchancement](Materialized-View) add more error infomation
for select materialized view fail (#17262)
28c55f15c9 is described below
commit 28c55f15c98f0c6ffd403f532b7b1c951759150c
Author: Pxl
AuthorDate: Mon Mar 6 18:59:46 2023 +0800
[Enchancement](Materialized-View) add more error infomation for select
materialized view fail (#17262)
add more error infomation for select materialized view fail
---
.../java/org/apache/doris/analysis/SlotRef.java| 9 +++
.../apache/doris/planner/SingleNodePlanner.java| 13 -
.../mv_with_view/mv_with_view.groovy | 4 ++
.../test_mv_useless/test_agg_mv_useless.groovy | 47 +---
.../test_mv_useless/test_dup_mv_useless.groovy | 65 ++
.../test_mv_useless/test_uniq_mv_useless.groovy| 16 +-
6 files changed, 33 insertions(+), 121 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
index aa10992ee8..ffb8c2ef37 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
@@ -551,10 +551,19 @@ public class SlotRef extends Expr {
if (!(originExpr instanceof SlotRef)) {
return true; // means this is alias of other expr.
}
+
SlotRef aliasExpr = (SlotRef) originExpr;
if (aliasExpr.getColumnName() == null) {
+if (desc.getSourceExprs() != null) {
+for (Expr expr : desc.getSourceExprs()) {
+if (!expr.matchExprs(exprs, stmt, ignoreAlias, tableName))
{
+return false;
+}
+}
+}
return true; // means this is alias of other expr.
}
+
if (aliasExpr.desc != null) {
TableIf table = aliasExpr.desc.getParent().getTable();
if (table != null && table.getName() != tableName) {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
b/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
index b6abbb8b30..cab354b0be 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
@@ -68,6 +68,7 @@ import org.apache.doris.common.UserException;
import org.apache.doris.common.util.VectorizedUtil;
import org.apache.doris.planner.external.ExternalFileScanNode;
import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.rewrite.mvrewrite.MVSelectFailedException;
import org.apache.doris.thrift.TNullSide;
import org.apache.doris.thrift.TPushAggOp;
@@ -1316,8 +1317,10 @@ public class SingleNodePlanner {
}
public boolean selectMaterializedView(QueryStmt queryStmt, Analyzer
analyzer)
-throws UserException {
+throws UserException, MVSelectFailedException {
boolean selectFailed = false;
+boolean haveError = false;
+String errorMsg = "select fail reason: ";
if (queryStmt instanceof SelectStmt) {
SelectStmt selectStmt = (SelectStmt) queryStmt;
for (TableRef tableRef : selectStmt.getTableRefs()) {
@@ -1364,6 +1367,11 @@ public class SingleNodePlanner {
selectStmt.getAggInfo().updateTypeOfAggregateExprs();
}
} catch (Exception e) {
+if (haveError) {
+errorMsg += ",";
+}
+errorMsg += e.getMessage();
+haveError = true;
tupleSelectFailed = true;
}
}
@@ -1379,6 +1387,9 @@ public class SingleNodePlanner {
selectFailed |=
selectMaterializedView(unionOperand.getQueryStmt(), analyzer);
}
}
+if (haveError) {
+throw new MVSelectFailedException(errorMsg);
+}
return selectFailed;
}
diff --git
a/regression-test/suites/materialized_view_p0/mv_with_view/mv_with_view.groovy
b/regression-test/suites/materialized_view_p0/mv_with_view/mv_with_view.groovy
index 4b794b7cb1..4c147d51ac 100644
---
a/regression-test/suites/materialized_view_p0/mv_with_view/mv_with_view.groovy
+++
b/regression-test/suites/materialized_view_p0/mv_with_view/mv_with_view.groovy
@@ -45,6 +45,10 @@ suite ("mv_with_view") {
}
qt_select_star "select * from d_table order by k1;"
+sql """
+drop view if exists v_k132;
+"""
+
sql """
create view v_k132 as select k1,
[GitHub] [doris] Yulei-Yang commented on pull request #17446: [fix](priv) fix duplicated priv check when check column priv
Yulei-Yang commented on PR #17446: URL: https://github.com/apache/doris/pull/17446#issuecomment-1455925871 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17281: [enhancement](k8s)K8s yml demo
zddr commented on PR #17281: URL: https://github.com/apache/doris/pull/17281#issuecomment-1455927668 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #17445: [fix](meta) fix catalog parameter when checking privilege of show_create_table stmt
Yulei-Yang commented on PR #17445: URL: https://github.com/apache/doris/pull/17445#issuecomment-1455928838 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr commented on a diff in pull request #17281: [enhancement](k8s)K8s yml demo
zddr commented on code in PR #17281: URL: https://github.com/apache/doris/pull/17281#discussion_r1126257977 ## docker/runtime/k8s/backend.yml: ## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +apiVersion: v1 +kind: Service +metadata: + name: dbe Review Comment: Not necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee opened a new pull request, #17465: [RegressionTest](Bug) fix regression test fail to find vec function microseconds_add/sub
HappenLee opened a new pull request, #17465: URL: https://github.com/apache/doris/pull/17465 # Proposed changes Before： ``` mysql> select microseconds_add(col, 10) col1 from test_datetimev2_exprs_test order by col1; ERROR 1105 (HY000): errCode = 2, detailMessage = Function microseconds_add is not implemented ``` After: ``` mysql> select microseconds_add(col, 10) col1 from test_datetimev2_exprs order by col1; +-+ | col1| +-+ | 2022-01-01 11:11:11.211 | | 2022-01-01 11:11:11.322 | +-+ 2 rows in set (0.09 sec) ``` ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr commented on a diff in pull request #17281: [enhancement](k8s)K8s yml demo
zddr commented on code in PR #17281: URL: https://github.com/apache/doris/pull/17281#discussion_r1126258621 ## docker/runtime/k8s/backend.yml: ## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +apiVersion: v1 +kind: Service +metadata: + name: dbe + labels: +app: dbe +spec: + ports: +- port: 9060 + name: be +- port: 8040 + name: webserver +- port: 9050 + name: heartbeat-port #This name should be fixed. Doris will get the port information through this name +- port: 8060 + name: brpc + clusterIP: None + selector: +app: dbe Review Comment: k8s only support -, not _ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow opened a new pull request, #17466: [fix](function) width_bucket should get min and max from each tuple
morrySnow opened a new pull request, #17466: URL: https://github.com/apache/doris/pull/17466 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #17356: [fix](Nereids) remove bitmap_union_int(bigint) signature
morrySnow commented on PR #17356: URL: https://github.com/apache/doris/pull/17356#issuecomment-1455934632 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17466: [fix](function) width_bucket should get min and max from each tuple
github-actions[bot] commented on PR #17466: URL: https://github.com/apache/doris/pull/17466#issuecomment-1455938650 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #17355: [refactor](Nereids): refactor PushdownLimit
morrySnow commented on code in PR #17355:
URL: https://github.com/apache/doris/pull/17355#discussion_r1126263751
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushdownLimit.java:
##
@@ -67,65 +74,45 @@ public List buildRules() {
LogicalUnion union = limit.child();
ImmutableList newUnionChildren =
union.children()
.stream()
-.map(child -> addLimit(limit, child))
+.map(child -> limit.withChildren(child))
.collect(ImmutableList.toImmutableList());
+if (union.children().equals(newUnionChildren)) {
+return null;
+}
return
limit.withChildren(union.withChildren(newUnionChildren));
})
-.toRule(RuleType.PUSH_LIMIT_THROUGH_UNION)
+.toRule(RuleType.PUSH_LIMIT_THROUGH_UNION),
+logicalLimit(logicalOneRowRelation())
+.then(limit -> limit.getLimit() > 0
+? limit.child() : new
LogicalEmptyRelation(limit.child().getOutput()))
+.toRule(RuleType.PUSH_LIMIT_THROUGH_ONE_ROW_RELATION),
Review Comment:
this rule name is not good. it do not push limit **THROUGH** one row relation
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushdownLimit.java:
##
@@ -67,65 +74,45 @@ public List buildRules() {
LogicalUnion union = limit.child();
ImmutableList newUnionChildren =
union.children()
.stream()
-.map(child -> addLimit(limit, child))
+.map(child -> limit.withChildren(child))
.collect(ImmutableList.toImmutableList());
+if (union.children().equals(newUnionChildren)) {
+return null;
+}
return
limit.withChildren(union.withChildren(newUnionChildren));
})
-.toRule(RuleType.PUSH_LIMIT_THROUGH_UNION)
+.toRule(RuleType.PUSH_LIMIT_THROUGH_UNION),
+logicalLimit(logicalOneRowRelation())
+.then(limit -> limit.getLimit() > 0
+? limit.child() : new
LogicalEmptyRelation(limit.child().getOutput()))
+.toRule(RuleType.PUSH_LIMIT_THROUGH_ONE_ROW_RELATION),
+logicalLimit(logicalEmptyRelation())
+.then(UnaryNode::child)
+.toRule(RuleType.PUSH_LIMIT_THROUGH_EMPTY_RELATION),
Review Comment:
ditto, may be eliminate limit on is better
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushdownLimit.java:
##
@@ -40,24 +39,32 @@
*
* Limit can't be push down if it has a valid offset info.
*/
-public class LimitPushDown implements RewriteRuleFactory {
+public class PushdownLimit implements RewriteRuleFactory {
@Override
public List buildRules() {
return ImmutableList.of(
// limit -> join
logicalLimit(logicalJoin(any(),
any())).whenNot(Limit::hasValidOffset)
Review Comment:
maybe do not need `join(any(), any())`? `join()` is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu opened a new pull request, #17467: [fix](resource)Add s3 checker for alter resource
pengxiangyu opened a new pull request, #17467: URL: https://github.com/apache/doris/pull/17467 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] bobhan1 commented on issue #17448: [Feature] (array fucntion) support array_enumerate_uniq function
bobhan1 commented on issue #17448: URL: https://github.com/apache/doris/issues/17448#issuecomment-1455953894 @eldenmoon `gensrc/script/doris_builtins_functions.py`中有没有办法表示任意长度的入参？因为`array_enumerate_uniq()`函数的参数个数是可以是任意的。还是说现阶段我们只能手动枚举不同参数个数(一定范围内)的函数签名？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #17355: [refactor](Nereids): refactor PushdownLimit
morrySnow commented on code in PR #17355:
URL: https://github.com/apache/doris/pull/17355#discussion_r1126274674
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushdownLimit.java:
##
@@ -67,65 +74,45 @@ public List buildRules() {
LogicalUnion union = limit.child();
ImmutableList newUnionChildren =
union.children()
.stream()
-.map(child -> addLimit(limit, child))
+.map(child -> limit.withChildren(child))
.collect(ImmutableList.toImmutableList());
+if (union.children().equals(newUnionChildren)) {
+return null;
+}
return
limit.withChildren(union.withChildren(newUnionChildren));
})
-.toRule(RuleType.PUSH_LIMIT_THROUGH_UNION)
+.toRule(RuleType.PUSH_LIMIT_THROUGH_UNION),
+logicalLimit(logicalOneRowRelation())
+.then(limit -> limit.getLimit() > 0
+? limit.child() : new
LogicalEmptyRelation(limit.child().getOutput()))
+.toRule(RuleType.PUSH_LIMIT_THROUGH_ONE_ROW_RELATION),
+logicalLimit(logicalEmptyRelation())
+.then(UnaryNode::child)
+.toRule(RuleType.PUSH_LIMIT_THROUGH_EMPTY_RELATION),
Review Comment:
we have a file named EliminateLimit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu commented on pull request #17246: [feature](cooldown)add ut for cooldown on be
pengxiangyu commented on PR #17246: URL: https://github.com/apache/doris/pull/17246#issuecomment-1455965402 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] pengxiangyu commented on pull request #17467: [fix](resource)Add s3 checker for alter resource
pengxiangyu commented on PR #17467: URL: https://github.com/apache/doris/pull/17467#issuecomment-1455965559 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #17450: [enhance](Nereids): refactor code in Project
jackwener commented on PR #17450: URL: https://github.com/apache/doris/pull/17450#issuecomment-1455967440 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #17452: [enhance](Nereids): remove rule flag in LogicalJoin
jackwener commented on PR #17452: URL: https://github.com/apache/doris/pull/17452#issuecomment-1455968562 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17281: [Enhance](k8s)K8s yml demo
github-actions[bot] commented on PR #17281: URL: https://github.com/apache/doris/pull/17281#issuecomment-1455971881 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17281: [Enhance](k8s)K8s yml demo
github-actions[bot] commented on PR #17281: URL: https://github.com/apache/doris/pull/17281#issuecomment-1455971935 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr commented on pull request #17358: [doc](auth)auth doc
zddr commented on PR #17358: URL: https://github.com/apache/doris/pull/17358#issuecomment-1455978701 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
