github-actions[bot] commented on code in PR #17461: URL: https://github.com/apache/doris/pull/17461#discussion_r1126218842
########## be/test/util/counts_test.cpp: ########## @@ -59,7 +59,7 @@ TEST_F(TCountsTest, TotalTest) { counts.merge(&other1); // 1 1 1 1 2 5 7 7 9 9 10 19 50 50 50 99 99 100 100 100 - EXPECT_EQ(counts.terminate(0.3).val, 6.4); + EXPECT_EQ(counts.terminate(0.3), 6.4); Review Comment: warning: member reference base type 'double' is not a structure or union [clang-diagnostic-error] ```cpp EXPECT_EQ(counts.terminate(0.3).val, 6.4); ^ ``` **thirdparty/installed/include/gtest/gtest.h:2043:** expanded from macro 'EXPECT_EQ' ```cpp EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ ``` **thirdparty/installed/include/gtest/gtest_pred_impl.h:163:** expanded from macro 'EXPECT_PRED_FORMAT2' ```cpp GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_) ^ ``` **thirdparty/installed/include/gtest/gtest_pred_impl.h:148:** expanded from macro 'GTEST_PRED_FORMAT2_' ```cpp GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \ ^ ``` **thirdparty/installed/include/gtest/gtest_pred_impl.h:76:** expanded from macro 'GTEST_ASSERT_' ```cpp if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org