github-actions[bot] commented on code in PR #17461:
URL: https://github.com/apache/doris/pull/17461#discussion_r1126214752
##########
be/src/exprs/function_filter.h:
##########
@@ -26,7 +26,7 @@ namespace doris {
class FunctionFilter {
public:
FunctionFilter(bool opposite, const std::string& col_name,
doris::FunctionContext* fn_ctx,
- doris::StringVal string_param)
+ doris::StringRef string_param)
Review Comment:
warning: variable has incomplete type 'doris::StringRef'
[clang-diagnostic-error]
```cpp
doris::StringRef string_param)
^
```
**be/src/udf/udf.h:33:** forward declaration of 'doris::StringRef'
```cpp
struct StringRef;
^
```
##########
be/src/exprs/function_filter.h:
##########
@@ -36,8 +36,8 @@
std::string _col_name;
// these pointer's life time controlled by scan node
doris::FunctionContext* _fn_ctx;
- doris::StringVal
- _string_param; // only one param from conjunct, because now only
support like predicate
+ // only one param from conjunct, because now only support like predicate
+ doris::StringRef _string_param;
Review Comment:
warning: field has incomplete type 'doris::StringRef'
[clang-diagnostic-error]
```cpp
doris::StringRef _string_param;
^
```
**be/src/udf/udf.h:33:** forward declaration of 'doris::StringRef'
```cpp
struct StringRef;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
