Re: Review Request 125485: Unselect text when the text tool is deactivated.

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125485/#review86281
---


This change would go against a lot of special code that ensures the selection 
stays so I would not like this to go in - what i am not getting is why this is 
a problem - when the textshape is no longer selected the text is not either - 
so can you please explain a bit more - if I get it right the problem is more 
that the textshape stays selected when the slide is changed

- Camilla Boemann


On Oct. 2, 2015, 8:53 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125485/
> ---
> 
> (Updated Oct. 2, 2015, 8:53 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Otherwise text remains selected in Stage after switching to another
> shape, which is very unexpected.
> 
> 
> Diffs
> -
> 
>   plugins/textshape/TextTool.cpp dd9e0df252bb6ab6bcd25bb27c20fb8af29839cc 
> 
> Diff: https://git.reviewboard.kde.org/r/125485/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 125485: Unselect text when the text tool is deactivated.

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125485/#review86285
---


ahh - well i still think the solution is wrong and i am in berlin for the qt 
world summit so no near my home computer, but will take a look when I get a 
chance

- Camilla Boemann


On Oct. 3, 2015, 9:56 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125485/
> ---
> 
> (Updated Oct. 3, 2015, 9:56 a.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Otherwise text remains selected in Stage after switching to another
> shape, which is very unexpected.
> 
> 
> Diffs
> -
> 
>   plugins/textshape/TextTool.cpp dd9e0df252bb6ab6bcd25bb27c20fb8af29839cc 
> 
> Diff: https://git.reviewboard.kde.org/r/125485/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> text-selection-bug.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/d7bcacc1-e0c0-4021-9055-aa2b77f39a71__text-selection-bug.png
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 125509: TextTool: ignore Esc key so that it can be used to switch back to the interaction tool

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125509/#review86330
---

Ship it!


Ship It!

- Camilla Boemann


On Oct. 3, 2015, 5:21 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125509/
> ---
> 
> (Updated Oct. 3, 2015, 5:21 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> I expected the "empty text" test to catch it, but actually Key_Escape 
> generates
> the text "\033".
> 
> 
> Diffs
> -
> 
>   plugins/textshape/TextTool.cpp 8aa18917351c79b34e810fdbe29d229449cef856 
> 
> Diff: https://git.reviewboard.kde.org/r/125509/diff/
> 
> 
> Testing
> ---
> 
> Esc finally works ;)
> 
> I've been missing this since the flake redesign.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: ChangeListLevelCommand bug?

[Camilla Boemann]

Could look like that yes - unfortunately the guy who were most into this have 
not been active for over a year so i think the best way to know for sure is to 
debug it - all i can say is that the layout works

so it's either the interaction  - but your evidence suggests that is correct

or the setup of the indentation - as you suggest that is the culprit'

it could also be that it does something weird on purpose


> On 03 Oct 2015, at 23:43, David Faure  wrote:
> 
> If I make bullets in a calligra textbox, and press Key_Tab, the first time 
> nothing happens,
> I have to press Tab again to see the paragraph move to the right.
> 
> Debugging ChangeListLevelCommand::ChangeListLevelCommand shows
> 
> m_levels = QHash((0, 2)) 
> 
> the first time, and 
> 
> m_levels = QHash((0, 3)) 
> 
> the second time.
> 
> This looks correct, so does this mean the indentation position for level 1 
> and level 2 are the same ??
> 
> (please CC me)
> 
> -- 
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
> 
> ___
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: findings from the plugfest

[Camilla Boemann]

Thanks



-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Jos 
van den Oever
Sent: 19. november 2015 09:48
To: Calligra Suite developers and users mailing list 
Subject: findings from the plugfest

Hello dear Calligra developers,

At the last ODF plugfest, Calligra was put under quite some scrutiny, as were 
the other office suites.
The findings were written down in a report:
  http://odfplugfest.org/2015-thehague/report.html

The number of bugs found can be seen at the bottom of the page. The individual 
bugs for Calligra are prepended with 'Bug: Calligra'.

The names in bugs relate to the tests at
   http://autotests.opendocumentformat.org/

I hope you find the report useful in improving Calligra. At the next plugfest 
we will be running and evaluating the tests again.

Best regards,
Jos van den Oever

--
Jos van den Oever
co-chair OpenDocument Format Technical Committee 
.
Ministry of the Interior and Kingdom Relations Center for Standards | Logius 
Wilhelmina van Pruisenweg 52 | 2595 AN | Den Haag Postbus 96810 | 2509 JE | Den 
Haag 
.
M +31(0)6-54715404
jos.vanden.oe...@logius.nl
www.logius.nl
www.oasis-open.org/committees/office/
.
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: KDE ODF TC membership

[Camilla Boemann]

Yes it's still true

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Jos 
van den Oever
Sent: 3. december 2015 10:31
To: calligra-devel@kde.org
Subject: KDE ODF TC membership

Hello all,

Since September I represent the Dutch government in the ODF TC, although since 
they were not an OASIS member yet, officially I was still associated with KDE. 
Now .nl has joined OASIS, so I will not represent KDE any more in OASIS.

Currently Friedrich and Camilla are also registered at OASIS. I think Camilla 
volunteered to take over as primary contact. Is that still true?

So Calligra representation at OASIS is reduced by one. Would somebody else like 
to step up?

Cheers,
Jos


___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: Consistent naming of folders in libs/ & renaming kundo2 -> koundo

[Camilla Boemann]

Yeah regarding library names the renaming should rather be the other way

I don't want that ko everywhere

And regarding kundo2 - wasn't it supposed to be a clone of the qt5 so we could 
get rid of our own version ?

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of 
Friedrich W. H. Kossebau
Sent: 8. januar 2016 23:20
To: calligra-devel@kde.org
Subject: Consistent naming of folders in libs/ & renaming kundo2 -> koundo

Hi,

to remove some complexity and add more patterns to the code structure, both for 
us current developers and even more for future developers trying to grasp the 
landscapes of Calligra code, I will be going to do two things next week (around 
Wednesday 13th) in master:

a) rename the kundo2 lib and all its classes to koundo/KoUndo

b) rename folders in libs/ consistently to match the lib name

   version -> koversion
   widgetutils -> widgetutils
   widgets -> kowidgets
   store -> kostore
   odf -> koodf
   textlayout -> kotextlayout
   kundo2 -> koundo
main -> komain
rdf -> kordf
vectorimage -> kovectorimage


Any issues with that?

Cheers
Friedrich
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 125485: Unselect text when the text tool is deactivated.

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125485/#review92851
---



I'd prefer if this doesn't go in
In words at least it's on purpose that we keep the text selection. 1) because 
we wan't it to be selected so other tools can work with it 2) we want it to be 
there when the text tool is reactivated

some other solution might eventually work like not render the selection if the 
current tool doesn't want it to be rendered

- Camilla Boemann


On Oct. 3, 2015, 9:56 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125485/
> ---
> 
> (Updated Oct. 3, 2015, 9:56 a.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Otherwise text remains selected in Stage after switching to another
> shape, which is very unexpected.
> 
> 
> Diffs
> -
> 
>   plugins/textshape/TextTool.cpp dd9e0df252bb6ab6bcd25bb27c20fb8af29839cc 
> 
> Diff: https://git.reviewboard.kde.org/r/125485/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> text-selection-bug.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/d7bcacc1-e0c0-4021-9055-aa2b77f39a71__text-selection-bug.png
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra and GSoC 2016

[Camilla Boemann]

On Thursday 03 March 2016 01:08:11 Денис Купляков wrote:
> Good evening!
> 
> As you know GSoC 2016 will start soon. And I will be very happy to
> participate the third time with Calligra. Sorry, for being out of the deal
> for long period of time: I took too much of additional courses in
> university and I am on the final year of bachelor program, so were working
> on my qualification work.
> 
> So first question is: does Calligra plan to participate in GSoC this year?
> 
> Best regards, Denis Kuplyakov
I've replied in private.

Camilla
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127371/#review93691
---



In general my reservations is the same as you explain - an entire method just 
to enable a plugin

in theory it would be possible to use selectionRect but I conceede it would be 
really un-economical


libs/textlayout/KoTextLayoutEndNotesArea.h (line 48)
<https://git.reviewboard.kde.org/r/127371/#comment63880>

apidox pls since it's use is so specific



libs/textlayout/KoTextLayoutTableArea.cpp (line 287)
<https://git.reviewboard.kde.org/r/127371/#comment63881>

because for painting we want to repeat the headers on every page :)


- Camilla Boemann


On March 18, 2016, 12:56 a.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127371/
> ---
> 
> (Updated March 18, 2016, 12:56 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> A first approach to collect chars and their positions on a given page, as 
> needed by Okular.
> 
> I followed the logic used for painting, as that one also needs to calculate 
> what content is part of a certain page, so copying the algorithm seemed most 
> obvious for a start.
> 
> Disadvantage: This approach needs access to internal data of the area 
> objects, so I had to add the code to the actual *Area classes. So they now 
> carry logic for a currently single use-case, which also is not the most 
> typical. Surely not a lot of code, but ideally this special need for the 
> Okular plugin should not add its payload for everyone.
> 
> So looking for better ideas here, at least for later.
> 
> TODOs for the future:
> - text from master pages (headers/footers)
> - text in objects (floating text boxes, diagrams, whatever)
> - include header/paragraph numbering/bullet points
> - only add line-breaks for real paragraph ends perhaps
> 
> Please give this some first round of feedback. IMHO it already adds value, as 
> it finally allows to copy text from the main textflow.
> So would not mind to have this as-is for 3.0, to be improved than at least 
> later, if not before. Unless it is unacceptable for good reasons :)
> 
> In a perfect future Okular´s plugin API will allow native selections, so all 
> the knowledge about text flow is not lost. But for now we have to support the 
> API which exists.
> 
> (Short note: I will not be able to instantly reply, currently seeing to 
> replace broken IT, might take another week at least, no email or irc for now. 
> This patch here was already uploaded before things turned defunct locally, so 
> pushing it out now for review at least).
> 
> 
> Diffs
> -
> 
>   extras/okularodtgenerator/OkularOdtGenerator.h c4404c4 
>   extras/okularodtgenerator/OkularOdtGenerator.cpp d1d428d 
>   libs/textlayout/KoCharAreaInfo.h PRE-CREATION 
>   libs/textlayout/KoTextLayoutArea.h 27934d7 
>   libs/textlayout/KoTextLayoutArea.cpp bacfa58 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 6c1eb12 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp 2c1e241 
>   libs/textlayout/KoTextLayoutTableArea.h 8d912ee 
>   libs/textlayout/KoTextLayoutTableArea.cpp 4d2cdc1 
> 
> Diff: https://git.reviewboard.kde.org/r/127371/diff/
> 
> 
> Testing
> ---
> 
> Normal text, text in tables, text in generated content, footnotes & endnotes 
> could be selected in the ODT (& DOC/DOCX/WPD) files I tried.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 127338: Fix loading documents containing nested tables

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127338/#review93406
---



Again  - thanks but please close as discarded - I already have made a more 
correct fix - it's however not pushed to master yet - so please have some 
patience

- Camilla Boemann


On March 11, 2016, 12:08 a.m., Laszlo Pasztor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127338/
> ---
> 
> (Updated March 11, 2016, 12:08 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=359700
> 
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=359700
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Fix: in Calligra Words inserting a table to the first cell of a table causes 
> inserting an extra table after saving and loading the document back.
> 
> Reproducible: Always
> 
> 
> Diffs
> -
> 
>   libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 
> 
> Diff: https://git.reviewboard.kde.org/r/127338/diff/
> 
> 
> Testing
> ---
> 
> Steps to Reproduce:
> 1. Create a table.
> 2. Insert a table to the first cell of the previously created table.
> 3. Save the document. 
> 4. Close Words. 
> 5. Open Words with saved document.
> 
> Actual Results:  
> An additional table is inserted before the first table.
> 
> Expected Results:  
> Number of tables should be the same after saving.
> 
> 
> File Attachments
> 
> 
> Before saving
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/10/86fb1940-c90c-4458-8f44-ddf726107f2d__beforesave.png
> After reopening
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/10/f740fe55-bece-4d15-87c7-0149c03940e1__afteropen.png
> 
> 
> Thanks,
> 
> Laszlo Pasztor
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 124641: Refactoring KoTextEditor::recursivelyVisitSelection() to make it cleaner and easier to understand

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124641/#review93942
---



This rewrite fails as it doesn't check for cell1 == cell2 in which case it's 
not a complex selection

so it fails

please discard request

- Camilla Boemann


On Aug. 6, 2015, 11:48 a.m., Soma Schliszka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124641/
> ---
> 
> (Updated Aug. 6, 2015, 11:48 a.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> The KoTextEditor::recursivelyVisitSelection() function had a bit complex 
> conditional expression when there is a table inside the selection. 
> This change is following the previous behaviour but the expression is built 
> more logically. It isn't the shortest version, but it's much easier to 
> understand and simpler to use.
> There are several cases of selecting a table, and it's not trivial to say 
> whether entire or just a part is selected.
> 
> * The process has been divided into two section: first, the conditional 
> expression decides about the visiting mode (party or entirely), than just 
> 'visit' the objects in order.
> * I wasn't sure about why is it necessary to select the entire table in a 
> different way? If the entire table is selected, than selectedTableCells() 
> should do the same. That's why there is no different caret-selection-handling 
> right before the visit.
> * Other modification is the removed duplicate of cell-protection-check. If 
> only one cell is selected, the loop still can operate, just runs only once.
> * The patch contains many inline comments to cover all cases clearly.
> 
> *This patch is just a suggestion to make this snippet more cleaner.*
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoTextEditor.cpp 392f682 
> 
> Diff: https://git.reviewboard.kde.org/r/124641/diff/
> 
> 
> Testing
> ---
> 
> Builded successfully, table works the same as before.
> 
> 
> Thanks,
> 
> Soma Schliszka
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127371/#review94025
---


Ship it!




Ship It!

- Camilla Boemann


On March 18, 2016, 12:56 a.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127371/
> ---
> 
> (Updated March 18, 2016, 12:56 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> A first approach to collect chars and their positions on a given page, as 
> needed by Okular.
> 
> I followed the logic used for painting, as that one also needs to calculate 
> what content is part of a certain page, so copying the algorithm seemed most 
> obvious for a start.
> 
> Disadvantage: This approach needs access to internal data of the area 
> objects, so I had to add the code to the actual *Area classes. So they now 
> carry logic for a currently single use-case, which also is not the most 
> typical. Surely not a lot of code, but ideally this special need for the 
> Okular plugin should not add its payload for everyone.
> 
> So looking for better ideas here, at least for later.
> 
> TODOs for the future:
> - text from master pages (headers/footers)
> - text in objects (floating text boxes, diagrams, whatever)
> - include header/paragraph numbering/bullet points
> - only add line-breaks for real paragraph ends perhaps
> 
> Please give this some first round of feedback. IMHO it already adds value, as 
> it finally allows to copy text from the main textflow.
> So would not mind to have this as-is for 3.0, to be improved than at least 
> later, if not before. Unless it is unacceptable for good reasons :)
> 
> In a perfect future Okular´s plugin API will allow native selections, so all 
> the knowledge about text flow is not lost. But for now we have to support the 
> API which exists.
> 
> (Short note: I will not be able to instantly reply, currently seeing to 
> replace broken IT, might take another week at least, no email or irc for now. 
> This patch here was already uploaded before things turned defunct locally, so 
> pushing it out now for review at least).
> 
> 
> Diffs
> -
> 
>   extras/okularodtgenerator/OkularOdtGenerator.h c4404c4 
>   extras/okularodtgenerator/OkularOdtGenerator.cpp d1d428d 
>   libs/textlayout/KoCharAreaInfo.h PRE-CREATION 
>   libs/textlayout/KoTextLayoutArea.h 27934d7 
>   libs/textlayout/KoTextLayoutArea.cpp bacfa58 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 6c1eb12 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp 2c1e241 
>   libs/textlayout/KoTextLayoutTableArea.h 8d912ee 
>   libs/textlayout/KoTextLayoutTableArea.cpp 4d2cdc1 
> 
> Diff: https://git.reviewboard.kde.org/r/127371/diff/
> 
> 
> Testing
> ---
> 
> Normal text, text in tables, text in generated content, footnotes & endnotes 
> could be selected in the ODT (& DOC/DOCX/WPD) files I tried.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: working on saving to multiple formats

[Camilla Boemann]

Yes we simply havn't had the manpower to do this - so would appreciate any help

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Ryein 
C. Goddard
Sent: 16. maj 2016 00:54
To: calligra-devel@kde.org
Subject: working on saving to multiple formats

I was speaking with some folks on the kubuntu forum and they said the reason 
they didn't go with Calligra was because it cannot save to multiple file 
formats.

Any reason for this?  Is this an area that needs extra developer help?

Thanks
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: working on saving to multiple formats

[Camilla Boemann]

You are quite correct in that Words, Sheets and Stage can’t say to anything but 
ODF formats. The only format besides that is pdf and I think .txt neither of 
which is what people think of when talking about saving.

 

If it says Words can save to Word then it is to rtf when leaves a lot to be 
desired. Plan doesn’t save explicitly as it saves automatically all the time.

 

So there is free reign as to getting more saving support in. Saving to other 
formats is done through what we call filters. They take an .odf file and 
convert it to a target format file. So it’s rather independent of the rest of 
Calligra. That said there are some helper libraries, and something else to note 
is that we would prefer to not pull in any big dependencies.

 

Best regards

Camilla

 

From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Ryein 
Goddard
Sent: 16. maj 2016 23:41
To: Calligra Suite developers and users mailing list 
Subject: Re: working on saving to multiple formats

 

In 16.04 calligra can save to word in words, author. Sheets can't yet though. 
From what I can see Brain Dump doesn't save at all. Plan still needs saving 
functionality for word.

 

I haven't gotten a source version built because I wanted to talk with you all 
first to check.  I'd really love to help getting Kubuntu to a fully pure Qt/KDE 
state.  

 

On Mon, May 16, 2016 at 3:10 AM, Jaroslaw Staniek mailto:stan...@kde.org> > wrote:

 

 

On 16 May 2016 at 00:53, Ryein C. Goddard mailto:ry...@goddardlabs.com> > wrote:

I was speaking with some folks on the kubuntu forum and they said the reason
they didn't go with Calligra was because it cannot save to multiple file
formats.

 

​Calligra supports multiple formats in the Save As dialog.. Could you be more 
specific? 
Maybe it means level of support?

On the other hand we know that availability and timing for updates in _Ubuntu_ 
in general is rather suboptimal.

Special cases, for example Kexi has better support for file formats than the 
Kubuntu's default -- Kexi directly supports MDB and does not drag Java 
dependencies to the desktop. Kubuntu's counterparts do not have these 
advantages.

 

 

Any reason for this?  Is this an area that needs extra developer help?

 

​Yes, always. ​

 

Scope of the challenge shows that such projects can be easily of the size of 
entire KDE. There's probably more of specifications to implement/maintain/test 
than in web browser projects.
​


Thanks
___
calligra-devel mailing list
calligra-devel@kde.org  
https://mail.kde.org/mailman/listinfo/calligra-devel




-- 

regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek


___
calligra-devel mailing list
calligra-devel@kde.org  
https://mail.kde.org/mailman/listinfo/calligra-devel

 

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: Contributing again

[Camilla Boemann]

Hi and welcome back

I think the review policy is as ever, get it reviewed somehow if it touches 
common areas.

We use phabricator as the online tool.

So glad to get this mail - I feel motivated to hack this weekend too now - 
let's try and get this release going :)

Best regards
Camilla Boemann

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Dag
Sent: 1. juli 2016 09:22
To: calligra-devel@kde.org
Subject: Contributing again

Hi all,
looks like I will have some idle time over the summer, so I thought I might 
help getting 3.0 on the road.
Could somebody give directions on what's left, what has priority etc.
Probably not all apps will make it into 3.0?

I already had a look at plan and fixed a couple of crashes.
How is the commit/review policy atm?

Cheers,
Dag
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

state of release and release plan

[Camilla Boemann]

Hi

I think it's time we get a release out. We are stuck with not much work going 
on so inspired by Dag's return let's do a push to get ready.

I think we should cut down on the number of applications so we have something 
manageble left. It's tough but the alternative is that Calligra dies 
completely. And nothing prevents us from bringing apps back  later.

So my question is: What is missing for us to have a release. I am not talking 
about all the nice to have features and bug fixes. I am asking what would 
create huge problems for our users if we release.

Let's get things listed. I'll start:


Words: Nothing blocking

Stage: Nothing I'm aware of

Sheets: ???

Plan: the locale thing? how much would a quick fix take or should we just 
exclude Plan from first release?

Karbon: let's exclude from first release

Flow: let's exclude from first release

Kexi: are they even a part of the release schedule anymore

Braindump: let's drop it completely


Common stuff: ???

please fill in

and let's get ready for a release in a month or so ? We need to set a short 
deadline to keep motivation high

best regards
Camilla
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: state of release and release plan

[Camilla Boemann]

Looking at that I'd say only time and currency are real blockers - the others 
are lost functionality but nothing that produces wrong output

RDF support is lost in words, but that shouldn't stop the release

On Saturday 02 July 2016 20:37:17 Dag wrote:
> Preliminary input for Plan. Note that I have not even open all views
> much less tried much functionality, so there may be (a lot) more...
> Also, I'm on vacation 2 last weeks of july and 3. week of august, so
> expecting to be release ready in 1 month would be a bit optimistic ;)
> That said, this is what I know of now:
> 
> Locale/datetime: This could be a difficult problem. A possible solution
> could be to use time_t internally/for calculations etc and convert to
> QDateTime for ui.
> 
> Locale/currency: Should not be a problem, just needs a way to set the
> currency to use for a project so it does not follow the users locale.
> 
> Kross/python: Scripting is used for some functionallity so python
> support is needed. (or else convert to javascript)
> 
> Reports/KReport:
> Scripting is used for getting data from Project and ScheduleManager.
> Alternative to fix KReport is to implement a different way to get this
> info in Plan.
> 
> Report items Chart and Web has not afaics been ported yet.
> 
> Expects to know more on monday,
> Dag
> 
> Camilla Boemann skrev den 2016-07-02 08:17:
> > Hi
> > 
> > I think it's time we get a release out. We are stuck with not much work
> > going
> > on so inspired by Dag's return let's do a push to get ready.
> > 
> > I think we should cut down on the number of applications so we have
> > something
> > manageble left. It's tough but the alternative is that Calligra dies
> > completely. And nothing prevents us from bringing apps back  later.
> > 
> > So my question is: What is missing for us to have a release. I am not
> > talking
> > about all the nice to have features and bug fixes. I am asking what
> > would
> > create huge problems for our users if we release.
> > 
> > Let's get things listed. I'll start:
> > 
> > 
> > Words: Nothing blocking
> > 
> > Stage: Nothing I'm aware of
> > 
> > Sheets: ???
> > 
> > Plan: the locale thing? how much would a quick fix take or should we
> > just
> > exclude Plan from first release?
> > 
> > Karbon: let's exclude from first release
> > 
> > Flow: let's exclude from first release
> > 
> > Kexi: are they even a part of the release schedule anymore
> > 
> > Braindump: let's drop it completely
> > 
> > 
> > Common stuff: ???
> > 
> > please fill in
> > 
> > and let's get ready for a release in a month or so ? We need to set a
> > short
> > deadline to keep motivation high
> > 
> > best regards
> > Camilla
> > ___
> > calligra-devel mailing list
> > calligra-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/calligra-devel
> 
> ___
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Introduction of a "type mode" and an "unicode mode" of input

[Camilla Boemann]

Hi

I don't  understand this either.

1) all text in calligra is unicode
2) we have a dialog that allows you to enter specific charactes from any 
unicode range
3) yes it is true that the font used to show the text has to support the 
script. But a few free unicode fonts do exist already

On Saturday 02 July 2016 15:13:03 Huxshathra Theudanaz wrote:
> A distinction between two types of input, a "type mode" and an "unicode
> mode" in all Calligra applications. In "unicode mode," there should be two
> boxes, one that asks to "choose unicodfoe range" and the other that asks to
> "choose unicode font." Users should select an unicode range, such as Greek
> or Cyrillic, and then choose from a number of unicode fonts, which should
> come with Calligra, that support that range.
> 
> "Type mode" and "unicode mode" are different even now. If someone wants to
> type in non-Western European characters, they usually type in "type mode"
> using fonts they buy. Another option is to type in an unicode font such as
> Arial Unicode MS, and the other unicode fonts are obscure. As one plus,
> "unicode mode" of input will allow these typists to type in their language
> or script without having at buy extra fonts.
> 
> Plus word processors and email clients and apps usually do distinguish
> between "type" and "unicode." This feature will fully allow someone to
> type, create, and share documents in unicode.

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Introduction of a "type mode" and an "unicode mode" of input

[Camilla Boemann]

On Saturday 02 July 2016 21:18:05 Samiur Rahman wrote:
> The box should actually say "“Choose character set."

Definitely not. We use unicode and nothing else. We want to support the entire 
world. But we don't ship fonts and we don't provide input methods for other 
languages. Both tasks fall under the responsibility of the OS and user. We 
don't ship western fonts either mind you.

I feel that you mean something else like a way to select several "current 
fonts" rather than just a single font. And a way to assign what unicode range 
uses what font. Such multifont selection is only useful when you mix different 
scripts but maybe that is what you mean?'

best regards
Camilla


___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Introduction of a "type mode" and an "unicode mode" of input

[Camilla Boemann]

On Sunday 03 July 2016 12:06:40 Jos van den Oever wrote:
> On Sunday 03 July 2016 10:54:21 Camilla Boemann wrote:
> > I feel that you mean something else like a way to select several "current
> > fonts" rather than just a single font. And a way to assign what unicode
> > range uses what font. Such multifont selection is only useful when you mix
> > different scripts but maybe that is what you mean?'
> 
> ODF, SVG and CSS allow you to use a font only for a subset of characters.
> 
> https://www.w3.org/TR/REC-CSS2/fonts.html#descdef-unicode-range
> http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__
> RefHeading__1418164_253892949
> 
> Cheers,
> Jos
> 
Yes I know I what I had in mind to tie it to
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: How to number components of Calligra 3

[Camilla Boemann]

On Sunday 03 July 2016 01:10:52 Jaroslaw Staniek wrote:
> How to number components of Calligra 3? I mean apps and libs.

Well I wouldn't mind dates or codenames for the public versioning, but 
versions numbers are also for internal usage, so we know when we make big 
api/code changes

And I see no reason why we should change our internal numbering to 4.x just 
because you make huge ui changes.

I would however be fine with us having a more user friendly version scheme in 
addition to our current numbering.

best regards
Camilla
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: Plan status

[Camilla Boemann]

Have a nice vacation!

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Dag
Sent: 15. juli 2016 14:10
To: calligra-devel@kde.org
Subject: Plan status

Vacation is going to hit soon, and plan is not ready...
It has been a frustrating week with too much time used on non-productive 
things, but progress *has* been made and I am fairly confident I will be able 
to have something mid august.

Regarding currency, does somebody know what is needed for sheets?
Plan doesn't need a lot, but I was thinking about lifting at least some of the 
code from kde4, if it isn't too much hassle.

Well, I'm off a couple of weeks, have a nice summer everybody!

See you,
Dag
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: Qt version

[Camilla Boemann]

My build machine (debian) is still 5.6 so until they are at 5.7 I cannot
agree to bumping higher than 5.6

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of
Dag
Sent: 10. august 2016 14:27
To: calligra-devel@kde.org
Subject: Qt version

I added a 5.7 specific thing recently, which prompts the question:
which qt version will be used in the release?

Cheers, Dag

RE: state of release and release plan

[Camilla Boemann]

Thanks Boud for the offer - much appreciated!

Dag let's try and get something out the sooner the better - even if it has
some known bugs that are not too serious -  it's the only way to create buzz
and hopefully draw in more volunteers

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of
Dag
Sent: 12. november 2016 10:45
To: Calligra Suite developers and users mailing list

Subject: Re: state of release and release plan

Boudewijn Rempt skrev den 2016-11-11 15:16:
> On Tue, 8 Nov 2016, Dag wrote:
> 
>> Ok, seems we have some sort of commitment from from Tomas, Camilla 
>> (separate
>> mail) and me,
>> which means Sheets, Words and Plan along with the shapes and filters 
>> we find is working.
>> 
>> But, I am totally blank on release work, so who will possibly step up 
>> to handle that?
> 
> With the createtarball.rb script in the kde-dev-scripts, it's so 
> easy-peasy to make a source release that I'm fine with doing that, for 
> old times' sake. I can also upload the source releases to the right 
> place in download.kde.org; I've got rights for that. I have no time to 
> make binary builds, but we never did that for Calligra anyway.
Thanks, that's very nice of you, Boudewijn.
It might take a bit of time still. With the amount of serious bug reports on
2.9.11, there is quite a bit of testing needed :(
> 
> What I don't see myself doing is writing the announcement for 
> calligra.org. If there's someone who volunteers for that, all that is 
> needed is to tell me when to branch, tag, generate the tarball and 
> upload the result.
Yes, well, we'll tackle it when we get there...

Re: Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129420/#review100915
---


Ship it!




Ship It!

- Camilla Boemann


On Nov. 17, 2016, 6:54 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129420/
> ---
> 
> (Updated Nov. 17, 2016, 6:54 p.m.)
> 
> 
> Review request for Calligra and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   braindump/plugins/stateshape/CategorizedItemDelegate.cpp ad661c2 
>   libs/main/KoAutoSaveRecoveryDialog.cpp e543eaa 
>   libs/main/KoDocumentSectionDelegate.h ad4b9f1 
>   libs/main/KoDocumentSectionDelegate.cpp bcd7628 
>   libs/widgets/KoDockWidgetTitleBar.cpp 4d0d1aa 
>   plugins/textshape/dialogs/StylesCombo.cpp 9ca044b 
>   plugins/textshape/dialogs/StylesDelegate.cpp faa90fb 
> 
> Diff: https://git.reviewboard.kde.org/r/129420/diff/
> 
> 
> Testing
> ---
> 
> Build with Karbon.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---



It's great that you want to co maintain - i think you could even apply for 
maintaining without the "co-", but i also think it's a bit premature to remove 
that message. Maintain (be ambassador, fix bugs etc) for a month or so and if 
you are still warm about the idea we can remove the message.I mean the spot is 
yours if you want but make yourself a maintainer by deed before we make you one 
by name. Deal?

And just to emphazise it would be really great to see you work on karbon - it 
deserves to come to full glory!

- Camilla Boemann


On Nov. 17, 2016, 8:09 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 17, 2016, 8:09 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
>   karbon/CMakeLists.txt ba775ad 
>   karbon/main.cpp 2fa3f4d 
>   karbon/ui/KarbonAboutData.h aa96ee1 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

[Camilla Boemann]

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?

I'm sorry I don't understand what you mean? Also karbon doesn't have a 
maintainter. That webpage is wrong/out of date. You are very welcome to become 
the new maintainer, but let's not remove that message until we have seen that 
you are staying with us


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 17, 2016, 8:09 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> -------
> 
> (Updated Nov. 17, 2016, 8:09 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
>   karbon/CMakeLists.txt ba775ad 
>   karbon/main.cpp 2fa3f4d 
>   karbon/ui/KarbonAboutData.h aa96ee1 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

[Camilla Boemann]

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?

put calligra as reviewer, however we are not really using this reviewboard 
anymore, but rather phabricator instead


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129435: [shapefiltereffects] Update ConvolveMatrixEffect kernel accordingly to order

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129435/#review100953
---


Ship it!




Ship It!

- Camilla Boemann


On Nov. 19, 2016, 4:33 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129435/
> ---
> 
> (Updated Nov. 19, 2016, 4:33 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann, Friedrich W. H. Kossebau, and 
> Yue Liu.
> 
> 
> Bugs: 353816
> http://bugs.kde.org/show_bug.cgi?id=353816
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Added ability to save kernel changes by adding OK | Cancel buttons
> 
> 
> Diffs
> -
> 
>   plugins/shapefiltereffects/ConvolveMatrixEffectConfigWidget.cpp ef5b410 
> 
> Diff: https://git.reviewboard.kde.org/r/129435/diff/
> 
> 
> Testing
> ---
> 
> Build and run with Karbon
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

[Camilla Boemann]

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?
> 
> Camilla Boemann wrote:
> put calligra as reviewer, however we are not really using this 
> reviewboard anymore, but rather phabricator instead
> 
> Anthony Fieroni wrote:
> So should i put this and other one patch in phabricator ?

no that is not needed - we allow many types of review - also in person or via a 
mail - even in some cases self review


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129437: [widgets] Make sure destination xml file path exist

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129437/#review100968
---


Ship it!




Ship It!

- Camilla Boemann


On Nov. 20, 2016, 9:37 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129437/
> ---
> 
> (Updated Nov. 20, 2016, 9:37 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Otherwise it shown warning message ""Cannot write meta information to..."
> 
> 
> Diffs
> -
> 
>   libs/widgets/KoResourceServer.h 884e8ba 
>   libs/widgets/KoResourceTagStore.cpp 3ef0f4f 
> 
> Diff: https://git.reviewboard.kde.org/r/129437/diff/
> 
> 
> Testing
> ---
> 
> Build and run with Karbon.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129438: [karbon] Correct usage of KPageDialog in KarbonConfigureDialog.cpp

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129438/#review100969
---


Ship it!




Ship It!

- Camilla Boemann


On Nov. 20, 2016, 9:42 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129438/
> ---
> 
> (Updated Nov. 20, 2016, 9:42 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Now config dialog saves changes correct, it's a porting script bug
> 
> 
> Diffs
> -
> 
>   karbon/ui/dialogs/KarbonConfigureDialog.cpp 0ba166d 
> 
> Diff: https://git.reviewboard.kde.org/r/129438/diff/
> 
> 
> Testing
> ---
> 
> Build and run with Karbon.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

[Camilla Boemann]

> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?
> 
> Camilla Boemann wrote:
> put calligra as reviewer, however we are not really using this 
> reviewboard anymore, but rather phabricator instead
> 
> Anthony Fieroni wrote:
> So should i put this and other one patch in phabricator ?
> 
> Camilla Boemann wrote:
> no that is not needed - we allow many types of review - also in person or 
> via a mail - even in some cases self review
> 
> Anthony Fieroni wrote:
> Can we ship this, Arch (removed Karbon from git build), KaOS (removed it 
> entirely from repo)?

no not yet, but if you keep the fixes coming we can remove it right before 
release


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129532/#review101058
---




libs/main/KoView.cpp (line 342)
<https://git.reviewboard.kde.org/r/129532/#comment67757>

hmm we shouldn't hardcode these key combinations


- Camilla Boemann


On Nov. 22, 2016, 7:27 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129532/
> ---
> 
> (Updated Nov. 22, 2016, 7:27 p.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> + fullscreen action provide warning on runtime "Use 
> actionCollection->setDefaultShortcut instead of QAction->setShortcut
> 
> 
> Diffs
> -
> 
>   libs/main/KoMainWindow.cpp 828d789 
>   libs/main/KoView.cpp f3b6fd9 
> 
> Diff: https://git.reviewboard.kde.org/r/129532/diff/
> 
> 
> Testing
> ---
> 
> Build and run with Karbon
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129532/#review101060
---


Ship it!




but i just meant to use QKeySequence::Undo and redo

- Camilla Boemann


On Nov. 22, 2016, 8:30 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129532/
> ---
> 
> (Updated Nov. 22, 2016, 8:30 p.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> + fullscreen action provide warning on runtime "Use 
> actionCollection->setDefaultShortcut instead of QAction->setShortcut
> 
> 
> Diffs
> -
> 
>   libs/main/KoMainWindow.cpp 828d789 
>   libs/main/KoView.cpp f3b6fd9 
> 
> Diff: https://git.reviewboard.kde.org/r/129532/diff/
> 
> 
> Testing
> ---
> 
> Build and run with Karbon
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129532/#review101087
---


Ship it!




Ship It!

- Camilla Boemann


On Nov. 23, 2016, 5:36 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129532/
> ---
> 
> (Updated Nov. 23, 2016, 5:36 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> + fullscreen action provide warning on runtime "Use 
> actionCollection->setDefaultShortcut instead of QAction->setShortcut
> 
> 
> Diffs
> -
> 
>   libs/main/KoMainWindow.cpp 828d789 
>   libs/main/KoView.cpp f3b6fd9 
> 
> Diff: https://git.reviewboard.kde.org/r/129532/diff/
> 
> 
> Testing
> ---
> 
> Build and run with Karbon
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129531: [flake] Serialize / deserialize svg conicalGradient

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129531/#review101056
---


Ship it!




i must admit i don't know svg well enough but if you think it works then it's 
good enough for me

- Camilla Boemann


On Nov. 22, 2016, 9:07 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129531/
> ---
> 
> (Updated Nov. 22, 2016, 9:07 p.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Enable write / parse conicalGradient
> 
> 
> Diffs
> -
> 
>   libs/flake/svg/SvgParser.cpp 943c448 
>   libs/flake/svg/SvgStyleWriter.cpp b949dd5 
> 
> Diff: https://git.reviewboard.kde.org/r/129531/diff/
> 
> 
> Testing
> ---
> 
> Build and run with Karbon
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129514: [connectionTool] Check dynamic_cast return type

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129514/#review101109
---


Ship it!




Ship It!

- Camilla Boemann


On Nov. 21, 2016, 5:42 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129514/
> ---
> 
> (Updated Nov. 21, 2016, 5:42 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Bugs: 326258
> http://bugs.kde.org/show_bug.cgi?id=326258
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> I can't reproduce these days, but it's safe to check. Correct is based on 
> backtrace in bug report.
> 
> 
> Diffs
> -
> 
>   plugins/defaultTools/connectionTool/ConnectionTool.cpp 9e3dec6 
> 
> Diff: https://git.reviewboard.kde.org/r/129514/diff/
> 
> 
> Testing
> ---
> 
> PS: I manage to work on 2 wishlist, Px (pixels) if can be enabled from 
> settings (i still don't know why it's disabled) and export arrow line in SVG. 
> Other bus looks really outdated.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review101127
---



Also Anthony - for the really simple commits and stuff in karbon you can just 
commit without review request - we will review when we see the commit mails - 
just don't break build or push big stuff without some kind of warning etc

- Camilla Boemann


On Nov. 26, 2016, 6:12 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 26, 2016, 6:12 a.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129682: calligra: Update Czech Republic to Czechia

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129682/#review101530
---


Ship it!




Ship It!

- Camilla Boemann


On Dec. 20, 2016, 9:09 p.m., Jiri Bohac wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129682/
> ---
> 
> (Updated Dec. 20, 2016, 9:09 p.m.)
> 
> 
> Review request for Calligra and Albert Astals Cid.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> This year the country has oficially adopted the short name Czechia.
> The short name has been entered to the UNTERM and UNGEGN databases in July 
> 2016.
> Czechia is used in iso_3166 since September 2016.
> 
> This is a followup to
> https://git.reviewboard.kde.org/r/129644/
> As suggested by Albert Astals Cid, fixing the name in i10n is not enough: 
> country names are hardcoded in many places and they need to be fixed 
> separately.
> 
> 
> Diffs
> -
> 
>   karbon/stencils/Flags/czech_republic.desktop 0815af9 
>   karbon/stencils/Flags/czech_republic.odg 
> 8c01b1d306e83b97b1fd4925e81c23277415aebf 
>   karbon/stencils/Flags/czech_republic.png 
> c4bee8e4b4ad113b324544a48ae52f4c3a4fecd1 
>   karbon/stencils/Flags/czechia.desktop PRE-CREATION 
>   karbon/stencils/Flags/czechia.odg PRE-CREATION 
>   karbon/stencils/Flags/czechia.png PRE-CREATION 
>   sheets/Currency.cpp 48cf9ac 
> 
> Diff: https://git.reviewboard.kde.org/r/129682/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiri Bohac
> 
>

RE: 3.0.0.1 tarball + signature

[Camilla Boemann]

I have prepared a release announcement, but it doesn't say much so maybe
someone has suggestions as to what we should highlight?

https://www.calligra.org/?p=4837&preview=true

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of
Boudewijn Rempt
Sent: 3. januar 2017 11:58
To: Calligra Suite developers and users mailing list

Subject: Re: 3.0.0.1 tarball + signature

On Tue, 3 Jan 2017, Boudewijn Rempt wrote:

> On Tue, 3 Jan 2017, Dag wrote:
> 
> > Looks fine, it's a go from me!
> 
> Okay -- as soon as someone has done a release announcment, I'll upload 
> and we can publish.

Oh, and I've put the public key here:

https://share.kde.org/index.php/s/fJ99V5mZvuyD0z8

(If I did everything correctly)

> 
> > 
> > Dag skrev den 2017-01-02 13:49:
> > > Boudewijn Rempt skrev den 2017-01-02 13:12:
> > > > I've updated the tarball and the sig -- the tarball is now 58M
> > > Yes, looks better, I'm running a clean build now to test.
> > > 
> > > > On Mon, 2 Jan 2017, Boudewijn Rempt wrote:
> > > > 
> > > > > On Mon, 2 Jan 2017, Boudewijn Rempt wrote:
> > > > > 
> > > > > > Weird... I just let the script do its work, and then sign 
> > > > > > manually. So
> > > > > it
> > > > > > should compress the tarball. Even weirder, when I tried 
> > > > > > today, it
> > > > > suddenly
> > > > > > started asking for my key's passphrase for checking out the
> > > > > translations
> > > > > > a zillion times.
> > > > > 
> > > > > Hm, looks like that was a glitch...
> > > > > 
> > > > > >
> > > > > > On Mon, 2 Jan 2017, Dag wrote:
> > > > > >
> > > > > > > Hi, Boudewijn
> > > > > > > Happy new year.
> > > > > > >
> > > > > > > The tarball seems ok, except it is not compressed.
> > > > > > > The create_tarball script also uses the -a (or --armor) 
> > > > > > > option to
> > > > > sign.
> > > > > > >
> > > > > > > Cheers,
> > > > > > > Dag
> > > > > > >
> > > > > > > Boudewijn Rempt skrev den 2016-12-28 15:05:
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > I've finally figured out how to fix gpg-agent, so next 
> > > > > > > > to
> > > > > > > >
> > > > > > > > http://valdyas.org/~boud/calligra-3.0.0.1.tar.xz
> > > > > > > >
> > > > > > > > there's now also
> > > > > > > >
> > > > > > > > http://valdyas.org/~boud/calligra-3.0.0.1.tar.xz.sig
> > > > > > > >
> > > > > > > > which you can use to check whether I've done everything
> > > > > correctly...
> > > > > > > >
> > > > > > > > This should be the corresponding public key:
> > > > > > > >
> > > > > > > > http://valdyas.org/~boud/0x58b9596c722ea3bd.asc
> > > > > > > >
> > > > > > > > (anyone know of a better place to put that? My webserver 
> > > > > > > > isn't configured to use https yet...)
> > > > > > >
> > > > > >
> > > > > >
> > > > > 
> > > > > 
> > 
> 
> 

--
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org

RE: 3.0.0.1 tarball + signature

[Camilla Boemann]

Right, but that is just for a mail right ?

I mean our website announcement should be a bit more for end users

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of
Dag
Sent: 3. januar 2017 13:46
To: Calligra Suite developers and users mailing list

Subject: RE: 3.0.0.1 tarball + signature

Camilla Boemann skrev den 2017-01-03 12:59:
> I have prepared a release announcement, but it doesn't say much so 
> maybe someone has suggestions as to what we should highlight?

I was thinking something like this for the packagers:

A new version of Calligra has been released and files can be found here:
http://download.kde.org/stable/calligra/3.0.0.1/calligra-3.0.0.1.tar.xz
http://download.kde.org/stable/calligra/3.0.0.1/calligra-3.0.0.1.tar.xz.sig

Public key:
https://share.kde.org/index.php/s/fJ99V5mZvuyD0z8


Dependencies:
-
Note that atm Plan depends on KProperty and KReport version 3.0.0 exactly.
Afaik this is the only version released so far.

Building:
-
Note that the tarball contains modules that should not be included in the
release.
This release shall include the follow main apps: Words, Sheets, Karbon and
Plan.
The following main apps shall not be included: Stage, Flow and Braindump.

Specify the cmake flag:

-DRELEASE_BUILD=true

to only build the modules that shall be released.

See README.PACKAGERS for details.

Unit tests
--
Some unit tests fails if not run in the C locale, use LC_ALL=C make test to
avoid these failures.

Some unit tests fails but can be disregarded:
sheets-DatetimeFunctions
sheets-ValueConverter
sheets-ValueParser
libs-koodf-TestNumberStyle
libs-pigment-TestColorConversionSystem

Bug fixes:
--
This is mainly a port to KF5/Qt5, but some serious bugs present in
2.9.11 has been fixed:

Plan:
Fixed crash on startup, crash on close, crash when selecting New.

Words
Fixed crash when adding connected text frame.

ChartShape:
Fixed crash when adding a second chart.

RE: 3.0.0.1 tarball + signature

[Camilla Boemann]

Sure but I did say in my draft that we are porting and that it sets a bright 
new future – but really for the average user it doesn’t matter much what kind 
of tools we use – it’s what it means for the user that is important

 

From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of 
Jaroslaw Staniek
Sent: 5. januar 2017 11:45
To: Calligra Suite developers and users mailing list 
Subject: Re: 3.0.0.1 tarball + signature

 

 

 

On 5 January 2017 at 11:32, Boudewijn Rempt mailto:b...@valdyas.org> > wrote:

On Thu, 5 Jan 2017, Jaroslaw Staniek wrote:

> On 5 January 2017 at 11:05, Boudewijn Rempt   > wrote:
>
> > On Thu, 5 Jan 2017, Jaroslaw Staniek wrote:
> >
> > > IMHO ​If it's not​ marked as a big thing, the media and users will
> > > definitely mark this as not important and move over. Inkscape just made a
> > > release that highlights a port to GTK+3 as an important news.
> >
> > Um... The version inkscape just released isn't the gtk3 port, it's still
> > gtk2 based.
> >
> > ​I referred to
> https://inkscape.org/en/news/2017/01/04/inkscape-version-092-released/
> and it ​
>
> ​marks C++ upgrade and Gtk3 port as important.
> ​
>

No: it says "(Future infrastructure changes include switching from bzr to git, 
shifting from Gtk2 to Gtk3, and moving to the C++11 standard.)" I.e., that's 
what they're going to do.

 

Sorry, just noticed this, hard grammar to me; regardless, they found it 
important to notify users what they do apart of adding features and more 
importantly why :)
​

 



-- 

regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek

Re: Review Request 129782: [calligra] Buildsystem improvements

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129782/#review101845
---


Ship it!




Ship It!

- Camilla Boemann


On Jan. 6, 2017, 10:58 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129782/
> ---
> 
> (Updated Jan. 6, 2017, 10:58 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> 3 commits:
> 
> - Make Activities and KF5Html really optional.
>   Before, trying to use CMAKE_DISABLE_FIND_PACKAGE_KF5{Activities,KHtml} 
> errored out with:
>   "if given arguments: "VERSION_LESS" "5.16.0" Unknown arguments specified"
> 
> - Fix dependencies, sort and clean trailing whitespaces:
>   Add missing KF5JobWidgets
>   Drop unused KF5TextEditor
> 
> - Push KF5Threadweaver dep to the only place where it is used
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3779c9abeff3642ac867c497a2eef637276f8835 
>   libs/widgets/tests/CMakeLists.txt 39346304bb2c95ce12fea528998a512ab42d19cb 
> 
> Diff: https://git.reviewboard.kde.org/r/129782/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

RE: isn't it time for...

[Camilla Boemann]

Done

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of
Boudewijn Rempt
Sent: 14. januar 2017 20:29
To: calligra-devel@kde.org
Subject: isn't it time for...

A release announcement?

-- 
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org

RE: Release 3.0.1

[Camilla Boemann]

Nothing new from my end, so please go ahead

-Original Message-
From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of
Dag
Sent: 10. marts 2017 13:03
To: calligra-devel@kde.org
Subject: Release 3.0.1

Hi, should we make a bug fix release soon?

A few bugs has been fixed, and there is 3 months since 3.0.0 ;)

Anybody has something that *needs* to be fixed?

Cheers,
Dag

Re: Review Request 130196: Add a seed parameter to make the qHash used

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130196/#review103464
---


Ship it!




Ship It!

- Camilla Boemann


On July 22, 2017, 7:50 p.m., Jos van den Oever wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130196/
> ---
> 
> (Updated July 22, 2017, 7:50 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Without the seed parameter, the default qHash for QPair is used.
> The seed argument in qHash was introduced in Qt 5.0. The qHash for
> KoXmlStringPair did not have it and hence it was an unused function.
> 
> 
> Diffs
> -
> 
>   libs/store/KoXmlReader.cpp 4c7f434 
> 
> Diff: https://git.reviewboard.kde.org/r/130196/diff/
> 
> 
> Testing
> ---
> 
> All unit tests in kostore still pass.
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

D6844: clazy fixes for kostore

[Camilla Boemann]

boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.


  No need to review these very simple changes - just make sure you test before 
pushing

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D6844

To: vandenoever, #calligra:_3.0, Calligra-Devel-list, boemann
Cc: boemann, vandenoever

please turn off comments for calligra site

[Camilla Boemann]

There are way too many spam messages these 

 

Days so could someone with admin rights please turn them off or install a
captcha or something

 

Also it would be ice if more of us had admin rights

 

Please help out asap

 

 

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  I have my linux partiotion working again, so I'l take a look this weekend - 
is there a bug number and a test document somewhere ?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  Okay I basically believe you are right, but before I accept I ask you to make 
the corresponding changes in
  textshape/dialogs/ParagraphIndentSpacing.cpp
  
  Where the 120% should be 100% etc
  
  Also having tested with Libreoffice I think the correct scale is 1.16
  
  And finally the code you already wrote can be simplyfied by by not having an 
else but always multiplying
  
  Also 5 lines below a similar factor for dropcaps should probably also be 1.16
  
  Sorry it took me this long to look into it

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  So now we are just missing the texttool ui changes

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  no just:
  
  if (percent != 0)
  
height *= percent/100
  
  height *= 1.16;

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  in plugins/textshape/dialogs there is a file that handles line height (can't 
remember which exactly)
  
  when converting between the 1x, 2x etc and a percentage it right now aplies 
the 1.2
  
  but this is wrong: it should just convert 1x as 100%, 2x as 200%
  
  The 1.2 (or actually 1..16) is just a  behind the scenes detail handled in 
layout

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  yes and line 233-235 in the same file - fix that and we are ready to push

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  except that its 1, 1½, 2 and not 1,2,3 then it looks good

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann accepted this revision.
boemann added a comment.


  Thanks

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

[Camilla Boemann]

boemann added a comment.


  given that we no multiply with1.16 the values should be: 12*1.16, 24*1.16,  no
  Don't know what the last is supposed to be but it  should probably have the 
same treatment

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D9537

To: anthonyfieroni, danders, mecir, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Camilla Boemann]

boemann added a comment.


  What is the purpose of showing pixel units in general - pixels is not really 
a unit except in very specific cases - I'd saythis is very very wrong
  
  What is the size of pixel in your mind anyway?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Camilla Boemann]

boemann added a comment.


  Yes, that is exactly how they could use it but, I think we are doing a 
disservice by offering such an option- there is no way an author can know the 
destination resolution and it will only apply to one destination.
  
  Besides why would they even need to know - we are not pixel base to begin 
with, we are all vectors
  
  I'm convinced that most users are just not understanding how wrong pixel unit 
is - we should not contribute by letting pixel units be available

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Camilla Boemann]

boemann added a comment.


  The problem here is if they think they can place a line on a specific pixel 
position - we don't store coords as pixels - so  it will not end being rendered 
to a specific pixel anyway - we will just end up with users not getting what 
they think they get, even in such a case as you describe

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Camilla Boemann]

boemann added a comment.


  discard as a general solution - it doesn't make close to any sense for other 
than karbon when used as a tool to generate pixmaps in the end, and even then 
as I said it's a bad idea for various reasons

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

[Camilla Boemann]

boemann added a comment.


  I have no fundamentally against it, but I cannot test it right - so if it 
works 'm all for it

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15103

To: dcaliste, #calligra:_3.0, leinir, danders, boemann
Cc: Calligra-Devel-list, cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Camilla Boemann]

boemann added a comment.


  And none of that contradicts me saying it's not a general feature we want, 
but at most for Karbon, and that since we don't store pixel values but rather 
convert to points the user will not get pixel precise placement anyway

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: staniek, Calligra-Devel-list, cochise, vandenoever

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

[Camilla Boemann]

boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.


  I like what you have done - you seem to understand the concepts, so please 
commit when you feel  like it's working

INLINE COMMENTS

> TestBlockLayout.cpp:333
>  //qDebug() << blockLayout->lineAt(0).y();
> -QVERIFY(qAbs(blockLayout->lineAt(0).y() - (0.8*12 + 28.0-12.0 + 100.0)) 
> < ROUNDING);
> +QEXPECT_FAIL("", "FIXME: Should not this calculate with lineheight and 
> not fontsize?", Continue);
> +QVERIFY2(qAbs(blockLayout->lineAt(0).y() - line2_y) < ROUNDING, 
> QString("Actual: %1 Expected: 
> %2").arg(blockLayout->lineAt(0).y()).arg(line2_y).toLatin1());

yes I think so

REPOSITORY
  R8 Calligra

BRANCH
  blocklayout_unittest_danders

REVISION DETAIL
  https://phabricator.kde.org/D14901

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, cochise, vandenoever

D15403: {Style] Default sheets to white background

[Camilla Boemann]

boemann added a comment.


  No Idea about the code, but in general I have no problem with sheets 
respecting the palette

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15403

To: anthonyfieroni, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added inline comments.

INLINE COMMENTS

> KoTextLayoutNoteArea.cpp:143
> +
> +if (blockLayoutLine.isValid()) {
> +d->labelYOffset += blockLayoutLine.ascent();

I'm fine with this change

> KoTextLayoutTableArea.cpp:464
> +//if we couldn't fit the header rows
> +//try again don't reset cursor->row or we enter infinite loop
> +//cursor->row = 0;

nah this is too aggressive.
There are definitely cases where setting to 0 is the correct thing to do.
There might be some times we enter an infinite loop yes, but we need to catch 
this is some other way

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  The idea is that if we are at the beginning of a new page we don't get in 
here (virginpage is true)
  so we only reset if we are somewhere down on a page meaning we wil have more 
space to try on next time around
  But we should reset if the only thing we fitted was the table header as a 
table headerrow should never be the only thing on a page
  
  One reason why this might fail is if virginpage becomes false when we add the 
table headerrow (if we can fix this and that doesn't have other ill effect then 
I would prefer such a solution).
  So find out where we set virginpage to false, and make sure it doesn't go 
from true to false when adding the header row
  
  I hope this makes sense

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  I am more thinking of this place:
  
  
https://phabricator.kde.org/source/calligra/browse/master/libs/textlayout/KoTextLayoutTableArea.cpp$436
  
  this shouldn't be set if we are doing a headerrow, so please try this:
  
  if (cursor->row >= d->headerRows)
  
setVirginPage(false);
  
  It may still not be enough to fix the problem but it's step in the right 
direction i think 
  There is still the possibility that the user has completely written more than 
can be fitted - I wonder what we should do in that case then

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15412: [filters] Extend table lifetime

[Camilla Boemann]

boemann added a comment.


  No idea either - jaroslaw was the original author so maybe he can take a look

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15412

To: anthonyfieroni, danders, boemann, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15549: Words: Save anchor info also for page-anchored shapes

[Camilla Boemann]

boemann added a comment.


  Bah I can't remember this, but page anchored shapes don't have anchors as 
such, so I'm wondering what exactly is this writing to file?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15549

To: danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15549: Words: Save anchor info also for page-anchored shapes

[Camilla Boemann]

boemann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

BRANCH
  danders_words_anchor

REVISION DETAIL
  https://phabricator.kde.org/D15549

To: danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15728: Try to avoid segfaults on shape factory not found

[Camilla Boemann]

boemann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15728

To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

[Camilla Boemann]

boemann added a comment.


  'm sorry but the background should not be settable - it's a document property 
at best and in fact paper is mostly white,  so shouldn't even be settable

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

[Camilla Boemann]

boemann added a comment.


  Ahh well in that case I don't mind and the words code looks clean enough - 
I'll let someone else review the components

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16367: EnhancedPathShape: Shape is moved/resized on save/load

[Camilla Boemann]

boemann added a comment.


  Yes as i recall that code was made to handle masks being exported correctly 
for  OpenOffice or LO - I'd strongly prefer it not being thrown away like that

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16367

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16367: EnhancedPathShape: Shape is moved/resized on save/load

[Camilla Boemann]

boemann added a comment.


  As I recall it was one of the files in the huge dataset - there should be a 
bug on it

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16367

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16679: Words: Fix interop problem with LO/OO

[Camilla Boemann]

boemann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

BRANCH
  words_pagestyle_danders

REVISION DETAIL
  https://phabricator.kde.org/D16679

To: danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  Dan I like your diff better - I don't think it's completely there but it's a 
better starting point
  
  On a more conceptual level, what should happen if the design of table is such 
that headers can't fit on a virgin page? What should we do.? One one hand it 
should be there but on the other hand we will never get to show the real part 
of the table ever.
  What is the solution we should aim for?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  No you misunderstand. I wasn't talking about you diff - I want to know what 
it is we are trying to accomplish. in spoken words

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  Still not the description i was looking for. I want to know what the extreme 
case is and what the resulting document should look like when we give up:
  
  A table without header rows and that doesn't fit  will be layouted and shown 
in pieces
  
  What I want to know is: What should we do?.
  
  1. Should we not show the header rows- it will leave the user without context 
but at least the user will get to see normal rows
  2. should we layout one line past the headerrows even though that will never 
be visible on the printed paper (and then nothing interesting will ever be 
visible) - Should we then show the table at all instead of 100s of pages with 
just headerrows until we have disposed of all the contents one line at a time.
  
  You see - to me - it's not at all clear what it is we are trying to accomplish

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  And has anyone been able to produce a smaller 1  page example of the document 
- we are stumbling blindly here.
  Do we have an odf snippet of the table that gives the problem?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  good investigative work, but I fear those tests are way too simple to dare 
apply the patch.
  
  The table code handles a lot more cases than a simple 2x1 table merged will 
uncover. I'm a bit surprised of the problems you describe in master - I don't 
recall any such problems.
  
  I think it is time that we create a lot of unittests. Unittesting table 
layout is long overdue anyway

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

[Camilla Boemann]

boemann added a comment.


  Looks like a good first start to me - do they pass currently? - if so then i 
think they should be pushed
  
  I'll think about further tests

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18095

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

[Camilla Boemann]

boemann added a comment.


  absolutely

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18095

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18448: Replaced "distraction free" with "fullscreen" - BUG:378527

[Camilla Boemann]

boemann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

BRANCH
  replace-disturbfree-with-fullscreen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18448

To: niccolove, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Camilla Boemann]

boemann added a comment.


  Could you please describe what you have done and why

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Camilla Boemann]

boemann added a comment.


  Yes that description helped a lot, and you are doing great. Keep up the good 
work :)
  
  One concern though - how often and when is openDoumentInternal called. I'm a 
bit afraid that we just add some functionality to a place that might be used 
for something else

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Camilla Boemann]

boemann added a reviewer: danders.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Camilla Boemann]

boemann added a comment.


  Please check with loading a normal document,. The same concerns now applies 
to slotLoadCompleted - especially since you have now removed functionality from 
it.
  
  Also please check in all of our applications as some might reimplement 
virtual methods

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Camilla Boemann]

boemann added a comment.


  regarding the lambda connection - nice to see that you use the version with  
a "still alive" argument - but I fear this requires a qt version  higher than 
what we currently support - could you please check

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

[Camilla Boemann]

boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.


  I like it

REPOSITORY
  R8 Calligra

BRANCH
  calligra/3.1

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, 
cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Camilla Boemann]

boemann added a comment.


  Dan can you please reply - I'm fine with the account but I can't reply to Ben 
as I am not able to send email

REPOSITORY
  R8 Calligra

BRANCH
  print-remote-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18843: Activate stencils docker in all apps

[Camilla Boemann]

boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.


  I definitely don't want this docker default on, but if as you say it's 
default off then i guess your change is okay - i'll take your word for it

REPOSITORY
  R8 Calligra

BRANCH
  activate_stencils_danders

REVISION DETAIL
  https://phabricator.kde.org/D18843

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18989: Remove minor duplicate code and fix related bug

[Camilla Boemann]

boemann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D18989

To: ognarb, #calligra:_3.0, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Camilla Boemann]

boemann added a comment.


  totally agree about not theme'ing canvas
  
  Also a general agreement to do the page app thing as long as it's also 
supported in svg
  
  odg is hardly that much of a reason - it even seems like odf is moving away 
from odg as much as possible

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Camilla Boemann]

boemann added a comment.


  no

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Camilla Boemann]

boemann added a comment.


  In D19216#421654 , @rjvbb wrote:
  
  > >   No, the canvas is part of the document and must never be themed. The 
canvas background is as much part of your drawing as any line you put on it.
  >
  > This hasn't been sitting right with me and I finally realised why.
  >
  > That statement is true when you work with a real canvas and 
draw/paint/whatever directly onto that. If you take a grid paper the grid will 
become part of your art, but does Karbon print the grid which you can have it 
show (except possibly via an option)?
  >
  > In drawing applications, the canvas is NOT part of your art, but simulates 
the canvas you'll be printing on. It's a backdrop layer that sits behind/below 
the lowest layer you can draw on. If you plan to print on a coloured piece of 
paper, or one with a canvassy texture, you'll probably want to adapt your 
virtual canvas so you can incorporate the physical canvas properties into your 
design. But you don't want that virtual canvas to print as that would be a 
waste of toner at best...
  
  
  That is actual a valid point, although in say Krita with transparent pixels a 
checkerboard is shown.
  That said it might make more sense for this "testing background" to be part 
of the document and not a general setting - if the use case is as you say then 
the testing background would also be different for different projects
  
  > That's not to say that the virtual canvas should not be exportable at all: 
you'd want to be able to include it when generating a PDF (SVG, JPG, etc) 
format version for use in on-screen only presentations. Of course you could 
just add a backdrop layer in that case.
  > 
  > I'm not aware that Karbon has the equivalent of a slide/page design feature 
where you can define how each page will look. That could look be used to be 
achieve what I describe here but in Karbon that layer should probably not be 
printed by default (just like it isn't in presentation apps, IIRC).

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D22545: Add missing include QDate

[Camilla Boemann]

boemann accepted this revision.
boemann added a comment.
This revision is now accepted and ready to land.


  btw For such small fixes we don't usually require review

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D22545

To: usta, #calligra:_3.0, Calligra-Devel-list, boemann
Cc: boemann, dcaliste, cochise, vandenoever