[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Identical code to Linux apart from `/lwp/` in place of `/task/`. Wondered if we could share that but as long as it remains identical, we could always do it later if we want. It would be something like `getProcFile(::pid_t pid, ::pid_

[Lldb-commits] [lldb] [lldb] Disable TestTargetWatchAddress.py on Windows x86_64 (PR #142573)

2025-06-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142573 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Hemang Gadhavi (HemangGadhavi) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/issu

[Lldb-commits] [lldb] [lldb/cmake] Implicitly pass arguments to llvm_add_library (PR #142583)

2025-06-03 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/142583 If we're not touching them, we don't need to do anything special to pass them along -- with one important caveat: due to how cmake arguments work, the implicitly passed arguments need to be specified before argu

[Lldb-commits] [lldb] [lldb/cmake] Implicitly pass arguments to llvm_add_library (PR #142583)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-hexagon Author: Pavel Labath (labath) Changes If we're not touching them, we don't need to do anything special to pass them along -- with one important caveat: due to how cmake arguments work, the implicitly passed arguments need to be specifie

[Lldb-commits] [lldb] c48c91a - [lldb][test] XFAIL TestThreadJump.py on older Clang versions

2025-06-03 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-06-03T12:17:50+01:00 New Revision: c48c91a92e50e7e01ab9befa1ff7f3bc9662ecac URL: https://github.com/llvm/llvm-project/commit/c48c91a92e50e7e01ab9befa1ff7f3bc9662ecac DIFF: https://github.com/llvm/llvm-project/commit/c48c91a92e50e7e01ab9befa1ff7f3bc9662ecac.diff

[Lldb-commits] [lldb] 05547fc - [lldb][test] XFAIL TestClangModulesDeclLookup on Linux

2025-06-03 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-06-03T12:20:31+01:00 New Revision: 05547fc3ec803b779beefeb52d21ef76cf00413f URL: https://github.com/llvm/llvm-project/commit/05547fc3ec803b779beefeb52d21ef76cf00413f DIFF: https://github.com/llvm/llvm-project/commit/05547fc3ec803b779beefeb52d21ef76cf00413f.diff

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Hemang Gadhavi (HemangGadhavi) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-03 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi created https://github.com/llvm/llvm-project/pull/142586 This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/issues/1

[Lldb-commits] [lldb] [lldb-dap] Fix disassembled ranges for `disassemble` request (PR #105446)

2025-06-03 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: superseded by #140486 https://github.com/llvm/llvm-project/pull/105446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix disassembled ranges for `disassemble` request (PR #105446)

2025-06-03 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/105446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 75ec944 - [lldb][test] Disable image dump ast test on Windows

2025-06-03 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-06-03T09:33:24Z New Revision: 75ec944e38eedfc9357171697bceabe98dd9fadb URL: https://github.com/llvm/llvm-project/commit/75ec944e38eedfc9357171697bceabe98dd9fadb DIFF: https://github.com/llvm/llvm-project/commit/75ec944e38eedfc9357171697bceabe98dd9fadb.diff LOG

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-03 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-03 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable TestTargetWatchAddress.py on Windows x86_64 (PR #142573)

2025-06-03 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/142573 See #142196 and https://github.com/llvm/llvm-zorg/pull/452 for details. >From 7f770486b80d0f927f5e4ad16f5e31a771b2ad0a Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Tue, 3 Jun 2025 14:28:58 +0400 Subjec

[Lldb-commits] [lldb] [lldb] Disable TestTargetWatchAddress.py on Windows x86_64 (PR #142573)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb @llvm/pr-subscribers-platform-windows Author: Dmitry Vasilyev (slydiman) Changes See #142196 and https://github.com/llvm/llvm-zorg/pull/452 for details. --- Full diff: https://github.com/llvm/llvm-project/pull/142573.diff 1 Files Affected: - (mo

[Lldb-commits] [lldb] 3ddc1e1 - [lldb][test] XFAIL TestClangModulesDeclLookup.test on win-remote-linux

2025-06-03 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-06-03T13:16:03+01:00 New Revision: 3ddc1e1cf397bd495f5aa42b04630561a9e6bf47 URL: https://github.com/llvm/llvm-project/commit/3ddc1e1cf397bd495f5aa42b04630561a9e6bf47 DIFF: https://github.com/llvm/llvm-project/commit/3ddc1e1cf397bd495f5aa42b04630561a9e6bf47.diff

[Lldb-commits] [lldb] [lldb/cmake] Use ADDITIONAL_HEADER(_DIR)?S (PR #142587)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Replace (questionable) header globs with an explicit argument supported by llvm_add_library. --- Full diff: https://github.com/llvm/llvm-project/pull/142587.diff 17 Files Affected: - (modified) lldb/CMakeLi

[Lldb-commits] [lldb] [lldb/cmake] Use ADDITIONAL_HEADER(_DIR)?S (PR #142587)

2025-06-03 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/142587 Replace (questionable) header globs with an explicit argument supported by llvm_add_library. >From 450e714d9eb1a6f15a6b6065cf0c60f120948f65 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 3 Jun 2025 13:4

[Lldb-commits] [lldb] 9c52b17 - [lldb][test] Add test for looking up decls in Clang modules for C++

2025-06-03 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-06-03T12:10:15+01:00 New Revision: 9c52b177ea27778e904908c974e8113ed637dd69 URL: https://github.com/llvm/llvm-project/commit/9c52b177ea27778e904908c974e8113ed637dd69 DIFF: https://github.com/llvm/llvm-project/commit/9c52b177ea27778e904908c974e8113ed637dd69.diff

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -356,7 +356,21 @@ class StepInRequestHandler : public RequestHandler> { +public: + using RequestHandler::RequestHandler; + static llvm::StringLiteral GetCommand() { return "stepInTargets"; } + FeatureSet GetSupportedFeatures() const override { +return {protocol::eAdapte

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/2] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/3] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb-dap] Correct the disconnect helper on server shutdown. (PR #142508)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/142508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystem][NFC] CreateFunctionType to take parameters by llvm::ArrayRef (PR #142620)

2025-06-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/142620 None >From bd2788fb6c4ba71c400d615f723d9f8e9522450c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 3 Jun 2025 15:51:40 +0100 Subject: [PATCH] [lldb][TypeSystem][NFC] CreateFunctionType to take parame

[Lldb-commits] [lldb] [lldb][TypeSystem][NFC] CreateFunctionType to take parameters by llvm::ArrayRef (PR #142620)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/142620.diff 10 Files Affected: - (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp (+2-2) - (modified) lldb/sou

[Lldb-commits] [lldb] [lldb][TypeSystem][NFC] CreateFunctionType to take parameters by llvm::ArrayRef (PR #142620)

2025-06-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/142620 >From f69c768795f647d97b85bce5416b2302eb6b5a6d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 3 Jun 2025 15:51:40 +0100 Subject: [PATCH] [lldb][TypeSystem][NFC] CreateFunctionType to take parameters

[Lldb-commits] [lldb] [lldb] switch to CalculateNumChildren where possible (PR #142607)

2025-06-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: My original idea was that we can just call `CalculateNumChildren` and bubble up that error when something goes wrong. But if we're just going to consume it anyway, then keeping them as `CalculateNumChildrenIgnoringErrors` seems fine (though I would stil

[Lldb-commits] [lldb] [lldb] switch to CalculateNumChildren where possible (PR #142607)

2025-06-03 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > But if we're just going to consume it anyway, then keeping them as > `CalculateNumChildrenIgnoringErrors` seems fine (though I would still prefer > bubbling up errors, but that brings us back to the discussion about how we > should be using `llvm::Expected`) Agreed, th

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-06-03 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/141516 >From 06a2754bfbd434b6a957c6b252be15aac2bf8173 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 23 May 2025 01:20:46 + Subject: [PATCH] [lldb] Show coro_frame in `std::coroutine_handle` pre

[Lldb-commits] [lldb] [lldb][TypeSystem][NFC] CreateFunctionType to take parameters by llvm::ArrayRef (PR #142620)

2025-06-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/142620 >From f69c768795f647d97b85bce5416b2302eb6b5a6d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 3 Jun 2025 15:51:40 +0100 Subject: [PATCH 1/2] [lldb][TypeSystem][NFC] CreateFunctionType to take paramet

[Lldb-commits] [lldb] a90145e - [lldb] Disable TestTargetWatchAddress.py on Windows x86_64 (#142573)

2025-06-03 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2025-06-03T20:18:16+04:00 New Revision: a90145e0282fb9eef0ad9ff61f505aff4e30c01d URL: https://github.com/llvm/llvm-project/commit/a90145e0282fb9eef0ad9ff61f505aff4e30c01d DIFF: https://github.com/llvm/llvm-project/commit/a90145e0282fb9eef0ad9ff61f505aff4e30c01d.dif

[Lldb-commits] [lldb] [lldb] Disable TestTargetWatchAddress.py on Windows x86_64 (PR #142573)

2025-06-03 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/142573 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a903271 - [lldb] Emit an error when using --wait-for without a name or pid (#142424)

2025-06-03 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-03T09:19:50-07:00 New Revision: a9032712c453bda70449dedcaf00bead0fea6e88 URL: https://github.com/llvm/llvm-project/commit/a9032712c453bda70449dedcaf00bead0fea6e88 DIFF: https://github.com/llvm/llvm-project/commit/a9032712c453bda70449dedcaf00bead0fea6e88.d

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/142424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Use ADDITIONAL_HEADER(_DIR)?S (PR #142587)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread John Harrison via lldb-commits
@@ -33,6 +33,23 @@ static void SendThreadExitedEvent(DAP &dap, lldb::tid_t tid) { dap.SendJSON(llvm::json::Value(std::move(event))); } +void SendAdditionalCapabilities(DAP &dap) { + if (dap.target.IsValid()) { +// FIXME: stepInTargets request is only supported by the x

[Lldb-commits] [lldb] [lldb/cmake] Implicitly pass arguments to llvm_add_library (PR #142583)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -33,6 +33,23 @@ static void SendThreadExitedEvent(DAP &dap, lldb::tid_t tid) { dap.SendJSON(llvm::json::Value(std::move(event))); } +void SendAdditionalCapabilities(DAP &dap) { da-viper wrote: Will update was struggling to think of a good name. https:/

[Lldb-commits] [lldb] 20ca895 - [lldb] Add Python properties to SBBreakpoint and similar (#142215)

2025-06-03 Thread via lldb-commits
Author: Dave Lee Date: 2025-06-03T09:38:22-07:00 New Revision: 20ca8958604dc26d5b480cf9109b861d05341ac8 URL: https://github.com/llvm/llvm-project/commit/20ca8958604dc26d5b480cf9109b861d05341ac8 DIFF: https://github.com/llvm/llvm-project/commit/20ca8958604dc26d5b480cf9109b861d05341ac8.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -33,6 +33,23 @@ static void SendThreadExitedEvent(DAP &dap, lldb::tid_t tid) { dap.SendJSON(llvm::json::Value(std::move(event))); } +void SendAdditionalCapabilities(DAP &dap) { + if (dap.target.IsValid()) { da-viper wrote: I wanted to do it like that b

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -78,3 +78,31 @@ def test_basic(self): leaf_frame = self.dap_server.get_stackFrame() self.assertIsNotNone(leaf_frame, "expect a leaf frame") self.assertEqual(step_in_targets[1]["label"], leaf_frame["name"]) + +def test_supported_capability(self): +

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread John Harrison via lldb-commits
@@ -78,3 +78,31 @@ def test_basic(self): leaf_frame = self.dap_server.get_stackFrame() self.assertIsNotNone(leaf_frame, "expect a leaf frame") self.assertEqual(step_in_targets[1]["label"], leaf_frame["name"]) + +def test_supported_capability(self): +

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread John Harrison via lldb-commits
@@ -33,6 +33,23 @@ static void SendThreadExitedEvent(DAP &dap, lldb::tid_t tid) { dap.SendJSON(llvm::json::Value(std::move(event))); } +void SendAdditionalCapabilities(DAP &dap) { + if (dap.target.IsValid()) { ashgti wrote: We can always update it in the

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-03 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From b47eaa64397da7ea5d2a7ca46bea4513a37755f0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH 1/2] [lldb][headers] Create Python script to fix up fra

[Lldb-commits] [lldb] [lldb/cmake] Implicitly pass arguments to llvm_add_library (PR #142583)

2025-06-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/142583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Use ADDITIONAL_HEADER(_DIR)?S (PR #142587)

2025-06-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/142587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I think this could benefit from following the pattern of the other scripts, which is running on a single file and having CMake doing the globbing, presumably that means the build system can do all of this in parallel instead of making this a single-th

[Lldb-commits] [lldb] Add a pythin JIT loader class. (PR #142514)

2025-06-03 Thread via lldb-commits
jimingham wrote: This also seems like an awkward way to do what we've wanted for a while, which is the equivalent of stop hooks for "launch", "attach" and "module loaded", since you have to do all three, even if you only wanted to do one of the set. https://github.com/llvm/llvm-project/pull/14

[Lldb-commits] [lldb] Add a pythin JIT loader class. (PR #142514)

2025-06-03 Thread via lldb-commits
jimingham wrote: I changed the stop-hooks recently so they optionally fire when lldb first gets control of the process, so you can already write python code that intervenes when your "did_attach" and "did_launch" callbacks fire. https://github.com/llvm/llvm-project/pull/142514

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/4] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142439 >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH 1/5] [lldb-dap] Use structured types for stepInTargets request --

[Lldb-commits] [lldb] Add a pythin JIT loader class. (PR #142514)

2025-06-03 Thread via lldb-commits
jimingham wrote: But if you don't care so much about shared state, then I think a better way of doing what you want is just to add `target module-hook add`... https://github.com/llvm/llvm-project/pull/142514 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] Add a pythin JIT loader class. (PR #142514)

2025-06-03 Thread via lldb-commits
jimingham wrote: One thing that's nicer about this approach than independent callbacks for each of the hooks is that it allows you to group the three callbacks in the same class, so that you can more easily keep shared state. But that's a general problem with these affordances. For instance,

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142652 The current implementation hides any possible error from performing a step command. >From 7e940dcb0cfde1bc9be73c7cf2a40ba7f08d12e5 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 2 Jun 2025 17:07:50 +01

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread John Harrison via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-03 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > I think this could benefit from following the pattern of the other scripts, > which is running on a single file and having CMake doing the globbing, > presumably that means the build system can do all of this in parallel instead > of making this a single-threaded operati

[Lldb-commits] [lldb] Add a pythin JIT loader class. (PR #142514)

2025-06-03 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Hey @clayborg, this is pretty cool. I'm glad you were able to use and extend the ScriptedPythonInterface to implement this, hopefully it wasn't too complicated. LGTM! https://github.com/llvm/llvm-project/pull/142514 __

[Lldb-commits] [lldb] [lldb][TypeSystem][NFC] CreateFunctionType to take parameters by llvm::ArrayRef (PR #142620)

2025-06-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/142620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes The current implementation hides any possible error from performing a step command. --- Full diff: https://github.com/llvm/llvm-project/pull/142652.diff 3 Files Affected: - (modified) lldb/tools/lldb-dap/H

[Lldb-commits] [lldb] Add a python JIT loader class. (PR #142514)

2025-06-03 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/142514 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. For these three request handlers, should we also add a sanity check of: ``` if (!SBDebugger::StateIsStoppedState(process.GetState())) return make_error(); ``` To the `Run(...)` so we can get a specific error if the process isn't stoppe

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-03 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142652 >From 7e940dcb0cfde1bc9be73c7cf2a40ba7f08d12e5 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 2 Jun 2025 17:07:50 +0100 Subject: [PATCH 1/2] [lldb-dap] Forward any error from stepping. --- lldb/tools/l

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142489 >From 6076f7778f3f10d7360d8f0b156992809de73094 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 3 Jun 2025 10:44:43 -0700 Subject: [PATCH] [lldb] Fix data race in statusline format handling This

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/Core/Debugger.h lldb/include/lldb

[Lldb-commits] [lldb] Add a python JIT loader class. (PR #142514)

2025-06-03 Thread Alex Langford via lldb-commits
bulbazord wrote: > This seems like a generic module loading observer. I don't see anything JIT > specific about it. Not saying a generic module loading observer is not a good > idea. But calling it a JITLoader seems pretty confusing to me. +1 on the name. The design seems very general, so mayb

[Lldb-commits] [lldb] Add a python JIT loader class. (PR #142514)

2025-06-03 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > Hey @clayborg, this is pretty cool. I'm glad you were able to use and extend > the ScriptedPythonInterface to implement this, hopefully it wasn't too > complicated. LGTM! I meant LGTM on the scripting side of things. I still thing we should address Jim's comments: > For

[Lldb-commits] [lldb] [lldb-dap] Forward any error from stepping. (PR #142652)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Nice https://github.com/llvm/llvm-project/pull/142652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-03 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d204aa9 - [lldb][headers] Create script to fix up versioning (#141116)

2025-06-03 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2025-06-03T13:06:46-07:00 New Revision: d204aa9deb72b8dcaf5e5b5550871d0ebe982825 URL: https://github.com/llvm/llvm-project/commit/d204aa9deb72b8dcaf5e5b5550871d0ebe982825 DIFF: https://github.com/llvm/llvm-project/commit/d204aa9deb72b8dcaf5e5b5550871d0ebe982825.d

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142489 >From 6076f7778f3f10d7360d8f0b156992809de73094 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 3 Jun 2025 10:44:43 -0700 Subject: [PATCH 1/2] [lldb] Fix data race in statusline format handling

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Can you add a `Thread` serialization/deserialization unit test? https://github.com/llvm/llvm-project/pull/142510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/142510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint and similar (PR #142215)

2025-06-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
@@ -8,72 +8,43 @@ #include "DAP.h" #include "EventHelper.h" -#include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" +#include "ProtocolUtils.h" #include "RequestHandler.h" +#include "lldb/API/SBDebugger.h" +#include "lldb/API/SBDefines.h" +#include "llvm/Support/Error

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
@@ -116,77 +116,79 @@ void SendProcessEvent(DAP &dap, LaunchMethod launch_method) { // Send a thread stopped event for all threads as long as the process // is stopped. -void SendThreadStoppedEvent(DAP &dap) { +void SendThreadStoppedEvent(DAP &dap, bool on_entry) { --

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread John Harrison via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-03 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From b47eaa64397da7ea5d2a7ca46bea4513a37755f0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH 1/2] [lldb][headers] Create Python script to fix up fra

[Lldb-commits] [lldb] [lldb][RPC] Upstream LLDB to RPC converstion Python script (PR #138028)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Might be worth making this match the other scripts and doing this once instead of line-by-line. https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb][lldb-dap] explicitly set the expr as an alias for expression. (PR #134562)

2025-06-03 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/134562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a pythin JIT loader class. (PR #142514)

2025-06-03 Thread via lldb-commits
jimingham wrote: This seems like a generic module loading observer. I don't see anything JIT specific about it. Not saying a generic module loading observer is not a good idea. But calling it a JITLoader seems pretty confusing to me. https://github.com/llvm/llvm-project/pull/142514

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Free buffers in demangling tests to avoid leaks (PR #142676)

2025-06-03 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/142676 Test case added by f669b9c3eca9438d33259aefb8156f977f1df382 / #137793. Note that the `DemanglingParts` case above also frees the buffer; this new test case is inconsistent. >From 270b38ccfe58011c2b22e89e5b57

[Lldb-commits] [lldb] [lldb][test] Free buffers in demangling tests to avoid leaks (PR #142676)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes Test case added by f669b9c3eca9438d33259aefb8156f977f1df382 / #137793. Note that the `DemanglingParts` case above also frees the buffer; this new test case is inconsistent. --- Full diff: https://githu

[Lldb-commits] [lldb] [lldb][test] Free buffers in demangling tests to avoid leaks (PR #142676)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Maybe an opportunity to use a unique_ptr with a custom deleter? Something like: ``` struct TrackingOutputBufferDeleter { void operator()(TrackingOutputBuffer* TOB) { if (!TOB) return; std::free(TOB->getBuffer());

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-06-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142129 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Fixes #142581 --- Full diff: https://github.com/llvm/llvm-project/pull/142684.diff 6 Files Affected: - (modified) lldb/source/Commands/CommandObjectProcess.cpp (+1-1) - (modified) lldb/source/Symbol/SaveC

[Lldb-commits] [lldb] cb56e15 - [lldb][TypeSystem][NFC] CreateFunctionType to take parameters by llvm::ArrayRef (#142620)

2025-06-03 Thread via lldb-commits
Author: Michael Buch Date: 2025-06-03T23:37:39+01:00 New Revision: cb56e15bb3e92c8aab2b7fd74a7683ffd83ac10b URL: https://github.com/llvm/llvm-project/commit/cb56e15bb3e92c8aab2b7fd74a7683ffd83ac10b DIFF: https://github.com/llvm/llvm-project/commit/cb56e15bb3e92c8aab2b7fd74a7683ffd83ac10b.diff

[Lldb-commits] [lldb] 33fae08 - [lldb-dap] Forward any error from stepping. (#142652)

2025-06-03 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-03T23:40:00+01:00 New Revision: 33fae0840562ae7e93dd7b4bc6dd4a41150eee01 URL: https://github.com/llvm/llvm-project/commit/33fae0840562ae7e93dd7b4bc6dd4a41150eee01 DIFF: https://github.com/llvm/llvm-project/commit/33fae0840562ae7e93dd7b4bc6dd4a41150eee01.diff L

  1   2   >