https://github.com/DavidSpickett approved this pull request.
Identical code to Linux apart from `/lwp/` in place of `/task/`. Wondered if we could share that but as long as it remains identical, we could always do it later if we want. It would be something like `getProcFile(::pid_t pid, ::pid_t tid, const llvm::Twine &file, const llvm::Twine &task_folder)`. Then each would implement the current call by passing in the right name. By the time we've done that, we probably have the same number of lines again, but with more layers. So in summary, LGTM :) https://github.com/llvm/llvm-project/pull/142586 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits