[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

2023-09-20 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. Are Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} Shouldnt we build a relevant error message here incase ReadSMEControl fails on ReadZAHeader Comment at:

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

2023-09-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} omjavaid wrote: > Shouldnt we build a relevant error message here incase ReadSMEControl fails > on ReadZAHeader I thi

[Lldb-commits] [lldb] 87f937e - [lldb][Docs] Fix typo in style docs

2023-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-20T08:04:23Z New Revision: 87f937e9d68ae3ceea93982420f06bf90623aeba URL: https://github.com/llvm/llvm-project/commit/87f937e9d68ae3ceea93982420f06bf90623aeba DIFF: https://github.com/llvm/llvm-project/commit/87f937e9d68ae3ceea93982420f06bf90623aeba.diff LOG

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-20 Thread David Spickett via lldb-commits
@@ -18,19 +18,45 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

2023-09-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 557100. DavidSpickett added a comment. - Return error in SVCR read. - Note absence of write tests of SVCR because it's read only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

2023-09-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} DavidSpickett wrote: > omjavaid wrote: > > Shouldnt we build a relevan

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

2023-09-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 557101. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [lldb] 1446e3c - Revert "Fix a bug with cancelling "attach -w" after you have run a process previously (#65822)"

2023-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-20T08:19:53Z New Revision: 1446e3cf7605f0988b914fac0a34d63045394ff3 URL: https://github.com/llvm/llvm-project/commit/1446e3cf7605f0988b914fac0a34d63045394ff3 DIFF: https://github.com/llvm/llvm-project/commit/1446e3cf7605f0988b914fac0a34d63045394ff3.diff LOG

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is failing on AArch64 Linux and Windows, it finds some async error in the output but the bots don't say what. I'll find what it is. https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

2023-09-20 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is good too. Thanks!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread David Spickett via lldb-commits
@@ -127,3 +128,65 @@ def tearDown(self): # Call super's tearDown(). TestBase.tearDown(self) + +def test_run_then_attach_wait_interrupt(self): +# Test that having run one process doesn't cause us to be unable +# to interrupt a

[Lldb-commits] [lldb] [reland][libc][cmake] Tidy compiler includes (#66783) (PR #66878)

2023-09-20 Thread Guillaume Chatelet via lldb-commits
https://github.com/gchatelet created https://github.com/llvm/llvm-project/pull/66878 This is a reland of #66783 a35a3b75b219247eb9ff6784d1a0fe562f72d415 fixing the benchmark breakage. >From b3150085acea981ca9ed55c161ee9afeccfead20 Mon Sep 17 00:00:00 2001 From: Guillaume Chatelet Date: Tue,

[Lldb-commits] [lldb] [reland][libc][cmake] Tidy compiler includes (#66783) (PR #66878)

2023-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-libc Changes This is a reland of #66783 a35a3b75b219247eb9ff6784d1a0fe562f72d415 fixing the benchmark breakage. --- Full diff: https://github.com/llvm/llvm-project/pull/66878.diff 6 Files Affected: - (modified) libc/CMakeLists.txt (+5) - (modified

[Lldb-commits] [lldb] d7fab66 - [lldb][AArch64] Add SME's streaming vector control register

2023-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-20T10:20:45+01:00 New Revision: d7fab666955e9ef0d456b6dfb737f5a18241c97c URL: https://github.com/llvm/llvm-project/commit/d7fab666955e9ef0d456b6dfb737f5a18241c97c DIFF: https://github.com/llvm/llvm-project/commit/d7fab666955e9ef0d456b6dfb737f5a18241c97c.diff

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

2023-09-20 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd7fab666955e: [lldb][AArch64] Add SME's streaming vector control register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/n

[Lldb-commits] [lldb] [reland][libc][cmake] Tidy compiler includes (#66783) (PR #66878)

2023-09-20 Thread Guillaume Chatelet via lldb-commits
https://github.com/gchatelet closed https://github.com/llvm/llvm-project/pull/66878 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/66879 Migrated from https://reviews.llvm.org/D156774 >From 72f83fb2944829c60bd6f12a079bfba95da4f6e7 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 14 Sep 2023 09:46:53 +0300 Subject: [PATCH 1/2] Implemen

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Migrated from https://reviews.llvm.org/D156774 --- Full diff: https://github.com/llvm/llvm-project/pull/66879.diff 3 Files Affected: - (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (+9-6) - (modified) lldb/sour

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Vlad Serebrennikov via lldb-commits
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests, TestDefaultTemplateParamParsing) { } } } + +TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) { + const char *yamldata = R"( Endilll wrote: I find this YAML way of describing debug

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Vlad Serebrennikov via lldb-commits
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests, TestDefaultTemplateParamParsing) { } } } + +TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) { + const char *yamldata = R"( +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data:ELFDATA2LSB + T

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Vlad Serebrennikov via lldb-commits
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests, TestDefaultTemplateParamParsing) { } } } + +TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) { + const char *yamldata = R"( +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data:ELFDATA2LSB + T

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

2023-09-20 Thread Vlad Serebrennikov via Phabricator via lldb-commits
Endill added a comment. @Michael137 I moved this over to GitHub , and I need your help there writing the unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.or

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread David Spickett via lldb-commits
@@ -127,3 +128,65 @@ def tearDown(self): # Call super's tearDown(). TestBase.tearDown(self) + +def test_run_then_attach_wait_interrupt(self): +# Test that having run one process doesn't cause us to be unable +# to interrupt a

[Lldb-commits] [lldb] 3d422c4 - [lldb][API] Remove debug print in TestRunLocker.py

2023-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-20T10:01:32Z New Revision: 3d422c46828387770be07547d335a71719901979 URL: https://github.com/llvm/llvm-project/commit/3d422c46828387770be07547d335a71719901979 DIFF: https://github.com/llvm/llvm-project/commit/3d422c46828387770be07547d335a71719901979.diff LOG

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Michael Buch via lldb-commits
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests, TestDefaultTemplateParamParsing) { } } } + +TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) { + const char *yamldata = R"( +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data:ELFDATA2LSB + T

[Lldb-commits] [lldb] 96b1784 - [lldb-vscode] Use auto summaries whenever variables don't have a summary (#66551)

2023-09-20 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-09-20T10:23:41-04:00 New Revision: 96b1784ac8c52fb912150de1387117de62de13ad URL: https://github.com/llvm/llvm-project/commit/96b1784ac8c52fb912150de1387117de62de13ad DIFF: https://github.com/llvm/llvm-project/commit/96b1784ac8c52fb912150de1387117de62de13ad.di

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

2023-09-20 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fdc265b - [lldb][AArch64] Invalidate cached VG value before reconfiguring SVE registers

2023-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-20T16:05:34+01:00 New Revision: fdc265be26483be1e081ea3f1e11d78b8cc488af URL: https://github.com/llvm/llvm-project/commit/fdc265be26483be1e081ea3f1e11d78b8cc488af DIFF: https://github.com/llvm/llvm-project/commit/fdc265be26483be1e081ea3f1e11d78b8cc488af.diff

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

2023-09-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: I've just pushed a similar fix for SVE's VG (https://github.com/llvm/llvm-project/commit/fdc265be26483be1e081ea3f1e11d78b8cc488af). Fixes some test flakiness so I've pushed it directly. https://github.com/llvm/llvm-project/pull/66768 ___

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

2023-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/66768 >From 3d4834fd5ab994dd312b28b874e73f0807b117dc Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 22 Aug 2023 14:42:35 +0100 Subject: [PATCH] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

2023-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Michael Buch via lldb-commits
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests, TestDefaultTemplateParamParsing) { } } } + +TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) { + const char *yamldata = R"( +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data:ELFDATA2LSB + T

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

2023-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/66879 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

2023-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/66767 >From 705251d8ecbed546f46a5929a298ad88c70cc330 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 22 Aug 2023 11:12:23 +0100 Subject: [PATCH] [lldb][AArch64] Add release notes and documentation for SM

[Lldb-commits] [lldb] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-20 Thread Alex Voicu via lldb-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/65699 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-20 Thread Vlad Serebrennikov via lldb-commits
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests, TestDefaultTemplateParamParsing) { } } } + +TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) { + const char *yamldata = R"( +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data:ELFDATA2LSB + T

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: The way interruption works in lldb is that the first time you dispatch an interrupt, it just raises the "voluntary interrupt" flag. Turns out the process attach part of lldb isn't written in a way that makes checking for the interrupt flag possible, so that doesn't work. The

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: The way the test works, we run one real process and let it exit. Then we do "attach -w -n noone_would_use_this_name" because we don't want the second attach attempt to be able to succeed. lldb should just stay stuck till the interrupt succeeds, there shouldn't be anything ot

[Lldb-commits] [lldb] df93c4f - Remove some raciness from the TestProcessAttach.test_run_then_attach_wait_interrupt

2023-09-20 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2023-09-20T13:08:40-07:00 New Revision: df93c4ffdf220630ecceba5c9a7822c0aca7deaa URL: https://github.com/llvm/llvm-project/commit/df93c4ffdf220630ecceba5c9a7822c0aca7deaa DIFF: https://github.com/llvm/llvm-project/commit/df93c4ffdf220630ecceba5c9a7822c0aca7deaa.diff LO

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/66949 `std::basic_string` is not a regex, and treating it as such could unintentionally cause a formatter to substring match a template type parameter, for example: `std::vector>`. Differential Revision: https://r

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: You are right, there is a racy bit here - I was also getting ~one fails per 50 runs. The raciness is due to the time it takes between when we send the interrupt and when we finish up the command and produce the results. So we can end up reading from the command output befo

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes `std::basic_string` is not a regex, and treating it as such could unintentionally cause a formatter to substring match a template type parameter, for example: `std::vector>`. Differential Revision: https://revi

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. Good catch! I think I have suffered because of this at some point. https://github.com/llvm/llvm-project/pull/66949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: Interesting... I split the end stage of the test up into: (a) wait for up to 20 seconds the state to switch to eStateExited (b) wait another second, then check the command output file On macOS, as I said, that seemed to make the test quite robust, but when I checked the test

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: > On Sep 20, 2023, at 1:39 PM, Jim Ingham ***@***.***> wrote: > > Interesting... I split the end stage of the test up into: > > (a) wait for up to 20 seconds the state to switch to eStateExited > (b) wait another second, then check the command output file > > On macOS, as I

[Lldb-commits] [lldb] 933ad5c - [lldb] Add 'modify' type watchpoints, make it default (#66308)

2023-09-20 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2023-09-20T13:42:16-07:00 New Revision: 933ad5c897ee366759a54869b35b2d7285a92137 URL: https://github.com/llvm/llvm-project/commit/933ad5c897ee366759a54869b35b2d7285a92137 DIFF: https://github.com/llvm/llvm-project/commit/933ad5c897ee366759a54869b35b2d7285a92137.diff

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread via lldb-commits
jimingham wrote: In this case, it's clearly not a regex, so this change is fine. But ALSO, any regex matches against std types should be `^std::whatever` and not just `std::whatever` to avoid this sort of unintended matching. Jim > On Sep 20, 2023, at 1:37 PM, Walter Erquinigo ***@***.***>

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/66949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 56b148a - [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (#66949)

2023-09-20 Thread via lldb-commits
Author: Dave Lee Date: 2023-09-20T14:24:04-07:00 New Revision: 56b148aa8d6fcc61f0619d74cf5edca4d842 URL: https://github.com/llvm/llvm-project/commit/56b148aa8d6fcc61f0619d74cf5edca4d842 DIFF: https://github.com/llvm/llvm-project/commit/56b148aa8d6fcc61f0619d74cf5edca4d842.diff LOG:

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

2023-09-20 Thread Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG56b148aa8d6f: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (#66949) (authored by kastiglione, committed

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

2023-09-20 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. Merged in https://github.com/llvm/llvm-project/pull/66949 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158663/new/ https://reviews.llvm.org/D158663 ___ lldb-commits mailing

[Lldb-commits] [lldb] 7f34674 - Revert "Remove some raciness from the TestProcessAttach.test_run_then_attach_wait_interrupt"

2023-09-20 Thread Daniel Thornburgh via lldb-commits
Author: Daniel Thornburgh Date: 2023-09-20T14:30:24-07:00 New Revision: 7f3467412ed52d6749b7c53f7934c4374c6d2a00 URL: https://github.com/llvm/llvm-project/commit/7f3467412ed52d6749b7c53f7934c4374c6d2a00 DIFF: https://github.com/llvm/llvm-project/commit/7f3467412ed52d6749b7c53f7934c4374c6d2a00.d

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

2023-09-20 Thread David Blaikie via lldb-commits
@@ -132,6 +132,84 @@ std::vector GetStrings(const llvm::json::Object *obj, return strs; } +/// Create a short summary for a container that contains the summary of its +/// first children, so that the user can get a glimpse of its contents at a +/// glance. +static std::opti

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-20 Thread David Blaikie via lldb-commits
dwblaikie wrote: (aside: isn't the SBAPI meant to be the thing to use if you want to script stuff, rather than having formatted output/scraping that? - but sounds like the output has converged on a table rather than JSON anyway? So maybe a moot point) Re: errors, OSO (what does that stand for

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-20 Thread via lldb-commits
jimingham wrote: N_SO is the stab moniker for a source file, and N_OSO is the object file associated with that source file (N_SO was in Sun's implementation, we made up N_OSO). Most nm''s leave off the N_ when they print stabs, so then this became just OSO... We don't do DWO on Darwin, and n

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential Revision

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-20 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D157609#4645298 , @clayborg wrote: > In D157609#4644194 , @DavidSpickett > wrote: > >>> Any chance we could simplify this situation and have dwo searches use >>> exactly the same/sha

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-20 Thread David Blaikie via lldb-commits
dwblaikie wrote: > N_SO is the stab moniker for a source file, and N_OSO is the object file > associated with that source file (N_SO was in Sun's implementation, we made > up N_OSO). Most nm''s leave off the N_ when they print stabs, so then this > became just OSO... > We don't do DWO on Darw

[Lldb-commits] [lldb] de94c10 - The test: test_run_then_attach_wait_interrupt was flakey on Linux & Windows.

2023-09-20 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2023-09-20T17:38:27-07:00 New Revision: de94c109b64d098c52ffc6f60daadb3eaa8fb944 URL: https://github.com/llvm/llvm-project/commit/de94c109b64d098c52ffc6f60daadb3eaa8fb944 DIFF: https://github.com/llvm/llvm-project/commit/de94c109b64d098c52ffc6f60daadb3eaa8fb944.diff LO

[Lldb-commits] [lldb] 3c61e4b - Copy and paste error in a file header.

2023-09-20 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2023-09-20T17:43:44-07:00 New Revision: 3c61e4bf28538f5f267b073634e394dd5000af85 URL: https://github.com/llvm/llvm-project/commit/3c61e4bf28538f5f267b073634e394dd5000af85 DIFF: https://github.com/llvm/llvm-project/commit/3c61e4bf28538f5f267b073634e394dd5000af85.diff LO

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH] [libc++] Implement ranges::contains_subrange --- libcxx/inclu

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH] [libc++] Implement ranges::contains_subrange --- libcxx/inclu

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/2] [libc++] Implement ranges::contains_subrange --- libcxx/i

[Lldb-commits] [lldb] 1a78444 - Temoprarily stop running this test on Intel macs

2023-09-20 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2023-09-20T21:49:15-07:00 New Revision: 1a78b32ce8577b72aad6239525740da271ed URL: https://github.com/llvm/llvm-project/commit/1a78b32ce8577b72aad6239525740da271ed DIFF: https://github.com/llvm/llvm-project/commit/1a78b32ce8577b72aad6239525740da271ed.diff