[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

efriedma added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(&Demangled); +Demangler D(MangledName.data()); +const char *M = D.parseMangle(&Demangled); Is

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(&Demangled); +Demangler D(MangledName.data()); +const char *M = D.parseMangle(&Demangled);

[Lldb-commits] [PATCH] D152176: [Demangle] convert microsoftDemangle to take a std::string_view

nickdesaulniers created this revision. Herald added a subscriber: hiraditya. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commi

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(&Demangled); +Demangler D(MangledName.data()); +const char *M = D.parseMangle(&Demangled);

[Lldb-commits] [lldb] 65ceb42 - Replace deprecated startswith_insensitive with starts_with_insensitive

Author: Fangrui Song Date: 2023-06-05T11:01:27-07:00 New Revision: 65ceb42d636ea758a2c9ecdfb7473d528983a1e2 URL: https://github.com/llvm/llvm-project/commit/65ceb42d636ea758a2c9ecdfb7473d528983a1e2 DIFF: https://github.com/llvm/llvm-project/commit/65ceb42d636ea758a2c9ecdfb7473d528983a1e2.diff

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

zequanwu created this revision. zequanwu added reviewers: labath, rnk, aganea. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two age fields in a PDB file. One from the PDB Stream and another

[Lldb-commits] [lldb] 0bb6f83 - [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

Author: Alex Langford Date: 2023-06-05T12:52:38-07:00 New Revision: 0bb6f832fbf8ae022063c07e2090f07832136bd4 URL: https://github.com/llvm/llvm-project/commit/0bb6f832fbf8ae022063c07e2090f07832136bd4 DIFF: https://github.com/llvm/llvm-project/commit/0bb6f832fbf8ae022063c07e2090f07832136bd4.diff

[Lldb-commits] [PATCH] D151962: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb6f832fbf8: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151962/ne

[Lldb-commits] [PATCH] D151949: [lldb][NFCI] Use size_t in OptionValueProperties

This revision was automatically updated to reflect the committed changes. Closed by commit rG0871f22edca5: [lldb][NFCI] Use size_t in OptionValueProperties (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151949/new/ https://re

[Lldb-commits] [lldb] 0871f22 - [lldb][NFCI] Use size_t in OptionValueProperties

Author: Alex Langford Date: 2023-06-05T12:57:43-07:00 New Revision: 0871f22edca5036dad2aba0c4461a3975651b0c3 URL: https://github.com/llvm/llvm-project/commit/0871f22edca5036dad2aba0c4461a3975651b0c3 DIFF: https://github.com/llvm/llvm-project/commit/0871f22edca5036dad2aba0c4461a3975651b0c3.diff

[Lldb-commits] [lldb] db98ac0 - [Demangle] convert microsoftDemangle to take a std::string_view

Author: Nick Desaulniers Date: 2023-06-05T13:00:20-07:00 New Revision: db98ac082744880a6e352b2d4a97d8896d9a7694 URL: https://github.com/llvm/llvm-project/commit/db98ac082744880a6e352b2d4a97d8896d9a7694 DIFF: https://github.com/llvm/llvm-project/commit/db98ac082744880a6e352b2d4a97d8896d9a7694.di

[Lldb-commits] [PATCH] D152176: [Demangle] convert microsoftDemangle to take a std::string_view

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb98ac082744: [Demangle] convert microsoftDemangle to take a std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [lldb] 8a46369 - [lldb][NFCI] ConstString methods should take StringRefs by value

Author: Alex Langford Date: 2023-06-05T13:06:58-07:00 New Revision: 8a4636929fd649d4311fadb03c6e4be4fefec3af URL: https://github.com/llvm/llvm-project/commit/8a4636929fd649d4311fadb03c6e4be4fefec3af DIFF: https://github.com/llvm/llvm-project/commit/8a4636929fd649d4311fadb03c6e4be4fefec3af.diff

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a4636929fd6: [lldb][NFCI] ConstString methods should take StringRefs by value (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152010/

[Lldb-commits] [PATCH] D152013: [lldb/Commands] Fix disk completion from root directory

mib updated this revision to Diff 528560. mib marked an inline comment as done. mib added a comment. Address @bulbazord comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152013/new/ https://reviews.llvm.org/D152013 Files: lldb/source/Commands/CommandCompletions.cpp lldb/test/

[Lldb-commits] [PATCH] D152013: [lldb/Commands] Fix disk completion from root directory

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, this looks fine to me. I'm not 100% sure this will work on Windows, but we neither Ismail nor I have windows machines to test this on. Watch the windows bots please. CHANGES SINCE

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for adding the test! Most of this change looks fairly mechanical so I think this is probably good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152011/new/ https:

[Lldb-commits] [lldb] 59af0c3 - [lldb][NFCI] Change the way Process stores StructuredData plugins

Author: Alex Langford Date: 2023-06-05T13:49:58-07:00 New Revision: 59af0c38956346ece6e89276ec7ca99683010b2a URL: https://github.com/llvm/llvm-project/commit/59af0c38956346ece6e89276ec7ca99683010b2a DIFF: https://github.com/llvm/llvm-project/commit/59af0c38956346ece6e89276ec7ca99683010b2a.diff

[Lldb-commits] [PATCH] D151960: [lldb][NFCI] Change the way Process stores StructuredData plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rG59af0c389563: [lldb][NFCI] Change the way Process stores StructuredData plugins (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151960

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added a comment. > [Damangle] Damangle? dAmangle? *sigh* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D152176: [Demangle] convert microsoftDemangle to take a std::string_view

nickdesaulniers added a comment. This patch should have fixed the callsite in `llvm::demangle`...I will fix that up in D149104 which I am actively rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152176/new

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Wow. Well, I'm not going to argue otherwise. :) lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152189/new/ https://reviews.llvm.org/D152189

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

aprantl added a comment. Is ity possible to test this with a nested C++ type? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

kastiglione added a comment. +1 to a test thanks for the fix! Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:593 const DumpValueObjectOptions::PointerDepth &curr_ptr_depth) { - const uint32_t consumed_depth = (!m_options.m_pointer_as_array) ? 1 : 0; + con

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In the interest of keeping the ConstStrin

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Broadcasters don't need their names in the StringPool. It doesn't

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

JDevlieghere added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:1279 + // if you & in this bit the base code will not process the option. + eCustomCompletion = (1u << 24) +}; Should this be `<< 25`? CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

rupprecht added a comment. In D150805#4350849 , @JDevlieghere wrote: > I also like Jordan's rate limiting idea. In my mind that should be a property > of the broadcaster. Different tools (e.g. vscode vs the command line) could > specify different value

[Lldb-commits] [PATCH] D152225: [lldb] mark `clang_resource_path` as static

paperchalice created this revision. paperchalice added a reviewer: aprantl. Herald added a project: All. paperchalice requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The lifetime of `clang_resource_path` should be same as `kResourceDirSuffi

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

protze.joachim reopened this revision. protze.joachim added a comment. This revision is now accepted and ready to land. The review should not be closed, since the patch was reverted and should be recommitted (this time possibly with a reference to this review?) Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4398196 , @protze.joachim wrote: > The review should not be closed, since the patch was reverted and should be > recommitted (this time possibly with a reference to this review?) This is recommitted as 0beffb854