nickdesaulniers added inline comments.
================ Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 - Demangler D = Demangler(MangledName); - MangledName = D.parseMangle(&Demangled); + Demangler D(MangledName.data()); + const char *M = D.parseMangle(&Demangled); ---------------- nickdesaulniers wrote: > efriedma wrote: > > Isn't this still assuming MangledName is null-terminated? > (I have a rewrite of the D language demangler to use std::string_view > throughout, which I will post shortly; I believe that addresses your concern) D152177 PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
