Author: Pavel Labath
Date: 2022-05-03T10:28:47+02:00
New Revision: 51e72570d7e163d03ff211b7127899a1efd08174
URL:
https://github.com/llvm/llvm-project/commit/51e72570d7e163d03ff211b7127899a1efd08174
DIFF:
https://github.com/llvm/llvm-project/commit/51e72570d7e163d03ff211b7127899a1efd08174.diff
serge-sans-paille updated this revision to Diff 426620.
serge-sans-paille added a comment.
Fix nits
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124760/new/
https://reviews.llvm.org/D124760
Files:
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
lldb/source/Utility/ArchSpec.cp
Author: serge-sans-paille
Date: 2022-05-03T12:17:23+02:00
New Revision: f114f009486816ed4b3bf984f0fbbb8fc80914f6
URL:
https://github.com/llvm/llvm-project/commit/f114f009486816ed4b3bf984f0fbbb8fc80914f6
DIFF:
https://github.com/llvm/llvm-project/commit/f114f009486816ed4b3bf984f0fbbb8fc80914f6.d
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf114f0094868: [lldb] Fix ppc64 detection in lldb (authored
by serge-sans-paille).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124760/new/
https://reviews.
upsj updated this revision to Diff 426628.
upsj added a comment.
fix standalone builds
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
Files:
cmake/Modules/FindLibEdit.cmake
lldb/CMakeLists.txt
lldb
Author: David Spickett
Date: 2022-05-03T13:24:10Z
New Revision: 7667d805948e8049420b01c92f84c56528b42567
URL:
https://github.com/llvm/llvm-project/commit/7667d805948e8049420b01c92f84c56528b42567
DIFF:
https://github.com/llvm/llvm-project/commit/7667d805948e8049420b01c92f84c56528b42567.diff
LOG
DavidSpickett added a comment.
I reverted this due to an assert:
https://lab.llvm.org/buildbot/#/builders/96/builds/22715/steps/6/logs/stdio
(set cmake `LLVM_ENABLE_ASSERTIONS` to `ON`)
I think you could just add PowerPC to the `if (!reg_interface` there but first
time looking at the code I'm
Author: David Spickett
Date: 2022-05-03T13:40:14Z
New Revision: ca0b41665978d5efd8482188a0541342cb298031
URL:
https://github.com/llvm/llvm-project/commit/ca0b41665978d5efd8482188a0541342cb298031
DIFF:
https://github.com/llvm/llvm-project/commit/ca0b41665978d5efd8482188a0541342cb298031.diff
LOG
This revision was automatically updated to reflect the committed changes.
Closed by commit rGca0b41665978: [lldb][NFC] Add more tests for
GenerateOptionsUsage (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123500/new/
htt
DavidSpickett added a comment.
> Were there any tests for the help output? If not, maybe we should add one.
For these bits no, in fact I broke them without realising at first. Hence the
tests in the other review as you saw, they'll be landed before this.
Thanks for the reviews!
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61f2d3074699: [lldb][NFC] Simplify part of
Options::GenerateOptionUsage (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123501/new
Author: David Spickett
Date: 2022-05-03T14:32:26Z
New Revision: 61f2d307469981d5563187d646c44f8731ecf367
URL:
https://github.com/llvm/llvm-project/commit/61f2d307469981d5563187d646c44f8731ecf367
DIFF:
https://github.com/llvm/llvm-project/commit/61f2d307469981d5563187d646c44f8731ecf367.diff
LOG
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcf05de7168b0: [lldb][NFC] Refactor printing of short options
in help (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123502/new/
Author: David Spickett
Date: 2022-05-03T15:18:39Z
New Revision: cf05de7168b0ae2eaffdd6ab5a7c982bfa6da5c6
URL:
https://github.com/llvm/llvm-project/commit/cf05de7168b0ae2eaffdd6ab5a7c982bfa6da5c6
DIFF:
https://github.com/llvm/llvm-project/commit/cf05de7168b0ae2eaffdd6ab5a7c982bfa6da5c6.diff
LOG
wallace created this revision.
Herald added a subscriber: mgorny.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This diffs implements per-core tracing on lldb-server. It also includes tests
that ensur
kastiglione added inline comments.
Comment at: lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h:50
uint32_t max_depth;
+ bool max_depth_is_default;
uint32_t ptr_depth;
aprantl wrote:
> Should this be with the other bools on line 45?
It wasn't
wallace updated this revision to Diff 426737.
wallace added a comment.
nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124858/new/
https://reviews.llvm.org/D124858
Files:
lldb/docs/lldb-gdb-remote.txt
lldb/include/lldb/Utility/TraceGDBRemot
wallace updated this revision to Diff 426742.
wallace added a comment.
add one test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124858/new/
https://reviews.llvm.org/D124858
Files:
lldb/docs/lldb-gdb-remote.txt
lldb/include/lldb/Utility/Trace
wallace updated this revision to Diff 426745.
wallace edited the summary of this revision.
wallace added a comment.
improve error message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124858/new/
https://reviews.llvm.org/D124858
Files:
lldb/docs
kastiglione updated this revision to Diff 426755.
kastiglione added a comment.
Addresses Adrian's feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123954/new/
https://reviews.llvm.org/D123954
Files:
lldb/include/lldb/DataFormatters/DumpVa
kastiglione updated this revision to Diff 426761.
kastiglione added a comment.
Fixed/improved docstring
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123954/new/
https://reviews.llvm.org/D123954
Files:
lldb/include/lldb/DataFormatters/DumpValueO
Author: Dave Lee
Date: 2022-05-03T10:39:42-07:00
New Revision: 2f9fc576be206bd5c4fddfec5f89fceb3554a8d6
URL:
https://github.com/llvm/llvm-project/commit/2f9fc576be206bd5c4fddfec5f89fceb3554a8d6
DIFF:
https://github.com/llvm/llvm-project/commit/2f9fc576be206bd5c4fddfec5f89fceb3554a8d6.diff
LOG:
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f9fc576be20: [lldb] Add setting for max depth of value
object printing (NFC) (authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123954
wallace added inline comments.
Comment at:
lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:47
+self.skipTest("Per core tracing is not supported. You need "
+"/proc/sys/kernel/perf_event_paranoid to be 0 or -1.")
+
---
JDevlieghere added inline comments.
Comment at: lldb/CMakeLists.txt:3-5
+if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)
+ set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
+endif()
Can this go in `lldb/cmake/modules/LLDBStandalone.cmake`?
Repository:
JDevlieghere created this revision.
JDevlieghere added a reviewer: aprantl.
Herald added a project: All.
JDevlieghere requested review of this revision.
This patch adds a function to check if lldb is running in an interactive debug
session. Currently this API only works on macOS. It's expected to
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM. I see how your workflow is set up. Yeah, you return an error if someone
tries to run debugserver in translation (and the inferior isn't x86_64) -
that's what we need to do,
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thank you! This is equally useful and untestable :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124872/new/
https://reviews.llvm.org/D124872
JDevlieghere created this revision.
JDevlieghere added a reviewer: mib.
Herald added a project: All.
JDevlieghere requested review of this revision.
When writing out the session transcript, output should be printed to the async
debugger streams.
https://reviews.llvm.org/D124873
Files:
lldb/s
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124873/new/
https://reviews.llvm.org/D124873
___
lldb-commits mailing list
lldb-comm
JDevlieghere updated this revision to Diff 426821.
JDevlieghere added a comment.
Typo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124873/new/
https://reviews.llvm.org/D124873
Files:
lldb/source/Core/Debugger.cpp
Index: lldb/source/Core/Debugger.cpp
===
aprantl added inline comments.
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:411
+bool Host::IsInteractiveSession() {
+#if !TARGET_OS_OSX
Wait. I think this is a misnomer. An lldb session over SSH is interactive, but
not graphical. Should this be called
JDevlieghere updated this revision to Diff 426822.
JDevlieghere added a comment.
IsInteractiveSession -> IsInteractiveGraphicSession
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124872/new/
https://reviews.llvm.org/D124872
Files:
lldb/include/lldb/Host/Host.h
lldb/source/Host/comm
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
One last request: Could you add a Doxygen comment?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124872/new/
https://reviews.llvm.org/D124872
__
mib added inline comments.
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:411
+bool Host::IsInteractiveSession() {
+#if !TARGET_OS_OSX
aprantl wrote:
> Wait. I think this is a misnomer. An lldb session over SSH is interactive,
> but not graphical. Should t
mib added inline comments.
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:411
+bool Host::IsInteractiveSession() {
+#if !TARGET_OS_OSX
mib wrote:
> aprantl wrote:
> > Wait. I think this is a misnomer. An lldb session over SSH is interactive,
> > but not gr
aprantl added inline comments.
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:411
+bool Host::IsInteractiveSession() {
+#if !TARGET_OS_OSX
mib wrote:
> mib wrote:
> > aprantl wrote:
> > > Wait. I think this is a misnomer. An lldb session over SSH is
> > >
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3d08c778c01e: [lldb] Session transcript should use the async
debugger streams (authored by JDevlieghere).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
Author: Jonas Devlieghere
Date: 2022-05-03T15:11:57-07:00
New Revision: 3d08c778c01e1577752762da8c980db32b4e6d55
URL:
https://github.com/llvm/llvm-project/commit/3d08c778c01e1577752762da8c980db32b4e6d55
DIFF:
https://github.com/llvm/llvm-project/commit/3d08c778c01e1577752762da8c980db32b4e6d55.d
Author: Jonas Devlieghere
Date: 2022-05-03T15:11:57-07:00
New Revision: b945b62cf35e1b45ffb9233958756743b2b5fd46
URL:
https://github.com/llvm/llvm-project/commit/b945b62cf35e1b45ffb9233958756743b2b5fd46
DIFF:
https://github.com/llvm/llvm-project/commit/b945b62cf35e1b45ffb9233958756743b2b5fd46.d
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb945b62cf35e: [lldb] Add a function to check if lldb is
running in an interactive session (authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D124
Author: Weverything
Date: 2022-05-03T16:07:58-07:00
New Revision: 3dd00461f9cb91a6582653500603882ed1475e51
URL:
https://github.com/llvm/llvm-project/commit/3dd00461f9cb91a6582653500603882ed1475e51
DIFF:
https://github.com/llvm/llvm-project/commit/3dd00461f9cb91a6582653500603882ed1475e51.diff
L
Author: Luboš Luňák
Date: 2022-05-04T06:18:20+02:00
New Revision: 20048f3150cf6c603c8f5a20912561048a868484
URL:
https://github.com/llvm/llvm-project/commit/20048f3150cf6c603c8f5a20912561048a868484
DIFF:
https://github.com/llvm/llvm-project/commit/20048f3150cf6c603c8f5a20912561048a868484.diff
L
This revision was automatically updated to reflect the committed changes.
Closed by commit rG20048f3150cf: [lldb] use one shared ThreadPool and task
groups (authored by llunak).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123226/new/
https://revie
llunak added a comment.
The prerequisities fo this change have been pushed, so this one is ready.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122975/new/
https://reviews.llvm.org/D122975
___
lldb-commits mailing list
lldb-commits@lists.llvm
45 matches
Mail list logo
