mib added inline comments.
================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:411
+bool Host::IsInteractiveSession() {
+#if !TARGET_OS_OSX
----------------
mib wrote:
> aprantl wrote:
> > Wait. I think this is a misnomer. An lldb session over SSH is interactive,
> > but not graphical. Should this be called
> > IsInteractiveDesktopSession/IsInteractiveGraphicSession/IsInteractiveGUISession?
> FWIW, if you `open` a file on macOS over SSH, it would still open it in the
> default app. I'd expect the same behaviour here.
> FWIW, if you `open` a file on macOS over SSH, it would still open it in the
> default app. I'd expect the same behaviour here.
... Even if you're not in front of the screen.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124872/new/
https://reviews.llvm.org/D124872
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
