[Lldb-commits] [PATCH] D124872: [lldb] Add a function to check if lldb is running in an interactive session

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:411
 
+bool Host::IsInteractiveSession() {
+#if !TARGET_OS_OSX
----------------
aprantl wrote:
> Wait. I think this is a misnomer. An lldb session over SSH is interactive, 
> but not graphical. Should this be called 
> IsInteractiveDesktopSession/IsInteractiveGraphicSession/IsInteractiveGUISession?
FWIW, if you `open` a file on macOS over SSH, it would still open it in the 
default app. I'd expect the same behaviour here. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124872/new/

https://reviews.llvm.org/D124872

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits