[Lldb-commits] [lldb] r366415 - [lldb][NFC] Tablegenify type commands

Author: teemperor Date: Thu Jul 18 01:22:19 2019 New Revision: 366415 URL: http://llvm.org/viewvc/llvm-project?rev=366415&view=rev Log: [lldb][NFC] Tablegenify type commands Modified: lldb/trunk/source/Commands/CommandObjectType.cpp lldb/trunk/source/Commands/Options.td Modified: lldb/tr

[Lldb-commits] [lldb] r366414 - [lldb] Don't double emit option groups

Author: teemperor Date: Thu Jul 18 01:22:11 2019 New Revision: 366414 URL: http://llvm.org/viewvc/llvm-project?rev=366414&view=rev Log: [lldb] Don't double emit option groups We currently emit the option groups twice if Groups<[1,2,3]> is used in the tablegen. This leads to compilation errors. Th

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:185-207 + if ( + // When the previous and current states are consistent this is the fi

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

labath added a comment. I haven't been keeping up with all the python cmake patches, but I'm not sure this will help the situation, as it will add another dimension to the configuration matrix. If we're still going to support cmake<3.12, then we're going to need to make the other branch of this

[Lldb-commits] [lldb] r366425 - [lldb] Tablegenify thread commands and fix completion bug for thread step-*

Author: teemperor Date: Thu Jul 18 04:12:00 2019 New Revision: 366425 URL: http://llvm.org/viewvc/llvm-project?rev=366425&view=rev Log: [lldb] Tablegenify thread commands and fix completion bug for thread step-* Beside turning the options into the new tablegen format, this patch also fixes that a

[Lldb-commits] [lldb] r366426 - [lldb][NFC] Format 'type' commands in Options.td

Author: teemperor Date: Thu Jul 18 04:43:45 2019 New Revision: 366426 URL: http://llvm.org/viewvc/llvm-project?rev=366426&view=rev Log: [lldb][NFC] Format 'type' commands in Options.td Modified: lldb/trunk/source/Commands/Options.td Modified: lldb/trunk/source/Commands/Options.td URL: http:

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

teemperor created this revision. teemperor added reviewers: shafik, davide. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We currently don't support offsetof in the expression evaluator as it is implemented as a macro (which then calls __builtin_offsetof) in stddef.h. The

[Lldb-commits] [lldb] r366433 - [CMake] Always build debugserver on Darwin and allow tests to use the system's one

Author: stefan.graenitz Date: Thu Jul 18 06:30:37 2019 New Revision: 366433 URL: http://llvm.org/viewvc/llvm-project?rev=366433&view=rev Log: [CMake] Always build debugserver on Darwin and allow tests to use the system's one Summary: We can always build debugserver, but we can't always sign it t

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

This revision was automatically updated to reflect the committed changes. Closed by commit rL366433: [CMake] Always build debugserver on Darwin and allow tests to use the system's… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [lldb] r366440 - [lldb][NFC] Tablegenify alias/regex/history/source/script

Author: teemperor Date: Thu Jul 18 07:10:49 2019 New Revision: 366440 URL: http://llvm.org/viewvc/llvm-project?rev=366440&view=rev Log: [lldb][NFC] Tablegenify alias/regex/history/source/script (Converting these commands together as they are all simple commands that share the same file). Modifie

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

clayborg added a comment. nice! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64917/new/ https://reviews.llvm.org/D64917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This is good for now. I would add a comment explaining what you explained in the differential at the beginning of the macro section. Great work! Repository: rLLDB LLDB CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added a comment. I am sorry, but the code still seems a lot more verbose to me than it should be needed to implement the given functionality. I'd like to understand why/if it's that necessary.. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_WoW

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

amccarth requested changes to this revision. amccarth added a comment. This revision now requires changes to proceed. In D63165#1541944 , @clayborg wrote: > In D63165#1540606 , @Hui wrote: > > > > In D63165#1539118

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added a comment. In D63165#1591665 , @amccarth wrote: > I'm trying to think through the implications of this > always-use-an-lldb-server approach on cross-platform postmortem debugging. > I'll have to do some studying, but I guess this patch does

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

JDevlieghere abandoned this revision. JDevlieghere added a comment. Alright, it appears that the consensus is that this isn't desirable for now. From our side, r366447 fixed all the issues we were experiencing, so I'm abandoning this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D64865: [CMake] Polish folders in generated Xcode project

sgraenitz added a comment. I am going to land this, its cosmetics and the 9.0 branch was cut. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64865/new/ https://reviews.llvm.org/D64865 ___ lldb-commits m

[Lldb-commits] [lldb] r366459 - [CMake] Polish folders in generated Xcode project

Author: stefan.graenitz Date: Thu Jul 18 09:44:45 2019 New Revision: 366459 URL: http://llvm.org/viewvc/llvm-project?rev=366459&view=rev Log: [CMake] Polish folders in generated Xcode project Summary: Group plugins by subfolder. Move liblldb-resource-headers to `lldb misc`. Avoid install-distrib

[Lldb-commits] [PATCH] D64865: [CMake] Polish folders in generated Xcode project

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL366459: [CMake] Polish folders in generated Xcode project (authored by stefan.graenitz, committed by ). Herald added a pro

[Lldb-commits] [PATCH] D64255: Remove lldb-mi

This revision was automatically updated to reflect the committed changes. Closed by commit rG37fed664022e: [LLDB] Remove lldb-mi (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D64255?vs=208202&id=210622#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [lldb] r366471 - [swig] Enable autodoc feature

Author: jdevlieghere Date: Thu Jul 18 10:40:30 2019 New Revision: 366471 URL: http://llvm.org/viewvc/llvm-project?rev=366471&view=rev Log: [swig] Enable autodoc feature This patch enables the SWIG `autodoc` feature so that the generated Python reference [1] includes class properties. [1] https:/

[Lldb-commits] [lldb] r366476 - Add offsetof support to expression evaluator.

Author: teemperor Date: Thu Jul 18 10:58:04 2019 New Revision: 366476 URL: http://llvm.org/viewvc/llvm-project?rev=366476&view=rev Log: Add offsetof support to expression evaluator. Summary: We currently don't support offsetof in the expression evaluator as it is implemented as a macro (which th

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21fc8770ca4: Add offsetof support to expression evaluator. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64917/new/ https://review

[Lldb-commits] [lldb] r366489 - [FileSpecList] Add EmplaceBack method (NFC)

Author: jdevlieghere Date: Thu Jul 18 13:19:24 2019 New Revision: 366489 URL: http://llvm.org/viewvc/llvm-project?rev=366489&view=rev Log: [FileSpecList] Add EmplaceBack method (NFC) Instead of having to write FileSpecList::Append(FileSpec(args)) you can now call FileSpecList::EmplaceBack(args),

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

JDevlieghere updated this revision to Diff 210659. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Keep the indices correct when remapping a file fails. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62570/new/ https://reviews.llvm.org/D62570 Files: lldb/i

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

clayborg added a comment. We also need to test to ensure this doesn't regress parsing speed. Need a large C++ project, like LLDB with debug clang and debug llvm, and something that forces all line tables to be parsed (not just the prologues like when setting a breakpoint) and see how things com

[Lldb-commits] [lldb] r366493 - Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found

Author: jmolenda Date: Thu Jul 18 13:55:24 2019 New Revision: 366493 URL: http://llvm.org/viewvc/llvm-project?rev=366493&view=rev Log: Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found The new DriverKit user-land kernel drivers in macOS 10.15 / Catalina do not have a mai

[Lldb-commits] [PATCH] D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL366493: Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found (authored by jmolenda, committed by ).

[Lldb-commits] [lldb] r366495 - [Breakpoint] Replace use of ClangASTContext with TypeSystem

Author: xiaobai Date: Thu Jul 18 13:58:24 2019 New Revision: 366495 URL: http://llvm.org/viewvc/llvm-project?rev=366495&view=rev Log: [Breakpoint] Replace use of ClangASTContext with TypeSystem Modified: lldb/trunk/source/Breakpoint/Watchpoint.cpp Modified: lldb/trunk/source/Breakpoint/Watch

[Lldb-commits] [lldb] r366506 - The switch to table-genning command options broke

Author: jingham Date: Thu Jul 18 15:18:50 2019 New Revision: 366506 URL: http://llvm.org/viewvc/llvm-project?rev=366506&view=rev Log: The switch to table-genning command options broke the xcode project. This gets it a little closer to working, but I still have to figure out how to generate the ll

[Lldb-commits] [lldb] r366507 - Add an expectedFailure test for type finding.

Author: jingham Date: Thu Jul 18 15:21:16 2019 New Revision: 366507 URL: http://llvm.org/viewvc/llvm-project?rev=366507&view=rev Log: Add an expectedFailure test for type finding. When two .c files define a type of the same name, lldb just picks one and uses it regardless of context. That is not

[Lldb-commits] [lldb] r366508 - Remember to sort the Xcode project!!!

Author: jingham Date: Thu Jul 18 15:25:56 2019 New Revision: 366508 URL: http://llvm.org/viewvc/llvm-project?rev=366508&view=rev Log: Remember to sort the Xcode project!!! Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj ___ lldb-commits mailing

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added a comment. @daltenty Other than the minor nit, LGTM. Comment at: llvm/utils/lit/lit/util.py:449 +(recursively). It is currently implemented using the psutil module on some +plaftorms which provides a simple platform neutral implementation.

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

xiaobai added inline comments. Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50 - -option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF) -option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver instead of building it from source (Darwin only)

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, jingham, clayborg, compnerd. The methods to find types in a Target aren't clang specific and are pretty generalizable to type systems. Additionally, to support some of the use cases in SBTarget, I've added a "GetScratchTypeSyste

[Lldb-commits] [lldb] r366517 - [Commands] Remove unused header from CommandObjectFrame

Author: xiaobai Date: Thu Jul 18 17:26:31 2019 New Revision: 366517 URL: http://llvm.org/viewvc/llvm-project?rev=366517&view=rev Log: [Commands] Remove unused header from CommandObjectFrame Modified: lldb/trunk/source/Commands/CommandObjectFrame.cpp Modified: lldb/trunk/source/Commands/Comma

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. Makes it really clear that we need SBTarget::FindFirstTypeForLanguage, etc. But FindFirstType was always a crapshoot anyway... CHANGES SINCE LAST ACTION https://

[Lldb-commits] [lldb] r366519 - [NFC] Remove instances of unused ClangASTContext header

Author: xiaobai Date: Thu Jul 18 17:39:51 2019 New Revision: 366519 URL: http://llvm.org/viewvc/llvm-project?rev=366519&view=rev Log: [NFC] Remove instances of unused ClangASTContext header Modified: lldb/trunk/source/Expression/LLVMUserExpression.cpp lldb/trunk/source/Expression/Material

[Lldb-commits] [lldb] r366521 - [Target] Return an llvm::Expected from GetEntryPointAddress (NFC)

Author: jdevlieghere Date: Thu Jul 18 17:52:08 2019 New Revision: 366521 URL: http://llvm.org/viewvc/llvm-project?rev=366521&view=rev Log: [Target] Return an llvm::Expected from GetEntryPointAddress (NFC) Instead of taking a status and potentially returning an invalid address, return an expected

[Lldb-commits] [lldb] r366522 - [Target] Fix formatting and whitespace (NFC)

Author: jdevlieghere Date: Thu Jul 18 17:56:26 2019 New Revision: 366522 URL: http://llvm.org/viewvc/llvm-project?rev=366522&view=rev Log: [Target] Fix formatting and whitespace (NFC) Modified: lldb/trunk/include/lldb/Target/Target.h lldb/trunk/source/Target/Target.cpp Modified: lldb/tru

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Hui added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h:45-49 + NativeProcessWindows(ProcessLaunchInfo &launch_info, NativeDelegate &delegate, + llvm::Error &E); + + NativeProcessWindows(lldb::pid_t pid, i

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. All uses of this new function drop the error on the ground. Does that mean it doesn't matter? If it does, should we return an expected instead? Should we stop on the firs

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Hui added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp:104-109 + if (::SuspendThread(thread_handle) == -1) { +error.SetError(GetLastError(), eErrorTypeWin32); +LLDB_LOG(log, "{0} ResumeThread failed with

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai added a comment. In D64964#1592851 , @JDevlieghere wrote: > All uses of this new function drop the error on the ground. Does that mean it > doesn't matter? If it does, should we return an expected instead? Should we > stop on the first error, or

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Hui added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) { + // A WoW64 register info is the same as the i386's. + std::vector &g_register_infos = ---