Hui added inline comments.
================ Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h:45-49 + NativeProcessWindows(ProcessLaunchInfo &launch_info, NativeDelegate &delegate, + llvm::Error &E); + + NativeProcessWindows(lldb::pid_t pid, int terminal_fd, + NativeDelegate &delegate, llvm::Error &E); ---------------- labath wrote: > labath wrote: > > I guess these shouldn't be public as these object should be constructed > > through the factory, right? > This doesn't seem to be addressed. These constructors contain a call to function template make_unique that is not allowed to access private members of NativeProcessWindows. Simply do the following could address this concern. ``` - auto process_up = - std::make_unique<NativeProcessWindows>(launch_info, native_delegate, E); + auto process_up = std::unique_ptr<NativeProcessWindows>( + new NativeProcessWindows(launch_info, native_delegate, E)); ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63165/new/ https://reviews.llvm.org/D63165 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
