[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kkleine updated this revision to Diff 197922. kkleine added a comment. - Address formatting issues brought up in https://reviews.llvm.org/D61440#1488450 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61440/new/ https://reviews.llvm.org/D61440 File

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

teemperor added a comment. Looks good now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61440/new/ https://reviews.llvm.org/D61440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. @teemperor I've squashed my commits without the last one that did those many changes in the file `lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp`. I hope at least the result is fine now. Repository: rG LLVM Github Monorepo CHANGES SINC

Re: [Lldb-commits] [lldb] r359832 - Initialization: move InstructionEmulation to full initialization

On 02/05/2019 23:49, Saleem Abdulrasool via lldb-commits wrote: Author: compnerd Date: Thu May 2 14:49:29 2019 New Revision: 359832 URL: http://llvm.org/viewvc/llvm-project?rev=359832&view=rev Log: Initialization: move InstructionEmulation to full initialization The debug server does not need

[Lldb-commits] [lldb] r359862 - Revert "Initialization: move InstructionEmulation to full initialization"

Author: labath Date: Fri May 3 00:11:43 2019 New Revision: 359862 URL: http://llvm.org/viewvc/llvm-project?rev=359862&view=rev Log: Revert "Initialization: move InstructionEmulation to full initialization" This change is bogus. lldb-server definitely uses instruction emulation on some architectu

[Lldb-commits] [lldb] r359867 - Split TestVLA into two and XFAIL one part

Author: labath Date: Fri May 3 01:06:28 2019 New Revision: 359867 URL: http://llvm.org/viewvc/llvm-project?rev=359867&view=rev Log: Split TestVLA into two and XFAIL one part The part which checks whether vla_expr shows up in the variable list does not pass on non-darwin platforms. Add the approp

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

labath added a comment. I think there is a problem with this patch. I don't believe the TestVLA part would work on any non-darwin platform (it doesn't on linux: http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/923), and it works on darwin only accidentally. The reason the fails on l

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1489064 , @teemperor wrote: > Looks good now, thanks! Thank you for being patient with me! Can you merge the change for me please? I don't have commit rights, yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D61481: [DWARF] Reimplement/simplify DWARFUnit::GetID

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added subscribers: jdoerfert, arphaman. The implementation of GetID used a relatively complicated algorithm, which returned some kind of an offset of the unit in some file (depending on the debug info fla

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added a subscriber: arphaman. The offset of a compile unit is enough to identify in a section, but things start to get a lot more complicated when you have multiple object files, each with potentially sev

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath updated this revision to Diff 197936. labath added a comment. Fix two more things I noticed when looking at the patch in phab: - incorrect use of unit offset in DIERef constructor in the DebugMap case (I'm guessing this didn't cause any test failures because both offsets and IDs are gene

[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

martong added a comment. This is a good patch, it is good to separate responsibilities and it makes cleaner how the clang::ASTImporter is used. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:250 +/// imported while completing the original Decls). +class DeportQueueScope :

[Lldb-commits] [lldb] r359868 - C.128 override, virtual keyword handling

Author: teemperor Date: Fri May 3 03:03:28 2019 New Revision: 359868 URL: http://llvm.org/viewvc/llvm-project?rev=359868&view=rev Log: C.128 override, virtual keyword handling Summary: According to [C128] "Virtual functions should specify exactly one of `virtual`, `override`, or `final`", I've a

[Lldb-commits] [PATCH] D61473: ExpressionParser: only force link MCJIT when needed

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Did you run the test suite with this change? I get about 200 failures (non-shlib build), which is not surprising as without this lldb will not actually have a jit engine to evaluate

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL359868: C.128 override, virtual keyword handling (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

kkleine created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk edited the summary of this revision. kkleine updated this revision to Diff 197943. kkleine added a comment. Amend previous commit with copy paste error. The `run` command is only an abbrevia

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

kkleine updated this revision to Diff 197943. kkleine added a comment. Amend previous commit with copy paste error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.org/D61483 Files: lldb/www/lldb-gdb.html Index: l

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

kkleine updated this revision to Diff 197944. kkleine added a comment. - [www] move `run ` command down for educational purposes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.org/D61483 Files: lldb/www/lldb-gdb.ht

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, seems consistent with the row above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.org/D61483

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 197948. martong added a comment. - Log and do not assert anywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter.h clang

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

labath added a comment. This is the old documentation. You should edit the new one in `docs/use/map.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61483/new/ https://reviews.llvm.org/D61483 ___ l

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath added a comment. Jason, could you take a quick look at this. I don't expect this to be too contentious... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61018/new/ https://reviews.llvm.org/D61018 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added a subscriber: abidh. These two methods are very similar and various refactorizations need to modify both similar ways. Merge them as a template. O

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: lldb-commits, jdoerfert, abidh, arphaman, aprantl. D42892 changed a lot of code to use superclass `D

[Lldb-commits] [PATCH] D61502: 03/06: New CUDIERef

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. New `CUDIERef` contains `DWARFUnit *` + `dw_offset_t`; compared to `DIERef` which contains the CU as `dw_offset_t` which is

[Lldb-commits] [PATCH] D61503: 04/06: Track .debug_types vs. .debug_info difference

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: jdoerfert, abidh, arphaman, aprantl. Steal one bit from `DIERef`'s `die_offset`. That will make DWO's maximum CU size 4GB->2GB which s

[Lldb-commits] [PATCH] D61504: 05/06: Track CUs and TUs separately

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: jdoerfert, arphaman. jankratochvil added a parent revision: D61503: 04/06: Track .debug_types vs. .debug_info difference. There is one

[Lldb-commits] [PATCH] D61505: 06/06: Implement .debug_types

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: teemperor, mgorny. jankratochvil added a parent revision: D61504: 05/06: Track CUs and TUs separately. It is a rebased patch D32167

[Lldb-commits] [PATCH] D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset

labath added a comment. What you could do instead is have a single function which returns the CU if it is in the range `cu.GetOffset() <= input < cu.GetNextUnitOffset()`, then the wrapper functions could just perform a more stricter check on the returned cu (I.e. no templates or callbacks). T

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1767 DWARFUnit *dwarf_cu = -debug_info->GetCompileUnit(cu_offset, &cu_idx); +

[Lldb-commits] [PATCH] D61504: 05/06: Track CUs and TUs separately

labath added a comment. > FIXME: May DW_ATOM_cu_offset somehow contain a TypeUnit? Nope. In fact, until very recently attempting to generate a debug_types section on a mac crashed the compiler (now it just aborts the compilation iirc). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath added a comment. Hm... looking at @jankratochvil's patches, I realized that I completely omitted HashedNameToDIE from this patch (it used `emplace_back` to construct DIERefs, so it snuck past me). Thinking about it, I guess the best way to handle that would be to set the cu_idx to the in

[Lldb-commits] [PATCH] D61473: ExpressionParser: only force link MCJIT when needed

compnerd updated this revision to Diff 198020. compnerd added a comment. Move the inclusion as suggested. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61473/new/ https://reviews.llvm.org/D61473 Files: source/API/SystemInitializerFull.cpp source/Plugins/Ex

[Lldb-commits] [PATCH] D61481: [DWARF] Reimplement/simplify DWARFUnit::GetID

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with one inline comment. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:43 size_t GetNumCompileUnits(); DWARFUnit *GetCompileUnitAtIndex(

[Lldb-commits] [PATCH] D61473: ExpressionParser: only force link MCJIT when needed

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. Let's give that a shot. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61473/new/ https://reviews.llvm.org/D61473 _

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

jingham added a comment. IIUC, when Expected returns fails, it returns an Error object that might have information about what went wrong. Would it be possible to include the contents of that error n the log message? We often get "I can't run an expression in a really complex proprietary code

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

aadsm marked an inline comment as done. aadsm added a comment. @labath thank you for your kind words! Comment at: lldb/unittests/Symbol/TestLineEntry.cpp:96-122 +llvm::Expected LineEntryTest::GetModule() { + if (m_module_sp) +return m_module_sp; + + std::string yaml = Get

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

shafik updated this revision to Diff 198061. shafik added a comment. Updating after https://reviews.llvm.org/D46551 landed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59960/new/ https://reviews.llvm.org/D59960 Files: packages/Python/lldbsuite/test/expression_command/namespace_loca

[Lldb-commits] [lldb] r359921 - Fix for ambiguous lookup in expressions between local variable and namespace

Author: shafik Date: Fri May 3 12:59:22 2019 New Revision: 359921 URL: http://llvm.org/viewvc/llvm-project?rev=359921&view=rev Log: Fix for ambiguous lookup in expressions between local variable and namespace Summary: In an Objective-C context a local variable and namespace can cause an ambiguou

[Lldb-commits] [PATCH] D59960: Fix for ambiguous lookup in expressions between local variable and namespace

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL359921: Fix for ambiguous lookup in expressions between local variable and namespace (authored by shafik, committed by ).

[Lldb-commits] [PATCH] D61533: Make lldb-mi optional and change how we deal with missing tools in lit

JDevlieghere created this revision. JDevlieghere added a reviewer: davide. Herald added a subscriber: mgorny. https://reviews.llvm.org/D61533 Files: lldb/lit/CMakeLists.txt lldb/lit/lit.site.cfg.py.in lldb/lit/tools/lldb-instr/lit.local.cfg lldb/tools/CMakeLists.txt Index: lldb/tools/CM

[Lldb-commits] [lldb] r359925 - Supply a default implementation of IsRuntimeSupportValue.

Author: adrian Date: Fri May 3 13:28:19 2019 New Revision: 359925 URL: http://llvm.org/viewvc/llvm-project?rev=359925&view=rev Log: Supply a default implementation of IsRuntimeSupportValue. Thanks to Pavel for pointing this out. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla

[Lldb-commits] [PATCH] D61451: Hide runtime support values such as clang's __vla_expr from frame variable

aprantl added a comment. In D61451#1489109 , @labath wrote: > I think there is a problem with this patch. I don't believe the TestVLA part > would work on any non-darwin platform (it doesn't on linux: > http://lab.llvm.org:8014/builders/lldb-x86_64-debia

[Lldb-commits] [PATCH] D61533: Make lldb-mi optional and change how we deal with missing tools in lit

davide added inline comments. Comment at: lldb/lit/tools/lldb-instr/lit.local.cfg:1 -import sys - -if not config.have_lldb_instr: +if not "lldb-inst" in config.available_features: config.unsupported = True lldb-instr. CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D61533: Make lldb-mi optional and change how we deal with missing tools in lit

JDevlieghere updated this revision to Diff 198076. JDevlieghere added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61533/new/ https://reviews.llvm.org/D61533 Files: lldb/lit/CMakeLists.txt lldb/lit/lit.site.cfg.py.in lldb/lit/tools/lldb-instr/lit.local.cfg

[Lldb-commits] [PATCH] D61533: Make lldb-mi optional and change how we deal with missing tools in lit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL359926: Make lldb-mi optional and change how we deal with missing tools in lit (authored by JDevlieghere, committed by ).

[Lldb-commits] [lldb] r359926 - Make lldb-mi optional and change how we deal with missing tools in lit

Author: jdevlieghere Date: Fri May 3 13:33:58 2019 New Revision: 359926 URL: http://llvm.org/viewvc/llvm-project?rev=359926&view=rev Log: Make lldb-mi optional and change how we deal with missing tools in lit We don't need the variables in lit, we can use the capabilities to check if the utility

[Lldb-commits] [PATCH] D61469: [Alias] Add 're' alias for register

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61469/new/ https://reviews.llvm.org/D61469 ___ lldb-commi

[Lldb-commits] [lldb] r359927 - [Alias] Add 're' alias for register

Author: jdevlieghere Date: Fri May 3 13:37:09 2019 New Revision: 359927 URL: http://llvm.org/viewvc/llvm-project?rev=359927&view=rev Log: [Alias] Add 're' alias for register This patch makes `re` an alias for `register`. Currently `re` gives you the choice between `register` and `reproducer`. Gi

[Lldb-commits] [PATCH] D61469: [Alias] Add 're' alias for register

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359927: [Alias] Add 're' alias for register (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D61469?vs=197872&id=198078#toc Repository: rLLDB LLDB CHAN

[Lldb-commits] [lldb] r359929 - [lldb] Remove the 'www' folder.

Author: jdevlieghere Date: Fri May 3 13:42:45 2019 New Revision: 359929 URL: http://llvm.org/viewvc/llvm-project?rev=359929&view=rev Log: [lldb] Remove the 'www' folder. Now that the new website is live and everything is generated from the repository, we don't need the www folder anymore. Remov

[Lldb-commits] [lldb] r359930 - [test] Make check more strict

Author: jdevlieghere Date: Fri May 3 13:58:56 2019 New Revision: 359930 URL: http://llvm.org/viewvc/llvm-project?rev=359930&view=rev Log: [test] Make check more strict Before this change the test would always pass if the path to the test contained the number 11 in it. Thanks to Ted for pointing

[Lldb-commits] [lldb] r359931 - Fixed some minor style issues in rLLDB359921 [NFC]

Author: teemperor Date: Fri May 3 14:01:45 2019 New Revision: 359931 URL: http://llvm.org/viewvc/llvm-project?rev=359931&view=rev Log: Fixed some minor style issues in rLLDB359921 [NFC] Ran clang-format on the added test file and use the new StringRef comparison over the temporary ConstStrings.

[Lldb-commits] [lldb] r359944 - ExpressionParser: only force link MCJIT when needed

Author: compnerd Date: Fri May 3 16:19:27 2019 New Revision: 359944 URL: http://llvm.org/viewvc/llvm-project?rev=359944&view=rev Log: ExpressionParser: only force link MCJIT when needed This was added to support FreeBSD. The inclusion of this header increases the size of `lldb-server` due to MC

[Lldb-commits] [PATCH] D61473: ExpressionParser: only force link MCJIT when needed

compnerd closed this revision. compnerd added a comment. SVN r359944 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61473/new/ https://reviews.llvm.org/D61473 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization

compnerd created this revision. compnerd added reviewers: labath, xiaobai, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB. The debug server does not need to use the instruction emulation. This helps reduce the size of the final lldb-server binary by another ~100K (~1% s

[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61543/new/ https://reviews.llvm.org/D61543 ___ lldb-com

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 198114. aadsm added a comment. Herald added subscribers: jdoerfert, MaskRay, eraman, arichardson, mgorny, emaste. Herald added a reviewer: espindola. - Renamed CompareFileAndLine to FileAndLineEqual and made it return a bool - Made include_inlined_functions a m

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

aadsm updated this revision to Diff 198115. aadsm added a comment. Herald added subscribers: MaskRay, arichardson, emaste. Herald added a reviewer: espindola. - Renamed CompareFileAndLine to FileAndLineEqual and made it return a bool - Made include_inlined_functions a mandatory parameter in GetSa

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 198116. aadsm added a comment. Undo the previous changes because I updated to the wrong diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/U

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM, you should probably wait on Pavel's okay to the testing framework changes since that's more his baby... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi