[Lldb-commits] [lldb] r359925 - Supply a default implementation of IsRuntimeSupportValue.

[Adrian Prantl via lldb-commits]

Author: adrian
Date: Fri May  3 13:28:19 2019
New Revision: 359925

URL: http://llvm.org/viewvc/llvm-project?rev=359925&view=rev
Log:
Supply a default implementation of IsRuntimeSupportValue.

Thanks to Pavel for pointing this out.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py
    lldb/trunk/source/Core/ValueObject.cpp

Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py?rev=359925&r1=359924&r2=359925&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py Fri May  3 
13:28:19 2019
@@ -9,7 +9,6 @@ class TestVLA(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIf(compiler="clang", compiler_version=['<', '8.0'])
-    @expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples()))
     def test_variable_list(self):
         self.build()
         _, process, _, _ = lldbutil.run_to_source_breakpoint(

Modified: lldb/trunk/source/Core/ValueObject.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=359925&r1=359924&r2=359925&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObject.cpp (original)
+++ lldb/trunk/source/Core/ValueObject.cpp Fri May  3 13:28:19 2019
@@ -31,6 +31,7 @@
 #include "lldb/Symbol/Declaration.h"
 #include "lldb/Symbol/SymbolContext.h"
 #include "lldb/Symbol/Type.h"
+#include "lldb/Symbol/Variable.h"
 #include "lldb/Target/ExecutionContext.h"
 #include "lldb/Target/Language.h"
 #include "lldb/Target/LanguageRuntime.h"
@@ -1704,6 +1705,9 @@ bool ValueObject::IsRuntimeSupportValue(
       runtime = process->GetObjCLanguageRuntime();
     if (runtime)
       return runtime->IsRuntimeSupportValue(*this);
+    // If there is no language runtime, trust the compiler to mark all
+    // runtime support variables as artificial.
+    return GetVariable() && GetVariable()->IsArtificial();
   }
   return false;
 }


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits