labath added a comment.

I think there is a problem with this patch. I don't believe the TestVLA part 
would work on any non-darwin platform (it doesn't on linux: 
http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/923), and it works 
on darwin only accidentally.

The reason the fails on linux is that we don't have a "language runtime" plugin 
for the "C" language, so there is noone to ask if the variable is a runtime 
support value, and so we return false from 
`ValueObject::IsRuntimeSupportValue`. I believe the reason this works on darwin 
is because `ValueObject::IsRuntimeSupportValue` has a fallback (not sure why) 
which explicitly asks for the ObjC runtime if the desired language is not 
present. On linux, we don't have an ObjC runtime..

I can think of a couple of solutions here (adding a C language runtime, 
defaulting to return  `IsArtificial` in ValueObject if no language runtime is 
present) but none of them seemed too obvious to commit straight-away, so I've 
disabled a part of that test for the time being (r359867). Nonetheless, could 
you please take a look at this problem?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61451/new/

https://reviews.llvm.org/D61451



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to