[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks for moving the function to a more generic place. I can get rid of the copy in NativeProcessLinux once this lands. Comment at: source/Plugins/Process

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

labath added a comment. In D55582#1330715 , @JDevlieghere wrote: > I played around with this today: > > - I'm totally convinced that we should replay by swapping out stdin with a > file from the reproducer. This makes this better overall. > - I'm not con

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

On 13/12/2018 23:19, Zachary Turner wrote: The permanent solution would be figuring out what to do about the ObjectFile situation (e.g. do we want to make an ObjectFilePDB or do we want to live in a world where SymbolFiles need not be backed by ObjectFiles?), and then regardless of what we deci

[Lldb-commits] [lldb] r349149 - Mark Permissions as a bitmask enum

Author: labath Date: Fri Dec 14 05:51:20 2018 New Revision: 349149 URL: http://llvm.org/viewvc/llvm-project?rev=349149&view=rev Log: Mark Permissions as a bitmask enum this allows one to use bitwise operators on the variables of this type without complicated casting. The gotcha here is that the

[Lldb-commits] [lldb] r349153 - Fix build with older (<3.0) swigs

Author: labath Date: Fri Dec 14 06:25:20 2018 New Revision: 349153 URL: http://llvm.org/viewvc/llvm-project?rev=349153&view=rev Log: Fix build with older (<3.0) swigs It turns out it wasn't the compilers, but swig who had issues with my previous patch -- older versions do not recognise the "const

[Lldb-commits] [lldb] r349154 - Fix minidump unit test failures from r349062

Author: labath Date: Fri Dec 14 06:41:04 2018 New Revision: 349154 URL: http://llvm.org/viewvc/llvm-project?rev=349154&view=rev Log: Fix minidump unit test failures from r349062 This commit added new test inputs, but it did not add them to the cmake files. This caused the test to fail at runtime.

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

labath created this revision. labath added reviewers: clayborg, krytarowski. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. This patch attempts to move as much code as possible out of the CreateSections function to make room for future improvements there. Some o

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

krytarowski edited reviewers, added: joerg; removed: krytarowski. krytarowski added a comment. I recommend joerg@ as a reviewer for ELF specifics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55706/new/ https://reviews.llvm.org/D55706 ___

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere added a comment. In D55582#1331145 , @labath wrote: > Hm.. so the way, I'd imagine this working is that `-o` and friends (as well > as pretty much every other command line argument) would be captured by the SB > recorder, once they cross the

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

labath added a comment. In D55582#1331333 , @JDevlieghere wrote: > Yes, this is how SB record/replay will work. I don't disagree with this > approach, it's just that, as I said in my earlier reply, I was hoping to get > the driver working without the ne

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

stella.stamenova added a comment. local-variables.cpp is failing on the Buildbot: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2255/steps/test/logs/stdio Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55575/new/ https://reviews.llvm.org/D5557

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

I can't access the buildbot right now, it's just timing out and never loading the webpage. If you have it open and can paste the output here I can try to figure out what's wrong, otherwise I'll have to wait for it to become available again. On Fri, Dec 14, 2018 at 10:31 AM Stella Stamenova via Ph

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

stella.stamenova added a comment. $ ":" "RUN: at line 5" $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\lo

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

Ahh, that seems easy enough to fix. Just need to change the 7 to a {{.*}}. Since we're actually compiling and running a process on the buildbot, different versions of Windows will affect this. On Fri, Dec 14, 2018 at 10:39 AM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote: >

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55706/new/ https://reviews.llvm.org/D55706 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] r349175 - [NativePDB] Fix local-variables.cpp test.

Author: zturner Date: Fri Dec 14 10:43:42 2018 New Revision: 349175 URL: http://llvm.org/viewvc/llvm-project?rev=349175&view=rev Log: [NativePDB] Fix local-variables.cpp test. Since we're actually running an executable on the host now, different versions of Windows could load different system lib

Re: [Lldb-commits] [lldb] r349175 - [NativePDB] Fix local-variables.cpp test.

On 14/12/2018 19:43, Zachary Turner via lldb-commits wrote: Author: zturner Date: Fri Dec 14 10:43:42 2018 New Revision: 349175 URL: http://llvm.org/viewvc/llvm-project?rev=349175&view=rev Log: [NativePDB] Fix local-variables.cpp test. Since we're actually running an executable on the host now,

Re: [Lldb-commits] [lldb] r349175 - [NativePDB] Fix local-variables.cpp test.

I don't know if there's a good way to do that. Because debuggers need to be able to see across multiple translation units, this is implemented internally as constructing one giant AST that contains everything for the entire program. LLDB has no notion of a per-module AST, so it would be hard to m

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

I've fixed it. It looks like the bot should be green again once this test starts passing. Can you make it noisy and starting to send emails now? On Fri, Dec 14, 2018 at 10:42 AM Zachary Turner wrote: > Ahh, that seems easy enough to fix. Just need to change the 7 to a > {{.*}}. Since we're a

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

It’s actually not green – the unexpected passes are counted as a failure. With Pavel’s change to add the gcc builder, most of those can now be enabled, so I am going to do that today, but there’s still a couple that are “unexpectedly passing” when they are in fact failing. We’ll need to fix that

Re: [Lldb-commits] [lldb] r349175 - [NativePDB] Fix local-variables.cpp test.

On 14/12/2018 19:52, Zachary Turner wrote: I don't know if there's a good way to do that.  Because debuggers need to be able to see across multiple translation units, this is implemented internally as constructing one giant AST that contains everything for the entire program.  LLDB has no notio

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

An unexpected pass won't make the bot red will it? If so, one option is to mark them skip, just to make sure we can get the bot turned on as quickly as possible. On Fri, Dec 14, 2018 at 10:56 AM Stella Stamenova wrote: > It’s actually not green – the unexpected passes are counted as a failure.

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

An unexpected pass makes the bot red. I might un-silence it despite the couple of issues left anyway, but it’s something to be aware of. Thanks, -Stella From: Zachary Turner Sent: Friday, December 14, 2018 11:04 AM To: Stella Stamenova Cc: reviews+d55575+public+5ea6161324294...@reviews.llvm.or

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

If you do decide to unsilence it, then just mark those skip and file bugs for them being flaky. On Fri, Dec 14, 2018 at 11:11 AM Stella Stamenova wrote: > An unexpected pass makes the bot red. I might un-silence it despite the > couple of issues left anyway, but it’s something to be aware of. >

Re: [Lldb-commits] [lldb] r349175 - [NativePDB] Fix local-variables.cpp test.

Ahh, so I misinterpreted what you originally said. There is one Clang AST *per SymboFile*. In PDB land, compile units are often called "modules" so it's easy to get confused. So in my original response, what I actually meant was that there's no notion of a per compile-unit AST. But that also ha

[Lldb-commits] [lldb] r349180 - Fix Xcode project for MIPS architecture plug-in and move of Event, Listener and Broadcaster to Utility.

Author: gclayton Date: Fri Dec 14 11:22:24 2018 New Revision: 349180 URL: http://llvm.org/viewvc/llvm-project?rev=349180&view=rev Log: Fix Xcode project for MIPS architecture plug-in and move of Event, Listener and Broadcaster to Utility. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

stella.stamenova added a comment. I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing: 2018-12-14T19:24:41.8890855Z 2018-12-14T19:24:41.8904193Z

[Lldb-commits] [lldb] r349182 - Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available

Author: gclayton Date: Fri Dec 14 11:36:01 2018 New Revision: 349182 URL: http://llvm.org/viewvc/llvm-project?rev=349182&view=rev Log: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available Breakpad creates minidump files that sometimes have:

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349182: Cache memory regions in ProcessMinidump and use the linux maps as the source of… (authored by gclayton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[Lldb-commits] [lldb] r349183 - Add missing .dmp files to test inputs.

Author: gclayton Date: Fri Dec 14 11:38:08 2018 New Revision: 349183 URL: http://llvm.org/viewvc/llvm-project?rev=349183&view=rev Log: Add missing .dmp files to test inputs. Modified: lldb/trunk/unittests/Process/minidump/CMakeLists.txt Modified: lldb/trunk/unittests/Process/minidump/CMakeL

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

clayborg added a comment. Fixed the test inputs CMakeLists.txt file: $ svn commit SendingCMakeLists.txt Transmitting file data .done Committing transaction... Committed revision 349183. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://revi

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

On 14/12/2018 20:32, Stella Stamenova via Phabricator wrote: stella.stamenova added a comment. I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing: Interesting. Can yo

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

The verbose output is below. If I run the two commands on the command line, they both succeed, but when I run them through build.py, the link command is failing. I suspect that the process that gets created through python doesn't inherit the environment with the PATH set, so it can't find the li

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

Don't we print the environment in verbose mode? Can we see that output as well? On Fri, Dec 14, 2018 at 11:53 AM Stella Stamenova wrote: > The verbose output is below. If I run the two commands on the command > line, they both succeed, but when I run them through build.py, the link > command is

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

Ah, yes, it does. It looks like it does contain /usr/bin. Script Arguments: Arch: 64 Compiler: any Outdir: /vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output Output: /vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output/exec-next-instruction.test.

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. The frame regex will get confused if you had a binary called "foo 0x1" Then we would treat "foo" as the binary name, 0x1 as the pc, and the rest would be the function name. I don

[Lldb-commits] [PATCH] D55559: Remove the Disassembly benchmarks.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] r349194 - Remove the Disassembly benchmarks.

Author: adrian Date: Fri Dec 14 13:06:00 2018 New Revision: 349194 URL: http://llvm.org/viewvc/llvm-project?rev=349194&view=rev Log: Remove the Disassembly benchmarks. While I was out hunting for remaining pexpect-based tests, I came across these tests that can't possibly work an any modern syste

[Lldb-commits] [PATCH] D55559: Remove the Disassembly benchmarks.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349194: Remove the Disassembly benchmarks. (authored by adrian, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D555

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

clayborg requested changes to this revision. clayborg added inline comments. Comment at: examples/python/crashlog.py:99 image_regex_uuid = re.compile( -'(0x[0-9a-fA-F]+)[- ]+(0x[0-9a-fA-F]+) +[+]?([^ ]+) +([^<]+)<([-0-9a-fA-F]+)> (.*)') +'(0x[0-9a-fA-F]+)[-

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Add ARC architecture (bare-metal) that can be debugged through an RSP-server. Repository: rLLDB LLDB htt

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, mgorny. Repository: rLLDB LLDB https://reviews.llvm.org/D55724 Files: source/API/SystemInitializerFull.cpp sour

[Lldb-commits] [lldb] r349208 - Update a comment according to r255360 "Remove -r and -R options from dotest.py"

Author: tkrasnukha Date: Fri Dec 14 15:02:41 2018 New Revision: 349208 URL: http://llvm.org/viewvc/llvm-project?rev=349208&view=rev Log: Update a comment according to r255360 "Remove -r and -R options from dotest.py" Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: l

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

clayborg created this revision. clayborg added reviewers: zturner, labath, lemo. Each process plug-in can create its own custom commands. I figured it would be nice to be able to dump things from the minidump file from the lldb command line, so I added the start of the some custom commands. Cur

[Lldb-commits] [PATCH] D55631: Delay replacing the process till after we've finalized it

jingham updated this revision to Diff 178306. jingham added a comment. This is better. Instead of just finalizing, I call DeleteCurrentProcess. All the plugins that implement DebugProcess actually call DeleteCurrentProcess, so this just makes sure it happens before we drop our (potentially las

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

zturner added a comment. This sounds like a good use-case for a lit / FileCheck test. Could you add some simple tests that run lldb with -c on a static minidump with known information inside that we don't change, then run these commands and check the output? CHANGES SINCE LAST ACTION https

[Lldb-commits] [lldb] r349211 - Fix the unittests for the move of Listener & Broadcaster

Author: jingham Date: Fri Dec 14 15:27:08 2018 New Revision: 349211 URL: http://llvm.org/viewvc/llvm-project?rev=349211&view=rev Log: Fix the unittests for the move of Listener & Broadcaster from Core to Utility. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.x

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

clayborg added a comment. In D55727#1331843 , @zturner wrote: > This sounds like a good use-case for a lit / FileCheck test. Could you add > some simple tests that run lldb with -c on a static minidump with known > information inside that we don't chang

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

lemo accepted this revision. lemo added a comment. This revision is now accepted and ready to land. I love the idea of custom dump commands, thanks Greg. The changes look good to me (I agree with Zach suggestion to add lit tests) Comment at: source/Plugins/Process/minidump/Min

[Lldb-commits] [lldb] r349231 - A brief outline of the packets that need to be implemented

Author: jmolenda Date: Fri Dec 14 18:36:39 2018 New Revision: 349231 URL: http://llvm.org/viewvc/llvm-project?rev=349231&view=rev Log: A brief outline of the packets that need to be implemented to write an lldb platform server that doesn't link against LLDB.framework to be able to fully run the ll

[Lldb-commits] [lldb] r349232 - Ah, forgot qModuleInfo. Need to look that one up

Author: jmolenda Date: Fri Dec 14 18:51:01 2018 New Revision: 349232 URL: http://llvm.org/viewvc/llvm-project?rev=349232&view=rev Log: Ah, forgot qModuleInfo. Need to look that one up and finish filling this in. Modified: lldb/trunk/docs/lldb-platform-packets.txt Modified: lldb/trunk/docs/l