An unexpected pass makes the bot red. I might un-silence it despite the couple of issues left anyway, but it’s something to be aware of.
Thanks, -Stella From: Zachary Turner <ztur...@google.com> Sent: Friday, December 14, 2018 11:04 AM To: Stella Stamenova <sti...@microsoft.com> Cc: reviews+d55575+public+5ea6161324294...@reviews.llvm.org; pa...@labath.sk; mose...@google.com; aleksandr.ura...@jetbrains.com; amcca...@google.com; clayb...@gmail.com; leonid.mashins...@jetbrains.com; abidh....@gmail.com; teempe...@gmail.com; apra...@apple.com; jdevliegh...@apple.com; lldb-commits@lists.llvm.org; l...@inglorion.net Subject: Re: [PATCH] D55575: [NativePDB] Support local variables An unexpected pass won't make the bot red will it? If so, one option is to mark them skip, just to make sure we can get the bot turned on as quickly as possible. On Fri, Dec 14, 2018 at 10:56 AM Stella Stamenova <sti...@microsoft.com<mailto:sti...@microsoft.com>> wrote: It’s actually not green – the unexpected passes are counted as a failure. With Pavel’s change to add the gcc builder, most of those can now be enabled, so I am going to do that today, but there’s still a couple that are “unexpectedly passing” when they are in fact failing. We’ll need to fix that before making it noisy. From: Zachary Turner <ztur...@google.com<mailto:ztur...@google.com>> Sent: Friday, December 14, 2018 10:53 AM To: reviews+d55575+public+5ea6161324294...@reviews.llvm.org<mailto:reviews%2bd55575%2bpublic%2b5ea6161324294...@reviews.llvm.org> Cc: pa...@labath.sk<mailto:pa...@labath.sk>; mose...@google.com<mailto:mose...@google.com>; aleksandr.ura...@jetbrains.com<mailto:aleksandr.ura...@jetbrains.com>; amcca...@google.com<mailto:amcca...@google.com>; clayb...@gmail.com<mailto:clayb...@gmail.com>; leonid.mashins...@jetbrains.com<mailto:leonid.mashins...@jetbrains.com>; Stella Stamenova <sti...@microsoft.com<mailto:sti...@microsoft.com>>; abidh....@gmail.com<mailto:abidh....@gmail.com>; teempe...@gmail.com<mailto:teempe...@gmail.com>; apra...@apple.com<mailto:apra...@apple.com>; jdevliegh...@apple.com<mailto:jdevliegh...@apple.com>; lldb-commits@lists.llvm.org<mailto:lldb-commits@lists.llvm.org>; l...@inglorion.net<mailto:l...@inglorion.net> Subject: Re: [PATCH] D55575: [NativePDB] Support local variables I've fixed it. It looks like the bot should be green again once this test starts passing. Can you make it noisy and starting to send emails now? On Fri, Dec 14, 2018 at 10:42 AM Zachary Turner <ztur...@google.com<mailto:ztur...@google.com>> wrote: Ahh, that seems easy enough to fix. Just need to change the 7 to a {{.*}}. Since we're actually compiling and running a process on the buildbot, different versions of Windows will affect this. On Fri, Dec 14, 2018 at 10:39 AM Stella Stamenova via Phabricator <revi...@reviews.llvm.org<mailto:revi...@reviews.llvm.org>> wrote: stella.stamenova added a comment. $ ":" "RUN: at line 5" $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe" "-s" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit" $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp" # command stderr: E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16: error: CHECK-NEXT: expected string not found in input // CHECK-NEXT: Dumping clang ast for 7 modules. ^ <stdin>:140:1: note: scanning from here Dumping clang ast for 8 modules. ^ error: command failed with exit status: 1 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55575/new/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575%2Fnew%2F&data=02%7C01%7Cstilis%40microsoft.com%7Ce94403b131ee422adccb08d661f70672%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804110949528178&sdata=GOMvr1K4ZNI8CHL8qckzeqlqv%2BWsB8ryz8iwxeLqxZ0%3D&reserved=0> https://reviews.llvm.org/D55575<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575&data=02%7C01%7Cstilis%40microsoft.com%7Ce94403b131ee422adccb08d661f70672%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804110949538186&sdata=3OZ6Kr08MiBnVOlM1BFaWCnD9dRB6nJvQ%2FytnH7GkNE%3D&reserved=0>
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
