labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good to me. Thanks for moving the function to a more generic place. I can
get rid of the copy in NativeProcessLinux once this lands.
================
Comment at: source/Plugins/Process/Utility/LinuxProcMaps.cpp:19
+static Status
+ParseMemoryRegionInfoFromProcMapsLine(llvm::StringRef &maps_line,
+ MemoryRegionInfo &memory_region_info) {
----------------
It doesn't look like this maps_line needs to be a reference.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55522/new/
https://reviews.llvm.org/D55522
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits