Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol &native_thread, u

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added a comment. In case of MIPS, ptrace always return 64 bit data irrespetive of Arch. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. According to https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396, characters with codes 1..31 (basically `< ' '`), are illegal as we

[Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

hhellyer created this revision. hhellyer added a reviewer: clayborg. hhellyer added a subscriber: lldb-commits. This adds new SB API calls and classes to allow a user of the SB API to obtain a full list of memory regions accessible within the process. Adding this to the API makes it possible use

[Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

labath created this revision. labath added a reviewer: clayborg. labath added subscribers: zturner, lldb-commits. using stdio in tests does not work on windows, and it is not completely reliable on linux. Avoid using stdio in this test, as it is not necessary for this purpose. http://reviews.llv

[Lldb-commits] [lldb] r270564 - [LLDB][MIPS] Fix floating point handling in case of thread step-out

Author: slthakur Date: Tue May 24 09:52:50 2016 New Revision: 270564 URL: http://llvm.org/viewvc/llvm-project?rev=270564&view=rev Log: [LLDB][MIPS] Fix floating point handling in case of thread step-out Patch by Nitesh Jain. Summary: These patch fix thread step-out for hard and soft float. Revi

Re: [Lldb-commits] [PATCH] D20416: [LLDB][MIPS] Fix floating point handling in case of thread step-out

This revision was automatically updated to reflect the committed changes. Closed by commit rL270564: [LLDB][MIPS] Fix floating point handling in case of thread step-out (authored by slthakur). Changed prior to commit: http://reviews.llvm.org/D20416?vs=57739&id=58236#toc Repository: rL LLVM

[Lldb-commits] [lldb] r270570 - Add a missing include to ItaniumABILanguageRuntime.h

Author: labath Date: Tue May 24 10:32:40 2016 New Revision: 270570 URL: http://llvm.org/viewvc/llvm-project?rev=270570&view=rev Log: Add a missing include to ItaniumABILanguageRuntime.h some (I'm not sure why only some, actually) implementations of std::map require the value type to be a fully s

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. Adrian, I'm going to take a look at this with you today. I'm reviewing all the comments on this so far. -Todd http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. So at this point, it looks like we're just missing a mechanism to check for gmodules support, and then add it to the supported_categories list if it is available. I'll have a look a that. This might be the time where we want to break out an apple-clang vs. llvm.org-cla

[Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

labath created this revision. labath added reviewers: ovyalov, zturner. labath added a subscriber: lldb-commits. http://reviews.llvm.org/D20570 Files: unittests/Utility/CMakeLists.txt unittests/Utility/Inputs/TestModule.c unittests/Utility/Inputs/TestModule.so unittests/Utility/ModuleCach

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

Just chiming in to say modules is unsupported on Windows even with clang, so please make sure the gmodules support function takes this into account On Tue, May 24, 2016 at 9:05 AM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > tfiala added a comment. > > So at this point, it l

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. In http://reviews.llvm.org/D19998#437820, @zturner wrote: > Just chiming in to say modules is unsupported on Windows even with clang, > so please make sure the gmodules support function takes this into account Okay, thanks Zachary. We'll make sure it doesn't somehow ge

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

clayborg added a comment. At some point we should probably make a host layer call like: const char *const char *Host::GetIllegalFilenameCharacters();" so that each host can determine the correct thing for the current host. Then FileSpec can be updated to use this function handle this with a met

Re: [Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Few minor changes, but looks great overall. Thanks for doing this. Comment at: include/lldb/Target/MemoryRegionInfo.h:18-19 @@ -17,3 +17,4 @@ { -class Memor

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

clayborg requested changes to this revision. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64 @@ +63,3 @@ +self.assertTrue(golden.IsValid(), "Encountered an error reading the process's golden vari

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

ovyalov updated this revision to Diff 58258. ovyalov added a comment. Added the check for symbol in [1;31] range. http://reviews.llvm.org/D20548 Files: source/Utility/ModuleCache.cpp Index: source/Utility/ModuleCache.cpp === ---

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

ovyalov added a comment. In http://reviews.llvm.org/D20548#437567, @labath wrote: > According to > https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396, > characters with codes 1..31 (basically `< ' '`), are illegal as well. We > might

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Nothing obvious that will break on Windows here, so looks good. http://reviews.llvm.org/D20570 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

ovyalov added a comment. In http://reviews.llvm.org/D20548#437862, @clayborg wrote: > At some point we should probably make a host layer call like: > > const char *const char *Host::GetIllegalFilenameCharacters();" so that each > host can determine the correct thing for the current host. Then Fi

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

labath added inline comments. Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64 @@ +63,3 @@ +self.assertTrue(golden.IsValid(), "Encountered an error reading the process's golden variable") +golden_str = str(golden) +self.assertT

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

labath added a comment. I like the idea of having a centralized place defining "invalid characters". However, I am not sure if that needs to be (at least in this case) system-dependent. Since presumably the code will need to work on all platforms anyway, having the escaping done in a divergent

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

ovyalov accepted this revision. Comment at: unittests/Utility/ModuleCacheTest.cpp:74 @@ +73,3 @@ +{ +HostInfo::Initialize(); +ObjectFileELF::Initialize(); If it's one-off initialization can we use setUpTestCase for these purposes (for HostInfo::Initialize

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

clayborg added a comment. I would just make a large buffer and use snprintf: char buffer[4096]; char *p = buffer; char *end = p + sizeof(buffer); p += snprintf(p, end - p, "a_as_A->a() = '%s'\n", a_as_A->a()); p += snprintf(p, end - p, "a_as_A->b() = '%s'\n", a_as_A->b()); http://revi

[Lldb-commits] [lldb] r270588 - Improve wording in TSan reports involving global variables. Don't repeat hex addresses that are the same.

Author: kuba.brecka Date: Tue May 24 12:47:23 2016 New Revision: 270588 URL: http://llvm.org/viewvc/llvm-project?rev=270588&view=rev Log: Improve wording in TSan reports involving global variables. Don't repeat hex addresses that are the same. Modified: lldb/trunk/source/Plugins/Instrumen

Re: [Lldb-commits] [lldb] r270488 - We have many radars showing that stepping through C++ code can result in slow steps.

On 23 May 2016 at 16:37, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Mon May 23 15:37:24 2016 > New Revision: 270488 > > URL: http://llvm.org/viewvc/llvm-project?rev=270488&view=rev > Log: > We have many radars showing that stepping through C++ code can result in slow > steps.

[Lldb-commits] [lldb] r270590 - Replace file system forbidden symbols in the hostname which passed to the ModuleCache.

Author: ovyalov Date: Tue May 24 13:09:05 2016 New Revision: 270590 URL: http://llvm.org/viewvc/llvm-project?rev=270590&view=rev Log: Replace file system forbidden symbols in the hostname which passed to the ModuleCache. http://reviews.llvm.org/D20548 Modified: lldb/trunk/source/Utility/Mo

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

ovyalov closed this revision. ovyalov added a comment. Submitted as r270590 http://reviews.llvm.org/D20548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20509: Skip leading spaces when decoding hex values

This revision was automatically updated to reflect the committed changes. Closed by commit rL270592: Skip leading spaces when decoding hex values (authored by fjricci). Changed prior to commit: http://reviews.llvm.org/D20509?vs=58041&id=58277#toc Repository: rL LLVM http://reviews.llvm.org/

[Lldb-commits] [lldb] r270592 - Skip leading spaces when decoding hex values

Author: fjricci Date: Tue May 24 13:19:45 2016 New Revision: 270592 URL: http://llvm.org/viewvc/llvm-project?rev=270592&view=rev Log: Skip leading spaces when decoding hex values Summary: The StringExtractor functions using stroull will already skip leading whitespace (ie GetU64). Make sure that

[Lldb-commits] [lldb] r270593 - Lock out Process::RunThreadPlan so only one can be in flight at a time.

Author: jingham Date: Tue May 24 13:29:36 2016 New Revision: 270593 URL: http://llvm.org/viewvc/llvm-project?rev=270593&view=rev Log: Lock out Process::RunThreadPlan so only one can be in flight at a time. What with all sorts of folks (TSAN, ASAN, queue detection, etc...) trying to gather info by

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. F1981148: gmodules-test-support-v2.diff I just uploaded a modified patch. This patch does nothing more than fix invalid behavior in the initial patch, as it had several issues that would cause runtime errors. With the adjusted patch,

Re: [Lldb-commits] [lldb] r270488 - We have many radars showing that stepping through C++ code can result in slow steps.

r270570 fixed it for me. On 24 May 2016 at 19:11, Ed Maste via lldb-commits wrote: > On 23 May 2016 at 16:37, Greg Clayton via lldb-commits > wrote: >> Author: gclayton >> Date: Mon May 23 15:37:24 2016 >> New Revision: 270488 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=270488&view=rev >>

Re: [Lldb-commits] [lldb] r270488 - We have many radars showing that stepping through C++ code can result in slow steps.

On 24 May 2016 at 15:18, Pavel Labath wrote: > r270570 fixed it for me. Indeed, thank you. ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r270603 - xfail TestRedefinitionsInline with older Clang

Author: emaste Date: Tue May 24 14:51:11 2016 New Revision: 270603 URL: http://llvm.org/viewvc/llvm-project?rev=270603&view=rev Log: xfail TestRedefinitionsInline with older Clang This fails on FreeBSD 10 with the system compiler, Clang 3.4.1. llvm.org/pr27845 Modified: lldb/trunk/packages

[Lldb-commits] [lldb] r270608 - Reword the "Happened at" TSan-reported thread to contain a thread id.

Author: kuba.brecka Date: Tue May 24 15:35:28 2016 New Revision: 270608 URL: http://llvm.org/viewvc/llvm-project?rev=270608&view=rev Log: Reword the "Happened at" TSan-reported thread to contain a thread id. Modified: lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSa

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. F1981558: gmodules-test-support-v3.diff The attached patch contains an implementation that properly checks for gmodules support and runs clean on OS X. I filed a few bugs and marked a few tests as failing with gmodules debug info in th

[Lldb-commits] [lldb] r270618 - In r268475 I made a change to ObjectFileMachO so that if it is

Author: jmolenda Date: Tue May 24 16:46:23 2016 New Revision: 270618 URL: http://llvm.org/viewvc/llvm-project?rev=270618&view=rev Log: In r268475 I made a change to ObjectFileMachO so that if it is missing an LC_FUNCTION_STARTS section, we assume it has been aggressively stripped (it is *very* unu

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. F1981749: gmodules-test-support-v4.diff Patch updated. TestDeadStrip.py required xfailing for Ubuntu with gmodules debug info. http://reviews.llvm.org/D19998 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r270620 - Ach, editing too many files at once. Make this file compile again.

Author: jmolenda Date: Tue May 24 17:05:22 2016 New Revision: 270620 URL: http://llvm.org/viewvc/llvm-project?rev=270620&view=rev Log: Ach, editing too many files at once. Make this file compile again. Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Modified: lldb/

[Lldb-commits] [lldb] r270621 - Fix an issue where the NSDate data formatter was not using the proper alignment on watchOS targets

Author: enrico Date: Tue May 24 17:11:57 2016 New Revision: 270621 URL: http://llvm.org/viewvc/llvm-project?rev=270621&view=rev Log: Fix an issue where the NSDate data formatter was not using the proper alignment on watchOS targets Fixes rdar://problem/23298264 Modified: lldb/trunk/source/

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. F1981857: gmodules-test-support-v5.diff This is the final patch for the way I'd like to see this. It breaks out gmodules checking into a separate support module (in lldbsuite/support/gmodules.py). The skipUnless for gmodules now uses

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. In `is_compiler_clang_with_gmodules` you will need to explicitly return false if the target is Windows, because clang help will still show the command line option as being valid, even though it doesn't work properly. http://reviews.llvm.org/D19998 __

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. In http://reviews.llvm.org/D19998#438529, @zturner wrote: > In `is_compiler_clang_with_gmodules` you will need to explicitly return false > if the target is Windows, because clang help will still show the command line > option as being valid, even though it doesn't work

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. F1982070: gmodules-test-support-v6.diff Updated gmodules.is_compiler_clang_with_gmodules() to guard on Windows with: def _gmodules_supported_internal(): compiler = os.path.basename(compiler_path) if "clang" not in compiler:

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. In http://reviews.llvm.org/D19998#438586, @tfiala wrote: > F1982070: gmodules-test-support-v6.diff > > Updated gmodules.is_compiler_clang_with_gmodules() to guard on Windows with: > > def _gmodules_supported_internal(): > compile

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. In http://reviews.llvm.org/D19998#438614, @zturner wrote: > In http://reviews.llvm.org/D19998#438586, @tfiala wrote: > > > F1982070: gmodules-test-support-v6.diff > > > > Updated gmodules.is_compiler_clang_with_gmodules() to guard on Wind

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl updated this revision to Diff 58369. aprantl added a comment. Update with Todds most recent infrastructure additions. http://reviews.llvm.org/D19998 Files: packages/Python/lldbsuite/support/gmodules.py packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/ex

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl added a comment. In http://reviews.llvm.org/D19998#438666, @tfiala wrote: > In http://reviews.llvm.org/D19998#438614, @zturner wrote: > > > So I asked some of the guys here, and they said modules debug info (in > > particular -gmodules) will not work anywhere but OSX. > > > I don't think

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. Should this be disabled by default unless explicitly requested? Seems like "run the entire test suite N times" should be opt in, not opt out. If its opt in, I don't mind removing the os check for Windows. http://reviews.llvm.org/D19998 ___

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

Should this be disabled by default unless explicitly requested? Seems like "run the entire test suite N times" should be opt in, not opt out. If its opt in, I don't mind removing the os check for Windows. On Tue, May 24, 2016 at 6:25 PM Adrian Prantl wrote: > aprantl added a comment. > > In http

[Lldb-commits] [lldb] r270658 - Add support for arm64 compact unwind tables, used on darwin arm64

Author: jmolenda Date: Tue May 24 23:20:28 2016 New Revision: 270658 URL: http://llvm.org/viewvc/llvm-project?rev=270658&view=rev Log: Add support for arm64 compact unwind tables, used on darwin arm64 systems (ios, tvos, watchos). It's a simple format to use now that I have i386/x86_64 supported

[Lldb-commits] [lldb] r270662 - Include in Process.h - Jim's change in r270593 added a std::mutex

Author: jmolenda Date: Wed May 25 00:14:16 2016 New Revision: 270662 URL: http://llvm.org/viewvc/llvm-project?rev=270662&view=rev Log: Include in Process.h - Jim's change in r270593 added a std::mutex ivar and this header is needed for it to compile on linux, judging by the build bots. Modified: