labath added inline comments.
================
Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64
@@ +63,3 @@
+ self.assertTrue(golden.IsValid(), "Encountered an error reading the
process's golden variable")
+ golden_str = str(golden)
+ self.assertTrue("c_as_C" in golden_str)
----------------
clayborg wrote:
> Are we relying on std::string data formatters working here? Seems like a
> dangerous change as we would require any new ports of LLDB to have
> std::string formatters working or this test will fail?
That did not occur to me. Would shoving the data into a `char *` be acceptable?
http://reviews.llvm.org/D20567
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
