[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality

2022-07-11 Thread GitBox
mocobeta commented on issue #12: URL: https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1180040078 > Indeed, there was at least one comment (I think?) where the author used Markdown (which does not work in Jira, yet many of us forget and use it anyway, just like seeing a

[GitHub] [lucene-jira-archive] mocobeta commented on issue #27: Improve the `Jira Information` header?

2022-07-11 Thread GitBox
mocobeta commented on issue #27: URL: https://github.com/apache/lucene-jira-archive/issues/27#issuecomment-1180049119 For prototyping, it was the easiest way to embed the fixed template for Jira information in the conversion script for me... I agree that there are more sophisticated method

[jira] [Updated] (LUCENE-10645) Wrong autocomplete suggestion

2022-07-11 Thread Emiliyan Sinigerov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emiliyan Sinigerov updated LUCENE-10645: Description: I have problem with autocomplete suggestion (I use your test to show

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #31: Make converter script work without account mapping file

2022-07-11 Thread GitBox
mocobeta opened a new pull request, #31: URL: https://github.com/apache/lucene-jira-archive/pull/31 I have a second thought about this. It may be better to work the converter script regardless of whether there is an account mapping file or not (it's not a critical part of the converter).

[GitHub] [lucene-jira-archive] mocobeta merged pull request #31: Make converter script work without account mapping file

2022-07-11 Thread GitBox
mocobeta merged PR #31: URL: https://github.com/apache/lucene-jira-archive/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[GitHub] [lucene] shaie opened a new pull request, #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-11 Thread GitBox
shaie opened a new pull request, #1015: URL: https://github.com/apache/lucene/pull/1015 ### Description (or a Jira issue link if you have one) Add `fastMatchQuery` support to `MatchingFacetSetCounts` to improve counting efficiency in case of many possible facet-set indexed combination

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #32: only escape HTML tags

2022-07-11 Thread GitBox
mocobeta opened a new pull request, #32: URL: https://github.com/apache/lucene-jira-archive/pull/32 Follow-up of #23. To avoid unintentional escaping, escape only HTML tag-like texts (``) and preserve other `<`, `>`, and `&`. -- This is an automated message from the Apache Git Service.

[GitHub] [lucene-jira-archive] mocobeta merged pull request #32: only escape HTML tags

2022-07-11 Thread GitBox
mocobeta merged PR #32: URL: https://github.com/apache/lucene-jira-archive/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[GitHub] [lucene-jira-archive] mocobeta commented on issue #14: Investigate import failure of LUCENE-1498

2022-07-11 Thread GitBox
mocobeta commented on issue #14: URL: https://github.com/apache/lucene-jira-archive/issues/14#issuecomment-1180072639 The quick workaround (manual recovering) should work. I'm closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene-jira-archive] mocobeta closed issue #14: Investigate import failure of LUCENE-1498

2022-07-11 Thread GitBox
mocobeta closed issue #14: Investigate import failure of LUCENE-1498 URL: https://github.com/apache/lucene-jira-archive/issues/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (LUCENE-10629) Add fastMatchQuery param to MatchingFacetSetCounts

2022-07-11 Thread Shai Erera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564830#comment-17564830 ] Shai Erera commented on LUCENE-10629: - Oh [~stefanvodita] I didn't refresh the issu

[GitHub] [lucene] shaie commented on a diff in pull request #1001: LUCENE-10629: Add fastMatchQuery to MatchingFacetSetCounts

2022-07-11 Thread GitBox
shaie commented on code in PR #1001: URL: https://github.com/apache/lucene/pull/1001#discussion_r917641237 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ## @@ -76,8 +92,12 @@ private int count(String field, List matchingDocs) B

[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-11 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564885#comment-17564885 ] Adrien Grand commented on LUCENE-10480: --- I haven't tried to reproduce it but the

[GitHub] [lucene] jpountz merged pull request #1014: Add comment for no pauses in RateLimitedIndexOutput.writeBytes

2022-07-11 Thread GitBox
jpountz merged PR #1014: URL: https://github.com/apache/lucene/pull/1014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] jpountz merged pull request #1011: LUCENE-10647: Fix TestMergeSchedulerExternal failures

2022-07-11 Thread GitBox
jpountz merged PR #1011: URL: https://github.com/apache/lucene/pull/1011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[jira] [Commented] (LUCENE-10647) Failure in TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler

2022-07-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564896#comment-17564896 ] ASF subversion and git services commented on LUCENE-10647: -- Co

[jira] [Commented] (LUCENE-10647) Failure in TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler

2022-07-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564900#comment-17564900 ] ASF subversion and git services commented on LUCENE-10647: -- Co

[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand opened a new pull request, #33: URL: https://github.com/apache/lucene-jira-archive/pull/33 This is a start at #27 but I expect to iterate some more. Progress not perfection! Now the header is more compact and looks like this for issues w/ no attachments, PRs, etc:

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1180310425 Oh also note that I added another dependency (`dateutil`), very helpful for parsing ISO-8601 dates. I couldn't (quickly) figure out how to reliably do this with Python's `dat

[jira] [Resolved] (LUCENE-10647) Failure in TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler

2022-07-11 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10647. --- Fix Version/s: 9.3 Resolution: Fixed > Failure in TestMergeSchedulerExternal.testSub

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mocobeta commented on code in PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#discussion_r917859701 ## migration/src/jira2github_import.py: ## @@ -69,45 +70,53 @@ def convert_issue(num: int, dump_dir: Path, output_dir: Path, account_map: dict[ attach

[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand commented on code in PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#discussion_r917872038 ## migration/src/jira2github_import.py: ## @@ -69,45 +70,53 @@ def convert_issue(num: int, dump_dir: Path, output_dir: Path, account_map: dict[ atta

[jira] [Created] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
Nathan Meisels created LUCENE-10650: --- Summary: "after_effect": "no" was removed what replaces it? Key: LUCENE-10650 URL: https://issues.apache.org/jira/browse/LUCENE-10650 Project: Lucene - Core

[jira] [Updated] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Meisels updated LUCENE-10650: Description: Hi! We have been using an old version of elasticsearch with the following s

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1180351403 BTW, as I run the full Jira download, I see errors like this: ``` [2022-07-11 07:57:25,815] WARNING:download_jira: Can't download LUCENE-498. status code=404, message

[jira] [Updated] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Meisels updated LUCENE-10650: Description: Hi! We have been using an old version of elasticsearch with the following s

[jira] [Updated] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Meisels updated LUCENE-10650: Description: Hi! We have been using an old version of elasticsearch with the following s

[jira] [Updated] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Meisels updated LUCENE-10650: Description: Hi! We have been using an old version of elasticsearch with the following s

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mocobeta commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1180354136 Yes, I also noticed several issues do not exist (not sure why); in that case, the script just emits an error and proceeds to the next issue as you see. -- This is an automated

[jira] [Commented] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564988#comment-17564988 ] Adrien Grand commented on LUCENE-10650: --- Hi Nathan. When we introduced dynamic pr

[jira] [Resolved] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10650. --- Resolution: Won't Fix > "after_effect": "no" was removed what replaces it? > --

[jira] [Commented] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565003#comment-17565003 ] Nathan Meisels commented on LUCENE-10650: - Thanks for the answer! Just to clar

[jira] [Comment Edited] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565003#comment-17565003 ] Nathan Meisels edited comment on LUCENE-10650 at 7/11/22 1:26 PM: ---

[jira] [Reopened] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Meisels reopened LUCENE-10650: - > "after_effect": "no" was removed what replaces it? >

[jira] [Comment Edited] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-11 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565003#comment-17565003 ] Nathan Meisels edited comment on LUCENE-10650 at 7/11/22 1:54 PM: ---

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #34: Add a tool to generate account mapping

2022-07-11 Thread GitBox
mocobeta opened a new pull request, #34: URL: https://github.com/apache/lucene-jira-archive/pull/34 #3 This adds a helper tool to create a Jira user - GitHub account mapping file; this is used in "Convert Jira issues to GitHub issues" step. -- This is an automated message from th

[GitHub] [lucene] gsmiller commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread GitBox
gsmiller commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r918110247 ## lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java: ## @@ -73,6 +76,35 @@ public void index() throws IOException { indexWriter.addDocument

[GitHub] [lucene] gsmiller merged pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread GitBox
gsmiller merged PR #974: URL: https://github.com/apache/lucene/pull/974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[jira] [Commented] (LUCENE-10614) Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565075#comment-17565075 ] ASF subversion and git services commented on LUCENE-10614: -- Co

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-11 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1180601283 FYI @mikemccand @dweiss I will keep this open for a while and do some more extensive tests on that (this is a helper tool that should not block/conflict with the main scripts

[jira] [Commented] (LUCENE-10614) Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565081#comment-17565081 ] ASF subversion and git services commented on LUCENE-10614: -- Co

[jira] [Commented] (LUCENE-10614) Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565084#comment-17565084 ] Greg Miller commented on LUCENE-10614: -- Thanks again [~yutinggan] ! > Properly su

[jira] [Resolved] (LUCENE-10614) Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10614. -- Fix Version/s: 10.0 (main) Resolution: Fixed > Properly support getTopChildren in Rang

[jira] [Commented] (LUCENE-10614) Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565083#comment-17565083 ] Greg Miller commented on LUCENE-10614: -- Just merged this to {{{}main{}}}. I don't

[jira] [Commented] (LUCENE-10614) Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565089#comment-17565089 ] Yuting Gan commented on LUCENE-10614: - Thank you so much [~gsmiller] ! > Properly

[GitHub] [lucene] tang-hi opened a new pull request, #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-11 Thread GitBox
tang-hi opened a new pull request, #1016: URL: https://github.com/apache/lucene/pull/1016 [https://issues.apache.org/jira/browse/LUCENE-10646](JIRA) 1. I have add some comment on Lev1ParametricDescription, hope it will help others better understand the code of Lev2ParametricDescription,

[GitHub] [lucene] shahrs87 commented on pull request #907: LUCENE-10357 Ghost fields and postings/points

2022-07-11 Thread GitBox
shahrs87 commented on PR #907: URL: https://github.com/apache/lucene/pull/907#issuecomment-1180628206 @jpountz Hi Adrian, can you please make one more pass over the PR and provide your feedback ? Thank you. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1180758900 Good thing I tested on all issues -- I hit a couple fun exceptions -- so please don't push this PR just yet! -- This is an automated message from the Apache Git Service. To

[jira] [Created] (LUCENE-10651) SimpleQueryParser stack overflow for large nested queries.

2022-07-11 Thread Marc (Jira)
Marc created LUCENE-10651: - Summary: SimpleQueryParser stack overflow for large nested queries. Key: LUCENE-10651 URL: https://issues.apache.org/jira/browse/LUCENE-10651 Project: Lucene - Core Issue

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1180771389 Somehow I am hitting a stack overflow when trying to convert [LUCENE-550](https://issues.apache.org/jira/browse/LUCENE-550)! It doesn't look like a particularly challenging i

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1180785030 Hmm this seems to be an issue on `main` as well. This is what I'm running to trigger it: `python src/jira2github_import.py --min 550`. I'll catch the exception (trying

[GitHub] [lucene] stefanvodita commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-11 Thread GitBox
stefanvodita commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r918289599 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ## @@ -52,8 +52,10 @@ public MatchingFacetSetsCounts( String field,

[jira] [Created] (LUCENE-10652) Add a top-n range faceting example to RangeFacetsExample

2022-07-11 Thread Yuting Gan (Jira)
Yuting Gan created LUCENE-10652: --- Summary: Add a top-n range faceting example to RangeFacetsExample Key: LUCENE-10652 URL: https://issues.apache.org/jira/browse/LUCENE-10652 Project: Lucene - Core

[GitHub] [lucene] Yuti-G commented on a diff in pull request #974: LUCENE-10614: Properly support getTopChildren in RangeFacetCounts

2022-07-11 Thread GitBox
Yuti-G commented on code in PR #974: URL: https://github.com/apache/lucene/pull/974#discussion_r918297532 ## lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java: ## @@ -73,6 +76,35 @@ public void index() throws IOException { indexWriter.addDocument(d

[GitHub] [lucene] MarcusSorealheis commented on pull request #940: Use similarity.tf() in MoreLikeThis

2022-07-11 Thread GitBox
MarcusSorealheis commented on PR #940: URL: https://github.com/apache/lucene/pull/940#issuecomment-1180816282 Is there anything else needed here? Is there something we can add to improve the robustness of the quality check? Please advise us @rmuir and @mocobeta -- This is an automated m

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mikemccand commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1180836771 This is the comment that stack overflows during conversion: ``` A note on, and output from contrib/benchmark:

[jira] [Created] (LUCENE-10653) Should BlockMaxMaxscoreScorer rebuild its heap in bulk?

2022-07-11 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10653: Summary: Should BlockMaxMaxscoreScorer rebuild its heap in bulk? Key: LUCENE-10653 URL: https://issues.apache.org/jira/browse/LUCENE-10653 Project: Lucene - Core

[GitHub] [lucene] msokolov commented on pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-11 Thread GitBox
msokolov commented on PR #947: URL: https://github.com/apache/lucene/pull/947#issuecomment-1180963745 I'm looking to address various comments; just pushed a commit that makes the vector encoding explicit by adding a new enum and parameter "vectorEncoding", splitting this out from "similarit

[GitHub] [lucene] msokolov commented on pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-11 Thread GitBox
msokolov commented on PR #947: URL: https://github.com/apache/lucene/pull/947#issuecomment-1180965832 Also - if anybody has advice about how to rebase while maintaining this PR I'd be interested. Should I `git merge` from `main`?? -- This is an automated message from the Apache Git Servic

[GitHub] [lucene] msokolov commented on pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-11 Thread GitBox
msokolov commented on PR #947: URL: https://github.com/apache/lucene/pull/947#issuecomment-1181017377 > During merging when writing a merged vector field it looks like we first expand vector values only to again to compress them later? Would be nice to avoid this. In fact after chec

[jira] [Commented] (LUCENE-10653) Should BlockMaxMaxscoreScorer rebuild its heap in bulk?

2022-07-11 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565195#comment-17565195 ] Greg Miller commented on LUCENE-10653: -- Here's essentially what I'm thinking: htt

[GitHub] [lucene] gsmiller commented on a diff in pull request #1013: LUCENE-10644: Facets#getAllChildren testing should ignore child order

2022-07-11 Thread GitBox
gsmiller commented on code in PR #1013: URL: https://github.com/apache/lucene/pull/1013#discussion_r918423465 ## lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java: ## @@ -264,4 +264,24 @@ protected void assertFloatValuesEquals(FacetResult a, FacetResult b) {

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #33: Polish wording of Legacy Jira details header, and each comment footer

2022-07-11 Thread GitBox
mocobeta commented on PR #33: URL: https://github.com/apache/lucene-jira-archive/pull/33#issuecomment-1181218297 It looks like a bug introduced in https://github.com/apache/lucene-jira-archive/commit/cfbc821390859a7053e43028325b6bc616ec2b5b. (I have postponed testing it with the whole Jira

[jira] [Commented] (LUCENE-10471) Increase the number of dims for KNN vectors to 2048

2022-07-11 Thread Stanislav (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565240#comment-17565240 ] Stanislav commented on LUCENE-10471: I don't think there is a trend to increase dim

[jira] [Commented] (LUCENE-10628) Enable MatchingFacetSetCounts to use space partitioning data structures

2022-07-11 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565241#comment-17565241 ] Marc D'Mello commented on LUCENE-10628: --- I started work on this issue but I was i

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #35: Catch all exceptions (and proceed to the nexe issue) in jira2github_import.py

2022-07-11 Thread GitBox
mocobeta opened a new pull request, #35: URL: https://github.com/apache/lucene-jira-archive/pull/35 Added try-catch so that it does not stop with a conversion failure/error. ``` (.venv) migration $ python src/jira2github_import.py --issues 550 [2022-07-12 12:09:06,759] INFO:jira2

[GitHub] [lucene-jira-archive] mocobeta merged pull request #35: Catch all exceptions (and proceed to the nexe issue) in jira2github_import.py

2022-07-11 Thread GitBox
mocobeta merged PR #35: URL: https://github.com/apache/lucene-jira-archive/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-11 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r918535845 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ## @@ -52,8 +52,10 @@ public MatchingFacetSetsCounts( String field, Fa

[jira] [Comment Edited] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-11 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565261#comment-17565261 ] Zach Chen edited comment on LUCENE-10480 at 7/12/22 4:27 AM:

[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-11 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565261#comment-17565261 ] Zach Chen commented on LUCENE-10480: {quote}Another thing that changes performance

[jira] [Comment Edited] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-11 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565261#comment-17565261 ] Zach Chen edited comment on LUCENE-10480 at 7/12/22 4:27 AM:

[GitHub] [lucene] mocobeta commented on pull request #940: Use similarity.tf() in MoreLikeThis

2022-07-11 Thread GitBox
mocobeta commented on PR #940: URL: https://github.com/apache/lucene/pull/940#issuecomment-1181301533 Personally, I'd love to commit this to the upstream branch. I think we'd need a reproducible quality check (or regression test?) in Lucene as Robert suggested; I just haven't been able to

[GitHub] [lucene] stefanvodita commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-11 Thread GitBox
stefanvodita commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r918597529 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ## @@ -52,8 +52,10 @@ public MatchingFacetSetsCounts( String field,