[ 
https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565083#comment-17565083
 ] 

Greg Miller commented on LUCENE-10614:
--------------------------------------

Just merged this to {{{}main{}}}. I don't think we should backport this to 9.x 
since it is a functional change to an existing API. Because of this, I moved 
the CHANGES entry under 10.0 and added an entry to MIGRATE describing the 
difference and how to retain the 9.x functionality if desired.

> Properly support getTopChildren in RangeFacetCounts
> ---------------------------------------------------
>
>                 Key: LUCENE-10614
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10614
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: 10.0 (main)
>            Reporter: Greg Miller
>            Priority: Minor
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> As mentioned in LUCENE-10538, {{RangeFacetCounts}} is not implementing 
> {{getTopChildren}}. Instead of returning "top" ranges, it returns all 
> user-provided ranges in the order the user specified them when instantiating. 
> This is probably more useful functionality, but it would be nice to support 
> {{getTopChildren}} as well.
> LUCENE-10550 is introducing the concept of {{getAllChildren}}, so once that 
> lands, we can replace the current implementation of {{getTopChildren}} with 
> an actual "top children" implementation and direct users to 
> {{getAllChildren}} if they want to maintain the current behavior.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to