stefanvodita commented on code in PR #1015:
URL: https://github.com/apache/lucene/pull/1015#discussion_r918289599
##########
lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java:
##########
@@ -52,8 +52,10 @@ public MatchingFacetSetsCounts(
String field,
FacetsCollector hits,
FacetSetDecoder facetSetDecoder,
+ Query fastMatchQuery,
Review Comment:
What do you think of preserving the constructor without `fastMatchQuery`? It
would avoid adding that `null` to all existing (and possibly some future) uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
