[jira] [Resolved] (LUCENE-10555) avoid repeated NumericLeafComparator setScorer calls

2022-05-11 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10555. --- Fix Version/s: 9.2 Resolution: Fixed > avoid repeated NumericLeafComparator setScore

[GitHub] [lucene] wjp719 commented on a diff in pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread GitBox
wjp719 commented on code in PR #780: URL: https://github.com/apache/lucene/pull/780#discussion_r869953128 ## lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java: ## @@ -269,11 +276,23 @@ public PointValues.Relation compare(byte[] minPackedValue, byt

[GitHub] [lucene] wjp719 commented on pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread GitBox
wjp719 commented on PR #780: URL: https://github.com/apache/lucene/pull/780#issuecomment-1123279942 > I'm curious about `tryUpdateFailCount`, did you get better results on the benchmark with it than without it? @jpountz yes, with `tryUpdateFailCount`, the case `asc_sort_with_after_ti

[GitHub] [lucene] jpountz commented on a diff in pull request #875: LUCENE-10560: Speed up OrdinalMap construction a bit.

2022-05-11 Thread GitBox
jpountz commented on code in PR #875: URL: https://github.com/apache/lucene/pull/875#discussion_r870001129 ## lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java: ## @@ -48,10 +49,69 @@ public class OrdinalMap implements Accountable { // need it // TODO: use more

[GitHub] [lucene] jpountz commented on a diff in pull request #875: LUCENE-10560: Speed up OrdinalMap construction a bit.

2022-05-11 Thread GitBox
jpountz commented on code in PR #875: URL: https://github.com/apache/lucene/pull/875#discussion_r870010670 ## lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java: ## @@ -48,10 +49,69 @@ public class OrdinalMap implements Accountable { // need it // TODO: use more

[GitHub] [lucene] mocobeta commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mocobeta commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870023604 ## lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java: ## @@ -377,10 +377,13 @@ private static class FieldEntry { for (int level

[GitHub] [lucene] mocobeta commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mocobeta commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870030770 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java: ## @@ -43,7 +43,8 @@ public final class HnswGraphBuilder { /** Random seed for level generati

[GitHub] [lucene] mocobeta commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mocobeta commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870035060 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -31,6 +31,7 @@ public final class OnHeapHnswGraph extends HnswGraph { private final i

[GitHub] [lucene] jpountz merged pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread GitBox
jpountz merged PR #780: URL: https://github.com/apache/lucene/pull/780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[jira] [Commented] (LUCENE-10496) avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534783#comment-17534783 ] ASF subversion and git services commented on LUCENE-10496: -- Co

[jira] [Resolved] (LUCENE-10496) avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10496. --- Fix Version/s: 9.2 Resolution: Fixed > avoid unnecessary attempts to evaluate skippi

[jira] [Commented] (LUCENE-10496) avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534787#comment-17534787 ] ASF subversion and git services commented on LUCENE-10496: -- Co

[jira] [Commented] (LUCENE-10496) avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534786#comment-17534786 ] ASF subversion and git services commented on LUCENE-10496: -- Co

[jira] [Commented] (LUCENE-10496) avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534788#comment-17534788 ] ASF subversion and git services commented on LUCENE-10496: -- Co

[GitHub] [lucene] jpountz commented on pull request #876: LUCENE-9356: Change test to detect mismatched checksums instead of byte flips.

2022-05-11 Thread GitBox
jpountz commented on PR #876: URL: https://github.com/apache/lucene/pull/876#issuecomment-1123706148 I removed the dependency on LineFileDocs. Interestingly, this test caught an issue with vectors, which don't close index inputs on all paths. cc @mayya-sharipova since there are in-progress

[GitHub] [lucene] jpountz commented on pull request #873: LUCENE-10397: KnnVectorQuery doesn't tie break by doc ID

2022-05-11 Thread GitBox
jpountz commented on PR #873: URL: https://github.com/apache/lucene/pull/873#issuecomment-1123721194 Is it possible to somehow encode longs differently in the reverse case, so that we don't have to customize the comparison function? -- This is an automated message from the Apache Git Serv

[jira] [Commented] (LUCENE-9409) TestAllFilesDetectTruncation failures

2022-05-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534878#comment-17534878 ] Robert Muir commented on LUCENE-9409: - the test also doesn't account for the case th

[GitHub] [lucene] mikemccand closed pull request #861: LUCENE-10551: switch to PUAFIF

2022-05-11 Thread GitBox
mikemccand closed pull request #861: LUCENE-10551: switch to PUAFIF URL: https://github.com/apache/lucene/pull/861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [lucene] mayya-sharipova commented on pull request #877: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
mayya-sharipova commented on PR #877: URL: https://github.com/apache/lucene/pull/877#issuecomment-1123806812 @LuXugang Thanks for opening this PR. Is this a copy of https://github.com/apache/lucene/tree/vectors-disi-direct? I thought we can just open a PR of this branch against `main` branc

[GitHub] [lucene] LuXugang opened a new pull request, #880: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
LuXugang opened a new pull request, #880: URL: https://github.com/apache/lucene/pull/880 follow up of https://github.com/apache/lucene/pull/792 and https://github.com/apache/lucene/pull/870 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene] LuXugang closed pull request #877: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
LuXugang closed pull request #877: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc URL: https://github.com/apache/lucene/pull/877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene] LuXugang commented on pull request #877: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
LuXugang commented on PR #877: URL: https://github.com/apache/lucene/pull/877#issuecomment-1123826295 Thanks @mayya-sharipova, I just got to learn this new git operation, see https://github.com/apache/lucene/pull/880, this PR will be close. -- This is an automated message from the Apach

[jira] [Commented] (LUCENE-10551) LowercaseAsciiCompression should return false when it's unable to compress

2022-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534927#comment-17534927 ] Uwe Schindler commented on LUCENE-10551: I think you should also open a bug rep

[jira] [Created] (LUCENE-10567) Can LongDistanceFeatureQuery benefit from better sampling technique to evaluate iterator for competitive hits

2022-05-11 Thread Mayya Sharipova (Jira)
Mayya Sharipova created LUCENE-10567: Summary: Can LongDistanceFeatureQuery benefit from better sampling technique to evaluate iterator for competitive hits Key: LUCENE-10567 URL: https://issues.apache.org/jir

[GitHub] [lucene] LuXugang commented on pull request #880: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
LuXugang commented on PR #880: URL: https://github.com/apache/lucene/pull/880#issuecomment-1123836523 Hi, @mayya-sharipova , such merge operation is new to me, I am not sure if I could add an entry to CHANGES.txt correctly, so I could add entry after this PR merged or could you be nice to h

[GitHub] [lucene] mayya-sharipova commented on pull request #880: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
mayya-sharipova commented on PR #880: URL: https://github.com/apache/lucene/pull/880#issuecomment-1123863575 @LuXugang Right, you can add an entry to CHANGES.txt after this PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mayya-sharipova commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870463506 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java: ## @@ -68,42 +69,43 @@ public final class HnswGraphBuilder { * * @param vectors t

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mayya-sharipova commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870464398 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java: ## @@ -43,7 +43,8 @@ public final class HnswGraphBuilder { /** Random seed for level g

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mayya-sharipova commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870464781 ## lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java: ## @@ -256,10 +256,11 @@ public void testSearchWithSelectiveAcceptOrds() throws IOException

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mayya-sharipova commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870464973 ## lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java: ## @@ -377,10 +377,13 @@ private static class FieldEntry { for (int

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mayya-sharipova commented on code in PR #872: URL: https://github.com/apache/lucene/pull/872#discussion_r870466493 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -31,6 +31,7 @@ public final class OnHeapHnswGraph extends HnswGraph { private

[GitHub] [lucene] mayya-sharipova commented on pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

2022-05-11 Thread GitBox
mayya-sharipova commented on PR #872: URL: https://github.com/apache/lucene/pull/872#issuecomment-1123937553 @jtibshirani @mocobeta Thanks for your review. I've addressed your latest comments in d16168f77cbeae581a093daa53113bf897ab8e31. The plan for merging this PR is following: once

[GitHub] [lucene] mayya-sharipova merged pull request #880: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
mayya-sharipova merged PR #880: URL: https://github.com/apache/lucene/pull/880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[jira] [Commented] (LUCENE-10502) Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535028#comment-17535028 ] ASF subversion and git services commented on LUCENE-10502: -- Co

[GitHub] [lucene] mayya-sharipova commented on pull request #880: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
mayya-sharipova commented on PR #880: URL: https://github.com/apache/lucene/pull/880#issuecomment-1124044401 @LuXugang I've merged your PR to `main`. Other things we need to do: 1) Please create a PR against `main` add an entry to CHANGES.txt under the `Lucene 9.2.0` release.

[GitHub] [lucene] LuXugang opened a new pull request, #881: LUCENE-10502: add entry

2022-05-11 Thread GitBox
LuXugang opened a new pull request, #881: URL: https://github.com/apache/lucene/pull/881 Add entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] LuXugang commented on pull request #880: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread GitBox
LuXugang commented on PR #880: URL: https://github.com/apache/lucene/pull/880#issuecomment-1124111322 @mayya-sharipova , @jtibshirani Thanks for your reviews! >Please create a PR against main add an entry to CHANGES.txt under the Lucene 9.2.0 release. Addressed in https://git

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #881: LUCENE-10502: add entry

2022-05-11 Thread GitBox
mayya-sharipova commented on code in PR #881: URL: https://github.com/apache/lucene/pull/881#discussion_r870677297 ## lucene/CHANGES.txt: ## @@ -149,6 +149,9 @@ Optimizations when the search order and the index order are in opposite directions. (Jianping Weng) +* LUCENE-

[jira] [Commented] (LUCENE-10551) LowercaseAsciiCompression should return false when it's unable to compress

2022-05-11 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535093#comment-17535093 ] Michael McCandless commented on LUCENE-10551: - +1 to get to the bottom of t

[GitHub] [lucene] jtibshirani opened a new pull request, #882: LUCENE-10564: Make sure SparseFixedBitSet#or updates memory usage

2022-05-11 Thread GitBox
jtibshirani opened a new pull request, #882: URL: https://github.com/apache/lucene/pull/882 Before, it didn't update the estimated memory usage, so calls to ramBytesUsed could be totally off. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [lucene] shahrs87 opened a new pull request, #883: LUCENE-10561 Reduce class/member visibility of all normalizer and stemmer classes

2022-05-11 Thread GitBox
shahrs87 opened a new pull request, #883: URL: https://github.com/apache/lucene/pull/883 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach ta

[GitHub] [lucene] shahrs87 commented on pull request #883: LUCENE-10561 Reduce class/member visibility of all normalizer and stemmer classes

2022-05-11 Thread GitBox
shahrs87 commented on PR #883: URL: https://github.com/apache/lucene/pull/883#issuecomment-1124385828 ``` apache-lucene % ./gradlew check > Task :lucene:analysis:common:generateClassicTokenizerChecksumCheck FAILED FAILURE: Build failed with an exception. * Where: Scrip

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535139#comment-17535139 ] Rushabh Shah commented on LUCENE-10561: --- Hi, This is my first PR so apologies if

[GitHub] [lucene] LuXugang commented on a diff in pull request #881: LUCENE-10502: add entry

2022-05-11 Thread GitBox
LuXugang commented on code in PR #881: URL: https://github.com/apache/lucene/pull/881#discussion_r870839712 ## lucene/CHANGES.txt: ## @@ -149,6 +149,9 @@ Optimizations when the search order and the index order are in opposite directions. (Jianping Weng) +* LUCENE-10502:

[GitHub] [lucene] LuXugang commented on a diff in pull request #881: LUCENE-10502: add entry

2022-05-11 Thread GitBox
LuXugang commented on code in PR #881: URL: https://github.com/apache/lucene/pull/881#discussion_r870839898 ## lucene/CHANGES.txt: ## @@ -149,6 +149,9 @@ Optimizations when the search order and the index order are in opposite directions. (Jianping Weng) +* LUCENE-10502:

[GitHub] [lucene] mayya-sharipova merged pull request #881: LUCENE-10502: add entry

2022-05-11 Thread GitBox
mayya-sharipova merged PR #881: URL: https://github.com/apache/lucene/pull/881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[jira] [Commented] (LUCENE-10502) Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535804#comment-17535804 ] ASF subversion and git services commented on LUCENE-10502: -- Co

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535830#comment-17535830 ] Robert Muir commented on LUCENE-10561: -- Some of the tokenizers are auto-generated.

[GitHub] [lucene] mocobeta commented on pull request #883: LUCENE-10561 Reduce class/member visibility of all normalizer and stemmer classes

2022-05-11 Thread GitBox
mocobeta commented on PR #883: URL: https://github.com/apache/lucene/pull/883#issuecomment-1124499151 Hi @shahrs87. First of all, thanks for the great PR! As for the failed checksum check for `ClassicTokenizerImpl`, please refer to Robert's comment in Jira - I think you can omit `Classic

[GitHub] [lucene] shahrs87 commented on pull request #883: LUCENE-10561 Reduce class/member visibility of all normalizer and stemmer classes

2022-05-11 Thread GitBox
shahrs87 commented on PR #883: URL: https://github.com/apache/lucene/pull/883#issuecomment-1124521767 @mocobeta Thank you the reply. I have removed the classes that are generated via jflex. I also ran all the workflow test mentioned in Contributors guide and all seems to pass. Can you pleas

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535858#comment-17535858 ] Rushabh Shah commented on LUCENE-10561: --- Thank you [~rcmuir]  for the comment. I

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535859#comment-17535859 ] Rushabh Shah commented on LUCENE-10561: --- [~rcmuir]  Also can you please assign th

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535862#comment-17535862 ] Robert Muir commented on LUCENE-10561: -- I think i didn't explain my suggestion wel

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535865#comment-17535865 ] Rushabh Shah commented on LUCENE-10561: --- Thank you [~rcmuir]  for the clarificati

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535866#comment-17535866 ] Tomoko Uchida commented on LUCENE-10561: {quote}Also can you please assign the

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535870#comment-17535870 ] Tomoko Uchida commented on LUCENE-10561: {quote}Generally speaking, public cons

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535872#comment-17535872 ] Tomoko Uchida commented on LUCENE-10561: {quote}One followup question. Should I

[jira] [Commented] (LUCENE-10561) Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and PersianNormalizer

2022-05-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535874#comment-17535874 ] Tomoko Uchida commented on LUCENE-10561: (So... we need to switch Jira/GitHub e

[GitHub] [lucene] zacharymorn merged pull request #833: LUCENE-10411: Add NN vectors support to ExitableDirectoryReader

2022-05-11 Thread GitBox
zacharymorn merged PR #833: URL: https://github.com/apache/lucene/pull/833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[jira] [Commented] (LUCENE-10411) Add NN vectors support to ExitableDirectoryReader

2022-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535875#comment-17535875 ] ASF subversion and git services commented on LUCENE-10411: -- Co

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-11 Thread Shad Storhaug (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535898#comment-17535898 ] Shad Storhaug commented on LUCENE-10557: The Lucene.NET project switched to Git

[GitHub] [lucene] jpountz commented on a diff in pull request #882: LUCENE-10564: Make sure SparseFixedBitSet#or updates memory usage

2022-05-11 Thread GitBox
jpountz commented on code in PR #882: URL: https://github.com/apache/lucene/pull/882#discussion_r871000644 ## lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java: ## @@ -71,4 +71,27 @@ public void testApproximateCardinalityOnDenseSet() { } assertEqua

[jira] [Comment Edited] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-11 Thread Shad Storhaug (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535898#comment-17535898 ] Shad Storhaug edited comment on LUCENE-10557 at 5/12/22 6:40 AM: