[
https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535139#comment-17535139
]
Rushabh Shah commented on LUCENE-10561:
---------------------------------------
Hi,
This is my first PR so apologies if I ask dumb questions.
I created PR for this change. When I am running ./gradlew check, it is throwing
error below.
{noformat}
apache-lucene % ./gradlew check
> Task :lucene:analysis:common:generateClassicTokenizerChecksumCheck FAILED
FAILURE: Build failed with an exception.
* Where:
Script '/Users/rushabh.shah/apache-lucene/gradle/generation/regenerate.gradle'
line: 184
* What went wrong:
Execution failed for task
':lucene:analysis:common:generateClassicTokenizerChecksumCheck'.
> Checksums mismatch for derived resources; you might have modified a generated
> resource (regenerate task: generateClassicTokenizer):
Current:
lucene/analysis/common/src/java/org/apache/lucene/analysis/classic/ClassicTokenizerImpl.java=c825a8b8d0d0d893b4914e7161bcd119e7b07b40
Expected:
lucene/analysis/common/src/java/org/apache/lucene/analysis/classic/ClassicTokenizerImpl.java=381a9627fd7da6402216e3279cf81a09af222aaf
{noformat}
I understand that I need to update checksum somewhere but don't know whether we
have some script that does that or we have to compute manually. Please advise.
[~rcmuir] [~tomoko]
> Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and
> PersianNormalizer
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-10561
> URL: https://issues.apache.org/jira/browse/LUCENE-10561
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Tomoko Uchida
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is a spin-off of [LUCENE-10312].
> Constants and methods in those classes are exposed to the outside packages;
> we should be able to limit the visibility to {{private}} or, at least to
> {{package private}}.
> This change breaks backward compatibility so should be applied to the main
> branch (10.0) only, and a MIGRATE entry may be needed.
> Also, they seem unchanged since 2008, we could refactor them to embrace newer
> Java APIs as we did in [https://github.com/apache/lucene/pull/540].
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
