[
https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535862#comment-17535862
]
Robert Muir commented on LUCENE-10561:
--------------------------------------
I think i didn't explain my suggestion well enough. When i said "make entire
classes package private", I mean that, for example, ArabicNormalizer does not
need to be public class anymore.
I think this is easier than modifying many individual constants. Some of the
constants modified in the PR are not related to stemmers/normalizers and may
cause problems.
Generally speaking, public constants are harmless, so I don't think there is
much benefit in hiding them.
But entire classes that need not be public, that is worth fixing because it
clutters up javadoc and API for no good reason.
> Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and
> PersianNormalizer
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-10561
> URL: https://issues.apache.org/jira/browse/LUCENE-10561
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Tomoko Uchida
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is a spin-off of [LUCENE-10312].
> Constants and methods in those classes are exposed to the outside packages;
> we should be able to limit the visibility to {{private}} or, at least to
> {{package private}}.
> This change breaks backward compatibility so should be applied to the main
> branch (10.0) only, and a MIGRATE entry may be needed.
> Also, they seem unchanged since 2008, we could refactor them to embrace newer
> Java APIs as we did in [https://github.com/apache/lucene/pull/540].
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
