[jira] [Commented] (LUCENE-10216) Add concurrency to addIndexes(CodecReader…) API

2022-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530504#comment-17530504 ] Robert Muir commented on LUCENE-10216: -- {quote} I've also modified the MockRandomM

[GitHub] [lucene] rmuir commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
rmuir commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862451702 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return mergeSpec;

[GitHub] [lucene] uschindler commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
uschindler commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862455421 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merge

[GitHub] [lucene] uschindler commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
uschindler commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862455421 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merge

[GitHub] [lucene] msokolov commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
msokolov commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862485790 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return mergeSp

[GitHub] [lucene] uschindler commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
uschindler commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862504146 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merge

[GitHub] [lucene] uschindler commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
uschindler commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862504930 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merge

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862515687 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merg

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862515847 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merg

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862516293 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merg

[GitHub] [lucene] uschindler commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
uschindler commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862518550 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merge

[GitHub] [lucene] zacharymorn commented on pull request #833: LUCENE-10411: Add NN vectors support to ExitableDirectoryReader

2022-05-01 Thread GitBox
zacharymorn commented on PR #833: URL: https://github.com/apache/lucene/pull/833#issuecomment-111430 > It's great that we're tackling this! I can't see this really hurting performance (since the checks are simple and not frequent), but am curious what you think. I don't think we benchma

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-01 Thread GitBox
vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862565471 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merg