zacharymorn commented on PR #833: URL: https://github.com/apache/lucene/pull/833#issuecomment-1114344440
> It's great that we're tackling this! I can't see this really hurting performance (since the checks are simple and not frequent), but am curious what you think. I don't think we benchmark `ExitableDirectoryReader` in luceneutil. Thanks for the review and comment! Hmm that's a good question. I think it should have similar performance characteristics to other methods in `ExitableDirectoryReader` given the checking logic is similar, but I'm not sure if NN methods in general might be invoked more often than those to achieve their intended operations / use cases in real applications? Other than the lack of luceneutil tests for this, there's no baseline either since this is new. I guess we could release it first and then iterate based on user feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
