[GitHub] [lucene] dweiss commented on pull request #394: LUCENE-9997: write release revision to system temp dir

2021-10-19 Thread GitBox
dweiss commented on pull request #394: URL: https://github.com/apache/lucene/pull/394#issuecomment-946429811 Thanks Tomoko. What is this file for though? Is it really needed at all (can't it be a variable)? It'd also help to use Python's temporary-file facilities so that it's system-agnost

[jira] [Commented] (LUCENE-10185) gradle check fails on java 17 (security manager deprecation)

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430362#comment-17430362 ] Dawid Weiss commented on LUCENE-10185: -- Oh... completely forgot about polymorphic

[GitHub] [lucene] dweiss commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
dweiss commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946437537 > Or the script could run the main build in parallel and then run just the signing serially. Sure. Split in two - I also suggested removing "clean" because just rebuilding fr

[GitHub] [lucene] dweiss edited a comment on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
dweiss edited a comment on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946437537 > Or the script could run the main build in parallel and then run just the signing serially. Sure. Split in two - I also suggested removing "clean" because rebuilding

[jira] [Commented] (LUCENE-10166) Move relevant content of README.txt files from subprojects into package javadocs

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430375#comment-17430375 ] ASF subversion and git services commented on LUCENE-10166: -- Co

[jira] [Created] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread Jira
Jan Høydahl created LUCENE-10186: Summary: Maven artifacts built by gradle lack required META-INF content Key: LUCENE-10186 URL: https://issues.apache.org/jira/browse/LUCENE-10186 Project: Lucene - Co

[GitHub] [lucene] dweiss merged pull request #379: LUCENE-10166: removed module-level README.txt and modified a few links.

2021-10-19 Thread GitBox
dweiss merged pull request #379: URL: https://github.com/apache/lucene/pull/379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430376#comment-17430376 ] Dawid Weiss commented on LUCENE-10186: -- I'll handle this today, Jan. > Maven arti

[jira] [Resolved] (LUCENE-10166) Move relevant content of README.txt files from subprojects into package javadocs

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10166. -- Fix Version/s: main (9.0) Assignee: Dawid Weiss Resolution: Fixed > Move rele

[jira] [Assigned] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10186: Assignee: Dawid Weiss > Maven artifacts built by gradle lack required META-INF content >

[jira] [Commented] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430377#comment-17430377 ] Dawid Weiss commented on LUCENE-10186: -- Do source packages need a manifest though?

[jira] [Commented] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430378#comment-17430378 ] Dawid Weiss commented on LUCENE-10186: -- We actually explicitly skip those JARs fro

[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
janhoy commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946453138 @mocobeta I got the same as you - looks like LICENSE and NOTICE are not copied into the maven jars. Strange, since they exist in the binary-release jars. Looks like maven task re-bu

[jira] [Reopened] (LUCENE-10174) Update buildAndPushRelease.py for new gradle build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened LUCENE-10174: -- Re-opening to enhance the 'assembleRelease' step, to avoid OOM in gpg-agent. Will split in two c

[jira] [Commented] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430383#comment-17430383 ] Dawid Weiss commented on LUCENE-10186: -- I filed a PR. I think this was intentional

[jira] [Commented] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430386#comment-17430386 ] ASF subversion and git services commented on LUCENE-10186: -- Co

[GitHub] [lucene] dweiss merged pull request #395: LUCENE-10186: Include manifest and legalese in source and javadoc jars.

2021-10-19 Thread GitBox
dweiss merged pull request #395: URL: https://github.com/apache/lucene/pull/395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Resolved] (LUCENE-10186) Maven artifacts built by gradle lack required META-INF content

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10186. -- Fix Version/s: main (9.0) Resolution: Fixed > Maven artifacts built by gradle lack req

[jira] [Commented] (LUCENE-10174) Update buildAndPushRelease.py for new gradle build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430393#comment-17430393 ] Jan Høydahl commented on LUCENE-10174: -- When we skip "clean" step, the task does n

[GitHub] [lucene] janhoy opened a new pull request #396: LUCENE-10174 BuildAndPushRelease additional improvements

2021-10-19 Thread GitBox
janhoy opened a new pull request #396: URL: https://github.com/apache/lucene/pull/396 https://issues.apache.org/jira/browse/LUCENE-10174 Makes assembleRelease OOM safe with max-workers=2 and faster by avoiding 'clean' -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (LUCENE-10174) Update buildAndPushRelease.py for new gradle build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430393#comment-17430393 ] Jan Høydahl edited comment on LUCENE-10174 at 10/19/21, 8:23 AM:

[jira] [Commented] (LUCENE-10174) Update buildAndPushRelease.py for new gradle build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430396#comment-17430396 ] Jan Høydahl commented on LUCENE-10174: -- See PR https://github.com/apache/lucene/pu

[GitHub] [lucene] janhoy edited a comment on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
janhoy edited a comment on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946453138 @mocobeta I got the same as you - looks like LICENSE and NOTICE are not copied into the maven jars. Strange, since they exist in the binary-release jars. Looks like maven tas

[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
janhoy commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946481179 @mocobeta I think you asked whether the `./gradlew` commands are windows safe. I really don't know. I see tons of `/` in that script so perhaps python translates it? I don't use Win

[jira] [Resolved] (LUCENE-10182) TestRamUsageEstimator asserts trivial equality

2021-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-10182. Resolution: Fixed > TestRamUsageEstimator asserts trivial equality >

[jira] [Commented] (LUCENE-10182) TestRamUsageEstimator asserts trivial equality

2021-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430408#comment-17430408 ] Uwe Schindler commented on LUCENE-10182: Hi, I think we should not backport the

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430415#comment-17430415 ] Dawid Weiss commented on LUCENE-9997: - I ran the full check with local keys and dev

[GitHub] [lucene] dweiss commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
dweiss commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946494828 I use Windows - these scripts are not compatible. I don't think we have to make it a priority to make them compatible. Too many variables to think of. -- This is an automated mess

[GitHub] [lucene] stefanvodita opened a new pull request #397: LUCENE-10182: Order assertion parameters correctly

2021-10-19 Thread GitBox
stefanvodita opened a new pull request #397: URL: https://github.com/apache/lucene/pull/397 # Description Reorder assert parameters in `TestRamUsageEstimator.testStaticOverloads` like `assertEquals(expected, actual)` instead of `assertEquals(actual, expected)`. # Checklis

[jira] [Commented] (LUCENE-10182) TestRamUsageEstimator asserts trivial equality

2021-10-19 Thread Stefan Vodita (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430430#comment-17430430 ] Stefan Vodita commented on LUCENE-10182: Might as well fix the assertion order,

[GitHub] [lucene] mocobeta commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
mocobeta commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946544474 @janhoy @dweiss Commands with `./` do not work on Windows. Yesterday I just tested it on my Windows OS; I saw Command Prompt and PowerShell do not support `./gradlew`.

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430442#comment-17430442 ] Dawid Weiss commented on LUCENE-9997: - The rev.txt file is for running on a "prepare

[GitHub] [lucene] mocobeta edited a comment on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
mocobeta edited a comment on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946544474 @janhoy @dweiss Commands with `./` do not work on Windows. Yesterday I just tested it on my Windows OS; I saw Command Prompt and PowerShell do not support `./gradlew

[GitHub] [lucene] dweiss commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
dweiss commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-946571894 I'm really fine with these scripts working just on Unix-ish systems. If you really want to, WSL or a virtual machines is a fine workaround for Windows users (like you or me). Like I

[GitHub] [lucene] apanimesh061 commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-19 Thread GitBox
apanimesh061 commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r731752215 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper getR

[GitHub] [lucene] dnhatn commented on pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-19 Thread GitBox
dnhatn commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-946649980 @rmuir @jpountz Thanks for reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (LUCENE-9613) Create blocks for ords when it helps in Lucene80DocValuesFormat

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430493#comment-17430493 ] ASF subversion and git services commented on LUCENE-9613: - Commi

[jira] [Commented] (LUCENE-10159) Index corruption: IndexOutOfBoundsException for doc values

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430492#comment-17430492 ] ASF subversion and git services commented on LUCENE-10159: -- Co

[GitHub] [lucene] dnhatn merged pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-19 Thread GitBox
dnhatn merged pull request #389: URL: https://github.com/apache/lucene/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Updated] (LUCENE-10159) Index corruption: IndexOutOfBoundsException for doc values

2021-10-19 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-10159: - Fix Version/s: main (9.0) Resolution: Fixed Status: Resolved (was: Patch Avai

[GitHub] [lucene] jpountz commented on pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-19 Thread GitBox
jpountz commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-946681702 @rmuir Agreed with your thoughts. I wonder what you would think of reducing the padding to the strict minimum depending on the number of bits per value. This would make it harder t

[GitHub] [lucene] rmuir commented on pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-19 Thread GitBox
rmuir commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-946683120 +1 to that idea as a followup issue too. it is really bad that it masked the bug here! Thanks @dnhatn for all the debugging and the fix! -- This is an automated message from the Ap

[jira] [Created] (LUCENE-10187) Reduce DirectWriter's padding to a minimum

2021-10-19 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10187: - Summary: Reduce DirectWriter's padding to a minimum Key: LUCENE-10187 URL: https://issues.apache.org/jira/browse/LUCENE-10187 Project: Lucene - Core Issue

[jira] [Created] (LUCENE-10188) Give SortedSetDocValues a docValueCount()?

2021-10-19 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10188: - Summary: Give SortedSetDocValues a docValueCount()? Key: LUCENE-10188 URL: https://issues.apache.org/jira/browse/LUCENE-10188 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430531#comment-17430531 ] Adrien Grand commented on LUCENE-10180: --- I'm not sure either, I don't think I did

[GitHub] [lucene] jpountz merged pull request #385: LUCENE-10180: Avoid using lambdas in SegmentMerger.

2021-10-19 Thread GitBox
jpountz merged pull request #385: URL: https://github.com/apache/lucene/pull/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430532#comment-17430532 ] Adrien Grand commented on LUCENE-10180: --- bq. does the proposed solution (function

[jira] [Commented] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430533#comment-17430533 ] ASF subversion and git services commented on LUCENE-10180: -- Co

[jira] [Resolved] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10180. --- Fix Version/s: main (9.0) Resolution: Fixed > Remove usage of lambdas in SegmentMerg

[GitHub] [lucene] jpountz opened a new pull request #398: LUCENE-10187: Reduce DirectWriter's padding.

2021-10-19 Thread GitBox
jpountz opened a new pull request #398: URL: https://github.com/apache/lucene/pull/398 It would make us more likely to detect out-of-bounds access in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] uschindler commented on pull request #385: LUCENE-10180: Avoid using lambdas in SegmentMerger.

2021-10-19 Thread GitBox
uschindler commented on pull request #385: URL: https://github.com/apache/lucene/pull/385#issuecomment-946762526 Thanks! ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430575#comment-17430575 ] Uwe Schindler commented on LUCENE-10180: {quote} bq. does the proposed solution

[jira] [Comment Edited] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430575#comment-17430575 ] Uwe Schindler edited comment on LUCENE-10180 at 10/19/21, 2:20 PM: --

[jira] [Comment Edited] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430575#comment-17430575 ] Uwe Schindler edited comment on LUCENE-10180 at 10/19/21, 2:21 PM: --

[GitHub] [lucene] uschindler merged pull request #397: LUCENE-10182: Order assertion parameters correctly

2021-10-19 Thread GitBox
uschindler merged pull request #397: URL: https://github.com/apache/lucene/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (LUCENE-10182) TestRamUsageEstimator asserts trivial equality

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430581#comment-17430581 ] ASF subversion and git services commented on LUCENE-10182: -- Co

[jira] [Commented] (LUCENE-10182) TestRamUsageEstimator asserts trivial equality

2021-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430582#comment-17430582 ] Uwe Schindler commented on LUCENE-10182: Merged! > TestRamUsageEstimator asser

[jira] [Created] (LUCENE-10189) Optimize SortedSet/SortedNumeric doc values writers for fields that are effectively single-valued

2021-10-19 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10189: - Summary: Optimize SortedSet/SortedNumeric doc values writers for fields that are effectively single-valued Key: LUCENE-10189 URL: https://issues.apache.org/jira/browse/LUCENE-10

[jira] [Created] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-10-19 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10190: Summary: Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber Key: LUCENE-10190 URL: https://issues.apache.org/jira/browse/LUCENE-10190 Project: Lucene -

[GitHub] [lucene] dweiss commented on pull request #396: LUCENE-10174 BuildAndPushRelease additional improvements

2021-10-19 Thread GitBox
dweiss commented on pull request #396: URL: https://github.com/apache/lucene/pull/396#issuecomment-946803083 CI failed with LUCENE-10190. I respinned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene] dweiss edited a comment on pull request #396: LUCENE-10174 BuildAndPushRelease additional improvements

2021-10-19 Thread GitBox
dweiss edited a comment on pull request #396: URL: https://github.com/apache/lucene/pull/396#issuecomment-946803083 CI failed with LUCENE-10190. I respun. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] janhoy commented on pull request #396: LUCENE-10174 BuildAndPushRelease additional improvements

2021-10-19 Thread GitBox
janhoy commented on pull request #396: URL: https://github.com/apache/lucene/pull/396#issuecomment-946830386 > LGTM. I also think all gradle invocations from within the python script shouldn't fork the daemon (--no-daemon) - this prevents leaking memory and makes sure nothing is left behin

[GitHub] [lucene] dweiss commented on pull request #396: LUCENE-10174 BuildAndPushRelease additional improvements

2021-10-19 Thread GitBox
dweiss commented on pull request #396: URL: https://github.com/apache/lucene/pull/396#issuecomment-946910151 Yes, I think --no-daemon would be helpful here (in addition to worker restriction). This leaves nothing behind - clean slate for a re-run. -- This is an automated message from the

[jira] [Commented] (LUCENE-10189) Optimize SortedSet/SortedNumeric doc values writers for fields that are effectively single-valued

2021-10-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430647#comment-17430647 ] Robert Muir commented on LUCENE-10189: -- For the SortedSetCase, seems like we want

[jira] [Commented] (LUCENE-10147) KnnVectorQuery can produce negative scores

2021-10-19 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430662#comment-17430662 ] Julie Tibshirani commented on LUCENE-10147: --- [~msoko...@gmail.com] you mentio

[GitHub] [lucene] janhoy merged pull request #396: LUCENE-10174 BuildAndPushRelease additional improvements

2021-10-19 Thread GitBox
janhoy merged pull request #396: URL: https://github.com/apache/lucene/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10174) Update buildAndPushRelease.py for new gradle build

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430670#comment-17430670 ] ASF subversion and git services commented on LUCENE-10174: -- Co

[jira] [Commented] (LUCENE-10189) Optimize SortedSet/SortedNumeric doc values writers for fields that are effectively single-valued

2021-10-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430710#comment-17430710 ] Adrien Grand commented on LUCENE-10189: --- Right, I tried to do this in the linked

[jira] [Closed] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-10-19 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova closed LUCENE-10126. Closing after the 8.10.1 release > CompetitiveIterator of NumericComparator can wrongly skip

[jira] [Closed] (LUCENE-10119) singleSort should not be set when after is non-null

2021-10-19 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova closed LUCENE-10119. Closing after the 8.10.1 release > singleSort should not be set when after is non-null > ---

[jira] [Closed] (LUCENE-10110) MultiCollector should conditionally wrap single leaf collector

2021-10-19 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova closed LUCENE-10110. Closing after the 8.10.1 release > MultiCollector should conditionally wrap single leaf coll

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430727#comment-17430727 ] Jan Høydahl commented on LUCENE-9997: - Yey, first smoketest SUCCESS on freshly built

[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
janhoy commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-947035468 ``` verify maven artifact sigs unpack l

[GitHub] [lucene] janhoy merged pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-19 Thread GitBox
janhoy merged pull request #391: URL: https://github.com/apache/lucene/pull/391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430730#comment-17430730 ] ASF subversion and git services commented on LUCENE-9997: - Commi

[jira] [Assigned] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned LUCENE-9997: --- Assignee: Jan Høydahl > Revisit smoketester for 9.0 build > ---

[jira] [Resolved] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved LUCENE-9997. - Fix Version/s: main (9.0) Resolution: Fixed > Revisit smoketester for 9.0 build > ---

[jira] [Created] (LUCENE-10191) Optimize vector functions by precomputing magnitudes

2021-10-19 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-10191: - Summary: Optimize vector functions by precomputing magnitudes Key: LUCENE-10191 URL: https://issues.apache.org/jira/browse/LUCENE-10191 Project: Lucene - Cor

[jira] [Updated] (LUCENE-10141) Update releaseWizard for 8x to correctly create back-compat indices and update Version in main after repo split

2021-10-19 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-10141: - Fix Version/s: (was: 8.10.1) > Update releaseWizard for 8x to correctly create back

[jira] [Commented] (LUCENE-10189) Optimize SortedSet/SortedNumeric doc values writers for fields that are effectively single-valued

2021-10-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430736#comment-17430736 ] Adrien Grand commented on LUCENE-10189: --- With the linked PR I'm getting the same

[GitHub] [lucene] jtibshirani opened a new pull request #400: LUCENE-10146: Add note that dot product is preferred over cosine

2021-10-19 Thread GitBox
jtibshirani opened a new pull request #400: URL: https://github.com/apache/lucene/pull/400 While VectorSimilarityFunction#COSINE is helpful when you need to preserve the original vectors, it is significantly slower than DOT_PRODUCT. This commit adds javadocs to COSINE explaining that

[GitHub] [lucene] jtibshirani commented on pull request #366: LUCENE-10146: Add VectorSimilarityFunction.COSINE

2021-10-19 Thread GitBox
jtibshirani commented on pull request #366: URL: https://github.com/apache/lucene/pull/366#issuecomment-947053287 @msokolov @mayya-sharipova following up: I ran benchmarks and it's indeed significantly slower (around 20% on some of the datasets we've been using). Here's what I've done:

[jira] [Commented] (LUCENE-10084) Rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery when docCount == maxDoc

2021-10-19 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430785#comment-17430785 ] Vigya Sharma commented on LUCENE-10084: --- I would like to work on this. > Rewrite

[GitHub] [lucene] mocobeta commented on pull request #394: LUCENE-9997: write release revision to system temp dir

2021-10-19 Thread GitBox
mocobeta commented on pull request #394: URL: https://github.com/apache/lucene/pull/394#issuecomment-947141245 The `rev.txt` file is used to reuse the git revision on the previous run when `--no-prepare` option is passed. https://github.com/apache/lucene/blob/c77e9ddf93ae872ba6556d39c48

[GitHub] [lucene] mocobeta merged pull request #394: LUCENE-9997: write release revision to system temp dir

2021-10-19 Thread GitBox
mocobeta merged pull request #394: URL: https://github.com/apache/lucene/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430792#comment-17430792 ] ASF subversion and git services commented on LUCENE-9997: - Commi

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430795#comment-17430795 ] Jan Høydahl commented on LUCENE-9997: - > r-- permissions on all maven artifact files

[GitHub] [lucene] dsmiley commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-19 Thread GitBox
dsmiley commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r732287420 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper getReader

[GitHub] [lucene] janhoy opened a new pull request #401: LUCENE-10174 Speed up 'pushLocal'

2021-10-19 Thread GitBox
janhoy opened a new pull request #401: URL: https://github.com/apache/lucene/pull/401 https://issues.apache.org/jira/browse/LUCENE-10174 When copying files from `lucene/distribution/build/release` to the target directory, the script uses `tar.bz2`, i.e. with compression. This is supe

[jira] [Commented] (LUCENE-10174) Update buildAndPushRelease.py for new gradle build

2021-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430801#comment-17430801 ] Jan Høydahl commented on LUCENE-10174: -- See [GitHub Pull Request #401|https://gith

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-19 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430811#comment-17430811 ] Tomoko Uchida commented on LUCENE-9997: --- bq. I think we should make the git revisi

[jira] [Commented] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-10-19 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430833#comment-17430833 ] Nhat Nguyen commented on LUCENE-10190: -- I am looking at this failure. > Assertion

[jira] [Commented] (LUCENE-10191) Optimize vector functions by precomputing magnitudes

2021-10-19 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430835#comment-17430835 ] Mayya Sharipova commented on LUCENE-10191: -- +1 great ideas to explore the perf

[jira] [Assigned] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-10-19 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen reassigned LUCENE-10190: Assignee: Nhat Nguyen > Assertion error in TestIndexWriter.testMaxCompletedSequenceNumbe

[jira] [Commented] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-10-19 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430843#comment-17430843 ] Nhat Nguyen commented on LUCENE-10190: -- I can reproduce the issue by sleeping for

[jira] [Comment Edited] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-10-19 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430843#comment-17430843 ] Nhat Nguyen edited comment on LUCENE-10190 at 10/20/21, 2:45 AM:

[jira] [Comment Edited] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-10-19 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430843#comment-17430843 ] Nhat Nguyen edited comment on LUCENE-10190 at 10/20/21, 2:46 AM:

[jira] [Commented] (LUCENE-10190) Assertion error in TestIndexWriter.testMaxCompletedSequenceNumber

2021-10-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430980#comment-17430980 ] Dawid Weiss commented on LUCENE-10190: -- Thank you, [~dnhatn]! > Assertion error i

[jira] [Created] (LUCENE-10192) Drop third-party JARs from the binary distribution

2021-10-19 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10192: Summary: Drop third-party JARs from the binary distribution Key: LUCENE-10192 URL: https://issues.apache.org/jira/browse/LUCENE-10192 Project: Lucene - Core

[jira] [Commented] (LUCENE-10084) Rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery when docCount == maxDoc

2021-10-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431010#comment-17431010 ] Adrien Grand commented on LUCENE-10084: --- Please feel free to give it a try! > Re

  1   2   >