[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430442#comment-17430442
]
Dawid Weiss commented on LUCENE-9997:
-------------------------------------
The rev.txt file is for running on a "prepared" package - it saves the git
revision in a separate file because otherwise it wouldn't have any means to
read it back from.
{code}
parser.add_argument('--no-prepare', dest='prepare', default=True,
action='store_false',
help='Use the already built release in the provided
checkout')
{code}
I think we should make the git revision part of the distribution artifacts -
then the smoke tester can read it directly from the distribution artifact
release folder. Moreover, the git revision could also be part of the "source"
distribution of Lucene - then the build scripts can be tweaked to actually work
without the git clone (on the true "source" distribution) by simulating the git
revision read from such a file.
Thoughts?
> Revisit smoketester for 9.0 build
> ---------------------------------
>
> Key: LUCENE-9997
> URL: https://issues.apache.org/jira/browse/LUCENE-9997
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Robert Muir
> Priority: Major
> Attachments: image-2021-10-12-12-47-11-480.png,
> image-2021-10-12-12-48-15-373.png
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> Currently we have a (great) {{dev-tools/scripts/smokeTester.py}} that will
> perform automated tests against a release.
> This was developed with the ant build process in mind.
> This issue is just about considering the automated checks we do here, maybe
> some of them can be done efficiently in the gradle build in earlier places:
> this would be a large improvement!
> Obviously some of them (e.g. GPG release key verifications) are really
> specific to the artifacts in question. These are most important to release
> verification, as that is actually the only place we can check it.
> Any other checks (and I do tend to think, this checker should try to be
> thorough, invoking gradle etc), should be stuff we regularly test in
> PRs/nightly/builds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
