janhoy commented on pull request #396: URL: https://github.com/apache/lucene/pull/396#issuecomment-946830386
> LGTM. I also think all gradle invocations from within the python script shouldn't fork the daemon (--no-daemon) - this prevents leaking memory and makes sure nothing is left behind in case of errors. Are you saying that `--no-daemon` would be better? I could fold that into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org