dweiss commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519618160
##
File path: lucene/native/build.gradle
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-723842876
bq. The windows equivalentWindowsDirectory.cpp still sits in misc module and
hasn't been moved over yet.
Ah... I didn't realize this is the case then - sorry. Give me a
bruno-roustant commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519684814
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -490,21 +492,19 @@ public CoreDescriptor getCoreDescriptor(String co
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228512#comment-17228512
]
Andrzej Bialecki commented on SOLR-14683:
-
{quote}Solr's JSON Response writer alr
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228512#comment-17228512
]
Andrzej Bialecki edited comment on SOLR-14683 at 11/9/20, 10:57 AM:
---
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228512#comment-17228512
]
Andrzej Bialecki edited comment on SOLR-14683 at 11/9/20, 10:58 AM:
---
[
https://issues.apache.org/jira/browse/SOLR-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228529#comment-17228529
]
Andreas Hubold commented on SOLR-14969:
---
I've tested concurrent core creation for b
bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723960636
Ok, now I think I integrated all comments.
This is an automated message from the Apache Git Service.
ErickErickson commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723990436
+1
> On Nov 8, 2020, at 3:30 PM, David Smiley wrote:
>
>
> So @dsmiley @ErickErickson do we all agree that we throw an exception in
in TransientSolrC
dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519792336
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -121,8 +101,8 @@ protected void close() {
// make a copy of the co
[
https://issues.apache.org/jira/browse/SOLR-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228572#comment-17228572
]
ASF subversion and git services commented on SOLR-14969:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228583#comment-17228583
]
ASF subversion and git services commented on SOLR-14969:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228593#comment-17228593
]
Andreas Hubold commented on SOLR-14969:
---
Works, no logged ERROR messages anymore. T
Erick Erickson created SOLR-14991:
-
Summary: tag and remove obsolete branches
Key: SOLR-14991
URL: https://issues.apache.org/jira/browse/SOLR-14991
Project: Solr
Issue Type: Improvement
mikemccand commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r519868079
##
File path: lucene/misc/src/java/org/apache/lucene/store/DirectIODirectory.java
##
@@ -66,45 +66,32 @@
*
* @lucene.experimental
*/
-public
mikemccand commented on a change in pull request #2022:
URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519873455
##
File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java
##
@@ -74,6 +74,18 @@ public BytesRef binaryValue() throws IOException
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228642#comment-17228642
]
Michael McCandless commented on LUCENE-9378:
{quote}IMO this is so definitel
mikemccand commented on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-724069358
> > But then I wonder why not just add a boolean compress option to
Lucene80DocValuesFormat? This is similar to the compression Mode we pass to
stored fields and term vec
mikemccand commented on a change in pull request #2022:
URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519881970
##
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundati
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228665#comment-17228665
]
Adrien Grand commented on LUCENE-9378:
--
I'll be looking into it for 8.8.
> Configu
msokolov merged pull request #2037:
URL: https://github.com/apache/lucene-solr/pull/2037
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228677#comment-17228677
]
ASF subversion and git services commented on LUCENE-9583:
-
Commi
mikemccand commented on a change in pull request #2022:
URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519895947
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -22,39 +22,60 @@
import java.nio.FloatBuffer
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228681#comment-17228681
]
Michael McCandless commented on LUCENE-9378:
{quote}I'll be looking into it
asfgit closed pull request #972:
URL: https://github.com/apache/lucene-solr/pull/972
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SOLR-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228687#comment-17228687
]
Erick Erickson commented on SOLR-14991:
---
I just did the grade branches, with the ex
bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-724113057
@dsmiley I pushed a new commit to have a NO OP TransientSolrCacheFactory
before SolrCores.load() is called.
This is to have your opinion, whether to keep it or remo
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-14683:
Attachment: SOLR-14683.patch
> Review the metrics API to ensure consistent placeholders for
[
https://issues.apache.org/jira/browse/SOLR-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228695#comment-17228695
]
Kevin Risden commented on SOLR-14951:
-
Sigh I missed merging it. I just saw the revie
[
https://issues.apache.org/jira/browse/SOLR-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-14951:
Fix Version/s: 8.8
> Upgrade Angular JS 1.7.9 to 1.8.0
> -
>
>
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r519944462
##
File path: solr/solr-ref-guide/src/learning-to-rank.adoc
##
@@ -247,6 +254,81 @@ The output XML will include feature values as a
comma-separate
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r519967315
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the A
Tomas Eduardo Fernandez Lobbe created SOLR-14992:
Summary: TestPullReplicaErrorHandling.testCantConnectToPullReplica
Failures
Key: SOLR-14992
URL: https://issues.apache.org/jira/browse/SOLR-14992
muse-dev[bot] commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519994863
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -62,55 +51,44 @@
// to essentially queue them up to be handled via
[
https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228742#comment-17228742
]
ASF subversion and git services commented on LUCENE-9322:
-
Commi
jpountz opened a new pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069
This adds a switch to `Lucene80DocValuesFormat` which allows to
configure whether to prioritize retrieval speed over compression ratio
or the other way around. When prioritizing retrieval spee
Adrien Grand created LUCENE-9602:
Summary: TestBackwardsCompatibility should test BEST_COMPRESSION
Key: LUCENE-9602
URL: https://issues.apache.org/jira/browse/LUCENE-9602
Project: Lucene - Core
mikemccand commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520024634
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene80/BaseLucene80DocValuesFormatTestCase.java
##
@@ -286,7 +278,7 @@ private void
dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520029778
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -51,7 +51,7 @@
// to essentially queue them up to be handled via pending
mikemccand commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520031264
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene80/TestBestSpeedLucene80DocValuesFormat.java
##
@@ -0,0 +1,33 @@
+/*
+ * License
jpountz commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520033652
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene80/TestBestSpeedLucene80DocValuesFormat.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed t
jpountz commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520034757
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene80/BaseLucene80DocValuesFormatTestCase.java
##
@@ -286,7 +278,7 @@ private void doT
jpountz commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520035432
##
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene87/Lucene87Codec.java
##
@@ -56,6 +57,23 @@
* @lucene.experim
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r520038324
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
##
@@ -210,50 +216
bruno-roustant commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520040508
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -51,7 +51,7 @@
// to essentially queue them up to be handled via
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-14683:
Attachment: SOLR-14683.patch
> Review the metrics API to ensure consistent placeholders for
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228768#comment-17228768
]
Andrzej Bialecki commented on SOLR-14683:
-
This patch adds configurable placehold
[
https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228769#comment-17228769
]
Kevin Risden commented on SOLR-14973:
-
FYI [~tallison] - not sure who updated Tika li
bruno-roustant commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520049002
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -62,55 +51,44 @@
// to essentially queue them up to be handled vi
mikemccand commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520055341
##
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene87/Lucene87Codec.java
##
@@ -56,6 +57,23 @@
* @lucene.expe
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r520055346
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
##
@@ -210,50 +216
dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520057072
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -51,7 +51,7 @@
// to essentially queue them up to be handled via pending
dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520058820
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -536,7 +538,9 @@ public void queueCoreToClose(SolrCore coreToClose) {
*
[
https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228776#comment-17228776
]
Tim Allison commented on SOLR-14973:
Thank you [~krisden] for the ping.
> Solr 8.6
bruno-roustant commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520089739
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -536,7 +538,9 @@ public void queueCoreToClose(SolrCore coreToClose)
dsmiley commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520092229
##
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##
@@ -536,7 +538,9 @@ public void queueCoreToClose(SolrCore coreToClose) {
*
dweiss commented on pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-724260281
Hmm... sorry, missed your mention/ request somehow. Yeah - these functions
are intended to read variables from multiple locations so it looks ok to me. I
didn't test it (or u
HoustonPutman commented on pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-724264582
Thanks for the sanity check!
I've tested pretty thoroughly, and the PR test does some checks on its own
too.
--
Allen Sooredoo created SOLR-14993:
-
Summary: Unable to download zookeeper files of 1byte in size
Key: SOLR-14993
URL: https://issues.apache.org/jira/browse/SOLR-14993
Project: Solr
Issue Type
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-724283052
Zach I've cleaned up the native build a bit - moved it under lucene/misc,
added Windows build (it does build the native library for me). I didn't check
whether it works on a
dweiss commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r520125532
##
File path: lucene/misc/native/build.gradle
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contri
jtibshirani opened a new pull request #2070:
URL: https://github.com/apache/lucene-solr/pull/2070
Previously we only checked that the first segment's ordinal deltas were all
zero. This didn't account for some rare cases where some of the segment's
ordinals are filtered out, so the ordi
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-724287441
Byt. if we do have to add that explicit 'build.native' option then I'd
implement it as a task (graph) exclusion rather than project exclusion. Windows
users in particular may
jtibshirani commented on pull request #2070:
URL: https://github.com/apache/lucene-solr/pull/2070#issuecomment-724288495
This should fix the failures we're seeing like
`TestLucene70DocValuesFormat#testSparseSortedVariableLengthVsStoredFields` and
`TestSimpleTextDocValuesFormat#testSparseSo
Anshum Gupta created SOLR-14994:
---
Summary: Bring in Solr Operator into the Lucene project
Key: SOLR-14994
URL: https://issues.apache.org/jira/browse/SOLR-14994
Project: Solr
Issue Type: Task
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228852#comment-17228852
]
Mark Robert Miller commented on SOLR-14788:
---
This Overseer work (release it fro
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228852#comment-17228852
]
Mark Robert Miller edited comment on SOLR-14788 at 11/9/20, 11:16 PM:
-
madrob commented on a change in pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r520198395
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java
##
@@ -334,11 +334,6 @@ private StreamComparator parseCo
jtibshirani opened a new pull request #2071:
URL: https://github.com/apache/lucene-solr/pull/2071
* Make sure the files are unique by renaming the term vectors extension to
`tvc`.
* Fix a bug where reading a vector would drop the leading digit of the first
element.
---
jtibshirani commented on pull request #2071:
URL: https://github.com/apache/lucene-solr/pull/2071#issuecomment-724386681
I found these issues while fixing the following failing test:
```
./gradlew test --tests TestSortingCodecReader.testSortOnAddIndicesRandom
-Dtests.seed=B38EBA45
msokolov commented on a change in pull request #2071:
URL: https://github.com/apache/lucene-solr/pull/2071#discussion_r520253512
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextVectorReader.java
##
@@ -245,8 +245,8 @@ private void readAllVect
msokolov merged pull request #2071:
URL: https://github.com/apache/lucene-solr/pull/2071
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228945#comment-17228945
]
ASF subversion and git services commented on LUCENE-9322:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228951#comment-17228951
]
ASF subversion and git services commented on LUCENE-9322:
-
Commi
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r520268743
##
File path: lucene/misc/src/java/org/apache/lucene/store/DirectIODirectory.java
##
@@ -66,45 +66,32 @@
*
* @lucene.experimental
*/
-public
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r520268743
##
File path: lucene/misc/src/java/org/apache/lucene/store/DirectIODirectory.java
##
@@ -66,45 +66,32 @@
*
* @lucene.experimental
*/
-public
zacharymorn commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r520270563
##
File path: lucene/misc/native/build.gradle
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-724434703
> Zach I've cleaned up the native build a bit - moved it under lucene/misc,
added Windows build (it does build the native library for me). I didn't check
whether it work
zacharymorn commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r520273368
##
File path: lucene/misc/native/build.gradle
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
[
https://issues.apache.org/jira/browse/LUCENE-9590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228980#comment-17228980
]
Lu Xugang commented on LUCENE-9590:
---
here the
link：https://www.amazingkoala.com.cn/Lu
80 matches
Mail list logo
