mikemccand commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520024634
##########
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene80/BaseLucene80DocValuesFormatTestCase.java
##########
@@ -286,7 +278,7 @@ private void doTestTermsEnumRandom(int numDocs,
Supplier<String> valuesProducer)
conf.setMergeScheduler(new SerialMergeScheduler());
// set to duel against a codec which has ordinals:
final PostingsFormat pf = TestUtil.getPostingsFormatWithOrds(random());
- final DocValuesFormat dv = new Lucene80DocValuesFormat();
+ final DocValuesFormat dv = getCodec().docValuesFormat();
Review comment:
Will this randomize between the different `Mode` tradeoffs?
##########
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene87/Lucene87Codec.java
##########
@@ -56,6 +57,23 @@
* @lucene.experimental
*/
public class Lucene87Codec extends Codec {
+
+ /** Configuration option for the codec. */
+ public static enum Mode {
+ /** Trade compression ratio for retrieval speed. */
+ BEST_SPEED(Lucene87StoredFieldsFormat.Mode.BEST_SPEED,
Lucene80DocValuesFormat.Mode.BEST_SPEED),
+ /** Trade retrieval speed for compression ratio. */
+ BEST_COMPRESSION(Lucene87StoredFieldsFormat.Mode.BEST_COMPRESSION,
Lucene80DocValuesFormat.Mode.BEST_COMPRESSION);
+
+ private final Lucene87StoredFieldsFormat.Mode storedMode;
+ private final Lucene80DocValuesFormat.Mode dvMode;
+
+ private Mode(Lucene87StoredFieldsFormat.Mode storedMode,
Lucene80DocValuesFormat.Mode dvMode) {
Review comment:
Nice! So we roll up the tradeoffs to Codec level which will then tell
each format how to tradeoff.
##########
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene80/TestBestSpeedLucene80DocValuesFormat.java
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.codecs.lucene80;
+
+import org.apache.lucene.codecs.Codec;
+import org.apache.lucene.util.TestUtil;
+
+/**
+ * Tests Lucene80DocValuesFormat
+ */
+public class TestBestSpeedLucene80DocValuesFormat extends
BaseLucene80DocValuesFormatTestCase {
Review comment:
Do we also have a dedicated `TestBestCompressedLucene80DocValuesFormat`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
