[GitHub] [lucene-solr] dweiss commented on a change in pull request #1950: LUCENE-9564: add spotless and gjf.

2020-10-08 Thread GitBox
dweiss commented on a change in pull request #1950: URL: https://github.com/apache/lucene-solr/pull/1950#discussion_r501492773 ## File path: gradle/validation/spotless.gradle ## @@ -0,0 +1,31 @@ + +def resources = scriptResources(buildscript) + +allprojects { prj -> + plugins

[jira] [Created] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2020-10-08 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9570: --- Summary: Review code diffs after automatic formatting and correct problems before it is applied Key: LUCENE-9570 URL: https://issues.apache.org/jira/browse/LUCENE-9570

[jira] [Created] (LUCENE-9571) Handle generated files (exclude from automated formatting)

2020-10-08 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9571: --- Summary: Handle generated files (exclude from automated formatting) Key: LUCENE-9571 URL: https://issues.apache.org/jira/browse/LUCENE-9571 Project: Lucene - Core

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1950: LUCENE-9564: add spotless and gjf.

2020-10-08 Thread GitBox
rmuir commented on a change in pull request #1950: URL: https://github.com/apache/lucene-solr/pull/1950#discussion_r501511928 ## File path: gradle/validation/spotless.gradle ## @@ -0,0 +1,31 @@ + +def resources = scriptResources(buildscript) + +allprojects { prj -> + plugins.

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1950: LUCENE-9564: add spotless and gjf.

2020-10-08 Thread GitBox
dweiss commented on a change in pull request #1950: URL: https://github.com/apache/lucene-solr/pull/1950#discussion_r501519479 ## File path: gradle/validation/spotless.gradle ## @@ -0,0 +1,31 @@ + +def resources = scriptResources(buildscript) + +allprojects { prj -> + plugins

[jira] [Resolved] (SOLR-14691) Metrics reporting should avoid creating objects

2020-10-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14691. - Resolution: Fixed Thanks Noble for review and fixes. > Metrics reporting should avoid cr

[GitHub] [lucene-solr] sigram opened a new pull request #1962: SOLR-14749 Provide a clean API for cluster-level event processing

2020-10-08 Thread GitBox
sigram opened a new pull request #1962: URL: https://github.com/apache/lucene-solr/pull/1962 This is just the API part of the ticket, separated from PR-1758 to facilitate reviews of pure API. This is an automated message fro

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

2020-10-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210131#comment-17210131 ] Andrzej Bialecki commented on SOLR-14749: - [~noble.paul] please see PR-1962 that

[GitHub] [lucene-solr] sigram commented on pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-08 Thread GitBox
sigram commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-705484706 Merged - thanks! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] sigram closed pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-08 Thread GitBox
sigram closed pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

2020-10-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210134#comment-17210134 ] Noble Paul commented on SOLR-14749: --- [~ab] The APIs themselves are pretty clean . Can

[GitHub] [lucene-solr] noblepaul commented on pull request #1953: SOLR-14917: Move DOMUtil and PropertiesUtil to SolrJ

2020-10-08 Thread GitBox
noblepaul commented on pull request #1953: URL: https://github.com/apache/lucene-solr/pull/1953#issuecomment-705486732 I have no objection to moving them. But is there any particular reason why you wish to move them?

[jira] [Resolved] (SOLR-14094) TestSolrCachePerf is flaky

2020-10-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14094. - Fix Version/s: master (9.0) Resolution: Fixed This hasn't been failing for a while

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210149#comment-17210149 ] ASF subversion and git services commented on SOLR-14576: Commit 8

[GitHub] [lucene-solr] noblepaul opened a new pull request #1963: SOLR-14827: Refactor schema loading to not use XPath

2020-10-08 Thread GitBox
noblepaul opened a new pull request #1963: URL: https://github.com/apache/lucene-solr/pull/1963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

2020-10-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210165#comment-17210165 ] Andrzej Bialecki commented on SOLR-14749: - [~noble.paul]  PR-1964 contains just t

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

2020-10-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210168#comment-17210168 ] Noble Paul commented on SOLR-14749: --- Thanks [~ab] . I shall review it soon > Provide a

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210154#comment-17210154 ] ASF subversion and git services commented on SOLR-14576: Commit a

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210157#comment-17210157 ] ASF subversion and git services commented on SOLR-14576: Commit a

[jira] [Created] (SOLR-14920) Format code automatically and enforce it in Solr

2020-10-08 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14920: - Summary: Format code automatically and enforce it in Solr Key: SOLR-14920 URL: https://issues.apache.org/jira/browse/SOLR-14920 Project: Solr Issue Type: I

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210159#comment-17210159 ] ASF subversion and git services commented on SOLR-14576: Commit a

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210160#comment-17210160 ] ASF subversion and git services commented on SOLR-14576: Commit a

[jira] [Commented] (SOLR-14576) HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210161#comment-17210161 ] ASF subversion and git services commented on SOLR-14576: Commit a

[GitHub] [lucene-solr] sigram opened a new pull request #1964: SOLR-14749: Cluster singleton part of PR-1785

2020-10-08 Thread GitBox
sigram opened a new pull request #1964: URL: https://github.com/apache/lucene-solr/pull/1964 This is just the `ClusterSingleton` part, with an example implementation that loads the ClusterSingleton plugins via `CustomerContainerPlugins` API. See `TestContainerPlugin` to see how it works.

[GitHub] [lucene-solr] dsmiley commented on pull request #1953: SOLR-14917: Move DOMUtil and PropertiesUtil to SolrJ

2020-10-08 Thread GitBox
dsmiley commented on pull request #1953: URL: https://github.com/apache/lucene-solr/pull/1953#issuecomment-705546872 I leave JIRA for context/motivation and PRs for the details, and so my PRs are often lacking anything other than a JIRA link. This issue, SOLR-14917 is a child task of http

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #1963: SOLR-14827: Refactor schema loading to not use XPath

2020-10-08 Thread GitBox
muse-dev[bot] commented on a change in pull request #1963: URL: https://github.com/apache/lucene-solr/pull/1963#discussion_r501702700 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -474,23 +481,28 @@ protected Analyzer getWrappedAnalyzer(String f

[GitHub] [lucene-solr] noblepaul merged pull request #1586: SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap

2020-10-08 Thread GitBox
noblepaul merged pull request #1586: URL: https://github.com/apache/lucene-solr/pull/1586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14787) Inequality support in Payload Check query parser

2020-10-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210252#comment-17210252 ] Gus Heck commented on SOLR-14787: - New Syntax with latest change (one less parameter, can

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210254#comment-17210254 ] Chris M. Hostetter commented on SOLR-14870: --- {quote}...If you can make it work

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210262#comment-17210262 ] Uwe Schindler commented on SOLR-14870: -- Hi [~hossman], the javadocs wont change anym

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210264#comment-17210264 ] Dawid Weiss commented on SOLR-14870: bq. with that possibility in mind i'm now less

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210265#comment-17210265 ] Uwe Schindler commented on SOLR-14870: -- bq. My opinion on the matter is that moving

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210268#comment-17210268 ] Chris M. Hostetter commented on SOLR-14870: --- {quote}My opinion on the matter is

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210277#comment-17210277 ] Dawid Weiss commented on SOLR-14870: For the record - you can also write precompiled

[jira] [Commented] (SOLR-14759) Separate the Lucene and Solr builds

2020-10-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210281#comment-17210281 ] Dawid Weiss commented on SOLR-14759: I took a tentative look at how difficult it woul

[jira] [Created] (LUCENE-9572) Allow TypeAsSynonymFilter to propagate selected flags and Ignore some types

2020-10-08 Thread Gus Heck (Jira)
Gus Heck created LUCENE-9572: Summary: Allow TypeAsSynonymFilter to propagate selected flags and Ignore some types Key: LUCENE-9572 URL: https://issues.apache.org/jira/browse/LUCENE-9572 Project: Lucene -

[jira] [Commented] (SOLR-14759) Separate the Lucene and Solr builds

2020-10-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210287#comment-17210287 ] Ishan Chattopadhyaya commented on SOLR-14759: - This sounds very cool! Can we

[jira] [Created] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

2020-10-08 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-9573: --- Summary: Add back compat tests for VectorFormat to TestBackwardsCompatibility Key: LUCENE-9573 URL: https://issues.apache.org/jira/browse/LUCENE-9573 Project: L

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-08 Thread GitBox
msokolov commented on a change in pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r501828351 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210303#comment-17210303 ] Uwe Schindler commented on SOLR-14870: -- I don't think in the current state we should

[GitHub] [lucene-solr] gus-asf opened a new pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-08 Thread GitBox
gus-asf opened a new pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-08 Thread Gus Heck (Jira)
Gus Heck created LUCENE-9574: Summary: Add a token filter to drop tokens based on flags. Key: LUCENE-9574 URL: https://issues.apache.org/jira/browse/LUCENE-9574 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated LUCENE-9574: - Description: (Breaking this off of SOLR-14597 for independent review) A filter that tests flags on toke

[jira] [Commented] (LUCENE-9572) Allow TypeAsSynonymFilter to propagate selected flags and Ignore some types

2020-10-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210332#comment-17210332 ] Gus Heck commented on LUCENE-9572: -- Since this is blocking SIP-9 and SOLR-14597 I'll be

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210333#comment-17210333 ] Gus Heck commented on LUCENE-9574: -- One interesting corner case came up when the first

[GitHub] [lucene-solr] gus-asf opened a new pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
gus-asf opened a new pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210335#comment-17210335 ] Gus Heck commented on LUCENE-9574: -- Since this is blocking SIP-9 and SOLR-14597 I'll be

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #1930: LUCENE-9322: add VectorValues to new Lucene90 codec

2020-10-08 Thread GitBox
muse-dev[bot] commented on a change in pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r501886824 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -562,6 +614,12 @@ private int processField(int docID, Indexa

[GitHub] [lucene-solr] uschindler commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
uschindler commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705717342 Hi @madrob are you planning to further work on this. I have seen one TODO regarding a README. If you don't have time, I can merge this and enable Jenkins Artifact builds.

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
uschindler edited a comment on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705717342 Hi @madrob are you planning to further work on this? I have seen one TODO regarding a README. If you don't have time, I can merge this and enable Jenkins Artifact

[jira] [Created] (LUCENE-9575) Add PatternTypingFilter

2020-10-08 Thread Gus Heck (Jira)
Gus Heck created LUCENE-9575: Summary: Add PatternTypingFilter Key: LUCENE-9575 URL: https://issues.apache.org/jira/browse/LUCENE-9575 Project: Lucene - Core Issue Type: New Feature Com

[jira] [Commented] (LUCENE-9572) Allow TypeAsSynonymFilter to propagate selected flags and Ignore some types

2020-10-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210350#comment-17210350 ] Gus Heck commented on LUCENE-9572: -- The test framework changes in this ticket are also

[GitHub] [lucene-solr] rmuir commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
rmuir commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705724494 please use https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/analysis/FilteringTokenFilter.java as a subclass and just implement accept(

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705735154 Yes, @rmuir is right. The TokenFilter should only subclass FilteringTokenFilter and implement accept(). By that all logic is obsolete and it get's a one-liner. I a

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705736515 The fillter token is obsolete. If you implement FilteringTokenFilter's accept don't try to inject tokens like this. Tests will pass.

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705738171 The problem why you hit the exception is wrong implementation. Don't look at tokens before calling incrementToken(). In addition, you must call addAttribute() before th

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on a change in pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#discussion_r501917428 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/DropIfFlaggedFilter.java ## @@ -0,0 +1,90 @@ +/* + * Licens

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on a change in pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#discussion_r501917428 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/DropIfFlaggedFilter.java ## @@ -0,0 +1,90 @@ +/* + * Licens

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705749147 FilteringTokenFilter also corrects positions. No filler tokens needed. This is an automated message from

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705753920 This would be your filter, plain simple, correct positions, no fillter tokens needed. All bug-specific tests are obsolete, as this type of Filter is tested to hell (we ha

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on a change in pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#discussion_r501937630 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/DropIfFlaggedFilter.java ## @@ -0,0 +1,90 @@ +/* + * Licens

[GitHub] [lucene-solr] gus-asf commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
gus-asf commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705761838 HI @uschindler , your comments sound like you think I will be unwilling to take feedback. I'm not sure why you feel this way and seem to need to say the same thing repeatedl

[GitHub] [lucene-solr] gus-asf edited a comment on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
gus-asf edited a comment on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705761838 HI @uschindler , your comments sound like you think I will be unwilling to take feedback. I'm not sure why you feel this way and seem to need to say the same thing re

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705765924 Read the code if FilteringTokenFilter. It will fix the positions. What you describes is not an issue, as this also affects StopFilter or others. If the first token

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-10-08 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210401#comment-17210401 ] Cassandra Targett commented on SOLR-14588: -- [~atris], This issue is marked as fi

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705768959 Your filter does not handle positions at all, so it will also corrupt the graph of later tokens are removed. It's a state machine and you have to understand it. Your pr

[GitHub] [lucene-solr] madrob commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
madrob commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705772790 Rebasing, squashing, and pushing later today This is an automated message from the Apache Git Service. To res

[GitHub] [lucene-solr] uschindler commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
uschindler commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705773298 You can just click the button... This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] madrob merged pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
madrob merged pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210411#comment-17210411 ] ASF subversion and git services commented on LUCENE-9488: - Commi

[GitHub] [lucene-solr] uschindler commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
uschindler commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705777022 Thanks. I will soon activate jenkins jobs. 👍🏻😉 This is an automated message from the Apache Git Service.

[jira] [Commented] (SOLR-14759) Separate the Lucene and Solr builds

2020-10-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210426#comment-17210426 ] Dawid Weiss commented on SOLR-14759: We don't need to wait This only affects mast

[GitHub] [lucene-solr] uschindler commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
uschindler commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705788992 Lucene artifact builds work: https://ci-builds.apache.org/job/Lucene/job/Lucene-Artifacts-master/ What's missing ist src.tgz files,are they not yet handled or do I

[GitHub] [lucene-solr] madrob commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
madrob commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705790424 They're not handled yet, I suspect we should just be doing `git archive` rather than defining a gradle task, but I'll have more time to follow up next week

[jira] [Created] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS volume.

2020-10-08 Thread Girish Nayak (Jira)
Girish Nayak created LUCENE-9576: Summary: IndexWriter::commit() hangs when the server has a stale NFS volume. Key: LUCENE-9576 URL: https://issues.apache.org/jira/browse/LUCENE-9576 Project: Lucene -

[GitHub] [lucene-solr] dweiss commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
dweiss commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705794061 This isn't so easy as the current gradle build can't be separated into Lucene and Solr-only parts (as it was the case with ant). We could distribute everything (Solr and Luce

[GitHub] [lucene-solr] uschindler commented on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
uschindler commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705795294 Yeah. At the moment both artifacts in source form would be the same. So I agree, just zip too level. At Ant times Solr always was also a combined zip. Lucene was ju

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-08 Thread GitBox
uschindler edited a comment on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-705795294 Yeah. At the moment both artifacts in source form would be the same. So I agree, just zip top level. At Ant times Solr always was also a combined zip. Lucene

[jira] [Commented] (SOLR-14759) Separate the Lucene and Solr builds

2020-10-08 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210433#comment-17210433 ] Anshum Gupta commented on SOLR-14759: - Thanks for doing this, [~dweiss]! This looks

[jira] [Commented] (SOLR-14759) Separate the Lucene and Solr builds

2020-10-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210437#comment-17210437 ] Jan Høydahl commented on SOLR-14759: This is encouraging. There's nothing wrong with

[jira] [Updated] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS volume.

2020-10-08 Thread Girish Nayak (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Girish Nayak updated LUCENE-9576: - Attachment: IndexWriter-commit.PNG > IndexWriter::commit() hangs when the server has a stale NFS

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS volume.

2020-10-08 Thread Girish Nayak (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210439#comment-17210439 ] Girish Nayak commented on LUCENE-9576: -- See IndexWriter-commit.PNG for call stack.

[jira] [Updated] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-08 Thread Girish Nayak (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Girish Nayak updated LUCENE-9576: - Summary: IndexWriter::commit() hangs when the server has a stale NFS mount. (was: IndexWriter::

[jira] [Commented] (SOLR-14656) Deprecate current autoscaling framework, remove from master

2020-10-08 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210445#comment-17210445 ] Cassandra Targett commented on SOLR-14656: -- [~ab], I notice this is not in CHANG

[jira] [Commented] (SOLR-14708) Backward-Compatible Replication

2020-10-08 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210455#comment-17210455 ] Cassandra Targett commented on SOLR-14708: -- [~tflobbe], [~marcussorealheis] - th

[jira] [Comment Edited] (SOLR-14708) Backward-Compatible Replication

2020-10-08 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210455#comment-17210455 ] Cassandra Targett edited comment on SOLR-14708 at 10/8/20, 9:06 PM: ---

[GitHub] [lucene-solr] gus-asf edited a comment on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
gus-asf edited a comment on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705761838 HI @uschindler , your comments sound like you think I will be unwilling to take feedback. I'm not sure why you feel this way and seem to need to say the same thing re

[GitHub] [lucene-solr] gus-asf edited a comment on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
gus-asf edited a comment on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705761838 HI @uschindler , your comments sound like you think I will be unwilling to take feedback. I'm not sure why you feel this way and seem to need to say the same thing re

[GitHub] [lucene-solr] uschindler commented on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705832388 Hi maybe let me explain it: With the filter how you implemented it originally, you have the problem of the first token (that has a synonym) leading to a 0 position incr

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler edited a comment on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705832388 Hi maybe let me explain it: With the filter how you implemented it originally, you have the problem of the first token (that has a synonym) leading to a 0 positi

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1966: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-08 Thread GitBox
uschindler edited a comment on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705832388 Hi maybe let me explain it: With the filter how you implemented it originally, you have the problem of the first token (that has a synonym) leading to a 0 positi

[jira] [Resolved] (LUCENE-9474) Change Jenkins jobs to use Gradle for trunk

2020-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9474. --- Resolution: Fixed All jobs are now using Gradle. Obsolete Jobs removed. > Change Jenkins jo

[jira] [Commented] (SOLR-14659) Remove restlet from Solr

2020-10-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210484#comment-17210484 ] ASF subversion and git services commented on SOLR-14659: Commit 0

[jira] [Created] (LUCENE-9577) Move HTML Documentation to a separate subproject

2020-10-08 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-9577: - Summary: Move HTML Documentation to a separate subproject Key: LUCENE-9577 URL: https://issues.apache.org/jira/browse/LUCENE-9577 Project: Lucene - Core Is

[GitHub] [lucene-solr] msokolov commented on pull request #1961: LUCENE-9567: JPOSSFF loads built-in stop tags by default

2020-10-08 Thread GitBox
msokolov commented on pull request #1961: URL: https://github.com/apache/lucene-solr/pull/1961#issuecomment-705849891 looks good - I will merge soon if nobody objects This is an automated message from the Apache Git Service.

[jira] [Commented] (SOLR-14708) Backward-Compatible Replication

2020-10-08 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210498#comment-17210498 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14708: -- bq. If I und

[GitHub] [lucene-solr] uschindler opened a new pull request #1967: LUCENE-9577: Move Lucene/Solr Documentation assembly to subproject

2020-10-08 Thread GitBox
uschindler opened a new pull request #1967: URL: https://github.com/apache/lucene-solr/pull/1967 This PR moves the changes.txt formatting, site Javadocs, markdown formatting to subprojects (`:lucene:documentation`, `:solr:documentation`. This is still WIP, not everything works. ---

[jira] [Commented] (LUCENE-9577) Move HTML Documentation to a separate subproject

2020-10-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210520#comment-17210520 ] Uwe Schindler commented on LUCENE-9577: --- First draft PR: https://github.com/apache

[GitHub] [lucene-solr] uschindler commented on pull request #1967: LUCENE-9577: Move Lucene/Solr Documentation assembly to subproject

2020-10-08 Thread GitBox
uschindler commented on pull request #1967: URL: https://github.com/apache/lucene-solr/pull/1967#issuecomment-705884519 This also removed some unnecessary assets from Solr's documentation. Those are leftovers from time before the refguide was included.

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210553#comment-17210553 ] Robert Muir commented on LUCENE-9576: - It hangs in JDK code trying to access the Fil

  1   2   >