muse-dev[bot] commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r501886824



##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java
##########
@@ -562,6 +614,12 @@ private int processField(int docID, IndexableField field, 
long fieldGen, int fie
       }
       indexPoint(docID, fp, field);
     }
+    if (fieldType.vectorDimension() != 0) {
+      if (fp == null) {
+        fp = getOrAddField(fieldName, fieldType, false);
+      }
+      indexVector(docID, fp, field);

Review comment:
       *NULL_DEREFERENCE:*  object `fp` last assigned on line 619 could be null 
and is dereferenced by call to `indexVector(...)` at line 621.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to