uschindler commented on pull request #1966:
URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705735154


   Yes, @rmuir is right. The TokenFilter should only subclass 
FilteringTokenFilter and implement accept(). By that all logic is obsolete and 
it get's a one-liner.
   
   I am not sure what SecureRandom or UUID has to do here. We should maybe 
allow to pass fillter token as parameter. If not given maybe default to empty 
token?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to