[
https://issues.apache.org/jira/browse/LUCENE-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207906#comment-17207906
]
Alan Woodward commented on LUCENE-9560:
---
Interval queries should already allow you
mocobeta commented on pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946#issuecomment-703493569
> BTW I stumbled on this split-package javadoc issue trying to add some
utilities in lucene/misc/src/java/org/apache/lucene/util/hnsw - I guess I won't
do that, but I wonde
mocobeta edited a comment on pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946#issuecomment-703493569
> BTW I stumbled on this split-package javadoc issue trying to add some
utilities in lucene/misc/src/java/org/apache/lucene/util/hnsw - I guess I won't
do that, but
[
https://issues.apache.org/jira/browse/LUCENE-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207923#comment-17207923
]
ASF subversion and git services commented on LUCENE-9558:
-
Commi
mocobeta merged pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-9558.
---
Fix Version/s: master (9.0)
Resolution: Fixed
> Clean up package name conflicts for a
iverase commented on pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907#issuecomment-703526645
Performance test shows a small impact in indexing performance:
```
Index time (sec)||Force merge time (sec)||Index size (GB)||Reader heap (MB)||
||Dev||Base||Diff
[
https://issues.apache.org/jira/browse/LUCENE-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207983#comment-17207983
]
Michael McCandless commented on LUCENE-9560:
+1 to make this simpler. The c
mayya-sharipova commented on a change in pull request #1937:
URL: https://github.com/apache/lucene-solr/pull/1937#discussion_r499499532
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestConjunctionDISI.java
##
@@ -391,4 +391,20 @@ public void testCollapseSubConju
mayya-sharipova commented on a change in pull request #1937:
URL: https://github.com/apache/lucene-solr/pull/1937#discussion_r499499632
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestConjunctionDISI.java
##
@@ -391,4 +391,20 @@ public void testCollapseSubConju
[
https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova updated LUCENE-9541:
Summary: Ensure sub-iterators of ConjunctionDISI are on the same document
(was: BitSetCon
mikemccand commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499232347
##
File path: .dir-locals.el
##
@@ -0,0 +1,3 @@
+;; set up Lucene style for emacs
+((java-mode . ((c-basic-offset . 2
Review comment:
W
[
https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208083#comment-17208083
]
ASF subversion and git services commented on LUCENE-9541:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208084#comment-17208084
]
ASF subversion and git services commented on LUCENE-9541:
-
Commi
mayya-sharipova merged pull request #1937:
URL: https://github.com/apache/lucene-solr/pull/1937
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
gezapeti opened a new pull request #1947:
URL: https://github.com/apache/lucene-solr/pull/1947
# Description
The Solr admin UI currently uses JQuery 3.4.1 (SOLR-14209). JQuery 3.5.1 is
out and addresses some security vulnerabilities. It would be good to upgrade.
# Solution
[
https://issues.apache.org/jira/browse/SOLR-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208102#comment-17208102
]
Gézapeti commented on SOLR-14887:
-
I've found a reference to jquery 2.1.3 in our owasp ch
dsmiley commented on a change in pull request #1921:
URL: https://github.com/apache/lucene-solr/pull/1921#discussion_r499647440
##
File path: solr/solr-ref-guide/src/common-query-parameters.adoc
##
@@ -307,11 +307,13 @@ The `echoParams` parameter controls what information
abou
arafalov commented on a change in pull request #1921:
URL: https://github.com/apache/lucene-solr/pull/1921#discussion_r499658300
##
File path: solr/solr-ref-guide/src/common-query-parameters.adoc
##
@@ -307,11 +307,13 @@ The `echoParams` parameter controls what information
abo
[
https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208122#comment-17208122
]
ASF subversion and git services commented on LUCENE-9541:
-
Commi
madrob edited a comment on pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-703715598
> Are we sure we need dependency at all. I would have assumed that Gradle
has it already.
Gradle has a shaded commons codec that we can use -
`org.gradle.intern
madrob commented on pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-703715598
> Are we sure we need dependency at all. I would have assumed that Gradle
has it already.
Gradle has a shaded commons codec that we can use -
`org.gradle.internal.impl
dweiss commented on pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-703718577
Yup, don't use internal* - not a good idea. As for gradle API - I don't
think it'll be easy to apply forbidden APIs here?
---
uschindler commented on pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-703723514
You can apply forbiddenapis to groovy or gradle code. But for that you need
to have everything compiled to build-src./build/classes With adhoc scripts it
wont work.
---
Johannes Baiter created SOLR-14913:
--
Summary: Including non-existing field in edismax field alias
breaks parsing of boolean query
Key: SOLR-14913
URL: https://issues.apache.org/jira/browse/SOLR-14913
[
https://issues.apache.org/jira/browse/SOLR-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Baiter updated SOLR-14913:
---
Description:
When including a non-existing field in a {{f..qf}} field alias, boolean
queries
dweiss commented on pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-703725625
That's what I though.
On Mon, Oct 5, 2020 at 5:55 PM Uwe Schindler
wrote:
> You can apply forbiddenapis to groovy or gradle code. But for that you
> need t
[
https://issues.apache.org/jira/browse/SOLR-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Baiter updated SOLR-14913:
---
Description:
When including a non-existing field in a {{f..qf}} field alias, boolean
queries
uschindler commented on pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-703727019
Nevertheless, there's still a forbiddenapis issue: When writing the SHA512
file, we don't apply charset, it's platform dependent.
---
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499709502
##
File path: gradle/releasing.gradle
##
@@ -0,0 +1,58 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
iverase commented on pull request #1940:
URL: https://github.com/apache/lucene-solr/pull/1940#issuecomment-703744381
@rmuir, I am trying to understand why adding this new API seems so
problematic, I would be more incline to deprecate `newPolygonQuery` in favour
of this new one. My feeling
danmuzi commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499759537
##
File path: gradle/releasing.gradle
##
@@ -0,0 +1,58 @@
+
Review comment:
minor comment but unnecessary blank line :)
--
danmuzi commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499759537
##
File path: gradle/releasing.gradle
##
@@ -0,0 +1,58 @@
+
Review comment:
minor comment but there is an unnecessary blank line :)
--
msokolov commented on pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#issuecomment-703831393
Thanks for the extensive comments, @mikemccand - I'll address soon with an
updated PR.
I also found some bugs in implementations of the random access interface,
and
jtibshirani opened a new pull request #1948:
URL: https://github.com/apache/lucene-solr/pull/1948
For doc values that are not too high cardinality, it is common for some large
segments to contain all distinct values. In this case, we can check if the
first
segment ords map perfectly t
jtibshirani commented on pull request #1948:
URL: https://github.com/apache/lucene-solr/pull/1948#issuecomment-703871852
I used `TestOrdinalMap` to test a map with 10,000 terms in a scenario and
~10 segments. In the scenario where one segment contains all ordinal values, it
shows a small i
msokolov edited a comment on pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#issuecomment-703872279
> Thank you for ... the tests catching mis-use where user tries to change
dimension or scoring function in an existing field.
Thanks to @mocobeta for those; I
msokolov commented on pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#issuecomment-703872279
> Thank you for ... the tests catching mis-use where user tries to change
dimension or scoring function in an existing field.
Thanks to @mocobeta for those; I was able to
msokolov commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499858704
##
File path: lucene/core/src/java/org/apache/lucene/codecs/VectorWriter.java
##
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache Software Foundation
msokolov commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499858704
##
File path: lucene/core/src/java/org/apache/lucene/codecs/VectorWriter.java
##
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache Software Foundation
jtibshirani edited a comment on pull request #1948:
URL: https://github.com/apache/lucene-solr/pull/1948#issuecomment-703871852
I used `TestOrdinalMap` to test a map with 10,000 terms and ~10 segments. In
the scenario where one segment contains all ordinal values, it shows a small
improvem
msokolov commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499862666
##
File path: lucene/core/src/java/org/apache/lucene/document/FieldType.java
##
@@ -351,6 +356,27 @@ public int pointNumBytes() {
return dimensi
msokolov commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499863809
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -374,7 +377,25 @@ private FieldNormStatus() {
/** Total numbe
mayya-sharipova commented on pull request #1943:
URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914
@jpountz Sorry for the noise, I have found the cause of this error, and the
latest commit addresses it.
[
https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208315#comment-17208315
]
Cassandra Targett commented on SOLR-14802:
--
[~dsmiley], [~spstorey] - I noticed
[
https://issues.apache.org/jira/browse/SOLR-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208321#comment-17208321
]
ASF subversion and git services commented on SOLR-13438:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208323#comment-17208323
]
ASF subversion and git services commented on SOLR-13438:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208332#comment-17208332
]
David Smiley commented on SOLR-14802:
-
the spatial-search.adoc page already documents
[
https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208333#comment-17208333
]
Shaun Storey commented on SOLR-14802:
-
Hi, [~ctargett] the change has just restored p
JohnHillegass opened a new pull request #1949:
URL: https://github.com/apache/lucene-solr/pull/1949
By default, jinja2 sets autoescape to False. Consider using autoescape=True
to mitigate XSS vulnerabilities.
# Description
Please provide a short description of the
msokolov commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499891879
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -0,0 +1,326 @@
+/*
+ * Licensed to the Apache S
msokolov commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499893497
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextVectorReader.java
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Ap
mayya-sharipova edited a comment on pull request #1943:
URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914
@jpountz Sorry for the noise, I have found the cause of this error, and the
latest commit addresses it.
Basically this PR will just address the failing test
msokolov commented on a change in pull request #1930:
URL: https://github.com/apache/lucene-solr/pull/1930#discussion_r499898687
##
File path: lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed to the Apache Software Found
[
https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208366#comment-17208366
]
Cassandra Targett commented on SOLR-14802:
--
Thanks to you both, that clears up m
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499901026
##
File path: solr/packaging/build.gradle
##
@@ -115,15 +121,15 @@ distributions {
into "server"
})
+ from(configurations.do
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499902511
##
File path: solr/packaging/build.gradle
##
@@ -115,15 +121,15 @@ distributions {
into "server"
})
+ from(configurations.do
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499903030
##
File path: solr/packaging/build.gradle
##
@@ -115,15 +121,15 @@ distributions {
into "server"
})
+ from(configurations.do
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499902932
##
File path: lucene/packaging/build.gradle
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499904208
##
File path: solr/packaging/build.gradle
##
@@ -62,12 +63,17 @@ dependencies {
example project(path: ":solr:example", configuration: "packagi
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499905487
##
File path: solr/packaging/build.gradle
##
@@ -62,12 +63,17 @@ dependencies {
example project(path: ":solr:example", configuration: "packagi
uschindler commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r499905829
##
File path: solr/packaging/build.gradle
##
@@ -115,15 +121,15 @@ distributions {
into "server"
})
+ from(configurations.do
[
https://issues.apache.org/jira/browse/LUCENE-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208416#comment-17208416
]
Gautam Worah commented on LUCENE-9540:
--
It turns out that we are not double indexin
[
https://issues.apache.org/jira/browse/LUCENE-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah resolved LUCENE-9476.
--
Resolution: Not A Problem
> Add a bulk ordinal->FacetLabel API
> -
[
https://issues.apache.org/jira/browse/LUCENE-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah reopened LUCENE-9476:
--
> Add a bulk ordinal->FacetLabel API
> --
>
> Key:
[
https://issues.apache.org/jira/browse/LUCENE-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah resolved LUCENE-9540.
--
Resolution: Not A Problem
> Investigate double indexing of the fullPathField in the
> Directo
David Smiley created LUCENE-9563:
Summary: Add .editorConfig
Key: LUCENE-9563
URL: https://issues.apache.org/jira/browse/LUCENE-9563
Project: Lucene - Core
Issue Type: Task
Report
[
https://issues.apache.org/jira/browse/LUCENE-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208424#comment-17208424
]
David Smiley commented on LUCENE-9493:
--
I filed LUCENE-9563 for a ".editorConfig" w
[
https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-14870:
--
Attachment: SOLR-14870.patch
Assignee: Chris M. Hostetter
Status: Open (w
dweiss commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500041550
##
File path: lucene/packaging/build.gradle
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contrib
dweiss commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500041959
##
File path: solr/packaging/build.gradle
##
@@ -62,12 +63,17 @@ dependencies {
example project(path: ":solr:example", configuration: "packaging")
dweiss commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500042473
##
File path: solr/packaging/build.gradle
##
@@ -115,15 +121,15 @@ distributions {
into "server"
})
+ from(configurations.docs,
72 matches
Mail list logo
