msokolov commented on pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#issuecomment-703831393
Thanks for the extensive comments, @mikemccand - I'll address soon with an updated PR. I also found some bugs in implementations of the random access interface, and I want to fix those and enhance the test coverage. Mainly, they were incorrectly sharing state with the enclosing iterators, which causes issues if you simultaneously iterate and access randomly. There were also a couple of bugs dealing with empty segments that apparently weren't caught by testRandom. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
