[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1720: SOLR-14712 Standardize RPC calls in Solr

2020-08-07 Thread GitBox
noblepaul commented on a change in pull request #1720: URL: https://github.com/apache/lucene-solr/pull/1720#discussion_r466858651 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java ## @@ -478,4 +479,11 @@ public Builder getThis() {

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1720: SOLR-14712 Standardize RPC calls in Solr

2020-08-07 Thread GitBox
noblepaul commented on a change in pull request #1720: URL: https://github.com/apache/lucene-solr/pull/1720#discussion_r466859745 ## File path: solr/solrj/src/java/org/apache/solr/common/util/RpcFactory.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r466860061 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r466862155 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AddReplicasRequest.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1720: SOLR-14712 Standardize RPC calls in Solr

2020-08-07 Thread GitBox
noblepaul commented on a change in pull request #1720: URL: https://github.com/apache/lucene-solr/pull/1720#discussion_r466860388 ## File path: solr/solrj/src/java/org/apache/solr/common/util/CallRouter.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1720: SOLR-14712 Standardize RPC calls in Solr

2020-08-07 Thread GitBox
noblepaul commented on a change in pull request #1720: URL: https://github.com/apache/lucene-solr/pull/1720#discussion_r466859745 ## File path: solr/solrj/src/java/org/apache/solr/common/util/RpcFactory.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r466864602 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Commented] (SOLR-14708) Backward-Compatible Replication

2020-08-07 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172946#comment-17172946 ] Marcus Eagan commented on SOLR-14708: - so far, [~tflobbe] test Case A fails in a few

[jira] [Commented] (SOLR-14708) Backward-Compatible Replication

2020-08-07 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172947#comment-17172947 ] Marcus Eagan commented on SOLR-14708: - Also, master/slave is not very documented as w

[jira] [Comment Edited] (SOLR-14708) Backward-Compatible Replication

2020-08-07 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172947#comment-17172947 ] Marcus Eagan edited comment on SOLR-14708 at 8/7/20, 7:18 AM: -

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r466866058 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyKeyFactory.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1720: SOLR-14712 Standardize RPC calls in Solr

2020-08-07 Thread GitBox
noblepaul commented on a change in pull request #1720: URL: https://github.com/apache/lucene-solr/pull/1720#discussion_r466859745 ## File path: solr/solrj/src/java/org/apache/solr/common/util/RpcFactory.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r466868182 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/ReplicaPlacement.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-14708) Backward-Compatible Replication

2020-08-07 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172952#comment-17172952 ] Marcus Eagan commented on SOLR-14708: - There is also a very strong chance that I am n

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1720: SOLR-14712 Standardize RPC calls in Solr

2020-08-07 Thread GitBox
anshumg commented on a change in pull request #1720: URL: https://github.com/apache/lucene-solr/pull/1720#discussion_r466892859 ## File path: solr/solrj/src/java/org/apache/solr/common/util/CallRouter.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1720: SOLR-14712 Standardize RPC calls in Solr

2020-08-07 Thread GitBox
anshumg commented on a change in pull request #1720: URL: https://github.com/apache/lucene-solr/pull/1720#discussion_r466893636 ## File path: solr/solrj/src/java/org/apache/solr/common/util/RpcFactory.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (SOLR-14684) CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-07 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172990#comment-17172990 ] Cao Manh Dat commented on SOLR-14684: - Ok, I figured out the problem for this issue.

[jira] [Created] (SOLR-14719) Handling exceeding timeAllowed consistently

2020-08-07 Thread Cao Manh Dat (Jira)
Cao Manh Dat created SOLR-14719: --- Summary: Handling exceeding timeAllowed consistently Key: SOLR-14719 URL: https://issues.apache.org/jira/browse/SOLR-14719 Project: Solr Issue Type: Improvemen

[jira] [Commented] (SOLR-14684) CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-07 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172992#comment-17172992 ] Cao Manh Dat commented on SOLR-14684: - Opened SOLR-14719 for that. > CloudExitableDi

[jira] [Commented] (SOLR-14630) CloudSolrClient doesn't pick correct core when server contains more shards

2020-08-07 Thread Ivan Djurasevic (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172998#comment-17172998 ] Ivan Djurasevic commented on SOLR-14630: [~cpoerschke] I'm sorry for late respons

[jira] [Commented] (SOLR-13381) Unexpected docvalues type SORTED_NUMERIC Exception when grouping by a PointField facet

2020-08-07 Thread Tobias Ibounig (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173003#comment-17173003 ] Tobias Ibounig commented on SOLR-13381: --- This happened to us Solr upgrade form 7.7.

[GitHub] [lucene-solr] atris commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r466918853 ## File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java ## @@ -53,6 +53,8 @@ public boolean handleRequest() throws InterruptedE

[jira] [Commented] (SOLR-14708) Backward-Compatible Replication

2020-08-07 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173011#comment-17173011 ] Marcus Eagan commented on SOLR-14708: - Honestly [~tflobbe] there seems to be a lot of

[jira] [Created] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-9448: - Summary: Make an eqivalent to Ant's "run" target for Luke module Key: LUCENE-9448 URL: https://issues.apache.org/jira/browse/LUCENE-9448 Project: Lucene - Core

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173022#comment-17173022 ] Tomoko Uchida commented on LUCENE-9448: --- I forgot about this, [~erickerickson] rem

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173034#comment-17173034 ] Dawid Weiss commented on LUCENE-9448: - Hmm... This would keep the gradle daemon runn

[jira] [Created] (SOLR-14720) Validate Sanctity of Request Type

2020-08-07 Thread Atri Sharma (Jira)
Atri Sharma created SOLR-14720: -- Summary: Validate Sanctity of Request Type Key: SOLR-14720 URL: https://issues.apache.org/jira/browse/SOLR-14720 Project: Solr Issue Type: Improvement Secu

[GitHub] [lucene-solr] atris commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r466947788 ## File path: solr/core/src/java/org/apache/solr/servlet/RateLimitManager.java ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173042#comment-17173042 ] Uwe Schindler commented on LUCENE-9448: --- I still think that a "quick tester" not a

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173058#comment-17173058 ] Dawid Weiss commented on LUCENE-9448: - It doesn't need to be a fat jar if it had pro

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173065#comment-17173065 ] Uwe Schindler commented on LUCENE-9448: --- The problem is that the lib folder struct

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173068#comment-17173068 ] Dawid Weiss commented on LUCENE-9448: - The local assemble task should sync everythin

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173070#comment-17173070 ] Tomoko Uchida commented on LUCENE-9448: --- While I try to write up my comment, the d

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173072#comment-17173072 ] Uwe Schindler commented on LUCENE-9448: --- bq. I don't mind having a 'run' task whic

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173074#comment-17173074 ] Uwe Schindler commented on LUCENE-9448: --- One example: I would also like to have th

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173081#comment-17173081 ] Dawid Weiss commented on LUCENE-9448: - > Why would that hang the IDE? I'm guessing

[jira] [Created] (SOLR-14721) RequestHandlerBase org.apache.solr.common.SolrException: No such core

2020-08-07 Thread anil (Jira)
anil created SOLR-14721: --- Summary: RequestHandlerBase org.apache.solr.common.SolrException: No such core Key: SOLR-14721 URL: https://issues.apache.org/jira/browse/SOLR-14721 Project: Solr Issue Type

[jira] [Updated] (SOLR-14721) RequestHandlerBase org.apache.solr.common.SolrException: No such core

2020-08-07 Thread anil (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] anil updated SOLR-14721: Security: Public (was: Private (Security Issue)) > RequestHandlerBase org.apache.solr.common.SolrException: No suc

[GitHub] [lucene-solr] CaoManhDat opened a new pull request #1724: SOLR-14684: CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-07 Thread GitBox
CaoManhDat opened a new pull request #1724: URL: https://github.com/apache/lucene-solr/pull/1724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (SOLR-14684) CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-07 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173089#comment-17173089 ] Cao Manh Dat commented on SOLR-14684: - I created a PR for this one, can you trying to

[jira] [Commented] (SOLR-14684) CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173088#comment-17173088 ] ASF subversion and git services commented on SOLR-14684: Commit 1

[GitHub] [lucene-solr] madrob commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
madrob commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r466985880 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -102,31 +103,101 @@ public Boolean call() throws Exception

[jira] [Commented] (LUCENE-9448) Make an eqivalent to Ant's "run" target for Luke module

2020-08-07 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173097#comment-17173097 ] Tomoko Uchida commented on LUCENE-9448: --- [~dweiss] thanks for the pointer. I'll op

[jira] [Updated] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2020-08-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9448: Summary: Make an equivalent to Ant's "run" target for Luke module (was: Make an eqivalent to Ant'

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2020-08-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173099#comment-17173099 ] Dawid Weiss commented on LUCENE-9448: - You can do this here as well, Tomoko - these

[jira] [Commented] (SOLR-14684) CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-07 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173100#comment-17173100 ] Erick Erickson commented on SOLR-14684: --- Actually, as luck would have it, I can't t

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2020-08-07 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173109#comment-17173109 ] Erick Erickson commented on LUCENE-9448: I mentioned this to Tomoko when I got b

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-07 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173135#comment-17173135 ] Erick Erickson commented on SOLR-13412: --- Getting back to this. This isn't part of t

[jira] [Resolved] (SOLR-14721) RequestHandlerBase org.apache.solr.common.SolrException: No such core

2020-08-07 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14721. --- Resolution: Incomplete Please raise questions like this on the user's list, we try to reserve

[jira] [Resolved] (SOLR-13381) Unexpected docvalues type SORTED_NUMERIC Exception when grouping by a PointField facet

2020-08-07 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-13381. --- Resolution: Information Provided First of all, any time you change your schema you should re-

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467083780 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyKeyFactory.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

[jira] [Updated] (LUCENE-9107) CommonsTermsQuery with huge no. of terms slower with top-k scoring

2020-08-07 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincenzo D'Amore updated LUCENE-9107: - Attachment: Screenshot 2020-08-07 at 16.20.01.png > CommonsTermsQuery with huge no. of t

[jira] [Comment Edited] (SOLR-14708) Backward-Compatible Replication

2020-08-07 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173011#comment-17173011 ] Marcus Eagan edited comment on SOLR-14708 at 8/7/20, 2:54 PM: -

[jira] [Updated] (LUCENE-9107) CommonsTermsQuery with huge no. of terms slower with top-k scoring

2020-08-07 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincenzo D'Amore updated LUCENE-9107: - Attachment: image-2020-08-07-16-54-27-905.png > CommonsTermsQuery with huge no. of terms

[jira] [Updated] (LUCENE-9107) CommonsTermsQuery with huge no. of terms slower with top-k scoring

2020-08-07 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincenzo D'Amore updated LUCENE-9107: - Attachment: Screenshot 2020-08-07 at 16.20.05.png > CommonsTermsQuery with huge no. of t

[jira] [Commented] (LUCENE-9107) CommonsTermsQuery with huge no. of terms slower with top-k scoring

2020-08-07 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173187#comment-17173187 ] Vincenzo D'Amore commented on LUCENE-9107: -- Hi, I did a little step further try

[jira] [Commented] (SOLR-14630) CloudSolrClient doesn't pick correct core when server contains more shards

2020-08-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173188#comment-17173188 ] Christine Poerschke commented on SOLR-14630: {quote}I'm sorry for late respon

[GitHub] [lucene-solr] HoustonPutman closed pull request #1717: Updating jenkins links to the new cluster.

2020-08-07 Thread GitBox
HoustonPutman closed pull request #1717: URL: https://github.com/apache/lucene-solr/pull/1717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467102867 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/MetricPropertyValue.java ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (SOLR-14708) Backward-Compatible Replication

2020-08-07 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173195#comment-17173195 ] Marcus Eagan commented on SOLR-14708: - Also, even with this change aside, Solr 9 is v

[GitHub] [lucene-solr] madrob commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
madrob commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467104137 ## File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java ## @@ -58,18 +58,18 @@ public RequestRateLimiter(RateLimiterConfig ra

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467108068 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementException.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Softwa

[jira] [Created] (LUCENE-9449) Skip non-competitive documents when sort by _doc with search after

2020-08-07 Thread Mayya Sharipova (Jira)
Mayya Sharipova created LUCENE-9449: --- Summary: Skip non-competitive documents when sort by _doc with search after Key: LUCENE-9449 URL: https://issues.apache.org/jira/browse/LUCENE-9449 Project: Luc

[GitHub] [lucene-solr] atris commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467110274 ## File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java ## @@ -58,18 +58,18 @@ public RequestRateLimiter(RateLimiterConfig rat

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r466860061 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-14716) Ref Guide: update leader/follower terminology

2020-08-07 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173227#comment-17173227 ] Cassandra Targett commented on SOLR-14716: -- Discussion on this in the Dev list:

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-07 Thread GitBox
mayya-sharipova opened a new pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725 Enhance DocComparator to provide an iterator over competitive documents when searching with "after" FieldDoc. This iterator can quickly position on the desired "after" document, and

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173238#comment-17173238 ] Christine Poerschke commented on LUCENE-8626: - {quote}Thank you very much fo

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173239#comment-17173239 ] Christine Poerschke commented on LUCENE-8626: - bq. Within the lucene test su

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-07 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467127445 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-13499) Fix "Apache License, Version 2.0" spelling -- in pom.xml.template

2020-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173245#comment-17173245 ] ASF subversion and git services commented on SOLR-13499: Commit a

[GitHub] [lucene-solr] cpoerschke merged pull request #674: SOLR-13499: Fix "Apache License, Version 2.0" spelling in pom.xml.template

2020-08-07 Thread GitBox
cpoerschke merged pull request #674: URL: https://github.com/apache/lucene-solr/pull/674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] tflobbe commented on pull request #1602: SOLR-14582: Expose IWC.setMaxCommitMergeWaitMillis in Solr's index config

2020-08-07 Thread GitBox
tflobbe commented on pull request #1602: URL: https://github.com/apache/lucene-solr/pull/1602#issuecomment-670593930 @dsmiley, looks good? should I merge? This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (SOLR-13499) Fix "Apache License, Version 2.0" spelling -- in pom.xml.template

2020-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173249#comment-17173249 ] ASF subversion and git services commented on SOLR-13499: Commit e

[GitHub] [lucene-solr] dsmiley commented on pull request #1723: SOLR prometheus: simplify concurrent collection

2020-08-07 Thread GitBox
dsmiley commented on pull request #1723: URL: https://github.com/apache/lucene-solr/pull/1723#issuecomment-670598671 @ErickErickson the gradle validateLogCalls is complaining because I added a log statement without explicitly checking "log.isErrorEnabled" first. validate-log-calls.gradle

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-08-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173265#comment-17173265 ] David Smiley commented on LUCENE-9379: -- Rajeswari -- you are referring to some Solr

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-07 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173271#comment-17173271 ] Erick Erickson commented on LUCENE-8626: Both should be the same IMO. > standar

[jira] [Resolved] (SOLR-13499) Fix "Apache License, Version 2.0" spelling -- in pom.xml.template

2020-08-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-13499. Fix Version/s: 8.7 master (9.0) Resolution: Fixed Thanks

[GitHub] [lucene-solr] ErickErickson commented on pull request #1723: SOLR prometheus: simplify concurrent collection

2020-08-07 Thread GitBox
ErickErickson commented on pull request #1723: URL: https://github.com/apache/lucene-solr/pull/1723#issuecomment-670608605 The first part of the line gives the most explicit statement: "cause: 'getMessage or getCause in log line’”, the latter part of the line is more generic. This c

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1716: SOLR-14706: Fix support for default autoscaling policy

2020-08-07 Thread GitBox
HoustonPutman commented on pull request #1716: URL: https://github.com/apache/lucene-solr/pull/1716#issuecomment-670612283 Tested this out locally upgrading 8.6.0 -> 8.6.1 RC1 (failure) -> this PR (success) Also added you to the CHANGES.txt Gus, thanks for all the invaluable help!

[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-670616622 @madrob Updated, please see and let me know your thoughts. This is an automated message from the Apache Git Se

[GitHub] [lucene-solr] ErickErickson commented on pull request #1723: SOLR prometheus: simplify concurrent collection

2020-08-07 Thread GitBox
ErickErickson commented on pull request #1723: URL: https://github.com/apache/lucene-solr/pull/1723#issuecomment-670617417 If you only knew how many times I’ve beaten my head against a wall for _hours_, then read something that was in front of my face all the time more carefully… ;)

[jira] [Commented] (SOLR-14702) Remove Master and Slave from Code Base and Docs

2020-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173321#comment-17173321 ] ASF subversion and git services commented on SOLR-14702: Commit 2

[GitHub] [lucene-solr] tflobbe merged pull request #1718: SOLR-14702: Add Upgrade Notes and CHANGES entry

2020-08-07 Thread GitBox
tflobbe merged pull request #1718: URL: https://github.com/apache/lucene-solr/pull/1718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] atris commented on pull request #1718: SOLR-14702: Add Upgrade Notes and CHANGES entry

2020-08-07 Thread GitBox
atris commented on pull request #1718: URL: https://github.com/apache/lucene-solr/pull/1718#issuecomment-670619396 I took a look late -- but +1 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] madrob commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
madrob commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467165632 ## File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java ## @@ -80,20 +79,12 @@ public RequestRateLimiter(RateLimiterConfig ra

[GitHub] [lucene-solr] atris commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467176662 ## File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java ## @@ -152,14 +143,22 @@ public RateLimiterConfig(SolrRequest.SolrReque

[GitHub] [lucene-solr] atris commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467178250 ## File path: solr/core/src/java/org/apache/solr/servlet/RateLimitManager.java ## @@ -132,12 +130,12 @@ public boolean handleRequest(HttpServletRequest

[GitHub] [lucene-solr] tflobbe merged pull request #1602: SOLR-14582: Expose IWC.setMaxCommitMergeWaitMillis in Solr's index config

2020-08-07 Thread GitBox
tflobbe merged pull request #1602: URL: https://github.com/apache/lucene-solr/pull/1602 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14582) Expose IWC.setMaxCommitMergeWaitMillis as an expert feature in Solr's index config

2020-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173386#comment-17173386 ] ASF subversion and git services commented on SOLR-14582: Commit e

[jira] [Commented] (SOLR-14582) Expose IWC.setMaxCommitMergeWaitMillis as an expert feature in Solr's index config

2020-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173387#comment-17173387 ] ASF subversion and git services commented on SOLR-14582: Commit 1

[jira] [Resolved] (SOLR-14582) Expose IWC.setMaxCommitMergeWaitMillis as an expert feature in Solr's index config

2020-08-07 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-14582. -- Fix Version/s: 8.7 master (9.0) Resolu

[GitHub] [lucene-solr] madrob commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
madrob commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467213763 ## File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java ## @@ -40,32 +42,35 @@ private final Semaphore borrowableSlotsPool;

[GitHub] [lucene-solr] atris commented on a change in pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on a change in pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467219496 ## File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java ## @@ -157,7 +162,7 @@ public void decrementRequest() { } }

[jira] [Created] (SOLR-14722) timeAllowed should track from the very start of the request

2020-08-07 Thread David Smiley (Jira)
David Smiley created SOLR-14722: --- Summary: timeAllowed should track from the very start of the request Key: SOLR-14722 URL: https://issues.apache.org/jira/browse/SOLR-14722 Project: Solr Issue

[jira] [Commented] (SOLR-14722) timeAllowed should track from the very start of the request

2020-08-07 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173435#comment-17173435 ] Atri Sharma commented on SOLR-14722: Huge +1. > timeAllowed should track from the ve

[GitHub] [lucene-solr] atris merged pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris merged pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (SOLR-13528) Rate limiting in Solr

2020-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173441#comment-17173441 ] ASF subversion and git services commented on SOLR-13528: Commit a

[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters

2020-08-07 Thread GitBox
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-670692047 Thank you @madrob and @anshumg ! This is an automated message from the Apache Git Service. To respond to the m

[jira] [Commented] (SOLR-14630) CloudSolrClient doesn't pick correct core when server contains more shards

2020-08-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173449#comment-17173449 ] David Smiley commented on SOLR-14630: - It'd be great if we could make an integration

  1   2   >