madrob commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467213763
##########
File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java
##########
@@ -40,32 +42,35 @@
private final Semaphore borrowableSlotsPool;
private final RateLimiterConfig rateLimiterConfig;
+ private final SlotMetadata guaranteedSlotMetadata;
+ private final SlotMetadata borrowedSlotMetadata;
+ private final SlotMetadata nullSlotMetadata;
Review comment:
can this be static? pretty minor but since it doesn't do anything, it
can be shared by all the instances and save some memory
##########
File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java
##########
@@ -157,7 +162,7 @@ public void decrementRequest() {
}
}
- public boolean isUsedPoolNull() {
+ public boolean isReleasable() {
return usedPool == null;
Review comment:
Should be != null, right? Check the condition wherever this is called
too, might need to invert those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
