atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r467178250
##########
File path: solr/core/src/java/org/apache/solr/servlet/RateLimitManager.java
##########
@@ -132,12 +130,12 @@ public boolean handleRequest(HttpServletRequest request)
throws InterruptedExcep
Thread.currentThread().interrupt();
}
- if (result != null && result.first()) {
- if (result.second() == null) {
- throw new IllegalStateException("AcquiredSlotMetadata object null
even when slot is acquired and rate limiters are enabled");
- }
+ if (result == null) {
Review comment:
Yes, thats why the check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
