Re: [RFA][rtl-optimization/52714] Do not allow combine to create invalid RTL

2014-02-11 Thread Eric Botcazou
> I pondered changing the condition for swapping the insn order, but it > didn't seem worth it. I doubt we see many 3->2 combinations where I3 is > a JUMP_INSN, the result turns into two simple sets and the insn swapping > code you wrote decides it needs to swap the insns. I didn't actually write

[committed] Add pr59927 testcase

2014-02-11 Thread Jakub Jelinek
Hi! On Tue, Feb 11, 2014 at 01:13:09AM +, rth at gcc dot gnu.org wrote: > --- Comment #9 from Richard Henderson --- > Author: rth > Date: Tue Feb 11 01:12:38 2014 > New Revision: 207677 > > URL: http://gcc.gnu.org/viewcvs?rev=207677&root=gcc&view=rev > Log: > PR target/59927 > > * c

[PATCH][ARM] Fix PR 55426

2014-02-11 Thread Kyrill Tkachov
Hi all, In this PR the 128-bit load-duplicate intrinsics in neon.exp ICE on big-endian with an unrecognisable insn error: neon-vld1_dupQ.c:24:1: error: unrecognizable insn: (insn 94 93 31 (set (subreg:DI (reg:V2DI 95 d16 [orig:137 D.14400 ] [137]) 0) (subreg:DI (reg:V2DI 95 d16 [orig:1

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Richard Sandiford
Richard Biener writes: > On Sun, Feb 9, 2014 at 9:30 PM, Robert Dewar wrote: >> On 2/9/2014 3:23 PM, Richard Sandiford wrote: can't we just reword the one warning where there is an ambiguity to avoid the confusion, rather than creating such an earthquake, which as Arno says, really

[patch] Fix wrong code with VCE to bit-field type at -O

2014-02-11 Thread Eric Botcazou
Hi, this is an interesting regression from GCC 4.5 present on all active branches and triggered by recent SRA improvements. For the attached testcase, we have an unchecked conversion of a 3-byte slice of an array of 4 bytes to a record type containing a 3-byte bit-field; an unchecked conversio

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Florian Weimer
On 02/09/2014 09:00 PM, Richard Sandiford wrote: + return xstrdup (_("warning enabled by default")); I think this is still wrong because this message really means, "this warning cannot be controlled with a warning flag, but it can likely be switched off by other means". I don't think

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Robert Dewar
On 2/11/2014 4:45 AM, Richard Sandiford wrote: OK, this version drops the "[enabled by default]" altogether. Tested as before. OK to install? Still a huge earthquake in terms of affecting test suites and baselines of many users. is it really worth it? In the case of GNAT we have only recently

[PATCH][LTO] Fix PR60060

2014-02-11 Thread Richard Biener
This fixes the ICE seen in PR60060 which stems from us asking to output debug-info for a function-scope global twice - once via emitting the function and its BLOCK-associated vars and once via the debug-hook through lto_write_globals -> emit_debug_global_declarations. The list of "global" variab

Re: [RFA] [middle-end/54041] Convert modes as needed from expand_expr

2014-02-11 Thread Richard Biener
On Mon, Feb 10, 2014 at 5:35 PM, Jeff Law wrote: > On 02/07/14 02:17, Richard Biener wrote: >>> >>> +2014-02-05 Jeff Law >>> + >>> + PR middle-end/54041 >>> + * expr.c (expand_expr_addr_1): Handle expand_expr returning an >>> + object with an undesirable mode. >>> + >>> 2014

Re: RFA: XFAIL gcc.dg/vect/pr56787.c if vect_no_align

2014-02-11 Thread Richard Biener
On Mon, Feb 10, 2014 at 9:38 PM, Richard Sandiford wrote: > Not 100% sure whether this is the preferred fix, but gcc.dg/vect/pr56787.c > has lots of float * parameters that point who-knows-where and so is only > vectorised if the target supports misaligned vector accesses: > > void > foo (unsigned

[PING] [test case, patch] ICE in Cilk Plus structured block checker

2014-02-11 Thread Thomas Schwinge
Hi! Ping again for test case and rather trivial patch to cure a GCC trunk ICE in the Cilk Plus structured block checker if both -fcilkplus and -fopenmp are specified. Also, I'd still like to know whether the »Generalize diagnose_omp_blocks' structured block logic« patch is fine, too? (If that on

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Richard Sandiford
Robert Dewar writes: > On 2/11/2014 4:45 AM, Richard Sandiford wrote: >> OK, this version drops the "[enabled by default]" altogether. >> Tested as before. OK to install? > > Still a huge earthquake in terms of affecting test suites and > baselines of many users. is it really worth it? In the cas

Only assume 4-byte stack alignment on Solaris 9/x86 (PR libgomp/60107)

2014-02-11 Thread Rainer Orth
As described in the PR, a few libgomp testcases FAIL on Solaris 9/x86 because the SSE insns assume 16-byte stack alignment, while Solaris 9, unlike Solaris 10, only guarantees the 4-byte alignment prescribed by the i386 psABI. This can be fixed, at a slight performance penalty and code size increa

Re: [PATCH, PR52252] Vectorization for load/store groups of size 3.

2014-02-11 Thread Richard Biener
On Tue, 11 Feb 2014, Evgeny Stupachenko wrote: > Hi, > > The patch gives an expected 3 times gain for the test case in the PR52252 > (and even 6 times for AVX2). > It passes make check and bootstrap on x86. > spec2000/spec2006 got no regressions/gains on x86. > > Is this patch ok? I've worked o

Re: [PING] [test case, patch] ICE in Cilk Plus structured block checker

2014-02-11 Thread Thomas Schwinge
Hi! On Tue, 11 Feb 2014 13:43:46 +0100, I wrote: > Ping again for test case and rather trivial patch to cure a GCC trunk ICE > in the Cilk Plus structured block checker if both -fcilkplus and -fopenmp > are specified. Jakub asked me to »please repost just the (hopefully small) trunk patch alone«,

Re: [patch] Fix wrong code with VCE to bit-field type at -O

2014-02-11 Thread Richard Biener
On Tue, Feb 11, 2014 at 11:40 AM, Eric Botcazou wrote: > Hi, > > this is an interesting regression from GCC 4.5 present on all active branches > and triggered by recent SRA improvements. For the attached testcase, we have > an unchecked conversion of a 3-byte slice of an array of 4 bytes to a rec

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Richard Biener
On Tue, Feb 11, 2014 at 1:48 PM, Richard Sandiford wrote: > Robert Dewar writes: >> On 2/11/2014 4:45 AM, Richard Sandiford wrote: >>> OK, this version drops the "[enabled by default]" altogether. >>> Tested as before. OK to install? >> >> Still a huge earthquake in terms of affecting test suite

Re: [patch] Fix wrong code with VCE to bit-field type at -O

2014-02-11 Thread Jakub Jelinek
On Tue, Feb 11, 2014 at 02:17:04PM +0100, Richard Biener wrote: > > this is an interesting regression from GCC 4.5 present on all active > > branches > > and triggered by recent SRA improvements. For the attached testcase, we > > have > > an unchecked conversion of a 3-byte slice of an array of

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Robert Dewar
On 2/11/2014 7:48 AM, Richard Sandiford wrote: The patch deliberately didn't affect Ada's diagnostic routines given your comments from the first round. Calling this a "huge earthquake" for other languages seems like a gross overstatement. Actually it's much less of an impact for Ada for two r

Re: [patch] Fix wrong code with VCE to bit-field type at -O

2014-02-11 Thread Richard Biener
On Tue, Feb 11, 2014 at 2:22 PM, Jakub Jelinek wrote: > On Tue, Feb 11, 2014 at 02:17:04PM +0100, Richard Biener wrote: >> > this is an interesting regression from GCC 4.5 present on all active >> > branches >> > and triggered by recent SRA improvements. For the attached testcase, we >> > have

Re: [PATCH, PR52252] Vectorization for load/store groups of size 3.

2014-02-11 Thread Evgeny Stupachenko
Missed patch attached in plain-text. I have copyright assignment on file with the FSF covering work on GCC. Load/stores groups of length 3 is the most frequent non-power-of-2 case. It is used in RGB image processing (like test case in PR52252). For sure we can extend the patch to length 5 and mor

[patch c++]: Fix pr/58835 [4.7/4.8/4.9 Regression] ICE with __PRETTY_FUNCTION__ in broken function

2014-02-11 Thread Kai Tietz
Hi, the following patch adds missing handling of error_mark_node result of fname_decl within finish_fname. ChangeLog 2014-02-11 Kai Tietz PR c++/58835 * semantics.c (finish_fname): Handle error_mark_node. Regression tested for x86_64-unknown-linux-gnu, i686-w64-mingw32. Ok

Re: [PING] [test case, patch] ICE in Cilk Plus structured block checker

2014-02-11 Thread Jakub Jelinek
On Tue, Feb 11, 2014 at 02:15:00PM +0100, Thomas Schwinge wrote: > Jakub asked me to »please repost just the (hopefully small) trunk patch > alone«, so here we go: > > Consider the following code: > > void baz() > { > bad1: > #pragma omp parallel > goto bad1; > } >

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Richard Sandiford
Robert Dewar writes: >> I don't think gcc, g++, gfortran, etc, have ever made a commitment >> to producing textually identical warnings and errors for given inputs >> across different releases. It seems ridiculous to require that, >> especially if it stands in the way of improving the diagnostics

Re: Allow passing arrays in registers on AArch64

2014-02-11 Thread Marcus Shawcroft
On 6 February 2014 22:51, Michael Hudson-Doyle wrote: > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 16c51a8..958c667 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -1187,14 +1187,10 @@ aarch64_pass_by_reference (cumulativ

Re: Allow passing arrays in registers on AArch64

2014-02-11 Thread Jakub Jelinek
On Tue, Feb 11, 2014 at 02:51:08PM +, Marcus Shawcroft wrote: > On 6 February 2014 22:51, Michael Hudson-Doyle > wrote: > > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > > index 16c51a8..958c667 100644 > > --- a/gcc/config/aarch64/aarch64.c > > +++ b/gcc/config/

Re: [PATCH][ARM] Fix PR 55426

2014-02-11 Thread Kyrill Tkachov
On 11/02/14 09:38, Kyrill Tkachov wrote: Hi all, In this PR the 128-bit load-duplicate intrinsics in neon.exp ICE on big-endian with an unrecognisable insn error: neon-vld1_dupQ.c:24:1: error: unrecognizable insn: (insn 94 93 31 (set (subreg:DI (reg:V2DI 95 d16 [orig:137 D.14400 ] [137]) 0)

Re: [PATCH][AArch64] Wire up Cortex-A57 rtx costs

2014-02-11 Thread Marcus Shawcroft
On 10 February 2014 09:55, Marcus Shawcroft wrote: > On 30 January 2014 13:48, Kyrill Tkachov wrote: >> Hi all, >> >> This patch wires up the aarch64 backend to use the Cortex-A57 rtx costs >> table that is proposed at >> http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01954.html > > OK if release m

Re: [PATCH][ARM] Add -mcpu=native detection for Cortex-A53, A57

2014-02-11 Thread Ramana Radhakrishnan
On Mon, Feb 10, 2014 at 11:01 AM, Kyrill Tkachov wrote: > Hi all, > > This patchlet adds the part numbers for the Cortex-A53 and A57 cores so that > they can be detected when parsing /proc/cpuinfo on AArch32 Linux systems. > This will allow the -mcpu=native machinery to detect those cores. > > Tes

Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression

2014-02-11 Thread Ramana Radhakrishnan
On Mon, Feb 3, 2014 at 3:56 PM, Renlin Li wrote: > Hi all, > > This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c is > checked only when "-mfpu=vfp3 -mfloat-abi=softfp" is applicable for the > target. > > Accordingly, two procs (check_effective_target_arm_vfp3_ok and > add_op

Re: [PATCH][AArch64] Wire up Cortex-A57 rtx costs

2014-02-11 Thread Jakub Jelinek
On Tue, Feb 11, 2014 at 03:03:32PM +, Marcus Shawcroft wrote: > On 10 February 2014 09:55, Marcus Shawcroft > wrote: > > On 30 January 2014 13:48, Kyrill Tkachov wrote: > >> Hi all, > >> > >> This patch wires up the aarch64 backend to use the Cortex-A57 rtx costs > >> table that is proposed

Re: [PATCH, PR52252] Vectorization for load/store groups of size 3.

2014-02-11 Thread Richard Biener
On Tue, 11 Feb 2014, Evgeny Stupachenko wrote: > Missed patch attached in plain-text. > > I have copyright assignment on file with the FSF covering work on GCC. > > Load/stores groups of length 3 is the most frequent non-power-of-2 > case. It is used in RGB image processing (like test case in PR

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Robert Dewar
On 2/11/2014 9:36 AM, Richard Sandiford wrote: I find it hard to believe that significant numbers of users are not fixing the sources of those warnings and are instead requiring every release of GCC to produce warnings with a particular wording. Good enough for me, I think it is OK to make th

Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression

2014-02-11 Thread Kyrill Tkachov
On 11/02/14 15:11, Ramana Radhakrishnan wrote: On Mon, Feb 3, 2014 at 3:56 PM, Renlin Li wrote: Hi all, This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c is checked only when "-mfpu=vfp3 -mfloat-abi=softfp" is applicable for the target. Accordingly, two procs (check_eff

Re: [RFC, patch] Detect lack of 32-bit devel environment on x86_64-linux targets

2014-02-11 Thread Jakub Jelinek
On Fri, Jan 31, 2014 at 03:49:40PM +0100, Richard Biener wrote: > On Fri, Jan 31, 2014 at 3:45 PM, FX wrote: > >> I've just seen that an explicit --enable-multilib is a way to do that. > > > > Yes, I was writing that as a reply when I received your email. (Also, it's > > written in the configure

Re: [PATCH 4/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-11 Thread Thomas Schwinge
Hi! On Fri, 31 Jan 2014 15:16:07 +0400, Ilmir Usmanov wrote: > OpenACC 1.0 support -- GENERIC nodes and gimplify stubs. Thanks! This one is nearly ready for commit, and can then go in already, while the Fortran front end patches are still being dicussed. :-) Please merge »OpenACC 1.0 sup

Simple install hook

2014-02-11 Thread Philip Herron
Added install hook: /opt/gjit/bin/gcc -g -O2 -Wall t.c -o test -I/opt/gjit/include -lgccjit -L/opt/gjit/lib Compiles the helloworld examples correctly and it runs instead of pointing to my gcc build dir. Am working on getting more involved with this and started: https://github.com/redbrain/spy

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Franz Sirl
Am 2014-02-11 15:36, schrieb Richard Sandiford: I thought the trend these days was to move towards -Werror, so that for many people the expected output is to get no warnings at all. And bear in mind that the kind of warnings that are not under -W control tend to be those that are so likely to be

Re: [patch] Fix wrong code with VCE to bit-field type at -O

2014-02-11 Thread Eric Botcazou
> Hmm. The intent was of course to only allow truly no-op converts via > VIEW_CONVERT_EXPR - that is, the size of the operand type and the > result type should be the same. So, isn't SRA doing it wrong when > creating the VIEW_CONVERT_EXPR of a 3-byte type to a 4-byte type? That's debatable IMO

Re: [google gcc-4_8] Don't use gcov counter related ssa name as induction variables

2014-02-11 Thread Xinliang David Li
On Mon, Feb 10, 2014 at 11:48 PM, Wei Mi wrote: > Here is the updated patch, which follow UD chain to determine whether > iv.base is defined by __gcovx.xxx[] var. It is a lot simpler than > adding a tree bit. > > regression test and previously failed benchmark in piii mode is ok. > Other test is g

[PATCH] Use VIEW_CONVERT_EXPR in SRA created debug stmts if needed (PR debug/59776)

2014-02-11 Thread Jakub Jelinek
Hi! As discussed in the PR, this patch adds VCE if types aren't compatible, in order not to create invalid debug stmts. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-02-11 Richard Henderson Jakub Jelinek PR debug/59776 * tree-sra.c (l

Re: [PATCH] Use VIEW_CONVERT_EXPR in SRA created debug stmts if needed (PR debug/59776)

2014-02-11 Thread Richard Henderson
On 02/11/2014 09:36 AM, Jakub Jelinek wrote: > Hi! > > As discussed in the PR, this patch adds VCE if types aren't compatible, > in order not to create invalid debug stmts. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2014-02-11 Richard Henderson > Ja

[PATCH] Fix up -Wsequence-point handling (PR c/60101)

2014-02-11 Thread Jakub Jelinek
Hi! Right now we spent several minutes in verify_tree. The problems I see is that merge_tlist does the exact opposite of what should it be doing with copy flag (most merge_tlist calls are with copy=0, thus that means mostly unnecessary copying, but for the single one for SAVE_EXPR it actually pro

Re: [PING]Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression

2014-02-11 Thread H.J. Lu
On Mon, Feb 10, 2014 at 6:02 AM, Renlin Li wrote: > On 03/02/14 15:56, Renlin Li wrote: >> >> Hi all, >> >> This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c >> is checked only when "-mfpu=vfp3 -mfloat-abi=softfp" is applicable for the >> target. >> >> Accordingly, two procs

Re: [PING]Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression

2014-02-11 Thread H.J. Lu
On Tue, Feb 11, 2014 at 9:46 AM, H.J. Lu wrote: > On Mon, Feb 10, 2014 at 6:02 AM, Renlin Li wrote: >> On 03/02/14 15:56, Renlin Li wrote: >>> >>> Hi all, >>> >>> This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c >>> is checked only when "-mfpu=vfp3 -mfloat-abi=softfp" is a

Re: [PING]Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression

2014-02-11 Thread Renlin Li
On 11/02/14 17:47, H.J. Lu wrote: On Tue, Feb 11, 2014 at 9:46 AM, H.J. Lu wrote: On Mon, Feb 10, 2014 at 6:02 AM, Renlin Li wrote: On 03/02/14 15:56, Renlin Li wrote: Hi all, This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c is checked only when "-mfpu=vfp3 -mfloat-a

Re: [PATCH][LTO] Fix PR60060

2014-02-11 Thread Jan Hubicka
> > This fixes the ICE seen in PR60060 which stems from us asking to > output debug-info for a function-scope global twice - once via > emitting the function and its BLOCK-associated vars and once > via the debug-hook through lto_write_globals -> > emit_debug_global_declarations. > > The list of

[jit] Improvements to error-handling

2014-02-11 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * internal-api.c (gcc::jit::recording::context::add_error_va): If GCC_JIT_STR_OPTION_PROGNAME is NULL, use "libgccjit.so", as per the comment in libgccjit.h (gcc::jit::recording::label::replay_into): When reporting on an

Re: [google gcc-4_8] Don't use gcov counter related ssa name as induction variables

2014-02-11 Thread Wei Mi
>> +/* Return true if the use is defined by a gcov counter var. >> + It is used to check if an iv candidate is generated for >> + profiling. For profile generated ssa name, we should not >> + use it as IV because gcov counter may have data-race for >> + multithread program, it could involve

fix typo in doc/generic.texi

2014-02-11 Thread Prathamesh Kulkarni
* (generic.texi): Fix typo Index: generic.texi === --- generic.texi(revision 207627) +++ generic.texi(working copy) @@ -53,7 +53,7 @@ seems inelegant. @node Deficiencies @section Deficiencies -There are many places in which

Re: [google gcc-4_8] Don't use gcov counter related ssa name as induction variables

2014-02-11 Thread Xinliang David Li
ok for google branch for now. Please resubmit to trunk and backport the trunk version if needed. thanks, David On Tue, Feb 11, 2014 at 10:29 AM, Wei Mi wrote: >>> +/* Return true if the use is defined by a gcov counter var. >>> + It is used to check if an iv candidate is generated for >>> +

Re: fix typo in doc/generic.texi

2014-02-11 Thread Marek Polacek
On Wed, Feb 12, 2014 at 12:00:30AM +0530, Prathamesh Kulkarni wrote: > * (generic.texi): Fix typo > > Index: generic.texi > === > --- generic.texi(revision 207627) > +++ generic.texi(working copy) > @@ -53,7 +53,7 @@ seems ine

[PATCH, testsuite]: Revert PR testsuite/58630 on mainline

2014-02-11 Thread Uros Bizjak
Hello! Now that Richard fixed ms_abi limitation w.r.t. accumulate-outgoing-args, we can revert PR testsuite/58630 fix on mainline. On mainline, ms_abi works without problems with and without this option. 2014-02-11 Uros Bizjak PR target/59927 Revert 2013-12-15 Uros Bizjak

Re: Use "[warning enabled by default]" for default warnings

2014-02-11 Thread Ian Lance Taylor
On Tue, Feb 11, 2014 at 5:20 AM, Richard Biener wrote: > On Tue, Feb 11, 2014 at 1:48 PM, Richard Sandiford > wrote: >> Robert Dewar writes: >>> On 2/11/2014 4:45 AM, Richard Sandiford wrote: OK, this version drops the "[enabled by default]" altogether. Tested as before. OK to install

PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64

2014-02-11 Thread H.J. Lu
Hi, HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to pass --32 to assembler. Otherwise, we get the wrong result on x86-64. We already pass --32 to assembler on x86. It should be OK to do it in configure. OK for trunk? Thanks. H.J. --- 2014-02-11 H.J. Lu PR targ

Re: PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64

2014-02-11 Thread Rainer Orth
Hi H.J., > HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to > pass --32 to assembler. Otherwise, we get the wrong result on x86-64. > We already pass --32 to assembler on x86. It should be OK to do it > in configure. OK for trunk? This would break Solaris/x86 with as config

Re: PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64

2014-02-11 Thread Uros Bizjak
On Tue, Feb 11, 2014 at 8:28 PM, H.J. Lu wrote: > HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to > pass --32 to assembler. Otherwise, we get the wrong result on x86-64. > We already pass --32 to assembler on x86. It should be OK to do it > in configure. OK for trunk? Unf

RFA: one more version of patch for PR59535

2014-02-11 Thread Vladimir Makarov
This is one more version of the patch to fix the PR59535 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59535 Here are the results of applying the patch: ThumbThumb2 reload 2626334 2400154 lra (before the patch)

Re: PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64

2014-02-11 Thread H.J. Lu
On Tue, Feb 11, 2014 at 11:40 AM, Rainer Orth wrote: > Hi H.J., > >> HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to >> pass --32 to assembler. Otherwise, we get the wrong result on x86-64. >> We already pass --32 to assembler on x86. It should be OK to do it >> in configure

Re: [RFA][rtl-optimization/52714] Do not allow combine to create invalid RTL

2014-02-11 Thread Jeff Law
On 02/11/14 02:06, Eric Botcazou wrote: I pondered changing the condition for swapping the insn order, but it didn't seem worth it. I doubt we see many 3->2 combinations where I3 is a JUMP_INSN, the result turns into two simple sets and the insn swapping code you wrote decides it needs to swap t

[COMMITTED] Fix target/59927

2014-02-11 Thread Richard Henderson
[Re-send, since I never saw the original arrive on the list.] After the first version passed Kai's testing, we chatted on IRC about various other bits that might be relevant to the winx64 abi issues. The conditional call to ix86_eax_live_at_start_p seemed to be harmless either way, but confusing

Re: PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64

2014-02-11 Thread Rainer Orth
"H.J. Lu" writes: > On Tue, Feb 11, 2014 at 11:40 AM, Rainer Orth > wrote: >> Hi H.J., >> >>> HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to >>> pass --32 to assembler. Otherwise, we get the wrong result on x86-64. >>> We already pass --32 to assembler on x86. It should b

[PATCH] Avoid uninit warnings with Fortran optional args (PR fortran/52370)

2014-02-11 Thread Jakub Jelinek
Hi! Optional dummy arg support vars are often undefined in various paths, while the predicated uninit analysis can sometimes avoid false positives, sometimes it can't. So IMHO we should set TREE_NO_WARNING here, it is already set on the other support vars like size.N, ubound.N, lbound.N, etc. but

[jit] Fix error message in test

2014-02-11 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/testsuite/ * jit.dg/test-error-unplaced-label.c (verify_code): Update expected error message to reflect commit 6cd4f82c5237cc328aea229cdaaa428ff09d6e98. --- gcc/testsuite/ChangeLog.jit | 6 ++ gcc/testsuite/jit

Re: PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64

2014-02-11 Thread H.J. Lu
On Tue, Feb 11, 2014 at 12:29 PM, Rainer Orth wrote: > "H.J. Lu" writes: > >> On Tue, Feb 11, 2014 at 11:40 AM, Rainer Orth >> wrote: >>> Hi H.J., >>> HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to pass --32 to assembler. Otherwise, we get the wrong result on x86

Harden ipa-devirt for invalid programs, part 1 (and also fix a wrong code issue)

2014-02-11 Thread Jan Hubicka
Hi, this is first part of fix for lto/59468 that is about ipa-devirt ICEs on invalid C++ programs (violating ODR rule). This patch hardens it wrt various low-level VTABLE corruptions - the case virtual tables gets too small, their initalizer is missing or user decided to rewrite the symbol by a di

Re: [PATCH] Avoid uninit warnings with Fortran optional args (PR fortran/52370)

2014-02-11 Thread Steve Kargl
On Tue, Feb 11, 2014 at 09:38:20PM +0100, Jakub Jelinek wrote: > > Optional dummy arg support vars are often undefined in various paths, > while the predicated uninit analysis can sometimes avoid false positives, > sometimes it can't. So IMHO we should set TREE_NO_WARNING here, it is > already se

Re: [PATCH] Fix PR target/60137, no splitters for vectors that get GPR registers

2014-02-11 Thread David Edelsohn
On Mon, Feb 10, 2014 at 8:14 PM, Michael Meissner wrote: > This patch fixes PR target/60137 that shows up when some vector types get > allocated to GPR registers, and there wasn't a splitter for the type. It > shows > up when targetting ISA 2.07 (power8) when VSX is disabled but Altivec (VMX) is

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Teresa Johnson
On Mon, Feb 10, 2014 at 7:15 PM, Sriraman Tallam wrote: > Hi Teresa, > >I have attached a patch to recognize and reorder split functions in > the function reordering plugin. Please review. > > Thanks > Sri > Index: function_reordering_plugin/callgraph.c > =

patch fixing PR49008

2014-02-11 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49008 This typo was not important as the code worked correctly in the most cases as units required precence of only one another unit mostly. Committed as rev. 207701. 2014-02-11 Vladimir Makarov PR target/49

[jit] Add an explicit boolean type

2014-02-11 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * libgccjit.h (enum gcc_jit_types): Add GCC_JIT_TYPE_BOOL. * internal-api.h (gcc::jit::recording::comparison::comparison): Use GCC_JIT_TYPE_BOOL as the types of comparisons, rather than GCC_JIT_TYPE_INT. * interna

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2014-02-11 Thread Teresa Johnson
On Thu, Dec 19, 2013 at 10:19 PM, Teresa Johnson wrote: > On Thu, Dec 12, 2013 at 5:13 PM, Jan Hubicka wrote: >>> On Wed, Dec 11, 2013 at 1:21 AM, Martin Liška >>> wrote: >>> > Hello, >>> >I prepared a collection of systemtap graphs for GIMP. >>> > >>> > 1) just my profile-based function re

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Sriraman Tallam
On Tue, Feb 11, 2014 at 1:32 PM, Teresa Johnson wrote: > On Mon, Feb 10, 2014 at 7:15 PM, Sriraman Tallam wrote: >> Hi Teresa, >> >>I have attached a patch to recognize and reorder split functions in >> the function reordering plugin. Please review. >> >> Thanks >> Sri > >> Index: function_re

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-11 Thread Xinliang David Li
Is it better to add some logic in counts_to_freq to determine if the profile count needs to be dropped completely to force profile estimation? David On Mon, Feb 10, 2014 at 2:12 PM, Teresa Johnson wrote: > This patch attempts to address the lost profile issue for COMDATs in > more circumstances,

[google gcc-4_8] Remove DW_AT_GNU_addr_base from skeleton type unit DIEs

2014-02-11 Thread Cary Coutant
Remove DW_AT_GNU_addr_base from skeleton type unit DIEs. GCC currently adds a DW_AT_GNU_addr_base attribute to skeleton type unit DIEs, even though it's not needed there. By removing it, we can save the 8 bytes that a DW_FORM_addr takes up, plus the 24 bytes that the corresponding relocation takes

Re: [google gcc-4_8] Remove DW_AT_GNU_addr_base from skeleton type unit DIEs

2014-02-11 Thread Doug Evans
On Tue, Feb 11, 2014 at 3:55 PM, Cary Coutant wrote: > Remove DW_AT_GNU_addr_base from skeleton type unit DIEs. > > GCC currently adds a DW_AT_GNU_addr_base attribute to skeleton type unit > DIEs, even though it's not needed there. By removing it, we can save > the 8 bytes that a DW_FORM_addr take

Re: [PATCH, WWW] [AVX-512] Add news about AVX-512.

2014-02-11 Thread Gerald Pfeifer
On Mon, 10 Feb 2014, Kirill Yukhin wrote: > Index: htdocs/index.html > === > + Intel AVX-512 support > + [2014-02-07] > + Intel AVX-512 support was added to GCC. That includes inline > assembly > + support, extended exi

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Sriraman Tallam
On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson wrote: > > On Feb 11, 2014 2:37 PM, "Sriraman Tallam" wrote: >> >> On Tue, Feb 11, 2014 at 1:32 PM, Teresa Johnson >> wrote: >> > On Mon, Feb 10, 2014 at 7:15 PM, Sriraman Tallam >> > wrote: >> >> Hi Teresa, >> >> >> >>I have attached a patch

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam wrote: > On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson wrote: >> >> On Feb 11, 2014 2:37 PM, "Sriraman Tallam" wrote: >>> >>> On Tue, Feb 11, 2014 at 1:32 PM, Teresa Johnson >>> wrote: >>> > On Mon, Feb 10, 2014 at 7:15 PM, Sriraman Tallam >>>

[GOOGLE] Emit a single unaligned load/store instruction for i386 m_GENERIC

2014-02-11 Thread Cong Hou
This small patch lets GCC emit a single unaligned load/store instruction for m_GENERIC i386 CPUs. Bootstrapped and passed regression test. OK for Google branch? thanks, Cong Index: gcc/config/i386/i386.c === --- gcc/config/i386/i

Re: [GOOGLE] Emit a single unaligned load/store instruction for i386 m_GENERIC

2014-02-11 Thread Xinliang David Li
ok. David On Tue, Feb 11, 2014 at 4:50 PM, Cong Hou wrote: > This small patch lets GCC emit a single unaligned load/store > instruction for m_GENERIC i386 CPUs. > > Bootstrapped and passed regression test. > > OK for Google branch? > > > thanks, > Cong > > > Index: gcc/config/i386/i386.c > =

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Sriraman Tallam
On Tue, Feb 11, 2014 at 4:39 PM, Teresa Johnson wrote: > On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam wrote: >> On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson wrote: >>> >>> On Feb 11, 2014 2:37 PM, "Sriraman Tallam" wrote: On Tue, Feb 11, 2014 at 1:32 PM, Teresa Johnson wr

Re: [PATCH] Fix up -Wsequence-point handling (PR c/60101)

2014-02-11 Thread Joseph S. Myers
On Tue, 11 Feb 2014, Jakub Jelinek wrote: > Hi! > > Right now we spent several minutes in verify_tree. The problems I see > is that merge_tlist does the exact opposite of what should it be doing with > copy flag (most merge_tlist calls are with copy=0, thus that means mostly > unnecessary copyin

Re: Simple install hook

2014-02-11 Thread David Malcolm
On Tue, 2014-02-11 at 16:51 +, Philip Herron wrote: [adding the j...@gcc.gnu.org ML to the CC] > Added install hook: Thanks! I don't know that this is needed for a 3-line patch, but have you done the copyright assignment paperwork for GCC contribution? (I hope to merge my branch into gcc tr

Re: [google][gcc-4_8][patch]Handle Split functions in the Function Reordering Plugin

2014-02-11 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 4:51 PM, Sriraman Tallam wrote: > On Tue, Feb 11, 2014 at 4:39 PM, Teresa Johnson wrote: >> On Tue, Feb 11, 2014 at 4:32 PM, Sriraman Tallam wrote: >>> On Tue, Feb 11, 2014 at 3:29 PM, Teresa Johnson >>> wrote: On Feb 11, 2014 2:37 PM, "Sriraman Tallam" wrote

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-11 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 2:56 PM, Xinliang David Li wrote: > Is it better to add some logic in counts_to_freq to determine if the > profile count needs to be dropped completely to force profile > estimation? This is the problem I was mentioning below where we call counts_to_freqs before we have th

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-11 Thread Xinliang David Li
Why is call graph needed to determine whether to drop the profile? If that is needed, it might be possible to leverage the ipa_profile pass as it will walk through all function nodes to do profile annotation. With this you can make decision to drop callee profile in caller's context. David On Tu

[GOOGLE] Prevent x_flag_complex_method to be set to 2 for C++.

2014-02-11 Thread Cong Hou
With this patch x_flag_complex_method won't be set to 2 for C++ so that multiply/divide between std::complex objects won't be replaced by expensive builtin function calls. Bootstrapped and passed regression test. OK for Google branch? thanks, Cong Index: gcc/c-family/c-opts.c ===

Re: [GOOGLE] Prevent x_flag_complex_method to be set to 2 for C++.

2014-02-11 Thread Xinliang David Li
ok. David On Tue, Feb 11, 2014 at 5:30 PM, Cong Hou wrote: > With this patch x_flag_complex_method won't be set to 2 for C++ so > that multiply/divide between std::complex objects won't be replaced by > expensive builtin function calls. > > Bootstrapped and passed regression test. > > OK for Goo

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-11 Thread Teresa Johnson
On Tue, Feb 11, 2014 at 5:16 PM, Xinliang David Li wrote: > Why is call graph needed to determine whether to drop the profile? Because we detect this situation by looking for cases where the call edge counts greatly exceed the callee node count. > > If that is needed, it might be possible to lev

Re: [PATCH] Handle more COMDAT profiling issues

2014-02-11 Thread Xinliang David Li
On Tue, Feb 11, 2014 at 5:36 PM, Teresa Johnson wrote: > On Tue, Feb 11, 2014 at 5:16 PM, Xinliang David Li wrote: >> Why is call graph needed to determine whether to drop the profile? > > Because we detect this situation by looking for cases where the call > edge counts greatly exceed the callee

Warn about virtual table mismatches

2014-02-11 Thread Jan Hubicka
Hi, this patch implements warning when we merge two virtual tables that do not match. It compares the size and also go into fields. I had to implement my own comparsion code, since the vtables may subtly differ - in RTTI and also I need to do so during DECL merging (since we will forget about the

Re: Warn about virtual table mismatches

2014-02-11 Thread Jason Merrill
On 02/11/2014 07:54 PM, Jan Hubicka wrote: + /* Allow combining RTTI and non-RTTI is OK. */ You mean combining -frtti and -fno-rtti compiles? Yes, that's fine, though you need to prefer the -frtti version in case code from that translation unit uses the RTTI info. /aux/hubicka/fi

Re: Warn about virtual table mismatches

2014-02-11 Thread Jan Hubicka
> On 02/11/2014 07:54 PM, Jan Hubicka wrote: > >+ /* Allow combining RTTI and non-RTTI is OK. */ > > You mean combining -frtti and -fno-rtti compiles? Yes, that's fine, > though you need to prefer the -frtti version in case code from that > translation unit uses the RTTI info. Is there som

[Ping] Re: [C++ Patch/RFC] PR 60047

2014-02-11 Thread Paolo Carlini
Hi, the last version of this work is unreviewed, should be rather straightforward... Paolo.

Re: [PATCH] Documentation for dump and optinfo output

2014-02-11 Thread Thomas Schwinge
Hi! On Wed, 5 Feb 2014 16:33:19 -0800, Sharad Singhai wrote: > I am really sorry about the delay. No worries; not exactly a severe issue. ;-) > I couldn't exactly reproduce the > warning which you described Maybe the version of makeinfo is relevant? $ makeinfo --version | head -n 1 m