Re: [PR] webdav lock and unlock: ensure response must not be cached [tomcat]

2024-10-24 Thread via GitHub
Chenjp commented on PR #771: URL: https://github.com/apache/tomcat/pull/771#issuecomment-2436588929 > If the `ExpiresFilter` is setting cache control headers when it shouldn't then that Filter should be fixed. The same goes for any other component setting cache headers incorrectly.

Re: (tomcat) branch main updated: Create a HttpParser if none is found

2024-10-24 Thread Mark Thomas
On 24/10/2024 15:56, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 7767b84

(tomcat) branch 10.1.x updated: Create a HttpParser if none is found

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 5262c4570b Create a HttpParser if none is found 52

(tomcat) branch 9.0.x updated: Create a HttpParser if none is found

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0362def0d5 Create a HttpParser if none is found 0362

Buildbot failure in on tomcat-12.0.x

2024-10-24 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/120/builds/161 Blamelist: remm Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main] 7767b84d422cda47b55125eac892f08ad78883ac St

(tomcat) branch 11.0.x updated: Create a HttpParser if none is found

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new d6bc8f6bdd Create a HttpParser if none is found d6

Re: [PR] Improve mod_jk makefiles [tomcat-connectors]

2024-10-24 Thread via GitHub
mturk commented on code in PR #10: URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815580677 ## native/apache-2.0/Makefile.vc: ## @@ -16,38 +16,25 @@ PROJECT = mod_jk # Tools CC = cl.exe -LINK = link.exe +LN = link.exe RC = rc.exe -MT = mt.exe !IF !D

Re: [PR] Improve mod_jk makefiles [tomcat-connectors]

2024-10-24 Thread via GitHub
ChristopherSchultz commented on code in PR #10: URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815478755 ## native/apache-2.0/Makefile.vc: ## @@ -16,38 +16,25 @@ PROJECT = mod_jk # Tools CC = cl.exe -LINK = link.exe +LN = link.exe RC = rc.exe -MT = mt.

Re: [PR] Improve mod_jk makefiles [tomcat-connectors]

2024-10-24 Thread via GitHub
ChristopherSchultz commented on code in PR #10: URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815482357 ## native/apache-2.0/Makefile.vc: ## @@ -16,38 +16,25 @@ PROJECT = mod_jk # Tools CC = cl.exe -LINK = link.exe +LN = link.exe RC = rc.exe -MT = mt.

Re: (tomcat) branch main updated: Create a HttpParser if none is found

2024-10-24 Thread Rémy Maucherat
On Thu, Oct 24, 2024 at 7:11 PM Mark Thomas wrote: > > On 24/10/2024 15:56, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The fo

Re: [PR] Improve mod_jk makefiles [tomcat-connectors]

2024-10-24 Thread via GitHub
ChristopherSchultz commented on code in PR #10: URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815478755 ## native/apache-2.0/Makefile.vc: ## @@ -16,38 +16,25 @@ PROJECT = mod_jk # Tools CC = cl.exe -LINK = link.exe +LN = link.exe RC = rc.exe -MT = mt.

Buildbot success in on tomcat-12.0.x

2024-10-24 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/120/builds/160 Blamelist: remm Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 514c17151744907ae98df05b67e7d6443d7b4c20 Steps: worker_preparation:

Re: [PR] webdav lock and unlock: ensure response must not be cached [tomcat]

2024-10-24 Thread via GitHub
markt-asf commented on PR #771: URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434998619 If the `ExpiresFilter` is setting cache control headers when it should then that Filter should be fixed. The same goes for any other component setting cache headers incorrectly. -- This

(tomcat) branch main updated: Create a HttpParser if none is found

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 7767b84d42 Create a HttpParser if none is found 7767b8

(tomcat) branch main updated: Minor fixes

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 62473af6a0 Minor fixes 62473af6a0 is described below

(tomcat) branch 10.1.x updated: Minor fixes

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 1e9cba6c73 Minor fixes 1e9cba6c73 is described bel

(tomcat) branch 11.0.x updated: Minor fixes

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 259b06f7bd Minor fixes 259b06f7bd is described bel

(tomcat) branch 9.0.x updated: Minor fixes

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e1bca79d3d Minor fixes e1bca79d3d is described below

(tomcat) branch main updated: Remove Java 17 from the workflow

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c986117e95 Remove Java 17 from the workflow c986117e95

Re: [PR] webdav lock and unlock: ensure response must not be cached [tomcat]

2024-10-24 Thread via GitHub
rmaucher commented on PR #771: URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434585666 All of the WebDAV methods are "must not cache" actually (except PROPFIND, but IMO it's a bad idea to cache it), and it is 100% obvious why. If the proxy feels like it doesn't have to send t

(tomcat) branch main updated: Needs the property as well

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 514c171517 Needs the property as well 514c171517 is de

Re: [PR] webdav lock and unlock: ensure response must not be cached [tomcat]

2024-10-24 Thread via GitHub
rmaucher commented on PR #771: URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434710548 OTOH, +1 if you want to rewrite (they are too verbose right now) and expand the WebDAV tests. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Buildbot success in on tomcat-10.1.x

2024-10-24 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/1463 Blamelist: remm Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 10.1.x] 1e9cba6c7391689445ec7dce7b3894cad27be13e Steps: worker_preparatio

Re: [PR] webdav lock and unlock: ensure response must not be cached [tomcat]

2024-10-24 Thread via GitHub
Chenjp commented on PR #771: URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434716856 > This change is unnecessary. As per RFC 9111, methods other than GET are only cached if the method definition allows it. RFC 4918 is explicit that these methods are not cacheable. Cur

Buildbot failure in on tomcat-12.0.x

2024-10-24 Thread buildbot
Build status: BUILD FAILED: failed Snapshot deployed to ASF Maven snapshot repository (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/120/builds/159 Blamelist: remm Build Text: failed Snapshot deployed to ASF Maven snapshot repository (failure) Status Detected: new

Re: [PR] webdav lock and unlock: ensure response must not be cached [tomcat]

2024-10-24 Thread via GitHub
markt-asf commented on PR #771: URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434618560 This change is unnecessary. As per RFC 9111, methods other than GET are only cached if the method definition allows it. RFC 4918 is explicit that these methods are not cacheable. -- Thi

Re: [PR] webdav lock and unlock: ensure response must not be cached [tomcat]

2024-10-24 Thread via GitHub
markt-asf closed pull request #771: webdav lock and unlock: ensure response must not be cached URL: https://github.com/apache/tomcat/pull/771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

(tomcat) branch main updated: Add validate GH workflow

2024-10-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 21a8e3d48f Add validate GH workflow 21a8e3d48f is desc