Hi,
Could I get permissions to assign Geode tickets (especially to myself)?
User name is nreich.
Thanks,
Nick
in 4, so the
try catch idiom was the only option back in JUnit 3):
http://junit.org/junit4/javadoc/4.12/org/junit/rules/ExpectedException.html
- Nick Reich
On July 18, 2017, 1:20 a.m., anilkumar gingade wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60935/#review181270
---
Ship it!
Ship It!
- Nick Reich
On July 21, 2017, 7:18 p.m
my ability to string together the right mock call and
response sequences, though if it is the only way to get it done, it is still
better than nothing.
- Nick Reich
On July 26, 2017, 5:37 p.m., Eric Shu wrote:
>
> --
> On July 26, 2017, 8:11 p.m., Nick Reich wrote:
> >
All my comments are nits and only suggestions / thoughts and not barriers to
accepting this review and shipping it.
- Nick
---
This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61143/#review181588
---
Ship it!
Ship It!
- Nick Reich
On July 27, 2017, 5:32 p.m
There is a desire to improve backup creation and restore. The suggested
improvements are listed below and I am seeking feedback from the community:
1) Allow saving of backups to different locations/systems: currently,
backups are saved to a directory on each member. Users can manually or
through s
tely should change!
>
> -Dan
>
> On Thu, Aug 10, 2017 at 10:31 AM, Nick Reich wrote:
>
> > There is a desire to improve backup creation and restore. The suggested
> > improvements are listed below and I am seeking feedback from the
> community:
> >
> &g
I have created GEODE-3435 to fix the issue.
On Fri, Aug 11, 2017 at 3:41 PM, Kirk Lund wrote:
> Looks like it was this commit...
>
> commit 7072f8ef7b764d1507e26cca8ed0c4d184ccc81a
> Author: Nick Reich
> Date: Fri Jul 28 16:47:10 2017 -0700
>
> GEODE-3300: Complet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61676/#review183009
---
Ship it!
Ship It!
- Nick Reich
On Aug. 15, 2017, 10:47 p.m
ply, visit:
> https://reviews.apache.org/r/61676/
> ---
>
> (Updated Aug. 15, 2017, 10:47 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat,
> and Nick Reich.
>
>
> Bugs: GEODE-3444
> https://issues.apache.org/jira
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61722/#review183187
---
Ship it!
Ship It!
- Nick Reich
On Aug. 17, 2017, 11:20 p.m
Team,
I am working on exposing the parallel export/import of snapshots through
gfsh and would appreciate input on the best approach to adding to /
updating the existing interface.
Currently, ExportDataCommand and ImportDataCommand take a region name, a
member to run the command on, and a file loc
he new functionality as a separate command,
> I would suggest calling the gfsh commands: “export data-parallel” and
> “import data-parallel"
> >
> >> On Aug 22, 2017, at 11:32 AM, Nick Reich wrote:
> >>
> >> Team,
> >>
> >> I am working
options (but I agree: less options is generally better).
On Tue, Aug 22, 2017 at 1:59 PM, Jacob Barrett wrote:
> On Tue, Aug 22, 2017 at 1:49 PM Nick Reich wrote:
>
> > The idea of deprecating —file in favor of path is interesting. I wonder
> if
> > instead of making them
ion.
>
> No need for a new option (--parallel).
> No need for a new option (--path).
>
> In fact, no need for a change to gfsh command at all.
>
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: +1-631-835-4771
>
> On Tue, Aug 22, 2017 at
<https://reviews.apache.org/r/61895/#comment259995>
Is spyMgr.suspend() here being attempted to occur between when the two
threads start and before they complete? If so, is that guaranteed to occur?
- Nick Reich
On Aug. 25, 2017, 4:53 p.m., Er
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61895/#review184710
---
Ship it!
Ship It!
- Nick Reich
On Sept. 6, 2017, 6:42 p.m
atched)
<https://reviews.apache.org/r/62164/#comment261064>
It does not look like the second part of this method uses the shortcut or
overflow parameters, so it could be a seperate method. Since this method does
two different things, that would probably be optimal.
- Nick Reich
On Sept. 7, 2
/62164/#comment261070>
Normalize variable names to camel case?
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
Lines 249 (patched)
<https://reviews.apache.org/r/62164/#comment261067>
use TEST_REGION constant
- Nick Reich
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62164/#review184982
---
Ship it!
Ship It!
- Nick Reich
On Sept. 8, 2017, 4:10 p.m
> On Sept. 7, 2017, 8:08 p.m., Nick Reich wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/62164/diff/1/?file=1817801#file1817801line17>
>
Do not need to hold onto the set:
for (Object key : region.keySet())
- Nick Reich
On Sept. 22, 2017, 5:01 p.m., Eric Shu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
Here are the docs from github:
https://help.github.com/articles/about-pull-request-merges/
Based on those and using squash and commit for some of my merges, it looks
like it does what we want: just one commit for the merge of the feature
branch. Note that "rebase and merge" in github does not actu
+1 for moving those messages out of CliStrings if at all possible and
placing them where they are used. In my experiences with those strings, I
have rarely if ever seen them reused across classes, so they really should
belong in the class they are used by.
On Thu, Oct 19, 2017 at 3:05 PM, Jared St
Team,
I am in the progress of adding new benchmarks to the (currently sparse)
geode-benchmarks module. The lack of current examples in the module leads
me to wonder what the correct organization of benchmarks in the module is
(and if this is the right location).
The existing benchmarks are all in
ou put the cq benchmark
> code
> > > under geode-cq to near its source code, it might still have to access
> > code
> > > under other package, such as geode-core.
> > >
> > > So I think put benchmark test code under benchmark package is ok. Your
> >
This would solve the problem of specifying the parameters for a Declarable,
but if you provided support for any valid json, you could cover other
situations as well, including those with more complicated and possibly
nested configuration. If we would ever support such scenarios in the
future, I ass
+1 for deprecating --template-region. It feels like a convenience method
that by it very nature has an unobvious result and would require more
effort to understand so it could be used correctly by a user than the value
that it presents.
On Wed, Feb 7, 2018 at 10:26 AM, Anilkumar Gingade
wrote:
>
Team,
The time required to undertake a rebalance of a geode cluster has often
been an area for improvement noted by users. Currently, buckets are moved
one at a time and we propose that creating a system that moved buckets in
parallel could greatly improve performance for this feature.
Previously
hink we need to improve our rebalancing such that it iterates until
> it achieves balance, but not in a way that will consume all available
> resources.
>
> --
> Mike Stolz
>
>
> On Thu, Mar 8, 2018 at 2:25 PM, Nick Reich wrote:
>
> > Team,
> >
> > The tim
load looks like when rebalance is in
> > progress and hence could be difficult to get right. It would be ideal if
> we
> > can handle this using back pressure.
> >
> >> On Thu, Mar 8, 2018 at 12:05 PM Nick Reich wrote:
> >>
> >> Mike,
> >>
+1
I use an email filter (from:apachegeod...@gmail.com) to move all the
automated CI messages to a different section of my inbox, but having a
fully distinct email list, if possible, would be even nicer.
On Tue, Mar 20, 2018 at 2:27 PM, Galen O'Sullivan
wrote:
> Hi all,
>
> I'm wondering if it w
Team,
As part of validating the new JDBC connector for Geode, we have a need for
tests that involving connecting to specific databases (like MySQL and
Postgres) to validate proper function with those databases. Since these
tests require connecting to outside services, unlike existing Geode tests,
;m in favor of using docker for test isolation. We already have an
> > 'AcceptanceTest' category which you might consider using instead of
> > creating yet another category.
> >
> > --Jens
> >
> > On Tue, Apr 3, 2018 at 2:02 PM, Nick Reich wrote:
&g
35 matches
Mail list logo
