----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62164/#review184842 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java Lines 2460 (patched) <https://reviews.apache.org/r/62164/#comment261032> Can remove nesting by checking dr != null && destroyDiskRegion geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java Lines 91 (patched) <https://reviews.apache.org/r/62164/#comment261064> It does not look like the second part of this method uses the shortcut or overflow parameters, so it could be a seperate method. Since this method does two different things, that would probably be optimal. - Nick Reich On Sept. 7, 2017, 4:56 p.m., Lynn Gallinat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62164/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 4:56 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and > Nick Reich. > > > Repository: geode > > > Description > ------- > > We now update the stats in a member that lost a bucket due to rebalancing > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java > 465a3dd > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62164/diff/1/ > > > Testing > ------- > > Precheckin > > > Thanks, > > Lynn Gallinat > >
