----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60935/#review180818 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java Lines 370 (patched) <https://reviews.apache.org/r/60935/#comment256088> Duplicate code as above test: consider refactoring out a helper method. geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java Lines 377 (patched) <https://reviews.apache.org/r/60935/#comment256090> leftover println from debugging? geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java Line 335 (original), 382 (patched) <https://reviews.apache.org/r/60935/#comment256099> JUnit has a good way to test for exceptions using rules (added in 4, so the try catch idiom was the only option back in JUnit 3): http://junit.org/junit4/javadoc/4.12/org/junit/rules/ExpectedException.html - Nick Reich On July 18, 2017, 1:20 a.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60935/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 1:20 a.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick > Reich. > > > Repository: geode > > > Description > ------- > > The pdx registry needs to be persisted to use pdx with persistent region. > Currently while creating pdx the system checks, to see if there is a disk > store with data instead of looking for persistent region in the system. In > cases where persistent region is created and dropped, the system doesn't > allow creating pdx witout setting pdx persistence. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 2dda38c > geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java > 4c229db > > geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java > 61f91a0 > > geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java > 065255b > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java > 45c6120 > geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java > ef15cd5 > > > Diff: https://reviews.apache.org/r/60935/diff/1/ > > > Testing > ------- > > Added new test. > Precheckin started. > > > Thanks, > > anilkumar gingade > >
